[Libreoffice-commits] core.git: include/vcl vcl/source

Miklos Vajna vmiklos at collabora.co.uk
Fri Nov 13 00:55:25 PST 2015


 include/vcl/builder.hxx       |    2 +-
 vcl/source/window/builder.cxx |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 12d51ad73c68ffe238dc2c28f9abd6b679dffb34
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Fri Nov 13 09:54:43 2015 +0100

    vcl: loplugin:passstuffbyref
    
    Change-Id: I4ad2b77112a2c9bfbf76f0b84275d88046ed3851

diff --git a/include/vcl/builder.hxx b/include/vcl/builder.hxx
index fee4545..485bbe8 100644
--- a/include/vcl/builder.hxx
+++ b/include/vcl/builder.hxx
@@ -107,7 +107,7 @@ public:
     static void     reorderWithinParent(vcl::Window &rWindow, sal_uInt16 nNewPosition);
 
     /// Get label of the command (like of .uno:Save) from the description service
-    static OUString getCommandProperty(const OUString aProperty, const OUString& rCommand,
+    static OUString getCommandProperty(const OUString& rProperty, const OUString& rCommand,
                                        const css::uno::Reference<css::uno::XComponentContext>& rContext,
                                        const OUString& rModuleId);
 
diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx
index 626327f..40174d5 100644
--- a/vcl/source/window/builder.cxx
+++ b/vcl/source/window/builder.cxx
@@ -2168,7 +2168,7 @@ void VclBuilder::reorderWithinParent(std::vector<vcl::Window*>& rChilds, bool bI
     }
 }
 
-OUString VclBuilder::getCommandProperty(const OUString aProperty, const OUString& rCommand,
+OUString VclBuilder::getCommandProperty(const OUString& rProperty, const OUString& rCommand,
                                      const uno::Reference<uno::XComponentContext>& rContext, const OUString& rModuleId)
 {
     if (rCommand.isEmpty())
@@ -2186,7 +2186,7 @@ OUString VclBuilder::getCommandProperty(const OUString aProperty, const OUString
             {
                 for ( sal_Int32 i = 0; i < aProperties.getLength(); i++ )
                 {
-                    if (aProperties[i].Name == aProperty)
+                    if (aProperties[i].Name == rProperty)
                     {
                         OUString aLabel;
                         if (aProperties[i].Value >>= aLabel)


More information about the Libreoffice-commits mailing list