[Libreoffice-commits] core.git: 9 commits - hwpfilter/source i18nlangtag/source i18npool/source io/source io/test javaunohelper/source jurt/com jvmfwk/plugins jvmfwk/source libreofficekit/qa libreofficekit/source lingucomponent/source lotuswordpro/source qadevOOo/runner qadevOOo/tests remotebridges/examples sal/qa sc/source sd/source vcl/opengl wizards/com

Caolán McNamara caolanm at redhat.com
Tue Nov 24 02:36:12 PST 2015


 hwpfilter/source/hbox.h                                   |    6 -
 hwpfilter/source/hiodev.h                                 |    2 
 hwpfilter/source/htags.h                                  |    4 
 hwpfilter/source/hwpfile.h                                |    2 
 hwpfilter/source/list.hxx                                 |    4 
 hwpfilter/source/nodes.h                                  |    2 
 i18nlangtag/source/languagetag/languagetag.cxx            |    2 
 i18npool/source/calendar/calendar_jewish.cxx              |    4 
 i18npool/source/localedata/LocaleNode.hxx                 |    2 
 i18npool/source/search/textsearch.hxx                     |    2 
 io/source/acceptor/acc_pipe.cxx                           |    2 
 io/source/acceptor/acc_socket.cxx                         |    4 
 io/source/acceptor/acceptor.cxx                           |    2 
 io/source/connector/connector.cxx                         |    2 
 io/source/connector/connector.hxx                         |    4 
 io/source/connector/ctr_socket.cxx                        |    2 
 io/source/stm/odata.cxx                                   |    2 
 io/test/stm/datatest.cxx                                  |    6 -
 io/test/stm/marktest.cxx                                  |    4 
 io/test/stm/pipetest.cxx                                  |    2 
 io/test/stm/pumptest.cxx                                  |    2 
 javaunohelper/source/vm.cxx                               |    2 
 jurt/com/sun/star/uno/AnyConverter.java                   |    2 
 jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx          |    4 
 jvmfwk/plugins/sunmajor/pluginlib/util.cxx                |    6 -
 jvmfwk/plugins/sunmajor/pluginlib/util.hxx                |    4 
 jvmfwk/source/libxmlutil.hxx                              |    8 -
 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx       |    2 
 libreofficekit/source/gtk/tilebuffer.hxx                  |    2 
 lingucomponent/source/thesaurus/libnth/nthesdta.hxx       |    2 
 lotuswordpro/source/filter/lwpfribframe.hxx               |    2 
 qadevOOo/runner/base/java_fat_service.java                |    5 
 qadevOOo/tests/java/ifc/awt/_XNumericField.java           |   10 +
 qadevOOo/tests/java/ifc/connection/_XAcceptor.java        |    4 
 qadevOOo/tests/java/ifc/sdbc/_XRowUpdate.java             |    3 
 qadevOOo/tests/java/ifc/sheet/_XDataPilotTable2.java      |    3 
 remotebridges/examples/officeclient.cxx                   |    2 
 sal/qa/osl/mutex/osl_Mutex.cxx                            |   16 +--
 sal/qa/osl/process/osl_Thread.cxx                         |    4 
 sc/source/core/data/column.cxx                            |   18 +--
 sc/source/core/data/column2.cxx                           |   10 -
 sc/source/core/data/column3.cxx                           |    8 -
 sd/source/ui/animations/SlideTransitionPane.cxx           |    4 
 sd/source/ui/controller/displaymodecontroller.cxx         |    2 
 vcl/opengl/win/WinDeviceInfo.cxx                          |    4 
 wizards/com/sun/star/wizards/document/OfficeDocument.java |   72 +++++---------
 46 files changed, 119 insertions(+), 142 deletions(-)

New commits:
commit 70b09d932225027d531c9a95317320174f8ad687
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 24 10:09:57 2015 +0000

    cppcheck: noExplicitConstructor
    
    Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7

diff --git a/hwpfilter/source/hbox.h b/hwpfilter/source/hbox.h
index 921e631..8e5dcaa 100644
--- a/hwpfilter/source/hbox.h
+++ b/hwpfilter/source/hbox.h
@@ -47,7 +47,7 @@ struct HBox
  * Construct a HBox object with parameter hch.
  * @param hch 16bit character being able to have Korean character.
  */
-        HBox( hchar hch );
+        explicit HBox( hchar hch );
         virtual ~HBox();
 /**
  * @returns The Size of HBox object
@@ -75,7 +75,7 @@ struct SkipData: public HBox
     hchar dummy;
     char  *data_block;
 
-    SkipData(hchar);
+    explicit SkipData(hchar);
     virtual ~SkipData();
     virtual bool Read(HWPFile &hwpf) override;
 };
@@ -321,7 +321,7 @@ struct FBox: public HBox
 
     FBox      *prev, *next;
 
-    FBox( hchar hch );
+    explicit FBox( hchar hch );
     virtual ~FBox();
 };
 
diff --git a/hwpfilter/source/hiodev.h b/hwpfilter/source/hiodev.h
index ebc94b2..0a43d44 100644
--- a/hwpfilter/source/hiodev.h
+++ b/hwpfilter/source/hiodev.h
@@ -80,7 +80,7 @@ class HStreamIODev : public HIODev
         std::unique_ptr<HStream> _stream;
         gz_stream *_gzfp;
     public:
-        HStreamIODev(HStream* stream);
+        explicit HStreamIODev(HStream* stream);
         virtual ~HStreamIODev();
 /**
  * Check whether the stream is available
diff --git a/hwpfilter/source/htags.h b/hwpfilter/source/htags.h
index 9000d56..303b844 100644
--- a/hwpfilter/source/htags.h
+++ b/hwpfilter/source/htags.h
@@ -31,7 +31,7 @@ struct EmPicture
     char  type[16];
     uchar *data;
 
-    EmPicture(size_t size);
+    explicit EmPicture(size_t size);
     ~EmPicture(void);
 
     bool Read(HWPFile& hwpf);
@@ -60,7 +60,7 @@ struct OlePicture
 #else
     char *pis;
 #endif
-    OlePicture(int tsize);
+    explicit OlePicture(int tsize);
     ~OlePicture(void);
 
     bool Read(HWPFile& hwpf);
diff --git a/hwpfilter/source/hwpfile.h b/hwpfilter/source/hwpfile.h
index 07cf847..ea500e1 100644
--- a/hwpfilter/source/hwpfile.h
+++ b/hwpfilter/source/hwpfile.h
@@ -70,7 +70,7 @@ struct ColumnInfo{
     int start_page;
     bool bIsSet;
     ColumnDef *coldef;
-    ColumnInfo(int num){
+    explicit ColumnInfo(int num){
         start_page = num;
         bIsSet = false;
         coldef = NULL;
diff --git a/hwpfilter/source/list.hxx b/hwpfilter/source/list.hxx
index a605aca..99dcc7f 100644
--- a/hwpfilter/source/list.hxx
+++ b/hwpfilter/source/list.hxx
@@ -43,7 +43,7 @@ class LinkedList
 
 public:
     /// construct list with one element (pItem) or no element (pItem == NULL)
-    LinkedList( T* pItem = 0 );
+    explicit LinkedList( T* pItem = 0 );
     ~LinkedList();
 };
 
@@ -59,7 +59,7 @@ class LinkedListIterator
 
 public:
     /// construct list with single element
-    LinkedListIterator( LinkedList<T>* pList = 0 );
+    explicit LinkedListIterator( LinkedList<T>* pList = 0 );
     ~LinkedListIterator();
 
     // bug-compatible with original LinkedList.h/cxx: Ignore parameter!
diff --git a/hwpfilter/source/nodes.h b/hwpfilter/source/nodes.h
index 9f1d2eb..7d93f10 100644
--- a/hwpfilter/source/nodes.h
+++ b/hwpfilter/source/nodes.h
@@ -62,7 +62,7 @@ enum IDLIST {
 
 class Node{
 public:
-     Node(int _id) : id(_id)
+     explicit Node(int _id) : id(_id)
      {
           value = NULL;
           child = NULL;
diff --git a/i18nlangtag/source/languagetag/languagetag.cxx b/i18nlangtag/source/languagetag/languagetag.cxx
index bca22d5..9d0b295 100644
--- a/i18nlangtag/source/languagetag/languagetag.cxx
+++ b/i18nlangtag/source/languagetag/languagetag.cxx
@@ -1058,7 +1058,7 @@ bool LanguageTagImpl::canonicalize()
     struct dumper
     {
         lt_tag_t** mpp;
-        dumper( lt_tag_t** pp ) : mpp( *pp ? NULL : pp) {}
+        explicit dumper( lt_tag_t** pp ) : mpp( *pp ? NULL : pp) {}
         ~dumper() { if (mpp && *mpp) lt_tag_dump( *mpp); }
     };
     dumper aDumper( &mpImplLangtag);
diff --git a/i18npool/source/calendar/calendar_jewish.cxx b/i18npool/source/calendar/calendar_jewish.cxx
index 3073c37..19b62d3 100644
--- a/i18npool/source/calendar/calendar_jewish.cxx
+++ b/i18npool/source/calendar/calendar_jewish.cxx
@@ -136,7 +136,7 @@ private:
 public:
     HebrewDate(sal_Int32 m, sal_Int32 d, sal_Int32 y) { month = m; day = d; year = y; }
 
-    HebrewDate(sal_Int32 d) { // Computes the Hebrew date from the absolute date.
+    explicit HebrewDate(sal_Int32 d) { // Computes the Hebrew date from the absolute date.
     year = (d + HebrewEpoch) / 366; // Approximation from below.
     // Search forward for year from the approximation.
     while (d >= HebrewDate(7,1,year + 1))
@@ -214,7 +214,7 @@ private:
 public:
     GregorianDate(int m, int d, int y) { month = m; day = d; year = y; }
 
-    GregorianDate(int d) { // Computes the Gregorian date from the absolute date.
+    explicit GregorianDate(int d) { // Computes the Gregorian date from the absolute date.
         // Search forward year by year from approximate year
         year = d/366;
         while (d >= GregorianDate(1,1,year+1))
diff --git a/i18npool/source/localedata/LocaleNode.hxx b/i18npool/source/localedata/LocaleNode.hxx
index 142cb24..226d257 100644
--- a/i18npool/source/localedata/LocaleNode.hxx
+++ b/i18npool/source/localedata/LocaleNode.hxx
@@ -71,7 +71,7 @@ class Attr {
     Sequence <OUString> value;
 
 public:
-    Attr (const Reference< XAttributeList > & attr);
+    explicit Attr (const Reference< XAttributeList > & attr);
     const OUString& getValueByName (const sal_Char *str) const;
     sal_Int32 getLength() const;
     const OUString& getTypeByIndex (sal_Int32 idx) const;
diff --git a/i18npool/source/search/textsearch.hxx b/i18npool/source/search/textsearch.hxx
index 7b42fe7..5c2ef03 100644
--- a/i18npool/source/search/textsearch.hxx
+++ b/i18npool/source/search/textsearch.hxx
@@ -113,7 +113,7 @@ class TextSearch: public cppu::WeakImplHelper
                             throw(css::uno::RuntimeException);
 
 public:
-    TextSearch(
+    explicit TextSearch(
         const css::uno::Reference < css::uno::XComponentContext >& rxContext );
 
     virtual ~TextSearch();
diff --git a/io/source/acceptor/acc_pipe.cxx b/io/source/acceptor/acc_pipe.cxx
index 37097aa..74baf3b 100644
--- a/io/source/acceptor/acc_pipe.cxx
+++ b/io/source/acceptor/acc_pipe.cxx
@@ -42,7 +42,7 @@ namespace io_acceptor
         public MyPipeConnection
     {
     public:
-        PipeConnection( const OUString &sConnectionDescription);
+        explicit PipeConnection( const OUString &sConnectionDescription);
         virtual ~PipeConnection();
 
         virtual sal_Int32 SAL_CALL read( Sequence< sal_Int8 >& aReadBytes, sal_Int32 nBytesToRead )
diff --git a/io/source/acceptor/acc_socket.cxx b/io/source/acceptor/acc_socket.cxx
index 976b782..b1a30a1 100644
--- a/io/source/acceptor/acc_socket.cxx
+++ b/io/source/acceptor/acc_socket.cxx
@@ -69,7 +69,7 @@ namespace io_acceptor {
 
     {
     public:
-        SocketConnection( const OUString & sConnectionDescription );
+        explicit SocketConnection( const OUString & sConnectionDescription );
         virtual ~SocketConnection();
 
         virtual sal_Int32 SAL_CALL read( css::uno::Sequence< sal_Int8 >& aReadBytes,
@@ -135,7 +135,7 @@ namespace io_acceptor {
     struct callError {
         const Any & any;
 
-        callError(const Any & any);
+        explicit callError(const Any & any);
 
         void operator () (Reference<XStreamListener> xStreamListener);
     };
diff --git a/io/source/acceptor/acceptor.cxx b/io/source/acceptor/acceptor.cxx
index 12fde58..4822978 100644
--- a/io/source/acceptor/acceptor.cxx
+++ b/io/source/acceptor/acceptor.cxx
@@ -49,7 +49,7 @@ namespace io_acceptor
     class OAcceptor : public WeakImplHelper< XAcceptor, XServiceInfo >
     {
     public:
-        OAcceptor(const Reference< XComponentContext > & xCtx);
+        explicit OAcceptor(const Reference< XComponentContext > & xCtx);
         virtual ~OAcceptor();
     public:
         // Methods
diff --git a/io/source/connector/connector.cxx b/io/source/connector/connector.cxx
index 025f1a0..91071fe 100644
--- a/io/source/connector/connector.cxx
+++ b/io/source/connector/connector.cxx
@@ -52,7 +52,7 @@ namespace stoc_connector
         Reference< XMultiComponentFactory > _xSMgr;
         Reference< XComponentContext > _xCtx;
     public:
-        OConnector(const Reference< XComponentContext > &xCtx);
+        explicit OConnector(const Reference< XComponentContext > &xCtx);
         virtual ~OConnector();
         // Methods
         virtual Reference< XConnection > SAL_CALL connect(
diff --git a/io/source/connector/connector.hxx b/io/source/connector/connector.hxx
index 117d63d..ae9e98f 100644
--- a/io/source/connector/connector.hxx
+++ b/io/source/connector/connector.hxx
@@ -60,7 +60,7 @@ namespace stoc_connector
 
     {
     public:
-        PipeConnection( const OUString &sConnectionDescription );
+        explicit PipeConnection( const OUString &sConnectionDescription );
         virtual ~PipeConnection();
 
         virtual sal_Int32 SAL_CALL read( css::uno::Sequence< sal_Int8 >& aReadBytes,
@@ -89,7 +89,7 @@ namespace stoc_connector
 
     {
     public:
-        SocketConnection( const OUString & sConnectionDescription  );
+        explicit SocketConnection( const OUString & sConnectionDescription  );
         virtual ~SocketConnection();
 
         virtual sal_Int32 SAL_CALL read( css::uno::Sequence< sal_Int8 >& aReadBytes,
diff --git a/io/source/connector/ctr_socket.cxx b/io/source/connector/ctr_socket.cxx
index 3d7e320..2995aad 100644
--- a/io/source/connector/ctr_socket.cxx
+++ b/io/source/connector/ctr_socket.cxx
@@ -56,7 +56,7 @@ namespace stoc_connector {
     struct callError {
         const Any & any;
 
-        callError(const Any & any);
+        explicit callError(const Any & any);
 
         void operator () (Reference<XStreamListener> xStreamListener);
     };
diff --git a/io/source/stm/odata.cxx b/io/source/stm/odata.cxx
index 56b15f4..878e0df 100644
--- a/io/source/stm/odata.cxx
+++ b/io/source/stm/odata.cxx
@@ -1178,7 +1178,7 @@ class OObjectInputStream:
         XObjectInputStream, XMarkableStream >
 {
 public:
-    OObjectInputStream( const Reference < XComponentContext > &r)
+    explicit OObjectInputStream( const Reference < XComponentContext > &r)
         : m_rSMgr( r->getServiceManager() )
         , m_rCxt( r )
         , m_bValidMarkable(false)
diff --git a/io/test/stm/datatest.cxx b/io/test/stm/datatest.cxx
index 9ac2440..e6cc323 100644
--- a/io/test/stm/datatest.cxx
+++ b/io/test/stm/datatest.cxx
@@ -63,7 +63,7 @@ class ODataStreamTest :
         public WeakImplHelper< XSimpleTest >
 {
 public:
-    ODataStreamTest( const Reference < XMultiServiceFactory > & rFactory ) :
+    explicit ODataStreamTest( const Reference < XMultiServiceFactory > & rFactory ) :
         m_rFactory( rFactory )
         {}
 
@@ -374,7 +374,7 @@ public:
         m_c( 429 ),
         m_s( OUString( "foo"  ) )
         {}
-    MyPersistObject( const OUString & sServiceName ) : m_sServiceName( sServiceName )
+    explicit MyPersistObject( const OUString & sServiceName ) : m_sServiceName( sServiceName )
         {}
 
 
@@ -628,7 +628,7 @@ class OObjectStreamTest :
         public ODataStreamTest
 {
 public:
-    OObjectStreamTest( const Reference < XMultiServiceFactory > &r) : ODataStreamTest(r) {}
+    explicit OObjectStreamTest( const Reference < XMultiServiceFactory > &r) : ODataStreamTest(r) {}
 
 public:
     virtual void SAL_CALL testInvariant(const OUString& TestName,
diff --git a/io/test/stm/marktest.cxx b/io/test/stm/marktest.cxx
index e737f94..c8d2d19 100644
--- a/io/test/stm/marktest.cxx
+++ b/io/test/stm/marktest.cxx
@@ -45,7 +45,7 @@ using namespace ::com::sun::star::test;
 class OMarkableOutputStreamTest : public WeakImplHelper< XSimpleTest >
 {
 public:
-    OMarkableOutputStreamTest( const Reference< XMultiServiceFactory > & rFactory );
+    explicit OMarkableOutputStreamTest( const Reference< XMultiServiceFactory > & rFactory );
     ~OMarkableOutputStreamTest();
 
 public: // implementation names
@@ -403,7 +403,7 @@ OUString    OMarkableOutputStreamTest_getImplementationName() throw ()
 class OMarkableInputStreamTest : public WeakImplHelper< XSimpleTest >
 {
 public:
-    OMarkableInputStreamTest( const Reference< XMultiServiceFactory > & rFactory );
+    explicit OMarkableInputStreamTest( const Reference< XMultiServiceFactory > & rFactory );
     ~OMarkableInputStreamTest();
 
 public: // implementation names
diff --git a/io/test/stm/pipetest.cxx b/io/test/stm/pipetest.cxx
index f7dc2d4..d66b3c7 100644
--- a/io/test/stm/pipetest.cxx
+++ b/io/test/stm/pipetest.cxx
@@ -94,7 +94,7 @@ private:
 class OPipeTest : public WeakImplHelper < XSimpleTest >
 {
 public:
-    OPipeTest( const Reference< XMultiServiceFactory >  & rFactory );
+    explicit OPipeTest( const Reference< XMultiServiceFactory >  & rFactory );
     ~OPipeTest();
 
 public: // implementation names
diff --git a/io/test/stm/pumptest.cxx b/io/test/stm/pumptest.cxx
index b95d54c..ae2a28b 100644
--- a/io/test/stm/pumptest.cxx
+++ b/io/test/stm/pumptest.cxx
@@ -63,7 +63,7 @@ static void mywait()
 class OPumpTest : public WeakImplHelper < XSimpleTest >
 {
 public:
-    OPumpTest( const Reference< XMultiServiceFactory >  & rFactory );
+    explicit OPumpTest( const Reference< XMultiServiceFactory >  & rFactory );
     ~OPumpTest();
 
 public: // implementation names
diff --git a/javaunohelper/source/vm.cxx b/javaunohelper/source/vm.cxx
index cccec06..794a1d5 100644
--- a/javaunohelper/source/vm.cxx
+++ b/javaunohelper/source/vm.cxx
@@ -47,7 +47,7 @@ protected:
     virtual void SAL_CALL disposing() override;
 
 public:
-    inline SingletonFactory( ::rtl::Reference< ::jvmaccess::UnoVirtualMachine > const & vm_access )
+    explicit SingletonFactory( ::rtl::Reference< ::jvmaccess::UnoVirtualMachine > const & vm_access )
         : t_impl( m_mutex ),
           m_vm_access( vm_access )
         {}
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx
index de65fac..7bda1f9 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx
@@ -82,8 +82,8 @@ protected:
 
     PreRelease m_preRelease;
 public:
-    SunVersion(const char * szVer);
-    SunVersion(const OUString& usVer);
+    explicit SunVersion(const char * szVer);
+    explicit SunVersion(const OUString& usVer);
     ~SunVersion();
 
     /**
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
index b9ec443..f16f96f 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
@@ -222,7 +222,7 @@ rtl::Bootstrap * getBootstrap()
 class FileHandleGuard: private boost::noncopyable
 {
 public:
-    inline FileHandleGuard(oslFileHandle & rHandle):
+    explicit FileHandleGuard(oslFileHandle & rHandle):
         m_rHandle(rHandle) {}
 
     inline ~FileHandleGuard();
@@ -255,7 +255,7 @@ public:
         RESULT_ERROR
     };
 
-    inline FileHandleReader(oslFileHandle & rHandle):
+    explicit FileHandleReader(oslFileHandle & rHandle):
         m_aGuard(rHandle), m_nSize(0), m_nIndex(0), m_bLf(false) {}
 
     Result readLine(OString * pLine);
@@ -339,7 +339,7 @@ class AsynchReader: public salhelper::Thread
     void execute() override;
 public:
 
-    AsynchReader(oslFileHandle & rHandle);
+    explicit AsynchReader(oslFileHandle & rHandle);
 
     /** only call this function after this thread has finished.
 
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.hxx b/jvmfwk/plugins/sunmajor/pluginlib/util.hxx
index 456cfd7..7449733 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.hxx
@@ -65,7 +65,7 @@ bool makeDriveLetterSame(OUString * fileURL);
 struct InfoFindSame
 {
     OUString sJava;
-    InfoFindSame(const OUString& sJavaHome):sJava(sJavaHome){}
+    explicit InfoFindSame(const OUString& sJavaHome):sJava(sJavaHome){}
 
     bool operator () (const rtl::Reference<VendorBase> & aVendorInfo)
     {
@@ -76,7 +76,7 @@ struct InfoFindSame
 struct SameOrSubDirJREMap
 {
     OUString s1;
-    SameOrSubDirJREMap(const OUString& s):s1(s){
+    explicit SameOrSubDirJREMap(const OUString& s):s1(s){
     }
 
     bool operator () (const std::pair<const OUString, rtl::Reference<VendorBase> > & s2)
diff --git a/jvmfwk/source/libxmlutil.hxx b/jvmfwk/source/libxmlutil.hxx
index c9a8f66..4affff6 100644
--- a/jvmfwk/source/libxmlutil.hxx
+++ b/jvmfwk/source/libxmlutil.hxx
@@ -49,7 +49,7 @@ class CXPathContextPtr
     CXPathContextPtr & operator = (const CXPathContextPtr&) = delete;
 public:
     CXPathContextPtr();
-    CXPathContextPtr(xmlXPathContextPtr aContext);
+    explicit CXPathContextPtr(xmlXPathContextPtr aContext);
     CXPathContextPtr & operator = (xmlXPathContextPtr pObj);
     ~CXPathContextPtr();
     xmlXPathContext* operator -> () { return _object;}
@@ -66,7 +66,7 @@ class CXmlDocPtr
 public:
     CXmlDocPtr & operator = (const CXmlDocPtr&);
     CXmlDocPtr();
-    CXmlDocPtr(xmlDoc* aDoc);
+    explicit CXmlDocPtr(xmlDoc* aDoc);
     /** Takes ownership of xmlDoc
      */
     CXmlDocPtr & operator = (xmlDoc* pObj);
@@ -84,8 +84,8 @@ class CXmlCharPtr
     CXmlCharPtr & operator = (const CXmlCharPtr&) = delete;
 public:
     CXmlCharPtr();
-    CXmlCharPtr(xmlChar* aDoc);
-    CXmlCharPtr(const OUString &);
+    explicit CXmlCharPtr(xmlChar* aDoc);
+    explicit CXmlCharPtr(const OUString &);
     ~CXmlCharPtr();
     CXmlCharPtr & operator = (xmlChar* pObj);
     operator xmlChar* () const { return _object;}
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index 390f01b..77021bf 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -67,7 +67,7 @@ public:
     int m_nPositionPixel;
     TiledBarType m_eType;
 
-    TiledRowColumnBar(TiledBarType eType);
+    explicit TiledRowColumnBar(TiledBarType eType);
     static gboolean draw(GtkWidget* pWidget, cairo_t* pCairo, gpointer pData);
     gboolean drawImpl(GtkWidget* pWidget, cairo_t* pCairo);
     static gboolean docConfigureEvent(GtkWidget* pWidget, GdkEventConfigure* pEvent, gpointer pData);
diff --git a/libreofficekit/source/gtk/tilebuffer.hxx b/libreofficekit/source/gtk/tilebuffer.hxx
index 3d84dfb..96100d7 100644
--- a/libreofficekit/source/gtk/tilebuffer.hxx
+++ b/libreofficekit/source/gtk/tilebuffer.hxx
@@ -242,7 +242,7 @@ struct LOEvent
     ///@}
 
     /// Constructor to instantiate an object of type `type`.
-    LOEvent(int type)
+    explicit LOEvent(int type)
         : m_nType(type)
         , m_pCommand(nullptr)
         , m_pArguments(nullptr)
diff --git a/lingucomponent/source/thesaurus/libnth/nthesdta.hxx b/lingucomponent/source/thesaurus/libnth/nthesdta.hxx
index 8e551f2..bd506a8 100644
--- a/lingucomponent/source/thesaurus/libnth/nthesdta.hxx
+++ b/lingucomponent/source/thesaurus/libnth/nthesdta.hxx
@@ -41,7 +41,7 @@ class Meaning :
     Meaning & operator = (const Meaning &) = delete;
 
 public:
-    Meaning(const OUString &rTerm);
+    explicit Meaning(const OUString &rTerm);
     virtual ~Meaning();
 
     // XMeaning
diff --git a/lotuswordpro/source/filter/lwpfribframe.hxx b/lotuswordpro/source/filter/lwpfribframe.hxx
index b915a9a..d30a954 100644
--- a/lotuswordpro/source/filter/lwpfribframe.hxx
+++ b/lotuswordpro/source/filter/lwpfribframe.hxx
@@ -83,7 +83,7 @@ private:
 class LwpFribRubyFrame : public LwpFrib
 {
 public:
-    LwpFribRubyFrame( LwpPara* pPara) : LwpFrib(pPara){}
+    explicit LwpFribRubyFrame(LwpPara* pPara) : LwpFrib(pPara){}
     virtual ~LwpFribRubyFrame(){}
     void Read(LwpObjectStream* pObjStrm, sal_uInt16 len) override;
     LwpRubyLayout* GetLayout();
diff --git a/remotebridges/examples/officeclient.cxx b/remotebridges/examples/officeclient.cxx
index dcdf44f..b689b37 100644
--- a/remotebridges/examples/officeclient.cxx
+++ b/remotebridges/examples/officeclient.cxx
@@ -58,7 +58,7 @@ namespace remotebridges_officeclient {
 class OfficeClientMain : public WeakImplHelper1< XMain >
 {
 public:
-    OfficeClientMain( const Reference< XMultiServiceFactory > &r ) :
+    explicit OfficeClientMain( const Reference< XMultiServiceFactory > &r ) :
         m_xSMgr( r )
         {}
 public:     // Methods
diff --git a/sal/qa/osl/mutex/osl_Mutex.cxx b/sal/qa/osl/mutex/osl_Mutex.cxx
index 106dbc6..67924d2 100644
--- a/sal/qa/osl/mutex/osl_Mutex.cxx
+++ b/sal/qa/osl/mutex/osl_Mutex.cxx
@@ -65,7 +65,7 @@ struct resource {
 class IncreaseThread : public Thread
 {
 public:
-    IncreaseThread( struct resource *pData ): pResource( pData ) { }
+    explicit IncreaseThread( struct resource *pData ): pResource( pData ) { }
 
     virtual ~IncreaseThread( )
     {
@@ -93,7 +93,7 @@ protected:
 class DecreaseThread : public Thread
 {
 public:
-    DecreaseThread( struct resource *pData ): pResource( pData ) { }
+    explicit DecreaseThread( struct resource *pData ): pResource( pData ) { }
 
     virtual ~DecreaseThread( )
     {
@@ -130,7 +130,7 @@ class PutThread : public Thread
 {
 public:
     //get the struct pointer to write data to buffer
-    PutThread( struct chain* pData ): pChain( pData ) { }
+    explicit PutThread( struct chain* pData ): pChain( pData ) { }
 
     virtual ~PutThread( )
     {
@@ -168,7 +168,7 @@ class HoldThread : public Thread
 {
 public:
     //get the Mutex pointer to operate
-    HoldThread( Mutex* pMutex ): pMyMutex( pMutex ) { }
+    explicit HoldThread( Mutex* pMutex ): pMyMutex( pMutex ) { }
 
     virtual ~HoldThread( )
     {
@@ -190,7 +190,7 @@ class WaitThread : public Thread
 {
 public:
     //get the Mutex pointer to operate
-    WaitThread( Mutex* pMutex ): pMyMutex( pMutex ) { }
+    explicit WaitThread( Mutex* pMutex ): pMyMutex( pMutex ) { }
 
     virtual ~WaitThread( )
     {
@@ -525,7 +525,7 @@ class GuardThread : public Thread
 {
 public:
     //get the Mutex pointer to operate
-    GuardThread( Mutex* pMutex ): pMyMutex( pMutex ) { }
+    explicit GuardThread( Mutex* pMutex ): pMyMutex( pMutex ) { }
 
     virtual ~GuardThread( )
     {
@@ -606,7 +606,7 @@ class ClearGuardThread : public Thread
 {
 public:
     //get the Mutex pointer to operate
-    ClearGuardThread( Mutex* pMutex ): pMyMutex( pMutex ) {}
+    explicit ClearGuardThread( Mutex* pMutex ): pMyMutex( pMutex ) {}
 
     virtual ~ClearGuardThread( )
     {
@@ -743,7 +743,7 @@ class ResetGuardThread : public Thread
 {
 public:
     //get the Mutex pointer to operate
-    ResetGuardThread( Mutex* pMutex ): pMyMutex( pMutex ) {}
+    explicit ResetGuardThread( Mutex* pMutex ): pMyMutex( pMutex ) {}
 
     virtual ~ResetGuardThread( )
     {
diff --git a/sal/qa/osl/process/osl_Thread.cxx b/sal/qa/osl/process/osl_Thread.cxx
index 63207f9..29687f8 100644
--- a/sal/qa/osl/process/osl_Thread.cxx
+++ b/sal/qa/osl/process/osl_Thread.cxx
@@ -160,7 +160,7 @@ class ThreadSafeValue
     T   m_nFlag;
     Mutex   m_aMutex;
 public:
-    ThreadSafeValue(T n = 0): m_nFlag(n) {}
+    explicit ThreadSafeValue(T n = 0): m_nFlag(n) {}
     T getValue()
         {
             //block if already acquired by another thread.
@@ -1749,7 +1749,7 @@ public:
     // a public char member for test result checking
     char m_Char_Test;
     // for pass thread-special data to thread
-    myKeyThread(const char cData)
+    explicit myKeyThread(const char cData)
         : m_Char_Test(0)
         {
             m_nData = cData;
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 064e3b3..d820abc 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -997,7 +997,7 @@ class CopyTextAttrToClipHandler
     sc::CellTextAttrStoreType::iterator miPos;
 
 public:
-    CopyTextAttrToClipHandler( sc::CellTextAttrStoreType& rAttrs ) :
+    explicit CopyTextAttrToClipHandler( sc::CellTextAttrStoreType& rAttrs ) :
         mrDestAttrs(rAttrs), miPos(mrDestAttrs.begin()) {}
 
     void operator() ( const sc::CellTextAttrStoreType::value_type& aNode, size_t nOffset, size_t nDataSize )
@@ -2305,7 +2305,7 @@ class FormulaGroupPicker : public SharedTopFormulaCellPicker
     std::vector<sc::FormulaGroupEntry>& mrGroups;
 
 public:
-    FormulaGroupPicker( std::vector<sc::FormulaGroupEntry>& rGroups ) : mrGroups(rGroups) {}
+    explicit FormulaGroupPicker( std::vector<sc::FormulaGroupEntry>& rGroups ) : mrGroups(rGroups) {}
 
     virtual ~FormulaGroupPicker() {}
 
@@ -2596,7 +2596,7 @@ class UpdateCompileHandler
 {
     bool mbForceIfNameInUse:1;
 public:
-    UpdateCompileHandler(bool bForceIfNameInUse) :
+    explicit UpdateCompileHandler(bool bForceIfNameInUse) :
         mbForceIfNameInUse(bForceIfNameInUse) {}
 
     void operator() (size_t /*nRow*/, ScFormulaCell* pCell)
@@ -2609,7 +2609,7 @@ class TabNoSetter
 {
     SCTAB mnTab;
 public:
-    TabNoSetter(SCTAB nTab) : mnTab(nTab) {}
+    explicit TabNoSetter(SCTAB nTab) : mnTab(nTab) {}
 
     void operator() (size_t /*nRow*/, ScFormulaCell* pCell)
     {
@@ -2621,7 +2621,7 @@ class UsedRangeNameFinder
 {
     std::set<sal_uInt16>& mrIndexes;
 public:
-    UsedRangeNameFinder(std::set<sal_uInt16>& rIndexes) : mrIndexes(rIndexes) {}
+    explicit UsedRangeNameFinder(std::set<sal_uInt16>& rIndexes) : mrIndexes(rIndexes) {}
 
     void operator() (size_t /*nRow*/, const ScFormulaCell* pCell)
     {
@@ -2668,7 +2668,7 @@ class SetDirtyOnRangeHandler
     sc::SingleColumnSpanSet maValueRanges;
     ScColumn& mrColumn;
 public:
-    SetDirtyOnRangeHandler(ScColumn& rColumn) : mrColumn(rColumn) {}
+    explicit SetDirtyOnRangeHandler(ScColumn& rColumn) : mrColumn(rColumn) {}
 
     void operator() (size_t /*nRow*/, ScFormulaCell* p)
     {
@@ -2712,7 +2712,7 @@ class SetTableOpDirtyOnRangeHandler
     sc::SingleColumnSpanSet maValueRanges;
     ScColumn& mrColumn;
 public:
-    SetTableOpDirtyOnRangeHandler(ScColumn& rColumn) : mrColumn(rColumn) {}
+    explicit SetTableOpDirtyOnRangeHandler(ScColumn& rColumn) : mrColumn(rColumn) {}
 
     void operator() (size_t /*nRow*/, ScFormulaCell* p)
     {
@@ -2800,7 +2800,7 @@ class CompileAllHandler
 {
     sc::CompileFormulaContext& mrCxt;
 public:
-    CompileAllHandler( sc::CompileFormulaContext& rCxt ) : mrCxt(rCxt) {}
+    explicit CompileAllHandler( sc::CompileFormulaContext& rCxt ) : mrCxt(rCxt) {}
 
     void operator() (size_t /*nRow*/, ScFormulaCell* pCell)
     {
@@ -2914,7 +2914,7 @@ class FindEditCellsHandler
     sc::CellStoreType::iterator miCellPos;
 
 public:
-    FindEditCellsHandler(ScColumn& rCol) :
+    explicit FindEditCellsHandler(ScColumn& rCol) :
         mrColumn(rCol),
         miAttrPos(rCol.GetCellAttrStore().begin()),
         miCellPos(rCol.GetCellStore().begin()) {}
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 17b5133..01dde57 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -1120,7 +1120,7 @@ class TestTabRefAbsHandler
     SCTAB mnTab;
     bool mbTestResult;
 public:
-    TestTabRefAbsHandler(SCTAB nTab) : mnTab(nTab), mbTestResult(false) {}
+    explicit TestTabRefAbsHandler(SCTAB nTab) : mnTab(nTab), mbTestResult(false) {}
 
     void operator() (size_t /*nRow*/, const ScFormulaCell* pCell)
     {
@@ -2906,7 +2906,7 @@ class FindUsedRowsHandler
     UsedRowsType& mrUsed;
     UsedRowsType::const_iterator miUsed;
 public:
-    FindUsedRowsHandler(UsedRowsType& rUsed) : mrUsed(rUsed), miUsed(rUsed.begin()) {}
+    explicit FindUsedRowsHandler(UsedRowsType& rUsed) : mrUsed(rUsed), miUsed(rUsed.begin()) {}
 
     void operator() (const sc::CellStoreType::value_type& node, size_t nOffset, size_t nDataSize)
     {
@@ -3024,7 +3024,7 @@ class CompileDBFormulaHandler
     sc::CompileFormulaContext& mrCxt;
 
 public:
-    CompileDBFormulaHandler( sc::CompileFormulaContext& rCxt ) :
+    explicit CompileDBFormulaHandler( sc::CompileFormulaContext& rCxt ) :
         mrCxt(rCxt) {}
 
     void operator() (size_t, ScFormulaCell* p)
@@ -3037,7 +3037,7 @@ struct CompileColRowNameFormulaHandler
 {
     sc::CompileFormulaContext& mrCxt;
 public:
-    CompileColRowNameFormulaHandler( sc::CompileFormulaContext& rCxt ) : mrCxt(rCxt) {}
+    explicit CompileColRowNameFormulaHandler( sc::CompileFormulaContext& rCxt ) : mrCxt(rCxt) {}
 
     void operator() (size_t, ScFormulaCell* p)
     {
@@ -3122,7 +3122,7 @@ class UpdateSubTotalHandler
     }
 
 public:
-    UpdateSubTotalHandler(ScFunctionData& rData) : mrData(rData) {}
+    explicit UpdateSubTotalHandler(ScFunctionData& rData) : mrData(rData) {}
 
     void operator() (size_t /*nRow*/, double fVal)
     {
diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index 98b4caa..4737121 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -294,8 +294,8 @@ class AttachFormulaCellsHandler
     sc::StartListeningContext& mrCxt;
 
 public:
-    AttachFormulaCellsHandler( sc::StartListeningContext& rCxt ) :
-        mrCxt(rCxt) {}
+    explicit AttachFormulaCellsHandler(sc::StartListeningContext& rCxt)
+        : mrCxt(rCxt) {}
 
     void operator() (size_t /*nRow*/, ScFormulaCell* pCell)
     {
@@ -2937,8 +2937,8 @@ class GroupFormulaCells
     std::vector<ScAddress>* mpGroupPos;
 
 public:
-    GroupFormulaCells( std::vector<ScAddress>* pGroupPos ) :
-        mpGroupPos(pGroupPos) {}
+    explicit GroupFormulaCells(std::vector<ScAddress>* pGroupPos)
+        : mpGroupPos(pGroupPos) {}
 
     void operator() (sc::CellStoreType::value_type& node)
     {
diff --git a/sd/source/ui/animations/SlideTransitionPane.cxx b/sd/source/ui/animations/SlideTransitionPane.cxx
index 5c8c7b9..2cb163c 100644
--- a/sd/source/ui/animations/SlideTransitionPane.cxx
+++ b/sd/source/ui/animations/SlideTransitionPane.cxx
@@ -378,8 +378,8 @@ namespace sd
 class TransitionPane : public ValueSet
 {
 public:
-    TransitionPane( vcl::Window *pParent ) :
-        ValueSet( pParent, WB_TABSTOP | WB_3DLOOK | WB_BORDER |
+    explicit TransitionPane( vcl::Window *pParent )
+        : ValueSet( pParent, WB_TABSTOP | WB_3DLOOK | WB_BORDER |
                   WB_ITEMBORDER | WB_FLATVALUESET | WB_VSCROLL )
     {
         EnableFullItemMode( false );
diff --git a/sd/source/ui/controller/displaymodecontroller.cxx b/sd/source/ui/controller/displaymodecontroller.cxx
index 58e69ff..d5e3f47 100644
--- a/sd/source/ui/controller/displaymodecontroller.cxx
+++ b/sd/source/ui/controller/displaymodecontroller.cxx
@@ -32,7 +32,7 @@ namespace sd
 class DisplayModeController : public svt::PopupWindowController
 {
 public:
-    DisplayModeController( const css::uno::Reference< css::uno::XComponentContext >& rxContext );
+    explicit DisplayModeController( const css::uno::Reference< css::uno::XComponentContext >& rxContext );
 
     virtual VclPtr<vcl::Window> createPopupWindow( vcl::Window* pParent ) override;
 
diff --git a/vcl/opengl/win/WinDeviceInfo.cxx b/vcl/opengl/win/WinDeviceInfo.cxx
index 80f92a0..5fa5aac 100644
--- a/vcl/opengl/win/WinDeviceInfo.cxx
+++ b/vcl/opengl/win/WinDeviceInfo.cxx
@@ -436,8 +436,8 @@ namespace {
 
 struct compareIgnoreAsciiCase
 {
-    compareIgnoreAsciiCase(const OUString& rString):
-        maString(rString)
+    explicit compareIgnoreAsciiCase(const OUString& rString)
+        : maString(rString)
     {
     }
 
commit cbc5dc14d6bb795a9c2b54d624b10770a2a95a00
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 24 09:48:55 2015 +0000

    coverity#1326190 Explicit null dereferenced
    
    set this back to its original code pre..
    
    commit e5bc8b60ecfca09a2014ab7090659f3428c8efa0
    Date:   Tue Aug 5 12:18:20 2014 +0200
    
    to silence coverity about it
    
    Change-Id: I9d8f1bda1a32fbf97c0bdc73edfeab9f74d6443a
    cids: 1326180<->1326190

diff --git a/jurt/com/sun/star/uno/AnyConverter.java b/jurt/com/sun/star/uno/AnyConverter.java
index f0d1340..61c8c7e 100644
--- a/jurt/com/sun/star/uno/AnyConverter.java
+++ b/jurt/com/sun/star/uno/AnyConverter.java
@@ -621,7 +621,7 @@ public class AnyConverter
                 break;
             case TypeClass.ENUM_value:
                 if (tc == TypeClass.ENUM_value &&
-                    (destType.equals( type ) /* optional destType */))
+                    (null == destTClass || destType.equals( type ) /* optional destType */))
                 {
                     return object;
                 }
commit 79391ca3091f6b487687d87ca46fb0d3989d3eaf
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 24 09:41:23 2015 +0000

    coverity#1326265 Explicit null dereferenced
    
    Change-Id: I802e0f854cb5c560e7a860f2fcec0330e481da6c

diff --git a/wizards/com/sun/star/wizards/document/OfficeDocument.java b/wizards/com/sun/star/wizards/document/OfficeDocument.java
index a4f166c..8a85e68 100644
--- a/wizards/com/sun/star/wizards/document/OfficeDocument.java
+++ b/wizards/com/sun/star/wizards/document/OfficeDocument.java
@@ -102,68 +102,50 @@ public class OfficeDocument
 
     private static XFrame createNewPreviewFrame(XMultiServiceFactory xMSF, XTerminateListener listener)
     {
-        XToolkit xToolkit = null;
+        XFrame xFrame = null;
         try
         {
-            xToolkit = UnoRuntime.queryInterface(XToolkit.class, xMSF.createInstance("com.sun.star.awt.Toolkit"));
-        }
-        catch (Exception e)
-        {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
-        }
+            XToolkit xToolkit = UnoRuntime.queryInterface(XToolkit.class, xMSF.createInstance("com.sun.star.awt.Toolkit"));
 
-        //describe the window and its properties
-        WindowDescriptor aDescriptor = new WindowDescriptor();
-        aDescriptor.Type = com.sun.star.awt.WindowClass.TOP;
-        aDescriptor.WindowServiceName = "window";
-        aDescriptor.ParentIndex = -1;
-        aDescriptor.Parent = null;
-        aDescriptor.Bounds = new Rectangle(10, 10, 640, 480);
-        aDescriptor.WindowAttributes = WindowAttribute.BORDER |
+            //describe the window and its properties
+            WindowDescriptor aDescriptor = new WindowDescriptor();
+            aDescriptor.Type = com.sun.star.awt.WindowClass.TOP;
+            aDescriptor.WindowServiceName = "window";
+            aDescriptor.ParentIndex = -1;
+            aDescriptor.Parent = null;
+            aDescriptor.Bounds = new Rectangle(10, 10, 640, 480);
+            aDescriptor.WindowAttributes = WindowAttribute.BORDER |
                 WindowAttribute.MOVEABLE |
                 WindowAttribute.SIZEABLE |
                 //WindowAttribute.CLOSEABLE            |
                 VclWindowPeerAttribute.CLIPCHILDREN;
 
-        //create a new blank container window
-        XWindowPeer xPeer = null;
-        try
-        {
-            xPeer = UnoRuntime.queryInterface(XWindowPeer.class, xToolkit.createWindow(aDescriptor));
-        }
-        catch (IllegalArgumentException e)
-        {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
-        }
-        XWindow xWindow = UnoRuntime.queryInterface(XWindow.class, xPeer);
+            //create a new blank container window
+            XWindowPeer xPeer = UnoRuntime.queryInterface(XWindowPeer.class, xToolkit.createWindow(aDescriptor));
+            XWindow xWindow = UnoRuntime.queryInterface(XWindow.class, xPeer);
 
-        //define some further properties of the frame window
-        //if it's needed .-)
-        //xPeer->setBackground(...);
+            //define some further properties of the frame window
+            //if it's needed .-)
+            //xPeer->setBackground(...);
 
-        //create new empty frame and set window on it
-        XFrame xFrame = null;
-        try
-        {
+            //create new empty frame and set window on it
             xFrame = UnoRuntime.queryInterface(XFrame.class, xMSF.createInstance("com.sun.star.frame.Frame"));
+            xFrame.initialize(xWindow);
+
+            //from now this frame is useable ...
+            //and not part of the desktop tree.
+            //You are alone with him .-)
+
+            if (listener != null)
+            {
+                Desktop.getDesktop(xMSF).addTerminateListener(listener);
+            }
         }
         catch (Exception e)
         {
             // TODO Auto-generated catch block
             e.printStackTrace();
         }
-        xFrame.initialize(xWindow);
-
-        //from now this frame is useable ...
-        //and not part of the desktop tree.
-        //You are alone with him .-)
-
-        if (listener != null)
-        {
-            Desktop.getDesktop(xMSF).addTerminateListener(listener);
-        }
 
         return xFrame;
 
commit 8540bcc81003a9cc9ff9e11082a8723a7677760a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 24 09:33:19 2015 +0000

    coverity#1327143 UrF: Unread field
    
    Change-Id: Iff1a546cca83fed6fc81836e447bc30d68969274

diff --git a/qadevOOo/tests/java/ifc/connection/_XAcceptor.java b/qadevOOo/tests/java/ifc/connection/_XAcceptor.java
index 686f09a..924d9c0 100644
--- a/qadevOOo/tests/java/ifc/connection/_XAcceptor.java
+++ b/qadevOOo/tests/java/ifc/connection/_XAcceptor.java
@@ -43,8 +43,6 @@ import com.sun.star.uno.XInterface;
 */
 public class _XAcceptor extends MultiMethodTest {
 
-    protected PrintWriter log_ ;
-
     /**
     * Calls <code>accept()</code> method in a separate thread.
     * Then stores exception thrown by call if it occurred, or
@@ -98,8 +96,6 @@ public class _XAcceptor extends MultiMethodTest {
         connectString = (String)
             tEnv.getObjRelation("XAcceptor.connectStr") ;
 
-        log_ = log ;
-
         if (connectString == null)
             throw new StatusException("No object relation found",
                 new NullPointerException()) ;
commit 606d0ef7772fdcdd86d472a1ef7d60fa77013a91
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 24 09:27:59 2015 +0000

    coverity#1326596 Useless call
    
    Change-Id: I9aff17d367ba48609067abdb2a5fb5111daee38c

diff --git a/qadevOOo/runner/base/java_fat_service.java b/qadevOOo/runner/base/java_fat_service.java
index e0d843e..5a1a72b 100644
--- a/qadevOOo/runner/base/java_fat_service.java
+++ b/qadevOOo/runner/base/java_fat_service.java
@@ -62,8 +62,6 @@ public class java_fat_service implements TestBase {
             return false;
         }
 
-        param.getMSF();
-
         for (int l=0;l<entries.length;l++) {
 
             if (entries[l] == null ) {
@@ -213,7 +211,6 @@ public class java_fat_service implements TestBase {
     protected TestEnvironment getEnv(DescEntry entry, TestParameters param) {
             DynamicClassLoader dcl = new DynamicClassLoader();
             log = (LogWriter)dcl.getInstance((String)param.get("LogWriter"));
-            param.getMSF();
 
             TestEnvironment tEnv = null;
 
commit ee283cd59f4e2df3a9c68c0fc4e7b24cb6f8dfd8
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 24 09:26:50 2015 +0000

    coverity#1326597 Useless call
    
    Change-Id: I4f51d49a18adf76a741d55d67ed3ba2a7a2cc439

diff --git a/qadevOOo/runner/base/java_fat_service.java b/qadevOOo/runner/base/java_fat_service.java
index 5a254af..e0d843e 100644
--- a/qadevOOo/runner/base/java_fat_service.java
+++ b/qadevOOo/runner/base/java_fat_service.java
@@ -62,8 +62,6 @@ public class java_fat_service implements TestBase {
             return false;
         }
 
-        param.get("ConnectionString");
-
         param.getMSF();
 
         for (int l=0;l<entries.length;l++) {
commit 61273b37ecc521c6f00c480dccf0ef4d39d4d49a
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 24 09:23:56 2015 +0000

    coverity#1326892 FE: Test for floating point equality
    
    Change-Id: I47b9ccf2685bd0f37ee2722e93fad9ed668c3b81

diff --git a/qadevOOo/tests/java/ifc/sheet/_XDataPilotTable2.java b/qadevOOo/tests/java/ifc/sheet/_XDataPilotTable2.java
index 541e0d0..72f3cea 100644
--- a/qadevOOo/tests/java/ifc/sheet/_XDataPilotTable2.java
+++ b/qadevOOo/tests/java/ifc/sheet/_XDataPilotTable2.java
@@ -37,6 +37,7 @@ import com.sun.star.uno.UnoRuntime;
 import lib.MultiMethodTest;
 import lib.Status;
 import lib.StatusException;
+import util.utils;
 
 /**
  * Testing <code>com.sun.star.sheet.XDataPilotTable2</code>
@@ -121,7 +122,7 @@ public class _XDataPilotTable2 extends MultiMethodTest
             }
             log.println(formatCell(addr) + ": " + data.length + " rows (" + (data.length-1) + " records)");
 
-            if (val != sum)
+            if (!utils.approxEqual(val, sum))
                 testResult = false;
         }
         tRes.tested("getDrillDownData()", testResult);
commit 6318552774961c101beaa3020ede018e4c7a00d3
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 24 09:22:30 2015 +0000

    coverity#1326891 FE: Test for floating point equality
    
    Change-Id: I5cf13dfb5e085684b333c47d6bee73f92b758e81

diff --git a/qadevOOo/tests/java/ifc/sdbc/_XRowUpdate.java b/qadevOOo/tests/java/ifc/sdbc/_XRowUpdate.java
index 68e76a9..e57b2f0 100644
--- a/qadevOOo/tests/java/ifc/sdbc/_XRowUpdate.java
+++ b/qadevOOo/tests/java/ifc/sdbc/_XRowUpdate.java
@@ -22,6 +22,7 @@ import java.util.List;
 
 import lib.MultiMethodTest;
 import lib.Status;
+import util.utils;
 import util.ValueComparer;
 
 import com.sun.star.io.XDataInputStream;
@@ -353,7 +354,7 @@ public class _XRowUpdate extends MultiMethodTest {
             double newVal = 1.1 + row.getDouble(idx) ;
             oObj.updateDouble(idx, newVal) ;
             double getVal = row.getDouble(idx) ;
-            result = newVal == getVal ;
+            result = utils.approxEqual(newVal, getVal);
         } catch (SQLException e) {
             e.printStackTrace(log) ;
             result = false ;
commit 7ab95e6fcad86510ff2d133c51e6cf7957453898
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Nov 24 09:20:44 2015 +0000

    coverity#1326890 FE: Test for floating point equality
    
    Change-Id: I767df959a9b8d9845cb56a34538707c599f82849

diff --git a/qadevOOo/tests/java/ifc/awt/_XNumericField.java b/qadevOOo/tests/java/ifc/awt/_XNumericField.java
index 54c25fa..a194fe3 100644
--- a/qadevOOo/tests/java/ifc/awt/_XNumericField.java
+++ b/qadevOOo/tests/java/ifc/awt/_XNumericField.java
@@ -71,9 +71,10 @@ public class _XNumericField extends MultiMethodTest {
     public void _setValue() {
         requiredMethod("getValue()");
 
-        oObj.setValue(val + 1.1) ;
+        double value = val + 1.1;
+        oObj.setValue(value) ;
 
-        tRes.tested("setValue()", oObj.getValue() == val + 1.1) ;
+        tRes.tested("setValue()", utils.approxEqual(oObj.getValue(), value));
     }
 
     /**
@@ -222,8 +223,9 @@ public class _XNumericField extends MultiMethodTest {
         requiredMethod("getSpinSize()") ;
 
         boolean result = true ;
-        oObj.setSpinSize(spin + 1.1) ;
-        result = oObj.getSpinSize() == spin + 1.1 ;
+        double value = spin + 1.1;
+        oObj.setSpinSize(value) ;
+        result = utils.approxEqual(oObj.getSpinSize(), value);
 
         tRes.tested("setSpinSize()", result) ;
     }


More information about the Libreoffice-commits mailing list