[Libreoffice-commits] core.git: include/vcl

Noel Grandin noel at peralex.com
Wed Nov 25 04:04:18 PST 2015


 include/vcl/bitmap.hxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 94e98c674a4ff67dff78a2871d33f79ce74e6a77
Author: Noel Grandin <noel at peralex.com>
Date:   Wed Nov 25 14:03:28 2015 +0200

    -Werror=type-limits
    
    comparison is always true due to limited range of data type
    
    Change-Id: If4bcf1f3123cbbd9261e48d2c786a610fc7c0cbc

diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index 23587e5..c49b4f0 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -166,7 +166,9 @@ public:
     BmpFilterParam( sal_uInt16 nSepiaPercent, sal_uLong nProgressStart = 0, sal_uLong nProgressEnd = 0 ) :
         meFilter( BMP_FILTER_SEPIA ), mnProgressStart( nProgressStart ), mnProgressEnd( nProgressEnd ),
         mnSepiaPercent( nSepiaPercent )
-    { assert(nSepiaPercent>=0 && nSepiaPercent<=100); }
+        {
+            assert(nSepiaPercent<=100);
+        }
 
     BmpFilterParam( const Size& rMosaicTileSize, sal_uLong nProgressStart = 0, sal_uLong nProgressEnd = 0 ) :
         meFilter( BMP_FILTER_MOSAIC ), mnProgressStart( nProgressStart ), mnProgressEnd( nProgressEnd )


More information about the Libreoffice-commits mailing list