[Libreoffice-commits] core.git: drawinglayer/source

Stephan Bergmann sbergman at redhat.com
Mon Oct 12 02:48:10 PDT 2015


 drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 738f143f870b632fd1061123c53a607041c5892e
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Mon Oct 12 11:45:52 2015 +0200

    fTexHeightPos shall be incremented across loop iterations
    
    Regression introduced with 92c8d74c543aa94cd512369072975dca7006d5b3 "CppCheck :
    reduce variables scope," found by clang-analyzer-deadcode.DeadStores.
    
    Change-Id: I3758a9827d4d242d4fd57af7bbb77decf2d0f327

diff --git a/drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx b/drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx
index 1e594a0..a1c27c9 100644
--- a/drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx
+++ b/drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx
@@ -635,9 +635,9 @@ namespace drawinglayer
 
                 if(nLoopCount)
                 {
+                    double fTexHeightPos(0.0);
                     for(a = 0L; a < nLoopCount; a++)
                     {
-                        double fTexHeightPos(0.0);
                         const Slice3D& rSliceA(rSliceVector[a]);
                         const Slice3D& rSliceB(rSliceVector[(a + 1L) % nNumSlices]);
                         const bool bAcceptPair(SLICETYPE3D_REGULAR == rSliceA.getSliceType() && SLICETYPE3D_REGULAR == rSliceB.getSliceType());


More information about the Libreoffice-commits mailing list