[Libreoffice-commits] core.git: sc/qa

Stephan Bergmann sbergman at redhat.com
Wed Oct 14 03:47:11 PDT 2015


 sc/qa/complex/sc/CalcRTL.java |   12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

New commits:
commit f8eaeb8adeccdf304fde0b51bfc2ef3a545e60be
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Wed Oct 14 12:46:21 2015 +0200

    Assume util.ValueComparer.equalValue is precise enough here
    
    ...in this poorly understood legacy qadevOOo code
    
    Change-Id: Ic1322ecd4092c4be37a8ffe338b7b5a98397ee1f

diff --git a/sc/qa/complex/sc/CalcRTL.java b/sc/qa/complex/sc/CalcRTL.java
index f30fed0..7ca5be6 100644
--- a/sc/qa/complex/sc/CalcRTL.java
+++ b/sc/qa/complex/sc/CalcRTL.java
@@ -428,15 +428,9 @@ public class CalcRTL
                     System.out.println("new = " + toString(newValue));
                     System.out.println("result = " + toString(resValue));
 
-                    if (resValue != null) {
-                        if ((!ValueComparer.equalValue(resValue, oldValue)) ||
-                                (!resValue.equals(oldValue))) {
-                            System.out.println("But it has changed.");
-
-                            return true;
-                        } else {
-                            return false;
-                        }
+                    if (!ValueComparer.equalValue(resValue, oldValue)) {
+                        System.out.println("But it has changed.");
+                        return true;
                     } else {
                         return false;
                     }


More information about the Libreoffice-commits mailing list