[Libreoffice-commits] core.git: comphelper/source eventattacher/source extensions/source

Noel Grandin noelgrandin at gmail.com
Sat Oct 17 23:12:36 PDT 2015


 comphelper/source/xml/ofopxmlhelper.cxx                      |    2 +-
 eventattacher/source/eventattacher.cxx                       |    2 +-
 extensions/source/propctrlr/MasterDetailLinkDialog.hxx       |    2 +-
 extensions/source/propctrlr/browserlistbox.cxx               |    2 +-
 extensions/source/propctrlr/buttonnavigationhandler.hxx      |    2 +-
 extensions/source/propctrlr/cellbindinghandler.hxx           |    2 +-
 extensions/source/propctrlr/cellbindinghelper.cxx            |    2 +-
 extensions/source/propctrlr/composeduiupdate.cxx             |    6 +++---
 extensions/source/propctrlr/composeduiupdate.hxx             |    2 +-
 extensions/source/propctrlr/controlfontdialog.hxx            |    2 +-
 extensions/source/propctrlr/defaultforminspection.hxx        |    2 +-
 extensions/source/propctrlr/editpropertyhandler.hxx          |    2 +-
 extensions/source/propctrlr/eformshelper.cxx                 |    2 +-
 extensions/source/propctrlr/eformspropertyhandler.hxx        |    2 +-
 extensions/source/propctrlr/eventhandler.hxx                 |    2 +-
 extensions/source/propctrlr/fontdialog.cxx                   |    2 +-
 extensions/source/propctrlr/formbrowsertools.hxx             |    4 ++--
 extensions/source/propctrlr/formcomponenthandler.cxx         |    6 +++---
 extensions/source/propctrlr/formcomponenthandler.hxx         |    4 ++--
 extensions/source/propctrlr/formgeometryhandler.cxx          |    4 ++--
 extensions/source/propctrlr/formlinkdialog.cxx               |    2 +-
 extensions/source/propctrlr/genericpropertyhandler.hxx       |    2 +-
 extensions/source/propctrlr/inspectorhelpwindow.hxx          |    2 +-
 extensions/source/propctrlr/inspectormodelbase.cxx           |    2 +-
 extensions/source/propctrlr/pcrcommon.hxx                    |    4 ++--
 extensions/source/propctrlr/propcontroller.cxx               |    8 ++++----
 extensions/source/propctrlr/propcontroller.hxx               |    2 +-
 extensions/source/propctrlr/propertycomposer.cxx             |    2 +-
 extensions/source/propctrlr/propertycomposer.hxx             |    4 ++--
 extensions/source/propctrlr/propertycontrolextender.hxx      |    2 +-
 extensions/source/propctrlr/propertyhandler.cxx              |    2 +-
 extensions/source/propctrlr/propertyhandler.hxx              |    6 +++---
 extensions/source/propctrlr/pushbuttonnavigation.hxx         |    2 +-
 extensions/source/propctrlr/standardcontrol.cxx              |    4 ++--
 extensions/source/propctrlr/submissionhandler.hxx            |    2 +-
 extensions/source/propctrlr/taborder.cxx                     |    2 +-
 extensions/source/propctrlr/xsddatatypes.hxx                 |    2 +-
 extensions/source/propctrlr/xsdvalidationpropertyhandler.hxx |    2 +-
 extensions/source/resource/ResourceIndexAccess.cxx           |    6 +++---
 39 files changed, 56 insertions(+), 56 deletions(-)

New commits:
commit e2a7cb31ed5b413ea2f846d0a5c562d1ad97195a
Author: Noel Grandin <noelgrandin at gmail.com>
Date:   Sun Oct 18 07:53:51 2015 +0200

    cppcheck:noExplicitConstructor
    
    Change-Id: I2b68ba9e8caf7971efbba094ef060e72541bdccf
    Reviewed-on: https://gerrit.libreoffice.org/19426
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/comphelper/source/xml/ofopxmlhelper.cxx b/comphelper/source/xml/ofopxmlhelper.cxx
index 838072a..7b98dfb 100644
--- a/comphelper/source/xml/ofopxmlhelper.cxx
+++ b/comphelper/source/xml/ofopxmlhelper.cxx
@@ -68,7 +68,7 @@ class OFOPXMLHelper_Impl
 public:
     ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Sequence< ::com::sun::star::beans::StringPair > > GetParsingResult();
 
-    OFOPXMLHelper_Impl( sal_uInt16 nFormat ); // must not be created directly
+    explicit OFOPXMLHelper_Impl( sal_uInt16 nFormat ); // must not be created directly
     virtual ~OFOPXMLHelper_Impl();
 
     // XDocumentHandler
diff --git a/eventattacher/source/eventattacher.cxx b/eventattacher/source/eventattacher.cxx
index 1f10231..79cd4db 100644
--- a/eventattacher/source/eventattacher.cxx
+++ b/eventattacher/source/eventattacher.cxx
@@ -211,7 +211,7 @@ sal_Bool SAL_CALL InvocationToAllListenerMapper::hasProperty(const OUString& Nam
 class EventAttacherImpl : public WeakImplHelper < XEventAttacher2, XInitialization, XServiceInfo >
 {
 public:
-    EventAttacherImpl( const Reference< XComponentContext >& );
+    explicit EventAttacherImpl( const Reference< XComponentContext >& );
     virtual ~EventAttacherImpl();
 
     // XServiceInfo
diff --git a/extensions/source/propctrlr/MasterDetailLinkDialog.hxx b/extensions/source/propctrlr/MasterDetailLinkDialog.hxx
index eff31fe..79cb0ed 100644
--- a/extensions/source/propctrlr/MasterDetailLinkDialog.hxx
+++ b/extensions/source/propctrlr/MasterDetailLinkDialog.hxx
@@ -34,7 +34,7 @@ namespace pcr
                                     ,public PcrClient
     {
     public:
-        MasterDetailLinkDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxContext);
+        explicit MasterDetailLinkDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxContext);
 
         // XServiceInfo - static methods
         static css::uno::Sequence< OUString > getSupportedServiceNames_static() throw( css::uno::RuntimeException );
diff --git a/extensions/source/propctrlr/browserlistbox.cxx b/extensions/source/propctrlr/browserlistbox.cxx
index 2253b94..8ef421c 100644
--- a/extensions/source/propctrlr/browserlistbox.cxx
+++ b/extensions/source/propctrlr/browserlistbox.cxx
@@ -139,7 +139,7 @@ namespace pcr
             @param _rContextImpl
                 the instance to delegate events to
         */
-        PropertyControlContext_Impl( OBrowserListBox& _rContextImpl );
+        explicit PropertyControlContext_Impl( OBrowserListBox& _rContextImpl );
 
         /** disposes the context.
 
diff --git a/extensions/source/propctrlr/buttonnavigationhandler.hxx b/extensions/source/propctrlr/buttonnavigationhandler.hxx
index 10dcd17..7f930af 100644
--- a/extensions/source/propctrlr/buttonnavigationhandler.hxx
+++ b/extensions/source/propctrlr/buttonnavigationhandler.hxx
@@ -37,7 +37,7 @@ namespace pcr
             m_xSlaveHandler;
 
     public:
-        ButtonNavigationHandler(
+        explicit ButtonNavigationHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
         static OUString SAL_CALL getImplementationName_static(  ) throw (css::uno::RuntimeException);
diff --git a/extensions/source/propctrlr/cellbindinghandler.hxx b/extensions/source/propctrlr/cellbindinghandler.hxx
index a820b98..21f50d7 100644
--- a/extensions/source/propctrlr/cellbindinghandler.hxx
+++ b/extensions/source/propctrlr/cellbindinghandler.hxx
@@ -44,7 +44,7 @@ namespace pcr
         ::rtl::Reference< IPropertyEnumRepresentation > m_pCellExchangeConverter;
 
     public:
-        CellBindingPropertyHandler(
+        explicit CellBindingPropertyHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
 
diff --git a/extensions/source/propctrlr/cellbindinghelper.cxx b/extensions/source/propctrlr/cellbindinghelper.cxx
index 83d0866..860af6f 100644
--- a/extensions/source/propctrlr/cellbindinghelper.cxx
+++ b/extensions/source/propctrlr/cellbindinghelper.cxx
@@ -66,7 +66,7 @@ namespace pcr
             OUString m_sReference;
 
         public:
-            StringCompare( const OUString& _rReference ) : m_sReference( _rReference ) { }
+            explicit StringCompare( const OUString& _rReference ) : m_sReference( _rReference ) { }
 
             inline bool operator()( const OUString& _rCompare )
             {
diff --git a/extensions/source/propctrlr/composeduiupdate.cxx b/extensions/source/propctrlr/composeduiupdate.cxx
index e1e6c2f8cf..45fdf38 100644
--- a/extensions/source/propctrlr/composeduiupdate.cxx
+++ b/extensions/source/propctrlr/composeduiupdate.cxx
@@ -171,7 +171,7 @@ namespace pcr
         class MethodGuard : public ::osl::MutexGuard
         {
         public:
-            MethodGuard( CachedInspectorUI& rInstance )
+            explicit MethodGuard( CachedInspectorUI& rInstance )
                 : ::osl::MutexGuard( rInstance.m_aMutex )
             {
                 rInstance.checkDisposed();
@@ -444,7 +444,7 @@ namespace pcr
             CachedInspectorUI::FGetStringBag  m_pGetter;
 
         public:
-            StringBagClearer( CachedInspectorUI::FGetStringBag _pGetter ) :m_pGetter( _pGetter ) { }
+            explicit StringBagClearer( CachedInspectorUI::FGetStringBag _pGetter ) :m_pGetter( _pGetter ) { }
 
             void operator()( const ImplMapHandlerToUI::value_type& _rUI )
             {
@@ -597,7 +597,7 @@ namespace pcr
             StringBag&  m_rMinuend;
 
         public:
-            StringBagComplement( StringBag& _rMinuend ) :m_rMinuend( _rMinuend ) { }
+            explicit StringBagComplement( StringBag& _rMinuend ) :m_rMinuend( _rMinuend ) { }
 
             void operator()( const OUString& _rPropertyToSubtract )
             {
diff --git a/extensions/source/propctrlr/composeduiupdate.hxx b/extensions/source/propctrlr/composeduiupdate.hxx
index 84fd9fe..429268f 100644
--- a/extensions/source/propctrlr/composeduiupdate.hxx
+++ b/extensions/source/propctrlr/composeduiupdate.hxx
@@ -193,7 +193,7 @@ namespace pcr
     private:
         ComposedPropertyUIUpdate&   m_rUIUpdate;
     public:
-        ComposedUIAutoFireGuard( ComposedPropertyUIUpdate& _rUIUpdate )
+        explicit ComposedUIAutoFireGuard( ComposedPropertyUIUpdate& _rUIUpdate )
             :m_rUIUpdate( _rUIUpdate )
         {
             m_rUIUpdate.suspendAutoFire();
diff --git a/extensions/source/propctrlr/controlfontdialog.hxx b/extensions/source/propctrlr/controlfontdialog.hxx
index 47c5ed3..9c8c59a 100644
--- a/extensions/source/propctrlr/controlfontdialog.hxx
+++ b/extensions/source/propctrlr/controlfontdialog.hxx
@@ -50,7 +50,7 @@ namespace pcr
         SfxPoolItem**           m_pItemPoolDefaults;    // pool defaults
 
     public:
-        OControlFontDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxContext);
+        explicit OControlFontDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxContext);
         virtual ~OControlFontDialog();
 
         // XTypeProvider
diff --git a/extensions/source/propctrlr/defaultforminspection.hxx b/extensions/source/propctrlr/defaultforminspection.hxx
index aaa6b78..ba4f285 100644
--- a/extensions/source/propctrlr/defaultforminspection.hxx
+++ b/extensions/source/propctrlr/defaultforminspection.hxx
@@ -62,7 +62,7 @@ namespace pcr
                         Create(const css::uno::Reference< css::uno::XComponentContext >&);
 
     public:
-        DefaultFormComponentInspectorModel( bool _bUseFormFormComponentHandlers = true );
+        explicit DefaultFormComponentInspectorModel( bool _bUseFormFormComponentHandlers = true );
 
     protected:
         // Service constructors
diff --git a/extensions/source/propctrlr/editpropertyhandler.hxx b/extensions/source/propctrlr/editpropertyhandler.hxx
index 0e6f115..e8e04da 100644
--- a/extensions/source/propctrlr/editpropertyhandler.hxx
+++ b/extensions/source/propctrlr/editpropertyhandler.hxx
@@ -37,7 +37,7 @@ namespace pcr
     class EditPropertyHandler : public EditPropertyHandler_Base
     {
     public:
-        EditPropertyHandler(
+        explicit EditPropertyHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
 
diff --git a/extensions/source/propctrlr/eformshelper.cxx b/extensions/source/propctrlr/eformshelper.cxx
index 3a19297..9ca7908 100644
--- a/extensions/source/propctrlr/eformshelper.cxx
+++ b/extensions/source/propctrlr/eformshelper.cxx
@@ -576,7 +576,7 @@ namespace pcr
             PropertyBag& m_rProperties;
 
         public:
-            PropertyBagInserter( PropertyBag& rProperties ) : m_rProperties( rProperties ) { }
+            explicit PropertyBagInserter( PropertyBag& rProperties ) : m_rProperties( rProperties ) { }
 
             void operator()( const Property& _rProp )
             {
diff --git a/extensions/source/propctrlr/eformspropertyhandler.hxx b/extensions/source/propctrlr/eformspropertyhandler.hxx
index 9d3f8b9..17b8fd2 100644
--- a/extensions/source/propctrlr/eformspropertyhandler.hxx
+++ b/extensions/source/propctrlr/eformspropertyhandler.hxx
@@ -47,7 +47,7 @@ namespace pcr
         bool                            m_bSimulatingModelChange;
 
     public:
-        EFormsPropertyHandler(
+        explicit EFormsPropertyHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
 
diff --git a/extensions/source/propctrlr/eventhandler.hxx b/extensions/source/propctrlr/eventhandler.hxx
index 234c4e1..e730a99 100644
--- a/extensions/source/propctrlr/eventhandler.hxx
+++ b/extensions/source/propctrlr/eventhandler.hxx
@@ -102,7 +102,7 @@ namespace pcr
         static css::uno::Reference< css::uno::XInterface > Create( const css::uno::Reference< css::uno::XComponentContext >& _rxContext );
 
     protected:
-        EventHandler(
+        explicit EventHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
        );
 
diff --git a/extensions/source/propctrlr/fontdialog.cxx b/extensions/source/propctrlr/fontdialog.cxx
index 6432fc9..5ee879c 100644
--- a/extensions/source/propctrlr/fontdialog.cxx
+++ b/extensions/source/propctrlr/fontdialog.cxx
@@ -77,7 +77,7 @@ namespace pcr
                     m_xPropStateAccess;
 
     public:
-        OFontPropertyExtractor( const css::uno::Reference< css::beans::XPropertySet >&
+        explicit OFontPropertyExtractor( const css::uno::Reference< css::beans::XPropertySet >&
             _rxProps );
 
     public:
diff --git a/extensions/source/propctrlr/formbrowsertools.hxx b/extensions/source/propctrlr/formbrowsertools.hxx
index ceafe79..15a2ac6 100644
--- a/extensions/source/propctrlr/formbrowsertools.hxx
+++ b/extensions/source/propctrlr/formbrowsertools.hxx
@@ -42,7 +42,7 @@ namespace pcr
         sal_Int32 m_nId;
 
     public:
-        FindPropertyByHandle( sal_Int32 _nId ) : m_nId ( _nId ) { }
+        explicit FindPropertyByHandle( sal_Int32 _nId ) : m_nId ( _nId ) { }
         bool operator()( const css::beans::Property& _rProp ) const
         {
             return m_nId == _rProp.Handle;
@@ -56,7 +56,7 @@ namespace pcr
         OUString m_sName;
 
     public:
-        FindPropertyByName( const OUString& _rName ) : m_sName( _rName ) { }
+        explicit FindPropertyByName( const OUString& _rName ) : m_sName( _rName ) { }
         bool operator()( const css::beans::Property& _rProp ) const
         {
             return m_sName == _rProp.Name;
diff --git a/extensions/source/propctrlr/formcomponenthandler.cxx b/extensions/source/propctrlr/formcomponenthandler.cxx
index 5949a64..7c4b414 100644
--- a/extensions/source/propctrlr/formcomponenthandler.cxx
+++ b/extensions/source/propctrlr/formcomponenthandler.cxx
@@ -2995,7 +2995,7 @@ namespace pcr
         class SQLCommandPropertyUI : public ISQLCommandPropertyUI
         {
         protected:
-            SQLCommandPropertyUI( const Reference< XPropertySet >& _rxObject )
+            explicit SQLCommandPropertyUI( const Reference< XPropertySet >& _rxObject )
                 : m_xObject(_rxObject)
             {
                 if ( !m_xObject.is() )
@@ -3012,7 +3012,7 @@ namespace pcr
         class FormSQLCommandUI : public SQLCommandPropertyUI
         {
         public:
-            FormSQLCommandUI( const Reference< XPropertySet >& _rxForm );
+            explicit FormSQLCommandUI( const Reference< XPropertySet >& _rxForm );
 
             // ISQLCommandAdapter
             virtual OUString        getSQLCommand() const override;
@@ -3079,7 +3079,7 @@ namespace pcr
         class ValueListCommandUI : public SQLCommandPropertyUI
         {
         public:
-            ValueListCommandUI( const Reference< XPropertySet >& _rxListOrCombo );
+            explicit ValueListCommandUI( const Reference< XPropertySet >& _rxListOrCombo );
 
             // ISQLCommandAdapter
             virtual OUString        getSQLCommand() const override;
diff --git a/extensions/source/propctrlr/formcomponenthandler.hxx b/extensions/source/propctrlr/formcomponenthandler.hxx
index c91a674..dea7179 100644
--- a/extensions/source/propctrlr/formcomponenthandler.hxx
+++ b/extensions/source/propctrlr/formcomponenthandler.hxx
@@ -95,7 +95,7 @@ namespace pcr
         sal_Int16                       m_nClassId;
 
     public:
-        FormComponentPropertyHandler(
+        explicit FormComponentPropertyHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
 
@@ -453,7 +453,7 @@ namespace pcr
         ::std::unique_ptr< WaitObject >       m_aWaitObject;
 
     public:
-        WaitCursor( vcl::Window* _pWindow )
+        explicit WaitCursor( vcl::Window* _pWindow )
         {
             if ( _pWindow )
                 m_aWaitObject.reset( new WaitObject( _pWindow ) );
diff --git a/extensions/source/propctrlr/formgeometryhandler.cxx b/extensions/source/propctrlr/formgeometryhandler.cxx
index 2d97599..3ade366 100644
--- a/extensions/source/propctrlr/formgeometryhandler.cxx
+++ b/extensions/source/propctrlr/formgeometryhandler.cxx
@@ -105,7 +105,7 @@ namespace pcr
     class BroadcastHelperBase
     {
     protected:
-        BroadcastHelperBase( ::osl::Mutex& _rMutex )
+        explicit BroadcastHelperBase( ::osl::Mutex& _rMutex )
             :maBHelper( _rMutex )
         {
         }
@@ -211,7 +211,7 @@ namespace pcr
     class FormGeometryHandler : public FormGeometryHandler_Base
     {
     public:
-        FormGeometryHandler(
+        explicit FormGeometryHandler(
             const Reference< XComponentContext >& _rxContext
         );
 
diff --git a/extensions/source/propctrlr/formlinkdialog.cxx b/extensions/source/propctrlr/formlinkdialog.cxx
index 127531a..246a25f 100644
--- a/extensions/source/propctrlr/formlinkdialog.cxx
+++ b/extensions/source/propctrlr/formlinkdialog.cxx
@@ -72,7 +72,7 @@ namespace pcr
         Link<>      m_aLinkChangeHandler;
 
     public:
-        FieldLinkRow( vcl::Window* _pParent );
+        explicit FieldLinkRow( vcl::Window* _pParent );
         virtual ~FieldLinkRow();
         virtual void dispose() override;
 
diff --git a/extensions/source/propctrlr/genericpropertyhandler.hxx b/extensions/source/propctrlr/genericpropertyhandler.hxx
index 58d89e9..58d8b63 100644
--- a/extensions/source/propctrlr/genericpropertyhandler.hxx
+++ b/extensions/source/propctrlr/genericpropertyhandler.hxx
@@ -86,7 +86,7 @@ namespace pcr
         static css::uno::Reference< css::uno::XInterface > Create( const css::uno::Reference< css::uno::XComponentContext >& _rxContext );
 
     protected:
-        GenericPropertyHandler(
+        explicit GenericPropertyHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
 
diff --git a/extensions/source/propctrlr/inspectorhelpwindow.hxx b/extensions/source/propctrlr/inspectorhelpwindow.hxx
index 61824ed..1b27429 100644
--- a/extensions/source/propctrlr/inspectorhelpwindow.hxx
+++ b/extensions/source/propctrlr/inspectorhelpwindow.hxx
@@ -40,7 +40,7 @@ namespace pcr
         sal_Int32       m_nMaxLines;
 
     public:
-        InspectorHelpWindow( vcl::Window* _pParent );
+        explicit InspectorHelpWindow( vcl::Window* _pParent );
         virtual ~InspectorHelpWindow();
         virtual void dispose() override;
 
diff --git a/extensions/source/propctrlr/inspectormodelbase.cxx b/extensions/source/propctrlr/inspectormodelbase.cxx
index a2296fa..8d682c5 100644
--- a/extensions/source/propctrlr/inspectormodelbase.cxx
+++ b/extensions/source/propctrlr/inspectormodelbase.cxx
@@ -67,7 +67,7 @@ namespace pcr
                                 m_pPropertyInfo;
 
     public:
-        InspectorModelProperties( ::osl::Mutex& _rMutex );
+        explicit InspectorModelProperties( ::osl::Mutex& _rMutex );
 
         using ::comphelper::OPropertyContainerHelper::convertFastPropertyValue;
         using ::comphelper::OPropertyContainerHelper::setFastPropertyValue;
diff --git a/extensions/source/propctrlr/pcrcommon.hxx b/extensions/source/propctrlr/pcrcommon.hxx
index a0b758a..6f5fceb 100644
--- a/extensions/source/propctrlr/pcrcommon.hxx
+++ b/extensions/source/propctrlr/pcrcommon.hxx
@@ -82,9 +82,9 @@ namespace pcr
 
     public:
         inline StlSyntaxSequence() : UnoBase() { }
-        inline StlSyntaxSequence( const UnoBase& rSeq ) : UnoBase( rSeq ) { }
+        explicit inline StlSyntaxSequence( const UnoBase& rSeq ) : UnoBase( rSeq ) { }
         inline StlSyntaxSequence( const ELEMENT* pElements, sal_Int32 len ) : UnoBase( pElements, len ) { }
-        inline StlSyntaxSequence( sal_Int32 len ) : UnoBase( len ) { }
+        explicit inline StlSyntaxSequence( sal_Int32 len ) : UnoBase( len ) { }
 
         operator const UnoBase&() const { return *this; }
         operator       UnoBase&()       { return *this; }
diff --git a/extensions/source/propctrlr/propcontroller.cxx b/extensions/source/propctrlr/propcontroller.cxx
index 0e74152..84d6ad4 100644
--- a/extensions/source/propctrlr/propcontroller.cxx
+++ b/extensions/source/propctrlr/propcontroller.cxx
@@ -990,7 +990,7 @@ namespace pcr
             {
                 DBG_ASSERT( aHandler->get(), "OPropertyBrowserController::doInspection: invalid handler!" );
 
-                StlSyntaxSequence< Property > aThisHandlersProperties = (*aHandler)->getSupportedProperties();
+                StlSyntaxSequence< Property > aThisHandlersProperties(  (*aHandler)->getSupportedProperties() );
 
                 if ( aThisHandlersProperties.empty() )
                 {
@@ -1032,7 +1032,7 @@ namespace pcr
                 }
 
                 // determine the superseded properties
-                StlSyntaxSequence< OUString > aSupersededByThisHandler = (*aHandler)->getSupersededProperties();
+                StlSyntaxSequence< OUString > aSupersededByThisHandler( (*aHandler)->getSupersededProperties() );
                 for (   StlSyntaxSequence< OUString >::const_iterator superseded = aSupersededByThisHandler.begin();
                         superseded != aSupersededByThisHandler.end();
                         ++superseded
@@ -1065,7 +1065,7 @@ namespace pcr
                 }
 
                 // see if the handler expresses interest in any actuating properties
-                StlSyntaxSequence< OUString > aInterestingActuations = (*aHandler)->getActuatingProperties();
+                StlSyntaxSequence< OUString > aInterestingActuations( (*aHandler)->getActuatingProperties() );
                 for (   StlSyntaxSequence< OUString >::const_iterator aLoop = aInterestingActuations.begin();
                         aLoop != aInterestingActuations.end();
                         ++aLoop
@@ -1180,7 +1180,7 @@ namespace pcr
 
         StlSyntaxSequence< PropertyCategoryDescriptor > aCategories;
         if ( m_xModel.is() )
-            aCategories = m_xModel->describeCategories();
+            aCategories = StlSyntaxSequence< PropertyCategoryDescriptor >(m_xModel->describeCategories());
 
         for (   StlSyntaxSequence< PropertyCategoryDescriptor >::const_iterator category = aCategories.begin();
                 category != aCategories.end();
diff --git a/extensions/source/propctrlr/propcontroller.hxx b/extensions/source/propctrlr/propcontroller.hxx
index ca434f6..a81c030 100644
--- a/extensions/source/propctrlr/propcontroller.hxx
+++ b/extensions/source/propctrlr/propcontroller.hxx
@@ -182,7 +182,7 @@ namespace pcr
         virtual css::uno::Reference< css::inspection::XPropertyControl > SAL_CALL createPropertyControl( ::sal_Int16 ControlType, sal_Bool CreateReadOnly ) throw (css::lang::IllegalArgumentException, css::uno::RuntimeException, std::exception) override;
 
     public:
-        OPropertyBrowserController(
+        explicit OPropertyBrowserController(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext);
 
     protected:
diff --git a/extensions/source/propctrlr/propertycomposer.cxx b/extensions/source/propctrlr/propertycomposer.cxx
index 0aebacd..9c99e8c 100644
--- a/extensions/source/propctrlr/propertycomposer.cxx
+++ b/extensions/source/propctrlr/propertycomposer.cxx
@@ -395,7 +395,7 @@ namespace pcr
             )
         {
             // TODO: make this cheaper (cache it?)
-            const StlSyntaxSequence< OUString > aThisHandlersActuatingProps = (*loop)->getActuatingProperties();
+            const StlSyntaxSequence< OUString > aThisHandlersActuatingProps( (*loop)->getActuatingProperties() );
             for (   StlSyntaxSequence< OUString >::const_iterator loopProps = aThisHandlersActuatingProps.begin();
                     loopProps != aThisHandlersActuatingProps.end();
                     ++loopProps
diff --git a/extensions/source/propctrlr/propertycomposer.hxx b/extensions/source/propctrlr/propertycomposer.hxx
index 2bb5039..36a0b87 100644
--- a/extensions/source/propctrlr/propertycomposer.hxx
+++ b/extensions/source/propctrlr/propertycomposer.hxx
@@ -72,7 +72,7 @@ namespace pcr
             @param _rSlaveHandlers
                 the set of slave handlers to invoke. Must not be <NULL/>
         */
-        PropertyComposer( const ::std::vector< css::uno::Reference< css::inspection::XPropertyHandler > >& _rSlaveHandlers );
+        explicit PropertyComposer( const ::std::vector< css::uno::Reference< css::inspection::XPropertyHandler > >& _rSlaveHandlers );
 
     public:
         // XPropertyHandler overridables
@@ -131,7 +131,7 @@ namespace pcr
         class MethodGuard : public ::osl::MutexGuard
         {
         public:
-            MethodGuard( PropertyComposer& _rInstance )
+            explicit MethodGuard( PropertyComposer& _rInstance )
                 : ::osl::MutexGuard( _rInstance.m_aMutex )
             {
                 if ( _rInstance.m_aSlaveHandlers.empty() )
diff --git a/extensions/source/propctrlr/propertycontrolextender.hxx b/extensions/source/propctrlr/propertycontrolextender.hxx
index df93e9e..efdcb18 100644
--- a/extensions/source/propctrlr/propertycontrolextender.hxx
+++ b/extensions/source/propctrlr/propertycontrolextender.hxx
@@ -41,7 +41,7 @@ namespace pcr
     class PropertyControlExtender : public PropertyControlExtender_Base
     {
     public:
-        PropertyControlExtender(
+        explicit PropertyControlExtender(
             const css::uno::Reference< css::inspection::XPropertyControl >& _rxObservedControl
         );
 
diff --git a/extensions/source/propctrlr/propertyhandler.cxx b/extensions/source/propctrlr/propertyhandler.cxx
index 701752a..e62eb9b 100644
--- a/extensions/source/propctrlr/propertyhandler.cxx
+++ b/extensions/source/propctrlr/propertyhandler.cxx
@@ -109,7 +109,7 @@ namespace pcr
         ::osl::MutexGuard aGuard( m_aMutex );
         if ( !m_bSupportedPropertiesAreKnown )
         {
-            m_aSupportedProperties = doDescribeSupportedProperties();
+            m_aSupportedProperties = StlSyntaxSequence<css::beans::Property>(doDescribeSupportedProperties());
             m_bSupportedPropertiesAreKnown = true;
         }
         return m_aSupportedProperties;
diff --git a/extensions/source/propctrlr/propertyhandler.hxx b/extensions/source/propctrlr/propertyhandler.hxx
index e6e7e55..65a0b80 100644
--- a/extensions/source/propctrlr/propertyhandler.hxx
+++ b/extensions/source/propctrlr/propertyhandler.hxx
@@ -97,7 +97,7 @@ namespace pcr
         ::std::unique_ptr< OPropertyInfoService >             m_pInfoService;
 
     protected:
-        PropertyHandler(
+        explicit PropertyHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
         virtual ~PropertyHandler();
@@ -356,7 +356,7 @@ namespace pcr
                                     ,public PropertyHandlerComponent_Base
     {
     protected:
-        PropertyHandlerComponent(
+        explicit PropertyHandlerComponent(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
 
@@ -398,7 +398,7 @@ namespace pcr
     class HandlerComponentBase : public PropertyHandlerComponent
     {
     protected:
-        HandlerComponentBase( const css::uno::Reference< css::uno::XComponentContext >& _rxContext )
+        explicit HandlerComponentBase( const css::uno::Reference< css::uno::XComponentContext >& _rxContext )
             :PropertyHandlerComponent( _rxContext )
         {
         }
diff --git a/extensions/source/propctrlr/pushbuttonnavigation.hxx b/extensions/source/propctrlr/pushbuttonnavigation.hxx
index 13296f7..a293c3e 100644
--- a/extensions/source/propctrlr/pushbuttonnavigation.hxx
+++ b/extensions/source/propctrlr/pushbuttonnavigation.hxx
@@ -43,7 +43,7 @@ namespace pcr
             @param _rxControlModel
                 the control model which is or will be bound
         */
-        PushButtonNavigation(
+        explicit PushButtonNavigation(
             const css::uno::Reference< css::beans::XPropertySet >& _rxControlModel
         );
 
diff --git a/extensions/source/propctrlr/standardcontrol.cxx b/extensions/source/propctrlr/standardcontrol.cxx
index 3910f39..6d19877 100644
--- a/extensions/source/propctrlr/standardcontrol.cxx
+++ b/extensions/source/propctrlr/standardcontrol.cxx
@@ -962,7 +962,7 @@ namespace pcr
         virtual void    Resize() override;
 
     public:
-                        OMultilineFloatingEdit(vcl::Window* _pParen);
+        explicit        OMultilineFloatingEdit(vcl::Window* _pParen);
         virtual         ~OMultilineFloatingEdit();
         virtual void    dispose() override;
         MultiLineEdit&  getEdit() { return *m_aImplEdit.get(); }
@@ -1385,7 +1385,7 @@ namespace pcr
             Sequence< OUString > aStringLines;
             if ( !( _rValue >>= aStringLines ) && _rValue.hasValue() )
                 throw IllegalTypeException();
-            getTypedControlWindow()->SetStringListValue( aStringLines );
+            getTypedControlWindow()->SetStringListValue( StlSyntaxSequence<OUString>(aStringLines) );
         }
         break;
         }
diff --git a/extensions/source/propctrlr/submissionhandler.hxx b/extensions/source/propctrlr/submissionhandler.hxx
index fce5942..1969013 100644
--- a/extensions/source/propctrlr/submissionhandler.hxx
+++ b/extensions/source/propctrlr/submissionhandler.hxx
@@ -74,7 +74,7 @@ namespace pcr
         ::comphelper::OPropertyChangeMultiplexer*   m_pPropChangeMultiplexer;
 
     public:
-        SubmissionPropertyHandler(
+        explicit SubmissionPropertyHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
 
diff --git a/extensions/source/propctrlr/taborder.cxx b/extensions/source/propctrlr/taborder.cxx
index 6ab3612..e650e0c 100644
--- a/extensions/source/propctrlr/taborder.cxx
+++ b/extensions/source/propctrlr/taborder.cxx
@@ -48,7 +48,7 @@ namespace pcr
         Sequence< Reference< XControlModel > > m_aModels;
 
     public:
-        OSimpleTabModel( const Sequence< Reference< XControlModel > >& _rModels )
+        explicit OSimpleTabModel( const Sequence< Reference< XControlModel > >& _rModels )
             :m_aModels( _rModels )
         {
         }
diff --git a/extensions/source/propctrlr/xsddatatypes.hxx b/extensions/source/propctrlr/xsddatatypes.hxx
index 75b1058..b08c65e 100644
--- a/extensions/source/propctrlr/xsddatatypes.hxx
+++ b/extensions/source/propctrlr/xsddatatypes.hxx
@@ -50,7 +50,7 @@ namespace pcr
                             m_xFacetInfo;
 
     public:
-        XSDDataType(
+        explicit XSDDataType(
             const css::uno::Reference< css::xsd::XDataType >& _rxDataType
         );
 
diff --git a/extensions/source/propctrlr/xsdvalidationpropertyhandler.hxx b/extensions/source/propctrlr/xsdvalidationpropertyhandler.hxx
index 0564799..204f452 100644
--- a/extensions/source/propctrlr/xsdvalidationpropertyhandler.hxx
+++ b/extensions/source/propctrlr/xsdvalidationpropertyhandler.hxx
@@ -41,7 +41,7 @@ namespace pcr
         ::std::unique_ptr< XSDValidationHelper >  m_pHelper;
 
     public:
-        XSDValidationPropertyHandler(
+        explicit XSDValidationPropertyHandler(
             const css::uno::Reference< css::uno::XComponentContext >& _rxContext
         );
 
diff --git a/extensions/source/resource/ResourceIndexAccess.cxx b/extensions/source/resource/ResourceIndexAccess.cxx
index 4ddc432..638433f 100644
--- a/extensions/source/resource/ResourceIndexAccess.cxx
+++ b/extensions/source/resource/ResourceIndexAccess.cxx
@@ -40,7 +40,7 @@ namespace
     class ResourceIndexAccessBase : public cppu::WeakImplHelper< css::container::XIndexAccess>
     {
         public:
-            ResourceIndexAccessBase( std::shared_ptr<ResMgr> pResMgr)
+            explicit ResourceIndexAccessBase( std::shared_ptr<ResMgr> pResMgr)
                 : m_pResMgr(pResMgr)
             {
                 OSL_ENSURE(m_pResMgr, "no resource manager given");
@@ -61,7 +61,7 @@ namespace
     class ResourceStringIndexAccess : public ResourceIndexAccessBase
     {
         public:
-            ResourceStringIndexAccess( std::shared_ptr<ResMgr> pResMgr)
+            explicit ResourceStringIndexAccess( std::shared_ptr<ResMgr> pResMgr)
                 : ResourceIndexAccessBase(pResMgr) {}
             // XIndexAccess
             virtual css::uno::Any SAL_CALL getByIndex( ::sal_Int32 Index ) throw (css::lang::IndexOutOfBoundsException, css::lang::WrappedTargetException, css::uno::RuntimeException, std::exception) override;
@@ -73,7 +73,7 @@ namespace
     class ResourceStringListIndexAccess : public ResourceIndexAccessBase
     {
         public:
-            ResourceStringListIndexAccess( std::shared_ptr<ResMgr> pResMgr)
+            explicit ResourceStringListIndexAccess( std::shared_ptr<ResMgr> pResMgr)
                 : ResourceIndexAccessBase(pResMgr) {}
             // XIndexAccess
             virtual css::uno::Any SAL_CALL getByIndex( ::sal_Int32 Index ) throw (css::lang::IndexOutOfBoundsException, css::lang::WrappedTargetException, css::uno::RuntimeException, std::exception) override;


More information about the Libreoffice-commits mailing list