[Libreoffice-commits] core.git: vcl/source

Stephan Bergmann sbergman at redhat.com
Thu Sep 3 03:18:29 PDT 2015


 vcl/source/control/scrbar.cxx |   18 ------------------
 1 file changed, 18 deletions(-)

New commits:
commit c95e3eeeb9950c48e32948e14d3081dff8fd709e
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Sep 3 12:16:53 2015 +0200

    clang-tidy clang-analyzer-deadcode.DeadStores
    
    ...of computing nDraw, since 04c037d8a8f1ca954181d75ab3a7cc648a5d1d63 "refactor
    ScrollBar to use RenderContext" replaced call to ImplDraw(nDraw,this) with call
    to Invalidate()
    
    Change-Id: Ifb9a2494715363c35c19574e85852b488667f97e

diff --git a/vcl/source/control/scrbar.cxx b/vcl/source/control/scrbar.cxx
index 0246276..be52f24 100644
--- a/vcl/source/control/scrbar.cxx
+++ b/vcl/source/control/scrbar.cxx
@@ -135,11 +135,6 @@ void ScrollBar::dispose()
 
 void ScrollBar::ImplUpdateRects( bool bUpdate )
 {
-    sal_uInt16      nOldStateFlags  = mnStateFlags;
-    Rectangle   aOldPage1Rect = maPage1Rect;
-    Rectangle   aOldPage2Rect = maPage2Rect;
-    Rectangle   aOldThumbRect = maThumbRect;
-
     mnStateFlags  &= ~SCRBAR_STATE_BTN1_DISABLE;
     mnStateFlags  &= ~SCRBAR_STATE_BTN2_DISABLE;
 
@@ -217,19 +212,6 @@ void ScrollBar::ImplUpdateRects( bool bUpdate )
 
     if ( bUpdate )
     {
-        sal_uInt16 nDraw = 0;
-        if ( (nOldStateFlags & SCRBAR_STATE_BTN1_DISABLE) !=
-             (mnStateFlags & SCRBAR_STATE_BTN1_DISABLE) )
-            nDraw |= SCRBAR_DRAW_BTN1;
-        if ( (nOldStateFlags & SCRBAR_STATE_BTN2_DISABLE) !=
-             (mnStateFlags & SCRBAR_STATE_BTN2_DISABLE) )
-            nDraw |= SCRBAR_DRAW_BTN2;
-        if ( aOldPage1Rect != maPage1Rect )
-            nDraw |= SCRBAR_DRAW_PAGE1;
-        if ( aOldPage2Rect != maPage2Rect )
-            nDraw |= SCRBAR_DRAW_PAGE2;
-        if ( aOldThumbRect != maThumbRect )
-            nDraw |= SCRBAR_DRAW_THUMB;
         Invalidate();
     }
 }


More information about the Libreoffice-commits mailing list