[Libreoffice-commits] core.git: writerperfect/source

Stephan Bergmann sbergman at redhat.com
Thu Sep 10 06:38:58 PDT 2015


 writerperfect/source/common/WPXSvInputStream.cxx |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

New commits:
commit bb71e3a40067e4ef6c6879e6d26ad20f728dd822
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Sep 10 15:38:14 2015 +0200

    This presumably wants to swallow exceptions from XSeekable::seek
    
    ...instead of doing a needless catch and re-throw
    
    Change-Id: I1b1c593ac19a46aa7acfca753bc8177aa7a8ff12

diff --git a/writerperfect/source/common/WPXSvInputStream.cxx b/writerperfect/source/common/WPXSvInputStream.cxx
index d3befd0..84bcabb 100644
--- a/writerperfect/source/common/WPXSvInputStream.cxx
+++ b/writerperfect/source/common/WPXSvInputStream.cxx
@@ -60,12 +60,11 @@ PositionHolder::PositionHolder(const Reference<XSeekable> &rxSeekable)
 {
 }
 
-PositionHolder::~PositionHolder() try
-{
-    mxSeekable->seek(mnPosition);
-}
-catch (...)
+PositionHolder::~PositionHolder()
 {
+    try {
+        mxSeekable->seek(mnPosition);
+    } catch (...) {}
 }
 
 } // anonymous namespace


More information about the Libreoffice-commits mailing list