[Libreoffice-commits] core.git: Branch 'private/tml/splitgroup' - sc/source

Tor Lillqvist tml at collabora.com
Tue Sep 15 06:00:20 PDT 2015


 sc/source/core/data/formulacell.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 2ba28a0a96a2340dcc87c7341fab0b06db49ba53
Author: Tor Lillqvist <tml at collabora.com>
Date:   Tue Sep 15 15:59:45 2015 +0300

    Update comments

diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx
index 7f8180f..b4ba29b 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -3837,14 +3837,13 @@ bool ScFormulaCell::InterpretFormulaGroup()
     if (mxGroup->mbInvariant && false)
         return InterpretInvariantFormulaGroup();
 
-    // Should obviously be based on some heuristics based on the kind
-    // of OpenCL device or some of its properties.
     int nMaxGroupLength = INT_MAX;
 
 #ifdef WNT
     // Heuristic: Certain old low-end OpenCL implementations don't
     // work for us with too large group lengths. 1000 was determined
-    // empirically to be a good compromise.
+    // empirically to be a good compromise. Looking at the preferred
+    // float vector width seems to be a way to detect these devices.
     if (opencl::gpuEnv.mnPreferredVectorWidthFloat == 4)
         nMaxGroupLength = 1000;
 #endif


More information about the Libreoffice-commits mailing list