[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sd/source
Caolán McNamara
caolanm at redhat.com
Fri Sep 18 05:29:29 PDT 2015
sd/source/filter/ppt/propread.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 301391a6d1257d345ca4df19bfd35d2eefe7f9aa
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Sep 18 12:27:45 2015 +0100
reusing i here from the outer loop is definitely bogus
Change-Id: I4ee52c76b2c1723639185bc99b85d83be5b4fdd7
(cherry picked from commit 637ad743bb74a826ddd4db5efbcd33779b9132cd)
Reviewed-on: https://gerrit.libreoffice.org/18686
Reviewed-by: David Tardon <dtardon at redhat.com>
Tested-by: David Tardon <dtardon at redhat.com>
diff --git a/sd/source/filter/ppt/propread.cxx b/sd/source/filter/ppt/propread.cxx
index ca9cbe0..e4dc401 100644
--- a/sd/source/filter/ppt/propread.cxx
+++ b/sd/source/filter/ppt/propread.cxx
@@ -302,8 +302,8 @@ bool Section::GetDictionary( Dictionary& rDict )
nSize >>= 1;
aStream.Seek( nPos );
sal_Unicode* pWString = reinterpret_cast<sal_Unicode*>(pString);
- for ( i = 0; i < nSize; i++ )
- aStream.ReadUInt16( pWString[ i ] );
+ for (sal_uInt32 j = 0; j < nSize; ++j)
+ aStream.ReadUInt16(pWString[j]);
aString = OUString(pWString, lcl_getMaxSafeStrLen(nSize));
}
else
More information about the Libreoffice-commits
mailing list