[Libreoffice-commits] core.git: sal/rtl

Caolán McNamara caolanm at redhat.com
Fri Sep 18 06:24:33 PDT 2015


 sal/rtl/random.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5db6ec77d851b2aa9f22a735d1d2a9a5465759cc
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Sep 18 13:53:32 2015 +0100

    valgrind: memleak in randompool
    
    regression from
    
    commit 91457fb326dda7bd1fc6d9e1b3afe0667425121c
    Author: Norbert Thiebaud <nthiebaud at gmail.com>
    Date:   Tue Apr 21 20:55:15 2015 -0500
    
        use osl_get_system_random data in rtlRamdomPool
    
    Change-Id: Ib5ff6b7fbd08869d9a6dbc1f4df883d701cf765c

diff --git a/sal/rtl/random.cxx b/sal/rtl/random.cxx
index 48dc886..6a8142e 100644
--- a/sal/rtl/random.cxx
+++ b/sal/rtl/random.cxx
@@ -298,8 +298,8 @@ void SAL_CALL rtl_random_destroyPool (rtlRandomPool Pool) SAL_THROW_EXTERN_C()
         if(pImpl->m_hDigest)
         {
             rtl_digest_destroy (pImpl->m_hDigest);
-            rtl_freeZeroMemory (pImpl, sizeof (RandomPool_Impl));
         }
+        rtl_freeZeroMemory (pImpl, sizeof (RandomPool_Impl));
     }
 }
 


More information about the Libreoffice-commits mailing list