[Libreoffice-commits] core.git: reportdesign/source

Caolán McNamara caolanm at redhat.com
Sun Apr 3 20:52:50 UTC 2016


 reportdesign/source/ui/dlg/GroupsSorting.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e860d1ebaf5d009d2b73784a400539f8902c06b0
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Apr 3 21:52:05 2016 +0100

    coverity#1358027 silence Using invalid iterator
    
    Change-Id: Id4306122a7d51491392996b8914e1411e9a4ed0f

diff --git a/reportdesign/source/ui/dlg/GroupsSorting.cxx b/reportdesign/source/ui/dlg/GroupsSorting.cxx
index 2beba3d..d81924b 100644
--- a/reportdesign/source/ui/dlg/GroupsSorting.cxx
+++ b/reportdesign/source/ui/dlg/GroupsSorting.cxx
@@ -668,8 +668,8 @@ void SAL_CALL OFieldExpressionControl::elementRemoved(const container::Container
     sal_Int32 nGroupPos = 0;
     if ( evt.Accessor >>= nGroupPos )
     {
-        ::std::vector<sal_Int32>::iterator aFind = ::std::find(m_aGroupPositions.begin(),m_aGroupPositions.end(),nGroupPos);
-        ::std::vector<sal_Int32>::const_iterator aEnd  = m_aGroupPositions.end();
+        std::vector<sal_Int32>::iterator aEnd = m_aGroupPositions.end();
+        std::vector<sal_Int32>::iterator aFind = std::find(m_aGroupPositions.begin(), aEnd, nGroupPos);
         if (aFind != aEnd)
         {
             *aFind = NO_GROUP;


More information about the Libreoffice-commits mailing list