[Libreoffice-commits] core.git: include/svl svl/source vcl/source

Noel Grandin noel at peralex.com
Mon Apr 4 12:16:04 UTC 2016


 include/svl/filerec.hxx        |    5 ++---
 include/svl/imageitm.hxx       |    2 +-
 include/svl/zformat.hxx        |    3 +--
 svl/source/filerec/filerec.cxx |    5 ++---
 svl/source/items/imageitm.cxx  |    4 ++--
 svl/source/numbers/zformat.cxx |    5 ++---
 vcl/source/window/toolbox.cxx  |    2 +-
 7 files changed, 11 insertions(+), 15 deletions(-)

New commits:
commit 1e55aad7990a47a7d4353ec3365ca46b6c54a10c
Author: Noel Grandin <noel at peralex.com>
Date:   Fri Apr 1 16:06:38 2016 +0200

    loplugin:constantparam in svl
    
    Change-Id: I6c336034a12fda493825b4a8388d3bde6bead910
    Reviewed-on: https://gerrit.libreoffice.org/23729
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/include/svl/filerec.hxx b/include/svl/filerec.hxx
index 6581610..7088e37 100644
--- a/include/svl/filerec.hxx
+++ b/include/svl/filerec.hxx
@@ -436,8 +436,7 @@ protected:
 
                         SfxMultiVarRecordWriter( sal_uInt8 nRecordType,
                                                  SvStream *pStream,
-                                                 sal_uInt16 nRecordTag,
-                                                 sal_uInt8 nRecordVer );
+                                                 sal_uInt16 nRecordTag );
 
     void                FlushContent_Impl();
 
@@ -627,7 +626,7 @@ inline SfxMultiFixRecordWriter::~SfxMultiFixRecordWriter()
  */
 inline SfxMultiMixRecordWriter::SfxMultiMixRecordWriter( SvStream* pStream,
                                                          sal_uInt16 nRecordTag )
-: SfxMultiVarRecordWriter( SFX_REC_TYPE_MIXTAGS, pStream, nRecordTag, 0 )
+: SfxMultiVarRecordWriter( SFX_REC_TYPE_MIXTAGS, pStream, nRecordTag )
 {
 }
 
diff --git a/include/svl/imageitm.hxx b/include/svl/imageitm.hxx
index 570c745..bfe972e 100644
--- a/include/svl/imageitm.hxx
+++ b/include/svl/imageitm.hxx
@@ -29,7 +29,7 @@ class SVL_DLLPUBLIC SfxImageItem : public SfxInt16Item
     SfxImageItem_Impl*      pImp;
 public:
                             static SfxPoolItem* CreateDefault();
-                            SfxImageItem( sal_uInt16 nWhich = 0, sal_uInt16 nImage = 0 );
+                            SfxImageItem( sal_uInt16 nWhich = 0 );
                             SfxImageItem( const SfxImageItem& );
     virtual                 ~SfxImageItem();
 
diff --git a/include/svl/zformat.hxx b/include/svl/zformat.hxx
index 2b3569e..0289e8e 100644
--- a/include/svl/zformat.hxx
+++ b/include/svl/zformat.hxx
@@ -167,8 +167,7 @@ public:
                    ImpSvNumberformatScan* pSc,
                    ImpSvNumberInputScan* pISc,
                    sal_Int32& nCheckPos,
-                   LanguageType& eLan,
-                   bool bStand = false );
+                   LanguageType& eLan );
 
     // Copy ctor
     SvNumberformat( SvNumberformat& rFormat );
diff --git a/svl/source/filerec/filerec.cxx b/svl/source/filerec/filerec.cxx
index e1f9db7..4556d2c 100644
--- a/svl/source/filerec/filerec.cxx
+++ b/svl/source/filerec/filerec.cxx
@@ -339,9 +339,8 @@ sal_uInt32 SfxMultiFixRecordWriter::Close()
  */
 SfxMultiVarRecordWriter::SfxMultiVarRecordWriter(sal_uInt8  nRecordType,
                                                  SvStream*  pStream,
-                                                 sal_uInt16 nRecordTag,
-                                                 sal_uInt8  nRecordVer)
-:   SfxMultiFixRecordWriter( nRecordType, pStream, nRecordTag, nRecordVer ),
+                                                 sal_uInt16 nRecordTag)
+:   SfxMultiFixRecordWriter( nRecordType, pStream, nRecordTag, 0 ),
     _nContentVer( 0 )
 {
 }
diff --git a/svl/source/items/imageitm.cxx b/svl/source/items/imageitm.cxx
index e956460..9d07db3 100644
--- a/svl/source/items/imageitm.cxx
+++ b/svl/source/items/imageitm.cxx
@@ -34,8 +34,8 @@ struct SfxImageItem_Impl
 };
 
 
-SfxImageItem::SfxImageItem( sal_uInt16 which, sal_uInt16 nImage )
-    : SfxInt16Item( which, nImage )
+SfxImageItem::SfxImageItem( sal_uInt16 which )
+    : SfxInt16Item( which, 0 )
 {
     pImp = new SfxImageItem_Impl;
     pImp->nAngle = 0;
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index 99b086b..8238315 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -591,8 +591,7 @@ SvNumberformat::SvNumberformat(OUString& rString,
                                ImpSvNumberformatScan* pSc,
                                ImpSvNumberInputScan* pISc,
                                sal_Int32& nCheckPos,
-                               LanguageType& eLan,
-                               bool bStan)
+                               LanguageType& eLan)
         : rScan(*pSc)
         , bAdditionalBuiltin( false )
         , bStarFlag( false )
@@ -623,7 +622,7 @@ SvNumberformat::SvNumberformat(OUString& rString,
     {
         maLocale.meLanguage = eLan;
     }
-    bStandard = bStan;
+    bStandard = false;
     bIsUsed = false;
     fLimit1 = 0.0;
     fLimit2 = 0.0;
diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx
index d7ea498..eb3b005 100644
--- a/vcl/source/window/toolbox.cxx
+++ b/vcl/source/window/toolbox.cxx
@@ -4563,7 +4563,7 @@ void ToolBox::statusChanged( const css::frame::FeatureStateEvent& Event )
     // Update image mirroring/rotation
     if ( Event.FeatureURL.Complete == ".uno:ImageOrientation" )
     {
-        SfxImageItem aItem( 1, 0 );
+        SfxImageItem aItem( 1 );
         aItem.PutValue( Event.State, 0 );
 
         mbImagesMirrored = aItem.IsMirrored();


More information about the Libreoffice-commits mailing list