[Libreoffice-commits] core.git: framework/source

akash akash96j at gmail.com
Tue Apr 5 14:50:05 UTC 2016


 framework/source/fwe/helper/titlehelper.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 1087ac3755da09f20a04f451a781f4fc8b53a680
Author: akash <akash96j at gmail.com>
Date:   Fri Apr 1 23:36:35 2016 +0530

    Prevent broadcast of title change events without a source
    
    Do not send title changed event if the source of the event is null.
    This case can occur in multi-threaded scenario where one thread calls
    disposing while some other thread calls impl_sendTitleChangedEvent().
    
    Change-Id: I86a65824ab5c60a3fd8d3fb323f6d78944b57a23
    Reviewed-on: https://gerrit.libreoffice.org/23736
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Michael Stahl <mstahl at redhat.com>

diff --git a/framework/source/fwe/helper/titlehelper.cxx b/framework/source/fwe/helper/titlehelper.cxx
index 52cb419..cbd18f9 100644
--- a/framework/source/fwe/helper/titlehelper.cxx
+++ b/framework/source/fwe/helper/titlehelper.cxx
@@ -268,6 +268,9 @@ void TitleHelper::impl_sendTitleChangedEvent ()
     aLock.clear ();
     // <- SYNCHRONIZED
 
+    if( ! (aEvent.Source).is() )
+        return;
+
     ::cppu::OInterfaceContainerHelper* pContainer = m_aListener.getContainer( cppu::UnoType<css::frame::XTitleChangeListener>::get());
     if ( ! pContainer)
         return;


More information about the Libreoffice-commits mailing list