[Libreoffice-commits] core.git: framework/qa

Akash Jain akash96j at gmail.com
Wed Apr 13 06:31:42 UTC 2016


 framework/qa/complex/XTitle/CheckXTitle.java |   14 --------------
 1 file changed, 14 deletions(-)

New commits:
commit e1d777722efcc9e6ae9900cff69f35b0ef8a1d3e
Author: Akash Jain <akash96j at gmail.com>
Date:   Wed Apr 13 09:44:46 2016 +0530

    remove unused m_xFrame in CheckXTitle unit test
    
    Change-Id: I1b654b308b79d13d23a1b9a935fd2eaf84836d91
    Reviewed-on: https://gerrit.libreoffice.org/24044
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/framework/qa/complex/XTitle/CheckXTitle.java b/framework/qa/complex/XTitle/CheckXTitle.java
index 3e98259..4228f5b 100644
--- a/framework/qa/complex/XTitle/CheckXTitle.java
+++ b/framework/qa/complex/XTitle/CheckXTitle.java
@@ -69,9 +69,6 @@ public class CheckXTitle
 
     // members
 
-    /** provides XComponentLoader interface */
-    private XFrame m_xFrame = null;
-
     /** will be set to xDesktop OR xFrame. */
     private XComponentLoader m_xLoader = null;
 
@@ -97,11 +94,6 @@ public class CheckXTitle
         /* provides XComponentLoader interface. */
         XFrame xDesktop = UnoRuntime.queryInterface(XFrame.class, m_xMSF.createInstance("com.sun.star.frame.Desktop"));
 
-        // create frame instance
-        m_xFrame = xDesktop.findFrame("testFrame_titleChecker",
-                                        FrameSearchFlag.TASKS | FrameSearchFlag.CREATE);
-        assertNotNull("Couldn't create test frame.", m_xFrame);
-
         // define default loader
         m_xLoader = UnoRuntime.queryInterface(XComponentLoader.class, xDesktop);
         assertNotNull("Desktop service doesn't support needed component loader interface.", m_xLoader);
@@ -116,10 +108,6 @@ public class CheckXTitle
      */
     @After public void after() throws Exception
     {
-        XCloseable xClose = UnoRuntime.queryInterface(XCloseable.class, m_xFrame);
-        xClose.close(false);
-
-        m_xFrame  = null;
         m_xLoader = null;
         m_xParser = null;
         m_xMSF    = null;
@@ -223,11 +211,9 @@ public class CheckXTitle
 
         // close document
         xDisProv = UnoRuntime.queryInterface( XDispatchProvider.class, xModel.getCurrentController() );
-        // todo: execute this on a new thread using executorservice and terminate it after some time
         try{
                 prepareQueryAndDispatch( xDisProv, UNO_URL_FOR_CLOSING_DOC );
         } catch( Exception e ) {
-        // cr: there is no exception being thrown when there should be one
             fail(e.toString());
         }
 


More information about the Libreoffice-commits mailing list