[Libreoffice-commits] core.git: 18 commits - chart2/inc chart2/source cui/source include/svx include/toolkit include/ucbhelper include/unoidl include/unotest include/vbahelper include/xmloff lotuswordpro/source reportdesign/inc reportdesign/source sc/inc sc/source sdext/source sd/inc sd/source slideshow/source svx/inc svx/source sw/inc sw/source ucbhelper/source ucb/source vbahelper/source writerfilter/source xmloff/inc xmloff/source
Noel Grandin
noel at peralex.com
Thu Apr 14 07:22:11 UTC 2016
chart2/inc/ChartModel.hxx | 2
chart2/source/controller/inc/AccessibleBase.hxx | 2
chart2/source/controller/inc/CharacterPropertyItemConverter.hxx | 2
chart2/source/controller/inc/ChartController.hxx | 2
chart2/source/controller/inc/ChartDocumentWrapper.hxx | 4 -
chart2/source/controller/inc/ItemConverter.hxx | 2
chart2/source/controller/inc/ObjectHierarchy.hxx | 2
chart2/source/controller/inc/SelectionHelper.hxx | 2
chart2/source/controller/inc/dlg_ObjectProperties.hxx | 4 -
chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx | 2
chart2/source/inc/InternalData.hxx | 4 -
chart2/source/inc/MediaDescriptorHelper.hxx | 2
chart2/source/inc/NumberFormatterWrapper.hxx | 2
chart2/source/inc/ObjectIdentifier.hxx | 4 -
chart2/source/inc/ReferenceSizeProvider.hxx | 2
chart2/source/model/template/ChartType.hxx | 2
chart2/source/model/template/ChartTypeTemplate.hxx | 2
chart2/source/model/template/DataInterpreter.hxx | 2
chart2/source/tools/ImplOPropertySet.hxx | 2
chart2/source/tools/InternalData.cxx | 4 -
chart2/source/tools/RegressionCurveModel.cxx | 14 +--
chart2/source/tools/RegressionCurveModel.hxx | 14 +--
chart2/source/view/axes/VAxisProperties.hxx | 2
chart2/source/view/inc/GL3DRenderer.hxx | 6 -
chart2/source/view/inc/PlottingPositionHelper.hxx | 2
chart2/source/view/inc/ScaleAutomatism.hxx | 4 -
chart2/source/view/inc/VCoordinateSystem.hxx | 5 -
chart2/source/view/inc/VDataSeries.hxx | 10 +-
chart2/source/view/main/GL3DRenderer.cxx | 6 -
chart2/source/view/main/VDataSeries.cxx | 2
cui/source/customize/macropg_impl.hxx | 2
cui/source/dialogs/SpellDialog.cxx | 2
cui/source/inc/cfg.hxx | 18 ++--
cui/source/inc/cuitabarea.hxx | 18 ++--
cui/source/inc/cuitabline.hxx | 8 +-
cui/source/inc/iconcdlg.hxx | 2
cui/source/inc/insdlg.hxx | 2
cui/source/inc/optdict.hxx | 4 -
cui/source/inc/scriptdlg.hxx | 4 -
cui/source/inc/thesdlg.hxx | 2
cui/source/options/cfgchart.hxx | 2
cui/source/options/personalization.cxx | 2
cui/source/options/personalization.hxx | 2
cui/source/options/personasdochandler.hxx | 2
include/svx/AccessibleControlShape.hxx | 2
include/svx/AccessibleShape.hxx | 2
include/svx/AccessibleShapeTreeInfo.hxx | 12 +--
include/svx/EnhancedCustomShape2d.hxx | 2
include/svx/SmartTagItem.hxx | 4 -
include/svx/SmartTagMgr.hxx | 2
include/svx/dlgctrl.hxx | 2
include/svx/drawitem.hxx | 12 +--
include/svx/fmsrcimp.hxx | 2
include/svx/galleryitem.hxx | 4 -
include/svx/galtheme.hxx | 2
include/svx/gridctrl.hxx | 2
include/svx/nbdtmg.hxx | 2
include/svx/scene3d.hxx | 2
include/svx/sdr/overlay/overlaymanager.hxx | 4 -
include/svx/sdr/overlay/overlayobject.hxx | 2
include/svx/sdr/overlay/overlaypolypolygon.hxx | 2
include/svx/sidebar/AreaPropertyPanelBase.hxx | 2
include/svx/svdedxv.hxx | 2
include/svx/svdhdl.hxx | 2
include/svx/svdmodel.hxx | 2
include/svx/svdobj.hxx | 6 -
include/svx/svdoole2.hxx | 2
include/svx/svdouno.hxx | 2
include/svx/svdpagv.hxx | 4 -
include/svx/svdpntv.hxx | 2
include/svx/svxgrahicitem.hxx | 2
include/svx/ucsubset.hxx | 2
include/svx/unoshape.hxx | 2
include/svx/xbitmap.hxx | 2
include/svx/xgrad.hxx | 6 -
include/svx/xhatch.hxx | 2
include/svx/xlnedit.hxx | 2
include/svx/xlnstit.hxx | 2
include/toolkit/awt/vclxdevice.hxx | 2
include/ucbhelper/interactionrequest.hxx | 2
include/unoidl/unoidl.hxx | 18 ++--
include/unotest/bootstrapfixturebase.hxx | 4 -
include/unotest/directories.hxx | 4 -
include/unotest/officeconnection.hxx | 2
include/vbahelper/vbadocumentbase.hxx | 2
include/xmloff/XMLTextMasterPageContext.hxx | 2
include/xmloff/shapeexport.hxx | 4 -
include/xmloff/table/XMLTableImport.hxx | 6 -
include/xmloff/txtparae.hxx | 14 +--
include/xmloff/xmlexp.hxx | 6 -
include/xmloff/xmlimp.hxx | 2
lotuswordpro/source/filter/lwpatomholder.hxx | 2
lotuswordpro/source/filter/lwpbackgroundoverride.hxx | 2
lotuswordpro/source/filter/lwpcelllayout.hxx | 2
lotuswordpro/source/filter/lwpfoundry.hxx | 2
lotuswordpro/source/filter/lwpfrib.hxx | 2
lotuswordpro/source/filter/lwpfribmark.hxx | 2
lotuswordpro/source/filter/lwpfribsection.hxx | 4 -
lotuswordpro/source/filter/lwpfribtext.hxx | 4 -
lotuswordpro/source/filter/lwpgrfobj.hxx | 2
lotuswordpro/source/filter/lwplayout.hxx | 4 -
lotuswordpro/source/filter/lwplaypiece.hxx | 4 -
lotuswordpro/source/filter/lwpmarker.hxx | 6 -
lotuswordpro/source/filter/lwpoverride.hxx | 4 -
lotuswordpro/source/filter/lwppara.hxx | 8 +-
lotuswordpro/source/filter/lwpparaproperty.hxx | 4 -
lotuswordpro/source/filter/lwpproplist.hxx | 4 -
lotuswordpro/source/filter/lwpshadow.hxx | 4 -
lotuswordpro/source/filter/lwpsilverbullet.hxx | 8 --
lotuswordpro/source/filter/lwpstory.hxx | 2
lotuswordpro/source/filter/lwptablelayout.hxx | 4 -
lotuswordpro/source/filter/lwptblcell.hxx | 8 +-
lotuswordpro/source/filter/xfilter/xfbookmark.hxx | 4 -
lotuswordpro/source/filter/xfilter/xfcontent.hxx | 2
lotuswordpro/source/filter/xfilter/xfdrawareastyle.hxx | 4 -
lotuswordpro/source/filter/xfilter/xfdrawlinestyle.hxx | 4 -
lotuswordpro/source/filter/xfilter/xffont.hxx | 4 -
lotuswordpro/source/filter/xfilter/xffontdecl.hxx | 4 -
lotuswordpro/source/filter/xfilter/xfnumberstyle.hxx | 2
lotuswordpro/source/filter/xfilter/xfparastyle.hxx | 6 -
lotuswordpro/source/filter/xfilter/xfsaxattrlist.hxx | 4 -
lotuswordpro/source/filter/xfilter/xfshadow.hxx | 4 -
lotuswordpro/source/filter/xfilter/xftextstyle.hxx | 2
reportdesign/inc/RptObject.hxx | 4 -
reportdesign/inc/RptPage.hxx | 2
reportdesign/inc/UndoActions.hxx | 2
reportdesign/source/core/inc/Group.hxx | 2
reportdesign/source/filter/xml/xmlExport.hxx | 4 -
reportdesign/source/filter/xml/xmlTable.hxx | 2
reportdesign/source/filter/xml/xmlfilter.cxx | 2
reportdesign/source/filter/xml/xmlfilter.hxx | 10 +-
reportdesign/source/ui/dlg/Navigator.cxx | 2
reportdesign/source/ui/inc/DesignView.hxx | 4 -
reportdesign/source/ui/inc/GeometryHandler.hxx | 2
reportdesign/source/ui/inc/ReportController.hxx | 8 +-
reportdesign/source/ui/inc/ReportSection.hxx | 2
reportdesign/source/ui/inc/ScrollHelper.hxx | 2
reportdesign/source/ui/inc/ViewsWindow.hxx | 4 -
sc/inc/addincol.hxx | 8 +-
sc/inc/chgtrack.hxx | 2
sc/inc/chgviset.hxx | 4 -
sc/inc/conditio.hxx | 2
sc/inc/defaultsoptions.hxx | 2
sc/inc/document.hxx | 4 -
sc/inc/dpgroup.hxx | 2
sc/inc/formulacell.hxx | 2
sc/inc/formulaopt.hxx | 6 -
sc/inc/rangenam.hxx | 4 -
sc/inc/recursionhelper.hxx | 2
sc/inc/scmatrix.hxx | 2
sc/inc/textuno.hxx | 2
sc/inc/token.hxx | 2
sc/source/core/data/documen9.cxx | 2
sc/source/core/data/dpobject.cxx | 2
sc/source/core/inc/interpre.hxx | 2
sc/source/filter/excel/xeformula.cxx | 2
sc/source/filter/excel/xename.cxx | 2
sc/source/filter/inc/excrecds.hxx | 2
sc/source/filter/inc/fapihelper.hxx | 2
sc/source/filter/inc/xcl97rec.hxx | 2
sc/source/filter/inc/xechart.hxx | 4 -
sc/source/filter/inc/xichart.hxx | 6 -
sc/source/filter/inc/xipivot.hxx | 2
sc/source/filter/inc/xlroot.hxx | 2
sc/source/filter/oox/workbookhelper.cxx | 4 -
sc/source/filter/xml/xmlexprt.hxx | 4 -
sc/source/filter/xml/xmlimprt.hxx | 8 +-
sc/source/filter/xml/xmlsubti.hxx | 6 -
sc/source/ui/app/drwtrans.cxx | 2
sc/source/ui/inc/cbutton.hxx | 4 -
sc/source/ui/inc/drwtrans.hxx | 2
sc/source/ui/inc/gridwin.hxx | 2
sc/source/ui/inc/namepast.hxx | 2
sc/source/ui/inc/notemark.hxx | 2
sc/source/ui/inc/preview.hxx | 2
sc/source/ui/inc/printfun.hxx | 6 -
sc/source/ui/inc/tphfedit.hxx | 2
sc/source/ui/inc/viewdata.hxx | 2
sc/source/ui/namedlg/namepast.cxx | 2
sc/source/ui/vba/vbachart.hxx | 2
sc/source/ui/vba/vbaformat.hxx | 2
sc/source/ui/vba/vbaformatconditions.hxx | 2
sc/source/ui/vba/vbanames.hxx | 2
sc/source/ui/vba/vbaworksheet.hxx | 4 -
sd/inc/CustomAnimationEffect.hxx | 6 -
sd/inc/drawdoc.hxx | 2
sd/inc/sdpage.hxx | 6 -
sd/source/ui/animations/CustomAnimationList.cxx | 2
sd/source/ui/annotations/annotationtag.hxx | 2
sd/source/ui/framework/configuration/ConfigurationUpdater.hxx | 4 -
sd/source/ui/func/fuconcs.cxx | 2
sd/source/ui/inc/DrawDocShell.hxx | 2
sd/source/ui/inc/DrawViewShell.hxx | 2
sd/source/ui/inc/FrameView.hxx | 2
sd/source/ui/inc/SlideSorter.hxx | 8 +-
sd/source/ui/inc/ViewShell.hxx | 4 -
sd/source/ui/inc/ViewTabBar.hxx | 2
sd/source/ui/inc/Window.hxx | 6 -
sd/source/ui/inc/framework/FrameworkHelper.hxx | 2
sd/source/ui/inc/framework/ViewShellWrapper.hxx | 2
sd/source/ui/inc/fuconcs.hxx | 2
sd/source/ui/remotecontrol/ZeroconfService.hxx | 2
sd/source/ui/sidebar/MasterPageContainer.cxx | 4 -
sd/source/ui/sidebar/MasterPageDescriptor.cxx | 2
sd/source/ui/sidebar/MasterPageDescriptor.hxx | 2
sd/source/ui/slidesorter/cache/SlsBitmapCache.cxx | 4 -
sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx | 2
sd/source/ui/slidesorter/inc/controller/SlsCurrentSlideManager.hxx | 2
sd/source/ui/slidesorter/inc/controller/SlsPageSelector.hxx | 2
sd/source/ui/slidesorter/inc/controller/SlsProperties.hxx | 8 +-
sd/source/ui/slidesorter/inc/controller/SlsSelectionManager.hxx | 2
sd/source/ui/slidesorter/inc/model/SlsPageDescriptor.hxx | 2
sd/source/ui/slidesorter/inc/model/SlsVisualState.hxx | 2
sd/source/ui/slidesorter/inc/view/SlideSorterView.hxx | 2
sd/source/ui/slidesorter/inc/view/SlsLayouter.hxx | 6 -
sd/source/ui/slidesorter/inc/view/SlsPageObjectLayouter.hxx | 4 -
sd/source/ui/view/DocumentRenderer.cxx | 2
sdext/source/presenter/PresenterBitmapContainer.cxx | 2
sdext/source/presenter/PresenterBitmapContainer.hxx | 2
sdext/source/presenter/PresenterController.cxx | 20 ++---
sdext/source/presenter/PresenterController.hxx | 20 ++---
sdext/source/presenter/PresenterNotesView.cxx | 2
sdext/source/presenter/PresenterNotesView.hxx | 2
sdext/source/presenter/PresenterPaneBase.cxx | 8 +-
sdext/source/presenter/PresenterPaneBase.hxx | 8 +-
sdext/source/presenter/PresenterSpritePane.cxx | 2
sdext/source/presenter/PresenterSpritePane.hxx | 2
sdext/source/presenter/PresenterTextView.cxx | 6 -
sdext/source/presenter/PresenterTextView.hxx | 6 -
sdext/source/presenter/PresenterToolBar.cxx | 14 +--
sdext/source/presenter/PresenterToolBar.hxx | 6 -
slideshow/source/engine/activities/activitybase.hxx | 4 -
slideshow/source/engine/shapeattributelayer.cxx | 2
slideshow/source/engine/shapes/drawshapesubsetting.cxx | 2
slideshow/source/engine/shapes/drawshapesubsetting.hxx | 2
slideshow/source/engine/shapes/shapeimporter.cxx | 2
slideshow/source/engine/shapes/viewappletshape.cxx | 2
slideshow/source/engine/shapes/viewappletshape.hxx | 2
slideshow/source/engine/shapes/viewbackgroundshape.cxx | 2
slideshow/source/engine/shapes/viewbackgroundshape.hxx | 2
slideshow/source/engine/shapes/viewmediashape.cxx | 2
slideshow/source/engine/shapes/viewmediashape.hxx | 2
slideshow/source/engine/shapes/viewshape.cxx | 2
slideshow/source/engine/shapes/viewshape.hxx | 4 -
slideshow/source/engine/shapesubset.cxx | 2
slideshow/source/engine/slide/slideimpl.cxx | 2
slideshow/source/engine/slide/userpaintoverlay.cxx | 2
slideshow/source/engine/slidebitmap.cxx | 2
slideshow/source/engine/slideview.cxx | 2
slideshow/source/inc/shapeattributelayer.hxx | 2
slideshow/source/inc/shapeattributelayerholder.hxx | 2
slideshow/source/inc/shapeimporter.hxx | 2
slideshow/source/inc/shapesubset.hxx | 2
slideshow/source/inc/slidebitmap.hxx | 2
svx/inc/galbrws2.hxx | 2
svx/source/dialog/dlgctrl.cxx | 2
svx/source/dialog/docrecovery.cxx | 4 -
svx/source/dialog/imapwnd.hxx | 2
svx/source/form/formcontroller.cxx | 2
svx/source/gallery2/galtheme.cxx | 2
svx/source/inc/datanavi.hxx | 4 -
svx/source/inc/docrecovery.hxx | 4 -
svx/source/inc/filtnav.hxx | 2
svx/source/inc/fmexch.hxx | 4 -
svx/source/inc/fmexpl.hxx | 4 -
svx/source/inc/fmitems.hxx | 2
svx/source/inc/fmshimp.hxx | 4 -
svx/source/inc/fmvwimp.hxx | 2
svx/source/inc/svdoutlinercache.hxx | 2
svx/source/inc/tabwin.hxx | 2
svx/source/sdr/attribute/sdrformtextattribute.cxx | 2
svx/source/sidebar/area/AreaPropertyPanelBase.cxx | 2
svx/source/svdraw/svdograf.cxx | 2
svx/source/svdraw/svdoole2.cxx | 6 -
svx/source/table/accessiblecell.hxx | 2
sw/inc/SidebarWin.hxx | 2
sw/inc/SwAppletImpl.hxx | 2
sw/inc/ToxWhitespaceStripper.hxx | 2
sw/inc/accmap.hxx | 2
sw/inc/anchoredobject.hxx | 2
sw/inc/authfld.hxx | 2
sw/inc/cellfml.hxx | 2
sw/inc/chpfld.hxx | 8 +-
sw/inc/dbfld.hxx | 2
sw/inc/dbmgr.hxx | 2
sw/inc/ddefld.hxx | 2
sw/inc/doc.hxx | 10 +-
sw/inc/docufld.hxx | 14 +--
sw/inc/expfld.hxx | 32 ++++----
sw/inc/fmtautofmt.hxx | 4 -
sw/inc/fmtftn.hxx | 2
sw/inc/fmtmeta.hxx | 2
sw/inc/fmtpdsc.hxx | 2
sw/inc/fmtruby.hxx | 4 -
sw/inc/fmturl.hxx | 6 -
sw/inc/format.hxx | 2
sw/inc/hints.hxx | 2
sw/inc/lineinfo.hxx | 2
sw/inc/modcfg.hxx | 8 +-
sw/inc/modeltoviewhelper.hxx | 2
sw/inc/ndgrf.hxx | 2
sw/inc/ndole.hxx | 4 -
sw/inc/numrule.hxx | 4 -
sw/inc/pagedesc.hxx | 2
sw/inc/printdata.hxx | 4 -
sw/inc/reffld.hxx | 2
sw/inc/rubylist.hxx | 2
sw/inc/section.hxx | 8 +-
sw/inc/shellio.hxx | 12 +--
sw/inc/splargs.hxx | 2
sw/inc/swmodule.hxx | 4 -
sw/inc/swtable.hxx | 2
sw/inc/tblafmt.hxx | 2
sw/inc/tox.hxx | 38 +++++-----
sw/inc/unodraw.hxx | 2
sw/inc/unosett.hxx | 2
sw/source/core/doc/list.cxx | 4 -
sw/source/core/doc/number.cxx | 2
sw/source/core/edit/edlingu.cxx | 4 -
sw/source/core/fields/expfld.cxx | 4 -
sw/source/core/fields/reffld.cxx | 2
sw/source/core/inc/swblocks.hxx | 6 -
sw/source/core/text/guess.hxx | 2
sw/source/core/text/inftxt.hxx | 2
sw/source/core/text/porfld.hxx | 2
sw/source/core/text/porftn.hxx | 2
sw/source/core/txtnode/fmtatr2.cxx | 2
sw/source/core/unocore/unostyle.cxx | 4 -
sw/source/filter/ascii/wrtasc.hxx | 2
sw/source/filter/html/htmltab.cxx | 2
sw/source/filter/ww8/WW8TableInfo.hxx | 8 +-
sw/source/filter/ww8/docxattributeoutput.hxx | 2
sw/source/filter/ww8/docxexport.hxx | 2
sw/source/filter/ww8/writerhelper.hxx | 4 -
sw/source/filter/ww8/ww8par.hxx | 6 -
sw/source/filter/ww8/ww8toolbar.hxx | 2
sw/source/filter/xml/xmlimpit.hxx | 4 -
sw/source/ui/vba/vbafield.cxx | 2
sw/source/ui/vba/vbalisthelper.hxx | 2
sw/source/ui/vba/vbapalette.hxx | 2
sw/source/ui/vba/vbarange.hxx | 4 -
sw/source/uibase/dbui/dbmgr.cxx | 2
sw/source/uibase/dbui/dbtree.cxx | 2
sw/source/uibase/inc/break.hxx | 4 -
sw/source/uibase/inc/concustomshape.hxx | 2
sw/source/uibase/inc/edtwin.hxx | 4 -
sw/source/uibase/inc/fldmgr.hxx | 8 +-
sw/source/uibase/inc/insfnote.hxx | 2
sw/source/uibase/inc/javaedit.hxx | 4 -
sw/source/uibase/inc/mailmergewizard.hxx | 2
sw/source/uibase/inc/mailmrge.hxx | 2
sw/source/uibase/inc/pview.hxx | 2
sw/source/uibase/inc/swuicnttab.hxx | 4 -
sw/source/uibase/inc/toxmgr.hxx | 8 +-
sw/source/uibase/ribbar/concustomshape.cxx | 2
ucb/source/core/providermap.hxx | 2
ucb/source/inc/regexpmap.hxx | 2
ucb/source/sorter/sortresult.hxx | 2
ucb/source/ucp/cmis/auth_provider.hxx | 2
ucb/source/ucp/file/filinsreq.hxx | 2
ucb/source/ucp/file/filtask.hxx | 2
ucb/source/ucp/ftp/ftpurl.hxx | 6 -
ucb/source/ucp/tdoc/tdoc_stgelems.hxx | 2
ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx | 2
ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx | 2
ucbhelper/source/provider/interactionrequest.cxx | 3
vbahelper/source/vbahelper/vbacommandbarhelper.hxx | 6 -
writerfilter/source/dmapper/DomainMapper_Impl.hxx | 26 +++---
writerfilter/source/dmapper/GraphicImport.hxx | 2
writerfilter/source/dmapper/LatentStyleHandler.cxx | 2
writerfilter/source/dmapper/LatentStyleHandler.hxx | 2
writerfilter/source/dmapper/NumberingManager.hxx | 14 +--
writerfilter/source/dmapper/OLEHandler.hxx | 6 -
writerfilter/source/dmapper/PropertyMap.hxx | 6 -
writerfilter/source/dmapper/TableData.hxx | 6 -
writerfilter/source/dmapper/TableManager.hxx | 6 -
writerfilter/source/dmapper/TablePositionHandler.hxx | 8 +-
writerfilter/source/dmapper/TblStylePrHandler.hxx | 2
writerfilter/source/dmapper/TextEffectsHandler.hxx | 2
writerfilter/source/dmapper/WrapPolygonHandler.hxx | 2
writerfilter/source/ooxml/OOXMLFastContextHandler.hxx | 6 -
writerfilter/source/ooxml/OOXMLStreamImpl.hxx | 2
writerfilter/source/rtftok/rtfdocumentimpl.hxx | 2
xmloff/inc/txtfldi.hxx | 2
xmloff/inc/txtvfldi.hxx | 2
xmloff/source/chart/SchXMLExport.cxx | 4 -
xmloff/source/draw/sdxmlimp_impl.hxx | 2
xmloff/source/transform/PersAttrListTContext.hxx | 2
xmloff/source/xforms/XFormsModelContext.hxx | 2
389 files changed, 726 insertions(+), 732 deletions(-)
New commits:
commit 84a86d8a085844fafe3c5c7abc63bfa6d18ae715
Author: Noel Grandin <noel at peralex.com>
Date: Wed Apr 13 15:42:27 2016 +0200
loplugin:passstuffbyref in cui
Change-Id: I13c2956ad5012373a41c8e6c2af70583fa18c339
diff --git a/cui/source/customize/macropg_impl.hxx b/cui/source/customize/macropg_impl.hxx
index efb53e6..514ba9c 100644
--- a/cui/source/customize/macropg_impl.hxx
+++ b/cui/source/customize/macropg_impl.hxx
@@ -52,7 +52,7 @@ public:
virtual ~AssignComponentDialog();
virtual void dispose() override;
- OUString getURL() const
+ const OUString& getURL() const
{ return maURL; }
};
diff --git a/cui/source/dialogs/SpellDialog.cxx b/cui/source/dialogs/SpellDialog.cxx
index 75a14c8..21d8309 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -145,7 +145,7 @@ public:
bool IsErrorLanguageSelected() const {return m_bIsErrorLanguageSelected;}
void SetDictionary(const Reference<XDictionary>& xDict) { m_xDictionary = xDict; }
- Reference<XDictionary> GetDictionary() const {return m_xDictionary;}
+ const Reference<XDictionary>& GetDictionary() const { return m_xDictionary; }
void SetAddedWord(const OUString& rWord) {m_sAddedWord = rWord;}
const OUString& GetAddedWord() const { return m_sAddedWord;}
diff --git a/cui/source/inc/cfg.hxx b/cui/source/inc/cfg.hxx
index acbdc90..9ca82b4 100644
--- a/cui/source/inc/cfg.hxx
+++ b/cui/source/inc/cfg.hxx
@@ -125,20 +125,20 @@ public:
bool IsReadOnly( ) { return bReadOnly; }
bool IsDocConfig( ) { return bDocConfig; }
- css::uno::Reference
- < css::ui::XUIConfigurationManager >
+ const css::uno::Reference
+ < css::ui::XUIConfigurationManager >&
GetConfigManager() { return m_xCfgMgr; };
- css::uno::Reference
- < css::ui::XUIConfigurationManager >
+ const css::uno::Reference
+ < css::ui::XUIConfigurationManager >&
GetParentConfigManager() { return m_xParentCfgMgr; };
- css::uno::Reference
- < css::ui::XImageManager >
+ const css::uno::Reference
+ < css::ui::XImageManager >&
GetImageManager() { return m_xImgMgr; };
- css::uno::Reference
- < css::ui::XImageManager >
+ const css::uno::Reference
+ < css::ui::XImageManager >&
GetParentImageManager() { return m_xParentImgMgr; };
css::uno::Reference
@@ -307,7 +307,7 @@ public:
void SetBackupGraphic( css::uno::Reference< css::graphic::XGraphic > graphic )
{ xBackupGraphic = graphic; }
- css::uno::Reference< css::graphic::XGraphic > GetBackupGraphic()
+ const css::uno::Reference< css::graphic::XGraphic >& GetBackupGraphic()
{ return xBackupGraphic; }
bool IsIconModified() { return xBackupGraphic.is(); }
diff --git a/cui/source/inc/cuitabarea.hxx b/cui/source/inc/cuitabarea.hxx
index 575d290..dfffa39 100644
--- a/cui/source/inc/cuitabarea.hxx
+++ b/cui/source/inc/cuitabarea.hxx
@@ -79,22 +79,22 @@ public:
void SetNewColorList( XColorListRef pColorList )
{ mpNewColorList = pColorList; }
- XColorListRef GetNewColorList() const { return mpNewColorList; }
- const XColorListRef GetColorList() const { return mpColorList; }
+ const XColorListRef& GetNewColorList() const { return mpNewColorList; }
+ const XColorListRef& GetColorList() const { return mpColorList; }
- void SetNewGradientList( XGradientListRef pGrdLst)
+ void SetNewGradientList( XGradientListRef pGrdLst)
{ mpNewGradientList = pGrdLst; }
- XGradientListRef GetNewGradientList() const
+ const XGradientListRef& GetNewGradientList() const
{ return mpNewGradientList; }
- void SetNewHatchingList( XHatchListRef pHtchLst)
+ void SetNewHatchingList( XHatchListRef pHtchLst)
{ mpNewHatchingList = pHtchLst; }
- XHatchListRef GetNewHatchingList() const
+ const XHatchListRef& GetNewHatchingList() const
{ return mpNewHatchingList; }
- void SetNewBitmapList( XBitmapListRef pBmpLst)
+ void SetNewBitmapList( XBitmapListRef pBmpLst)
{ mpNewBitmapList = pBmpLst; }
- XBitmapListRef GetNewBitmapList() const { return mpNewBitmapList; }
+ const XBitmapListRef& GetNewBitmapList() const { return mpNewBitmapList; }
};
/************************************************************************/
@@ -755,7 +755,7 @@ public:
void SetPropertyList( XPropertyListType t, const XPropertyListRef &xRef );
void SetColorList( const XColorListRef& pColList );
- XColorListRef GetColorList() { return pColorList; }
+ const XColorListRef& GetColorList() { return pColorList; }
void SaveToViewFrame( SfxViewFrame *pViewFrame );
void SetupForViewFrame( SfxViewFrame *pViewFrame );
diff --git a/cui/source/inc/cuitabline.hxx b/cui/source/inc/cuitabline.hxx
index 00b4ce5..d51780e 100644
--- a/cui/source/inc/cuitabline.hxx
+++ b/cui/source/inc/cuitabline.hxx
@@ -68,15 +68,15 @@ public:
void SetNewDashList( XDashListRef pInLst)
{ pNewDashList = pInLst; }
- XDashListRef GetNewDashList() const { return pNewDashList; }
+ const XDashListRef& GetNewDashList() const { return pNewDashList; }
void SetNewLineEndList( XLineEndListRef pInLst)
{ pNewLineEndList = pInLst; }
- XLineEndListRef GetNewLineEndList() const { return pNewLineEndList; }
+ const XLineEndListRef& GetNewLineEndList() const { return pNewLineEndList; }
void SetNewColorList( XColorListRef pColTab ) { mpNewColorList = pColTab; }
- XColorListRef GetNewColorList() const { return mpNewColorList; }
- XColorListRef GetColorList() const { return pColorList; }
+ const XColorListRef& GetNewColorList() const { return mpNewColorList; }
+ const XColorListRef& GetColorList() const { return pColorList; }
};
/*************************************************************************/
diff --git a/cui/source/inc/iconcdlg.hxx b/cui/source/inc/iconcdlg.hxx
index d97b03b..131e4d0 100644
--- a/cui/source/inc/iconcdlg.hxx
+++ b/cui/source/inc/iconcdlg.hxx
@@ -102,7 +102,7 @@ public:
virtual void ActivatePage( const SfxItemSet& );
virtual int DeactivatePage( SfxItemSet* pSet );
- OUString GetUserData() { return aUserString; }
+ const OUString& GetUserData() { return aUserString; }
virtual bool QueryClose();
void StateChanged( StateChangedType nType ) override;
diff --git a/cui/source/inc/insdlg.hxx b/cui/source/inc/insdlg.hxx
index 67b51a0..c4624a6 100644
--- a/cui/source/inc/insdlg.hxx
+++ b/cui/source/inc/insdlg.hxx
@@ -48,7 +48,7 @@ protected:
const OUString& rUIXMLDescription,
const css::uno::Reference < css::embed::XStorage >& xStorage);
public:
- css::uno::Reference < css::embed::XEmbeddedObject > GetObject()
+ const css::uno::Reference < css::embed::XEmbeddedObject >& GetObject()
{ return m_xObj; }
virtual css::uno::Reference< css::io::XInputStream > GetIconIfIconified( OUString* pGraphicMediaType );
virtual bool IsCreateNew() const;
diff --git a/cui/source/inc/optdict.hxx b/cui/source/inc/optdict.hxx
index 5f97eb9..ad46c19 100644
--- a/cui/source/inc/optdict.hxx
+++ b/cui/source/inc/optdict.hxx
@@ -65,8 +65,8 @@ public:
virtual ~SvxNewDictionaryDialog();
virtual void dispose() override;
- css::uno::Reference<
- css::linguistic2::XDictionary >
+ const css::uno::Reference<
+ css::linguistic2::XDictionary >&
GetNewDictionary() { return xNewDic; }
};
diff --git a/cui/source/inc/scriptdlg.hxx b/cui/source/inc/scriptdlg.hxx
index 53c92b0..54b659e 100644
--- a/cui/source/inc/scriptdlg.hxx
+++ b/cui/source/inc/scriptdlg.hxx
@@ -125,8 +125,8 @@ public:
const css::uno::Reference< css::frame::XModel >& entryModel) { nType = nT; nodes = entryNodes; loaded=false; model = entryModel; }
SFEntry( const SFEntry& r ) { nType = r.nType; nodes = r.nodes; loaded = r.loaded; }
virtual ~SFEntry() {}
- css::uno::Reference< css::script::browse::XBrowseNode > GetNode() { return nodes ;}
- css::uno::Reference< css::frame::XModel > GetModel() { return model ;};
+ const css::uno::Reference< css::script::browse::XBrowseNode >& GetNode() { return nodes ;}
+ const css::uno::Reference< css::frame::XModel >& GetModel() { return model ;};
bool isLoaded() const { return loaded; }
void setLoaded() { loaded=true; }
};
diff --git a/cui/source/inc/thesdlg.hxx b/cui/source/inc/thesdlg.hxx
index 82f2332..925ccf9 100644
--- a/cui/source/inc/thesdlg.hxx
+++ b/cui/source/inc/thesdlg.hxx
@@ -139,7 +139,7 @@ public:
virtual void dispose() override;
bool WordFound() const { return m_bWordFound; }
- OUString getErrStr() const { return m_aErrStr; }
+ const OUString& getErrStr() const { return m_aErrStr; }
// Handler
DECL_LINK_TYPED( ReplaceBtnHdl_Impl, Button *, void );
diff --git a/cui/source/options/cfgchart.hxx b/cui/source/options/cfgchart.hxx
index 401485f..3b8b0be 100644
--- a/cui/source/options/cfgchart.hxx
+++ b/cui/source/options/cfgchart.hxx
@@ -67,7 +67,7 @@ private:
css::uno::Sequence< OUString >
maPropertyNames;
- inline css::uno::Sequence< OUString > GetPropertyNames() const
+ const css::uno::Sequence< OUString >& GetPropertyNames() const
{ return maPropertyNames; }
bool RetrieveOptions();
diff --git a/cui/source/options/personalization.cxx b/cui/source/options/personalization.cxx
index bd97e91..2e990cf 100644
--- a/cui/source/options/personalization.cxx
+++ b/cui/source/options/personalization.cxx
@@ -202,7 +202,7 @@ void SelectPersonaDialog::SetAppliedPersonaSetting( OUString& rPersonaSetting )
m_aAppliedPersona = rPersonaSetting;
}
-OUString SelectPersonaDialog::GetAppliedPersonaSetting() const
+const OUString& SelectPersonaDialog::GetAppliedPersonaSetting() const
{
return m_aAppliedPersona;
}
diff --git a/cui/source/options/personalization.hxx b/cui/source/options/personalization.hxx
index 362fa6c..7bef5a6 100644
--- a/cui/source/options/personalization.hxx
+++ b/cui/source/options/personalization.hxx
@@ -102,7 +102,7 @@ public:
void AddPersonaSetting( OUString& );
void ClearSearchResults();
void SetAppliedPersonaSetting( OUString& );
- OUString GetAppliedPersonaSetting() const;
+ const OUString& GetAppliedPersonaSetting() const;
private:
/// Handle the Search button
diff --git a/cui/source/options/personasdochandler.hxx b/cui/source/options/personasdochandler.hxx
index c54616b..7875be6 100644
--- a/cui/source/options/personasdochandler.hxx
+++ b/cui/source/options/personasdochandler.hxx
@@ -22,7 +22,7 @@ private:
bool m_isLearnmoreTag, m_hasResults;
public:
PersonasDocHandler(){ m_isLearnmoreTag = false; m_hasResults = false; }
- std::vector<OUString> getLearnmoreURLs() { return m_vLearnmoreURLs; }
+ const std::vector<OUString>& getLearnmoreURLs() { return m_vLearnmoreURLs; }
bool hasResults() { return m_hasResults; }
// XDocumentHandler
commit e7d3fa58047c44bd3641973c065d1af9c2ac1fa0
Author: Noel Grandin <noel at peralex.com>
Date: Wed Apr 13 15:41:46 2016 +0200
loplugin:passstuffbyref in chart2
Change-Id: Id14015b1a02047c4d2e9d4ed4a9edfd0cb409c59
diff --git a/chart2/inc/ChartModel.hxx b/chart2/inc/ChartModel.hxx
index e3f9997..b3caaad 100644
--- a/chart2/inc/ChartModel.hxx
+++ b/chart2/inc/ChartModel.hxx
@@ -571,7 +571,7 @@ public:
css::uno::Reference< css::util::XNumberFormatsSupplier >
getNumberFormatsSupplier();
- css::uno::Reference< css::uno::XInterface > getChartView() { return xChartView;}
+ const css::uno::Reference< css::uno::XInterface >& getChartView() { return xChartView;}
bool isTimeBased() const { return mbTimeBased;}
void setTimeBased(bool bTimeBased);
diff --git a/chart2/source/controller/inc/AccessibleBase.hxx b/chart2/source/controller/inc/AccessibleBase.hxx
index 2fbee3d..8435132 100644
--- a/chart2/source/controller/inc/AccessibleBase.hxx
+++ b/chart2/source/controller/inc/AccessibleBase.hxx
@@ -214,7 +214,7 @@ protected:
const AccessibleElementInfo& GetInfo() const { return m_aAccInfo;}
void SetInfo( const AccessibleElementInfo & rNewInfo );
- AccessibleUniqueId GetId() const { return m_aAccInfo.m_aOID;}
+ const AccessibleUniqueId& GetId() const { return m_aAccInfo.m_aOID;}
// ________ WeakComponentImplHelper (XComponent::dispose) ________
virtual void SAL_CALL disposing() override;
diff --git a/chart2/source/controller/inc/CharacterPropertyItemConverter.hxx b/chart2/source/controller/inc/CharacterPropertyItemConverter.hxx
index f62b0cf..1beea2e 100644
--- a/chart2/source/controller/inc/CharacterPropertyItemConverter.hxx
+++ b/chart2/source/controller/inc/CharacterPropertyItemConverter.hxx
@@ -51,7 +51,7 @@ protected:
virtual bool ApplySpecialItem( sal_uInt16 nWhichId, const SfxItemSet & rItemSet )
throw (css::uno::Exception) override;
- css::uno::Reference<css::beans::XPropertySet> GetRefSizePropertySet() const;
+ const css::uno::Reference<css::beans::XPropertySet>& GetRefSizePropertySet() const;
private:
OUString m_aRefSizePropertyName;
diff --git a/chart2/source/controller/inc/ChartController.hxx b/chart2/source/controller/inc/ChartController.hxx
index f73d7e4..1a226bb 100644
--- a/chart2/source/controller/inc/ChartController.hxx
+++ b/chart2/source/controller/inc/ChartController.hxx
@@ -396,7 +396,7 @@ private:
void addListener( ChartController* pController );
void removeListener( ChartController* pController );
void tryTermination();
- css::uno::Reference< css::frame::XModel >
+ const css::uno::Reference< css::frame::XModel >&
getModel() const { return m_xModel;}
private:
diff --git a/chart2/source/controller/inc/ChartDocumentWrapper.hxx b/chart2/source/controller/inc/ChartDocumentWrapper.hxx
index 8b5c8e1..b121299 100644
--- a/chart2/source/controller/inc/ChartDocumentWrapper.hxx
+++ b/chart2/source/controller/inc/ChartDocumentWrapper.hxx
@@ -73,13 +73,13 @@ public:
static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
void setAddIn( const css::uno::Reference< css::util::XRefreshable >& xAddIn );
- css::uno::Reference< css::util::XRefreshable > getAddIn() const { return m_xAddIn;}
+ const css::uno::Reference< css::util::XRefreshable >& getAddIn() const { return m_xAddIn;}
void setUpdateAddIn( bool bUpdateAddIn );
bool getUpdateAddIn() const { return m_bUpdateAddIn;}
void setBaseDiagram( const OUString& rBaseDiagram );
- OUString getBaseDiagram() const { return m_aBaseDiagram;}
+ const OUString& getBaseDiagram() const { return m_aBaseDiagram;}
css::uno::Reference< css::drawing::XShapes > getAdditionalShapes() const;
diff --git a/chart2/source/controller/inc/ItemConverter.hxx b/chart2/source/controller/inc/ItemConverter.hxx
index 8ccc785..612a56f 100644
--- a/chart2/source/controller/inc/ItemConverter.hxx
+++ b/chart2/source/controller/inc/ItemConverter.hxx
@@ -167,7 +167,7 @@ protected:
/** Returns the XPropertySet that was given in the CTOR and is used to apply
items in ApplyItemSet().
*/
- css::uno::Reference< css::beans::XPropertySet > GetPropertySet() const { return m_xPropertySet;}
+ const css::uno::Reference< css::beans::XPropertySet >& GetPropertySet() const { return m_xPropertySet;}
// ____ ::utl::OEventListenerAdapter ____
virtual void _disposing( const css::lang::EventObject& rSource ) override;
diff --git a/chart2/source/controller/inc/ObjectHierarchy.hxx b/chart2/source/controller/inc/ObjectHierarchy.hxx
index 8d653dd..bf36a91 100644
--- a/chart2/source/controller/inc/ObjectHierarchy.hxx
+++ b/chart2/source/controller/inc/ObjectHierarchy.hxx
@@ -84,7 +84,7 @@ public:
ExplicitValueProvider * pExplicitValueProvider = nullptr );
bool handleKeyEvent( const css::awt::KeyEvent & rEvent );
- ObjectHierarchy::tOID getCurrentSelection() const { return m_aCurrentOID;}
+ const ObjectHierarchy::tOID& getCurrentSelection() const { return m_aCurrentOID;}
private:
void setCurrentSelection( const ObjectHierarchy::tOID& rOID );
diff --git a/chart2/source/controller/inc/SelectionHelper.hxx b/chart2/source/controller/inc/SelectionHelper.hxx
index a770a49..e6257a0 100644
--- a/chart2/source/controller/inc/SelectionHelper.hxx
+++ b/chart2/source/controller/inc/SelectionHelper.hxx
@@ -38,7 +38,7 @@ public: //methods
OUString getSelectedCID();
css::uno::Reference< css::drawing::XShape > getSelectedAdditionalShape();
- ObjectIdentifier getSelectedOID() const { return m_aSelectedOID;}
+ const ObjectIdentifier& getSelectedOID() const { return m_aSelectedOID;}
bool isResizeableObjectSelected();
bool isRotateableObjectSelected( const css::uno::Reference< css::frame::XModel >& xChartModel );
diff --git a/chart2/source/controller/inc/dlg_ObjectProperties.hxx b/chart2/source/controller/inc/dlg_ObjectProperties.hxx
index 3ec0631..781ef20 100644
--- a/chart2/source/controller/inc/dlg_ObjectProperties.hxx
+++ b/chart2/source/controller/inc/dlg_ObjectProperties.hxx
@@ -35,7 +35,7 @@ public:
void init( const css::uno::Reference< css::frame::XModel >& xModel );
ObjectType getObjectType() const { return m_eObjectType;}
- OUString getLocalizedName() const { return m_aLocalizedName;}
+ const OUString& getLocalizedName() const { return m_aLocalizedName;}
bool HasGeometryProperties() const { return m_bHasGeometryProperties;}
bool HasStatisticProperties() const { return m_bHasStatisticProperties;}
@@ -55,7 +55,7 @@ public:
bool IsCrossingAxisIsCategoryAxis() const { return m_bIsCrossingAxisIsCategoryAxis;}
const css::uno::Sequence< OUString >& GetCategories() const { return m_aCategories;}
- css::uno::Reference< css::chart2::XChartDocument >
+ const css::uno::Reference< css::chart2::XChartDocument >&
getDocument() const { return m_xChartDocument;}
bool IsComplexCategoriesAxis() const { return m_bComplexCategoriesAxis;}
diff --git a/chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx b/chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx
index 1991ef6..5573ff6 100644
--- a/chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx
@@ -552,7 +552,7 @@ bool CharacterPropertyItemConverter::ApplySpecialItem(
return bChanged;
}
-uno::Reference<beans::XPropertySet> CharacterPropertyItemConverter::GetRefSizePropertySet() const
+const uno::Reference<beans::XPropertySet>& CharacterPropertyItemConverter::GetRefSizePropertySet() const
{
return m_xRefSizePropSet;
}
diff --git a/chart2/source/inc/InternalData.hxx b/chart2/source/inc/InternalData.hxx
index 26ec9fc..9a7eb35 100644
--- a/chart2/source/inc/InternalData.hxx
+++ b/chart2/source/inc/InternalData.hxx
@@ -68,9 +68,9 @@ public:
typedef ::std::vector< ::std::vector< css::uno::Any > > tVecVecAny; //inner index is hierarchical level
void setComplexRowLabels( const tVecVecAny& rNewRowLabels );
- tVecVecAny getComplexRowLabels() const;
+ const tVecVecAny& getComplexRowLabels() const;
void setComplexColumnLabels( const tVecVecAny& rNewColumnLabels );
- tVecVecAny getComplexColumnLabels() const;
+ const tVecVecAny& getComplexColumnLabels() const;
void dump() const;
diff --git a/chart2/source/inc/MediaDescriptorHelper.hxx b/chart2/source/inc/MediaDescriptorHelper.hxx
index e1c573d..f018064 100644
--- a/chart2/source/inc/MediaDescriptorHelper.hxx
+++ b/chart2/source/inc/MediaDescriptorHelper.hxx
@@ -50,7 +50,7 @@ private:
public:
MediaDescriptorHelper( const css::uno::Sequence< css::beans::PropertyValue > & rMediaDescriptor );
- css::uno::Sequence< css::beans::PropertyValue > getReducedForModel() { return m_aModelProperties;}
+ const css::uno::Sequence< css::beans::PropertyValue >& getReducedForModel() { return m_aModelProperties;}
public:
//all properties given in the constructor are stored in the following three sequences
diff --git a/chart2/source/inc/NumberFormatterWrapper.hxx b/chart2/source/inc/NumberFormatterWrapper.hxx
index ae9c40c..4743054 100644
--- a/chart2/source/inc/NumberFormatterWrapper.hxx
+++ b/chart2/source/inc/NumberFormatterWrapper.hxx
@@ -37,7 +37,7 @@ public:
virtual ~NumberFormatterWrapper();
SvNumberFormatter* getSvNumberFormatter() const { return m_pNumberFormatter;}
- css::uno::Reference< css::util::XNumberFormatsSupplier >
+ const css::uno::Reference< css::util::XNumberFormatsSupplier >&
getNumberFormatsSupplier() { return m_xNumberFormatsSupplier; };
OUString getFormattedString( sal_Int32 nNumberFormatKey, double fValue, sal_Int32& rLabelColor, bool& rbColorChanged ) const;
diff --git a/chart2/source/inc/ObjectIdentifier.hxx b/chart2/source/inc/ObjectIdentifier.hxx
index a59c2e6..574b2c7 100644
--- a/chart2/source/inc/ObjectIdentifier.hxx
+++ b/chart2/source/inc/ObjectIdentifier.hxx
@@ -246,8 +246,8 @@ public:
bool isValid() const;
bool isAutoGeneratedObject() const;
bool isAdditionalShape() const;
- OUString getObjectCID() const { return m_aObjectCID;}
- css::uno::Reference< css::drawing::XShape > getAdditionalShape() const { return m_xAdditionalShape;}
+ const OUString& getObjectCID() const { return m_aObjectCID;}
+ const css::uno::Reference< css::drawing::XShape >& getAdditionalShape() const { return m_xAdditionalShape;}
css::uno::Any getAny() const;
private:
diff --git a/chart2/source/inc/ReferenceSizeProvider.hxx b/chart2/source/inc/ReferenceSizeProvider.hxx
index 02dac03..a12b2f2 100644
--- a/chart2/source/inc/ReferenceSizeProvider.hxx
+++ b/chart2/source/inc/ReferenceSizeProvider.hxx
@@ -50,7 +50,7 @@ public:
css::awt::Size aPageSize,
const css::uno::Reference< css::chart2::XChartDocument > & xChartDoc );
- css::awt::Size getPageSize() const { return m_aPageSize;}
+ const css::awt::Size& getPageSize() const { return m_aPageSize;}
/** Retrieves the state auto-resize from all objects that support this
feature. If all objects return the same state, AUTO_RESIZE_YES or
diff --git a/chart2/source/model/template/ChartType.hxx b/chart2/source/model/template/ChartType.hxx
index 0b94cd3..653ce0f 100644
--- a/chart2/source/model/template/ChartType.hxx
+++ b/chart2/source/model/template/ChartType.hxx
@@ -62,7 +62,7 @@ public:
protected:
explicit ChartType( const ChartType & rOther );
- css::uno::Reference< css::uno::XComponentContext >
+ const css::uno::Reference< css::uno::XComponentContext >&
GetComponentContext() const { return m_xContext;}
// ____ XChartType ____
diff --git a/chart2/source/model/template/ChartTypeTemplate.hxx b/chart2/source/model/template/ChartTypeTemplate.hxx
index 19ac487..2f7bdcb 100644
--- a/chart2/source/model/template/ChartTypeTemplate.hxx
+++ b/chart2/source/model/template/ChartTypeTemplate.hxx
@@ -230,7 +230,7 @@ protected:
virtual void adaptAxes(
const css::uno::Sequence< css::uno::Reference< css::chart2::XCoordinateSystem > > & rCoordSys );
- css::uno::Reference< css::uno::XComponentContext >
+ const css::uno::Reference< css::uno::XComponentContext >&
GetComponentContext() const { return m_xContext;}
static void copyPropertiesFromOldToNewCoordinateSystem(
diff --git a/chart2/source/model/template/DataInterpreter.hxx b/chart2/source/model/template/DataInterpreter.hxx
index 1d903e9..e9fd3e3 100644
--- a/chart2/source/model/template/DataInterpreter.hxx
+++ b/chart2/source/model/template/DataInterpreter.hxx
@@ -35,7 +35,7 @@ public:
explicit DataInterpreter( const css::uno::Reference< css::uno::XComponentContext > & xContext );
virtual ~DataInterpreter();
- css::uno::Reference< css::uno::XComponentContext >
+ const css::uno::Reference< css::uno::XComponentContext >&
GetComponentContext() const { return m_xContext;}
/// XServiceInfo declarations
diff --git a/chart2/source/tools/ImplOPropertySet.hxx b/chart2/source/tools/ImplOPropertySet.hxx
index 2bc7e6f..dc015b0 100644
--- a/chart2/source/tools/ImplOPropertySet.hxx
+++ b/chart2/source/tools/ImplOPropertySet.hxx
@@ -65,7 +65,7 @@ public:
const css::uno::Any & rValue );
bool SetStyle( const css::uno::Reference< css::style::XStyle > & xStyle );
- css::uno::Reference< css::style::XStyle >
+ const css::uno::Reference< css::style::XStyle >&
GetStyle() const { return m_xStyle;}
typedef
diff --git a/chart2/source/tools/InternalData.cxx b/chart2/source/tools/InternalData.cxx
index 8e19da5..a134240 100644
--- a/chart2/source/tools/InternalData.cxx
+++ b/chart2/source/tools/InternalData.cxx
@@ -481,7 +481,7 @@ void InternalData::setComplexRowLabels( const vector< vector< uno::Any > >& rNew
enlargeData( 0, nNewRowCount );
}
-InternalData::tVecVecAny InternalData::getComplexRowLabels() const
+const InternalData::tVecVecAny& InternalData::getComplexRowLabels() const
{
return m_aRowLabels;
}
@@ -496,7 +496,7 @@ void InternalData::setComplexColumnLabels( const vector< vector< uno::Any > >& r
enlargeData( nNewColumnCount, 0 );
}
-InternalData::tVecVecAny InternalData::getComplexColumnLabels() const
+const InternalData::tVecVecAny& InternalData::getComplexColumnLabels() const
{
return m_aColumnLabels;
}
diff --git a/chart2/source/tools/RegressionCurveModel.cxx b/chart2/source/tools/RegressionCurveModel.cxx
index 04e3160..e74f185 100644
--- a/chart2/source/tools/RegressionCurveModel.cxx
+++ b/chart2/source/tools/RegressionCurveModel.cxx
@@ -376,7 +376,7 @@ OUString SAL_CALL MeanValueRegressionCurve::getImplementationName()
return getImplementationName_Static();
}
-OUString MeanValueRegressionCurve::getImplementationName_Static()
+const OUString& MeanValueRegressionCurve::getImplementationName_Static()
{
return lcl_aImplementationName_MeanValue;
}
@@ -423,7 +423,7 @@ OUString SAL_CALL LinearRegressionCurve::getImplementationName()
return getImplementationName_Static();
}
-OUString LinearRegressionCurve::getImplementationName_Static()
+const OUString& LinearRegressionCurve::getImplementationName_Static()
{
return lcl_aImplementationName_Linear;
}
@@ -470,7 +470,7 @@ OUString SAL_CALL LogarithmicRegressionCurve::getImplementationName()
return getImplementationName_Static();
}
-OUString LogarithmicRegressionCurve::getImplementationName_Static()
+const OUString& LogarithmicRegressionCurve::getImplementationName_Static()
{
return lcl_aImplementationName_Logarithmic;
}
@@ -517,7 +517,7 @@ OUString SAL_CALL ExponentialRegressionCurve::getImplementationName()
return getImplementationName_Static();
}
-OUString ExponentialRegressionCurve::getImplementationName_Static()
+const OUString& ExponentialRegressionCurve::getImplementationName_Static()
{
return lcl_aImplementationName_Exponential;
}
@@ -564,7 +564,7 @@ OUString SAL_CALL PotentialRegressionCurve::getImplementationName()
return getImplementationName_Static();
}
-OUString PotentialRegressionCurve::getImplementationName_Static()
+const OUString& PotentialRegressionCurve::getImplementationName_Static()
{
return lcl_aImplementationName_Potential;
}
@@ -611,7 +611,7 @@ OUString SAL_CALL PolynomialRegressionCurve::getImplementationName()
return getImplementationName_Static();
}
-OUString PolynomialRegressionCurve::getImplementationName_Static()
+const OUString& PolynomialRegressionCurve::getImplementationName_Static()
{
return lcl_aImplementationName_Polynomial;
}
@@ -658,7 +658,7 @@ OUString SAL_CALL MovingAverageRegressionCurve::getImplementationName()
return getImplementationName_Static();
}
-OUString MovingAverageRegressionCurve::getImplementationName_Static()
+const OUString& MovingAverageRegressionCurve::getImplementationName_Static()
{
return lcl_aImplementationName_MovingAverage;
}
diff --git a/chart2/source/tools/RegressionCurveModel.hxx b/chart2/source/tools/RegressionCurveModel.hxx
index 5b03c5e..35e6300 100644
--- a/chart2/source/tools/RegressionCurveModel.hxx
+++ b/chart2/source/tools/RegressionCurveModel.hxx
@@ -159,7 +159,7 @@ public:
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
throw( css::uno::RuntimeException, std::exception ) override;
- static OUString getImplementationName_Static();
+ static const OUString& getImplementationName_Static();
static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
};
@@ -185,7 +185,7 @@ public:
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
throw( css::uno::RuntimeException, std::exception ) override;
- static OUString getImplementationName_Static();
+ static const OUString& getImplementationName_Static();
static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
};
@@ -211,7 +211,7 @@ public:
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
throw( css::uno::RuntimeException, std::exception ) override;
- static OUString getImplementationName_Static();
+ static const OUString& getImplementationName_Static();
static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
};
@@ -236,7 +236,7 @@ public:
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
throw( css::uno::RuntimeException, std::exception ) override;
- static OUString getImplementationName_Static();
+ static const OUString& getImplementationName_Static();
static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
};
@@ -262,7 +262,7 @@ public:
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
throw( css::uno::RuntimeException, std::exception ) override;
- static OUString getImplementationName_Static();
+ static const OUString& getImplementationName_Static();
static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
};
@@ -287,7 +287,7 @@ public:
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
throw( css::uno::RuntimeException, std::exception ) override;
- static OUString getImplementationName_Static();
+ static const OUString& getImplementationName_Static();
static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
};
@@ -312,7 +312,7 @@ public:
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
throw( css::uno::RuntimeException, std::exception ) override;
- static OUString getImplementationName_Static();
+ static const OUString& getImplementationName_Static();
static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
};
diff --git a/chart2/source/view/axes/VAxisProperties.hxx b/chart2/source/view/axes/VAxisProperties.hxx
index c29e43f..53d78c4 100644
--- a/chart2/source/view/axes/VAxisProperties.hxx
+++ b/chart2/source/view/axes/VAxisProperties.hxx
@@ -160,7 +160,7 @@ private:
TickmarkProperties makeTickmarkProperties( sal_Int32 nDepth ) const;
//@todo get this from somewhere; maybe for each subincrement
//so far the model does not offer different settings for each tick depth
- VLineProperties makeLinePropertiesForDepth( sal_Int32 /*nDepth*/ ) const { return m_aLineProperties; }
+ const VLineProperties& makeLinePropertiesForDepth( sal_Int32 /*nDepth*/ ) const { return m_aLineProperties; }
};
} //namespace chart
diff --git a/chart2/source/view/inc/GL3DRenderer.hxx b/chart2/source/view/inc/GL3DRenderer.hxx
index 2c8008d..9966a98 100644
--- a/chart2/source/view/inc/GL3DRenderer.hxx
+++ b/chart2/source/view/inc/GL3DRenderer.hxx
@@ -214,9 +214,9 @@ public:
void SetScrollSpeed(float scrollSpeed);
void SetScrollDistance(float scrollDistance);
void SetSceneEdge(float minCoordX, float maxCoordX);
- glm::mat4 GetProjectionMatrix();
- glm::mat4 GetViewMatrix();
- glm::mat4 GetGlobalScaleMatrix();
+ const glm::mat4& GetProjectionMatrix();
+ const glm::mat4& GetViewMatrix();
+ const glm::mat4& GetGlobalScaleMatrix();
glm::mat4 GetDiffOfTwoCameras(const glm::vec3& rBeginPos, const glm::vec3& rEndPos, const glm::vec3& rBeginDirection, const glm::vec3& rEndDirection);
glm::mat4 GetDiffOfTwoCameras(const glm::vec3& rEndPos, const glm::vec3& rEndDirection);
void AddMatrixDiff(const glm::mat4& aMat);
diff --git a/chart2/source/view/inc/PlottingPositionHelper.hxx b/chart2/source/view/inc/PlottingPositionHelper.hxx
index 1d60303..a191147 100644
--- a/chart2/source/view/inc/PlottingPositionHelper.hxx
+++ b/chart2/source/view/inc/PlottingPositionHelper.hxx
@@ -154,7 +154,7 @@ public:
virtual void setTransformationSceneToScreen( const css::drawing::HomogenMatrix& rMatrix) override;
virtual void setScales( const std::vector< ExplicitScaleData >& rScales, bool bSwapXAndYAxis ) override;
- ::basegfx::B3DHomMatrix getUnitCartesianToScene() const { return m_aUnitCartesianToScene;}
+ const ::basegfx::B3DHomMatrix& getUnitCartesianToScene() const { return m_aUnitCartesianToScene;}
virtual css::uno::Reference< css::chart2::XTransformation >
getTransformationScaledLogicToScene() const override;
diff --git a/chart2/source/view/inc/ScaleAutomatism.hxx b/chart2/source/view/inc/ScaleAutomatism.hxx
index 98c6ce1..221612a 100644
--- a/chart2/source/view/inc/ScaleAutomatism.hxx
+++ b/chart2/source/view/inc/ScaleAutomatism.hxx
@@ -96,8 +96,8 @@ public:
ExplicitScaleData& rExplicitScale,
ExplicitIncrementData& rExplicitIncrement ) const;
- css::chart2::ScaleData getScale() const { return m_aSourceScale;}
- Date getNullDate() const { return m_aNullDate;}
+ const css::chart2::ScaleData& getScale() const { return m_aSourceScale;}
+ const Date& getNullDate() const { return m_aNullDate;}
private:
/** Fills the passed scale data and increment data for category scaling. */
diff --git a/chart2/source/view/inc/VCoordinateSystem.hxx b/chart2/source/view/inc/VCoordinateSystem.hxx
index 15ceaa5..41f15b70 100644
--- a/chart2/source/view/inc/VCoordinateSystem.hxx
+++ b/chart2/source/view/inc/VCoordinateSystem.hxx
@@ -60,7 +60,7 @@ public:
void setParticle( const OUString& rCooSysParticle );
void setTransformationSceneToScreen( const css::drawing::HomogenMatrix& rMatrix );
- css::drawing::HomogenMatrix getTransformationSceneToScreen() { return m_aMatrixSceneToScreen;}
+ const css::drawing::HomogenMatrix& getTransformationSceneToScreen() { return m_aMatrixSceneToScreen;}
//better performance for big data
virtual css::uno::Sequence< sal_Int32 > getCoordinateSystemResolution( const css::awt::Size& rPageSize
@@ -103,8 +103,7 @@ public:
void set3DWallPositions( CuboidPlanePosition eLeftWallPos, CuboidPlanePosition eBackWallPos, CuboidPlanePosition eBottomPos );
- css::uno::Reference<
- css::chart2::XCoordinateSystem >
+ const css::uno::Reference< css::chart2::XCoordinateSystem >&
getModel() const { return m_xCooSysModel;}
/**
diff --git a/chart2/source/view/inc/VDataSeries.hxx b/chart2/source/view/inc/VDataSeries.hxx
index 94586f4..7231f05 100644
--- a/chart2/source/view/inc/VDataSeries.hxx
+++ b/chart2/source/view/inc/VDataSeries.hxx
@@ -65,7 +65,7 @@ public:
VDataSeries(const VDataSeries&) = delete;
const VDataSeries& operator=(const VDataSeries&) = delete;
- css::uno::Reference<css::chart2::XDataSeries> getModel() const;
+ const css::uno::Reference<css::chart2::XDataSeries>& getModel() const;
void setCategoryXAxis();
void setXValues( const css::uno::Reference<css::chart2::data::XDataSequence>& xValues );
@@ -147,12 +147,12 @@ public:
//this is here for deep stacking:
double m_fLogicZPos;//from 0 to series count -1
- OUString getCID() const { return m_aCID;}
- OUString getSeriesParticle() const { return m_aSeriesParticle;}
- OUString getPointCID_Stub() const { return m_aPointCID_Stub;}
+ const OUString& getCID() const { return m_aCID;}
+ const OUString& getSeriesParticle() const { return m_aSeriesParticle;}
+ const OUString& getPointCID_Stub() const { return m_aPointCID_Stub;}
OUString getErrorBarsCID( bool bYError ) const;
OUString getLabelsCID() const;
- OUString getLabelCID_Stub() const { return m_aLabelCID_Stub;}
+ const OUString& getLabelCID_Stub() const { return m_aLabelCID_Stub;}
OUString getDataCurveCID( sal_Int32 nCurveIndex, bool bAverageLine ) const;
css::chart2::DataPointLabel* getDataPointLabelIfLabel( sal_Int32 index ) const;
diff --git a/chart2/source/view/main/GL3DRenderer.cxx b/chart2/source/view/main/GL3DRenderer.cxx
index 98cacda..1c2c635 100644
--- a/chart2/source/view/main/GL3DRenderer.cxx
+++ b/chart2/source/view/main/GL3DRenderer.cxx
@@ -2476,17 +2476,17 @@ glm::mat4 OpenGL3DRenderer::GetDiffOfTwoCameras(const glm::vec3& rEndPos, const
return aEnd - m_3DView;
}
-glm::mat4 OpenGL3DRenderer::GetProjectionMatrix()
+const glm::mat4& OpenGL3DRenderer::GetProjectionMatrix()
{
return m_3DProjection;
}
-glm::mat4 OpenGL3DRenderer::GetViewMatrix()
+const glm::mat4& OpenGL3DRenderer::GetViewMatrix()
{
return m_3DView;
}
-glm::mat4 OpenGL3DRenderer::GetGlobalScaleMatrix()
+const glm::mat4& OpenGL3DRenderer::GetGlobalScaleMatrix()
{
return m_GlobalScaleMatrix;
}
diff --git a/chart2/source/view/main/VDataSeries.cxx b/chart2/source/view/main/VDataSeries.cxx
index 6d62e1b..1b4748f 100644
--- a/chart2/source/view/main/VDataSeries.cxx
+++ b/chart2/source/view/main/VDataSeries.cxx
@@ -328,7 +328,7 @@ void VDataSeries::releaseShapes()
m_nPolygonIndex = 0;
}
-uno::Reference<css::chart2::XDataSeries> VDataSeries::getModel() const
+const uno::Reference<css::chart2::XDataSeries>& VDataSeries::getModel() const
{
return m_xDataSeries;
}
commit 29a4b74caca601d10c15d58aa5df5166ec3e517c
Author: Noel Grandin <noel at peralex.com>
Date: Wed Apr 13 15:40:11 2016 +0200
loplugin:passstuffbyref in writerfilter
Change-Id: Ia85f5a7a9846802de7a1495e70d16c9e3418dc3e
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index 08757c1..82d1ce6 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
@@ -159,7 +159,7 @@ public:
FieldContext(css::uno::Reference<css::text::XTextRange> const& xStart);
~FieldContext();
- css::uno::Reference<css::text::XTextRange> GetStartRange() const { return m_xStartRange; }
+ const css::uno::Reference<css::text::XTextRange>& GetStartRange() const { return m_xStartRange; }
void AppendCommand(const OUString& rPart);
const OUString& GetCommand() const {return m_sCommand; }
@@ -173,28 +173,28 @@ public:
void SetFieldLocked() { m_bFieldLocked = true; }
bool IsFieldLocked() { return m_bFieldLocked; }
- css::uno::Reference<css::beans::XPropertySet> GetCustomField() const { return m_xCustomField; }
+ const css::uno::Reference<css::beans::XPropertySet>& GetCustomField() const { return m_xCustomField; }
void SetCustomField(css::uno::Reference<css::beans::XPropertySet> const& xCustomField) { m_xCustomField = xCustomField; }
- css::uno::Reference<css::text::XTextField> GetTextField() const { return m_xTextField;}
+ const css::uno::Reference<css::text::XTextField>& GetTextField() const { return m_xTextField;}
void SetTextField(css::uno::Reference<css::text::XTextField> const& xTextField) { m_xTextField = xTextField;}
- css::uno::Reference<css::text::XFormField> GetFormField() const { return m_xFormField;}
+ const css::uno::Reference<css::text::XFormField>& GetFormField() const { return m_xFormField;}
void SetFormField(css::uno::Reference<css::text::XFormField> const& xFormField) { m_xFormField = xFormField;}
void SetTOC(css::uno::Reference<css::beans::XPropertySet> const& xTOC) { m_xTOC = xTOC; }
- css::uno::Reference<css::beans::XPropertySet> GetTOC() { return m_xTOC; }
+ const css::uno::Reference<css::beans::XPropertySet>& GetTOC() { return m_xTOC; }
void SetTC(css::uno::Reference<css::beans::XPropertySet> const& xTC) { m_xTC = xTC; }
- css::uno::Reference<css::beans::XPropertySet> GetTC() { return m_xTC; }
+ const css::uno::Reference<css::beans::XPropertySet>& GetTC() { return m_xTC; }
void SetHyperlinkURL( const OUString& rURL ) { m_sHyperlinkURL = rURL; }
const OUString& GetHyperlinkURL() { return m_sHyperlinkURL; }
void setFFDataHandler(FFDataHandler::Pointer_t pFFDataHandler) { m_pFFDataHandler = pFFDataHandler; }
- FFDataHandler::Pointer_t getFFDataHandler() const { return m_pFFDataHandler; }
+ const FFDataHandler::Pointer_t& getFFDataHandler() const { return m_pFFDataHandler; }
void setFormControlHelper(FormControlHelper::Pointer_t pFormControlHelper) { m_pFormControlHelper = pFormControlHelper; }
- FormControlHelper::Pointer_t getFormControlHelper() const { return m_pFormControlHelper; }
- PropertyMapPtr getProperties() { return m_pProperties; }
+ const FormControlHelper::Pointer_t& getFormControlHelper() const { return m_pFormControlHelper; }
+ const PropertyMapPtr& getProperties() { return m_pProperties; }
::std::vector<OUString> GetCommandParts() const;
};
@@ -483,11 +483,11 @@ public:
css::uno::Reference<css::container::XNameContainer> GetPageStyles();
css::uno::Reference<css::text::XText> GetBodyText();
- css::uno::Reference<css::lang::XMultiServiceFactory> GetTextFactory() const
+ const css::uno::Reference<css::lang::XMultiServiceFactory>& GetTextFactory() const
{
return m_xTextFactory;
}
- css::uno::Reference<css::text::XTextDocument> GetTextDocument() const
+ const css::uno::Reference<css::text::XTextDocument>& GetTextDocument() const
{
return m_xTextDocument;
}
@@ -561,7 +561,7 @@ public:
void PopProperties(ContextType eId);
ContextType GetTopContextType() const { return m_aContextStack.top(); }
- PropertyMapPtr GetTopContext()
+ const PropertyMapPtr& GetTopContext()
{
return m_pTopContext;
}
@@ -607,7 +607,7 @@ public:
css::uno::Sequence<css::style::TabStop> GetCurrentTabStopAndClear();
void SetCurrentParaStyleId(const OUString& sStringValue) {m_sCurrentParaStyleId = sStringValue;}
- OUString GetCurrentParaStyleId() const {return m_sCurrentParaStyleId;}
+ const OUString& GetCurrentParaStyleId() const {return m_sCurrentParaStyleId;}
css::uno::Any GetPropertyFromStyleSheet(PropertyIds eId);
void SetStyleSheetImport( bool bSet ) { m_bInStyleSheetImport = bSet;}
diff --git a/writerfilter/source/dmapper/GraphicImport.hxx b/writerfilter/source/dmapper/GraphicImport.hxx
index cdc55fe..deb7383 100644
--- a/writerfilter/source/dmapper/GraphicImport.hxx
+++ b/writerfilter/source/dmapper/GraphicImport.hxx
@@ -91,7 +91,7 @@ public:
virtual void data(const sal_uInt8* buffer, size_t len, writerfilter::Reference<Properties>::Pointer_t ref) override;
css::uno::Reference<css::text::XTextContent> GetGraphicObject();
- css::uno::Reference<css::drawing::XShape> GetXShapeObject() { return m_xShape;}
+ const css::uno::Reference<css::drawing::XShape>& GetXShapeObject() { return m_xShape;}
bool IsGraphic() const;
private:
diff --git a/writerfilter/source/dmapper/LatentStyleHandler.cxx b/writerfilter/source/dmapper/LatentStyleHandler.cxx
index 0e9eb58..0b6cc64 100644
--- a/writerfilter/source/dmapper/LatentStyleHandler.cxx
+++ b/writerfilter/source/dmapper/LatentStyleHandler.cxx
@@ -68,7 +68,7 @@ void LatentStyleHandler::lcl_sprm(Sprm& /*rSprm*/)
{
}
-std::vector<beans::PropertyValue> LatentStyleHandler::getAttributes() const
+const std::vector<beans::PropertyValue>& LatentStyleHandler::getAttributes() const
{
return m_aAttributes;
}
diff --git a/writerfilter/source/dmapper/LatentStyleHandler.hxx b/writerfilter/source/dmapper/LatentStyleHandler.hxx
index 95dc2fb..80891b1 100644
--- a/writerfilter/source/dmapper/LatentStyleHandler.hxx
+++ b/writerfilter/source/dmapper/LatentStyleHandler.hxx
@@ -33,7 +33,7 @@ public:
LatentStyleHandler();
virtual ~LatentStyleHandler();
- std::vector<css::beans::PropertyValue> getAttributes() const;
+ const std::vector<css::beans::PropertyValue>& getAttributes() const;
};
} // namespace dmapper
diff --git a/writerfilter/source/dmapper/NumberingManager.hxx b/writerfilter/source/dmapper/NumberingManager.hxx
index 8235c80..19d8e11 100644
--- a/writerfilter/source/dmapper/NumberingManager.hxx
+++ b/writerfilter/source/dmapper/NumberingManager.hxx
@@ -84,8 +84,8 @@ public:
void SetParaStyle( const std::shared_ptr< StyleSheetEntry >& pStyle );
// Getters
- OUString GetBulletChar( ) { return m_sBulletChar; };
- std::shared_ptr< StyleSheetEntry > GetParaStyle( ) { return m_pParaStyle; };
+ const OUString& GetBulletChar( ) { return m_sBulletChar; };
+ const std::shared_ptr< StyleSheetEntry >& GetParaStyle( ) { return m_pParaStyle; };
bool isOutlineNumbering() const { return m_outline; }
// UNO mapping functions
@@ -115,7 +115,7 @@ public:
void SetId(sal_Int32 nId);
sal_Int32 GetId() { return m_nId;}
void SetShape(css::uno::Reference<css::drawing::XShape> const& xShape);
- css::uno::Reference<css::drawing::XShape> GetShape() { return m_xShape; }
+ const css::uno::Reference<css::drawing::XShape>& GetShape() { return m_xShape; }
private:
sal_Int32 m_nId;
css::uno::Reference<css::drawing::XShape> m_xShape;
@@ -157,12 +157,12 @@ public:
ListLevel::Pointer GetLevel( sal_uInt16 nLvl );
void AddLevel( );
- ListLevel::Pointer GetCurrentLevel( ) { return m_pCurrentLevel; };
+ const ListLevel::Pointer& GetCurrentLevel( ) { return m_pCurrentLevel; };
virtual css::uno::Sequence< css::uno::Sequence<css::beans::PropertyValue> > GetPropertyValues();
void SetNumStyleLink(const OUString& sValue) { m_sNumStyleLink = sValue; };
- OUString GetNumStyleLink() { return m_sNumStyleLink; };
+ const OUString& GetNumStyleLink() { return m_sNumStyleLink; };
};
class ListDef : public AbstractListDef
@@ -182,7 +182,7 @@ public:
// Accessors
void SetAbstractDefinition( AbstractListDef::Pointer pAbstract ) { m_pAbstractDef = pAbstract; };
- AbstractListDef::Pointer GetAbstractDefinition( ) { return m_pAbstractDef; };
+ const AbstractListDef::Pointer& GetAbstractDefinition( ) { return m_pAbstractDef; };
// Mapping functions
static OUString GetStyleName( sal_Int32 nId );
@@ -191,7 +191,7 @@ public:
void CreateNumberingRules(DomainMapper& rDMapper, css::uno::Reference<css::lang::XMultiServiceFactory> const& xFactory);
- css::uno::Reference<css::container::XIndexReplace> GetNumberingRules() { return m_xNumRules; }
+ const css::uno::Reference<css::container::XIndexReplace>& GetNumberingRules() { return m_xNumRules; }
};
diff --git a/writerfilter/source/dmapper/OLEHandler.hxx b/writerfilter/source/dmapper/OLEHandler.hxx
index b8ffb17..503c164 100644
--- a/writerfilter/source/dmapper/OLEHandler.hxx
+++ b/writerfilter/source/dmapper/OLEHandler.hxx
@@ -80,7 +80,7 @@ public:
OLEHandler(DomainMapper& rDomainMapper);
virtual ~OLEHandler();
- css::uno::Reference<css::drawing::XShape> getShape() { return m_xShape; };
+ const css::uno::Reference<css::drawing::XShape>& getShape() { return m_xShape; };
bool isOLEObject() { return m_xInputStream.is(); }
@@ -94,8 +94,8 @@ public:
OUString copyOLEOStream(css::uno::Reference<css::text::XTextDocument> const& xTextDocument);
- css::awt::Size getSize() const { return m_aShapeSize; }
- css::uno::Reference<css::graphic::XGraphic> getReplacement() const { return m_xReplacement; }
+ const css::awt::Size& getSize() const { return m_aShapeSize; }
+ const css::uno::Reference<css::graphic::XGraphic>& getReplacement() const { return m_xReplacement; }
};
typedef std::shared_ptr< OLEHandler > OLEHandlerPtr;
diff --git a/writerfilter/source/dmapper/PropertyMap.hxx b/writerfilter/source/dmapper/PropertyMap.hxx
index 1d82a1c..603f4e8 100644
--- a/writerfilter/source/dmapper/PropertyMap.hxx
+++ b/writerfilter/source/dmapper/PropertyMap.hxx
@@ -287,7 +287,7 @@ public:
m_xStartingRange = xRange;
}
- css::uno::Reference<css::text::XTextRange> GetStartingRange() const { return m_xStartingRange; }
+ const css::uno::Reference<css::text::XTextRange>& GetStartingRange() const { return m_xStartingRange; }
css::uno::Reference<css::beans::XPropertySet> GetPageStyle(const css::uno::Reference<css::container::XNameContainer>& xStyles,
const css::uno::Reference<css::lang::XMultiServiceFactory>& xTextFactory,
@@ -428,10 +428,10 @@ public:
sal_Int8 GetDropCapLength() const { return m_nDropCapLength;}
void SetDropCapLength(sal_Int8 nSet) { m_nDropCapLength = nSet;}
- css::uno::Reference<css::text::XTextRange> GetStartingRange() const { return m_xStartingRange; }
+ const css::uno::Reference<css::text::XTextRange>& GetStartingRange() const { return m_xStartingRange; }
void SetStartingRange(css::uno::Reference<css::text::XTextRange> const& xSet) { m_xStartingRange = xSet; }
- css::uno::Reference<css::text::XTextRange> GetEndingRange() const { return m_xEndingRange; }
+ const css::uno::Reference<css::text::XTextRange>& GetEndingRange() const { return m_xEndingRange; }
void SetEndingRange(css::uno::Reference<css::text::XTextRange> const& xSet) { m_xEndingRange = xSet; }
void SetParaStyleName( const OUString& rSet ) { m_sParaStyleName = rSet;}
diff --git a/writerfilter/source/dmapper/TableData.hxx b/writerfilter/source/dmapper/TableData.hxx
index ff5f6aa..84100cb 100644
--- a/writerfilter/source/dmapper/TableData.hxx
+++ b/writerfilter/source/dmapper/TableData.hxx
@@ -95,7 +95,7 @@ public:
/**
Return properties of the cell.
*/
- TablePropertyMapPtr getProperties() { return mpProps; }
+ const TablePropertyMapPtr& getProperties() { return mpProps; }
bool isOpen() const { return mbOpen; }
};
@@ -230,7 +230,7 @@ public:
/**
Return properties of the row.
*/
- TablePropertyMapPtr getProperties()
+ const TablePropertyMapPtr& getProperties()
{
return mpProperties;
}
@@ -362,7 +362,7 @@ public:
return mRows[i];
}
- const RowPointer_t getCurrentRow() const
+ const RowPointer_t& getCurrentRow() const
{
return mpRow;
}
diff --git a/writerfilter/source/dmapper/TableManager.hxx b/writerfilter/source/dmapper/TableManager.hxx
index e320120..334634d 100644
--- a/writerfilter/source/dmapper/TableManager.hxx
+++ b/writerfilter/source/dmapper/TableManager.hxx
@@ -125,7 +125,7 @@ class TableManager
mpCellProps = pProps;
}
- TablePropertyMapPtr getCellProps()
+ const TablePropertyMapPtr& getCellProps()
{
return mpCellProps;
}
@@ -140,7 +140,7 @@ class TableManager
mpRowProps = pProps;
}
- TablePropertyMapPtr getRowProps()
+ const TablePropertyMapPtr& getRowProps()
{
return mpRowProps;
}
@@ -283,7 +283,7 @@ protected:
mState.resetTableProps();
}
- css::uno::Reference<css::text::XTextRange> getHandle()
+ const css::uno::Reference<css::text::XTextRange>& getHandle()
{
return mCurHandle;
}
diff --git a/writerfilter/source/dmapper/TablePositionHandler.hxx b/writerfilter/source/dmapper/TablePositionHandler.hxx
index c513221..1a1daec 100644
--- a/writerfilter/source/dmapper/TablePositionHandler.hxx
+++ b/writerfilter/source/dmapper/TablePositionHandler.hxx
@@ -63,19 +63,19 @@ public:
return m_nBottomFromText;
}
- OUString getVertAnchor()
+ const OUString& getVertAnchor()
{
return m_aVertAnchor;
}
- OUString getYSpec()
+ const OUString& getYSpec()
{
return m_aYSpec;
}
- OUString getHorzAnchor()
+ const OUString& getHorzAnchor()
{
return m_aHorzAnchor;
}
- OUString getXSpec()
+ const OUString& getXSpec()
{
return m_aXSpec;
}
diff --git a/writerfilter/source/dmapper/TblStylePrHandler.hxx b/writerfilter/source/dmapper/TblStylePrHandler.hxx
index e895604..3932425 100644
--- a/writerfilter/source/dmapper/TblStylePrHandler.hxx
+++ b/writerfilter/source/dmapper/TblStylePrHandler.hxx
@@ -68,7 +68,7 @@ public:
explicit TblStylePrHandler( DomainMapper & rDMapper );
virtual ~TblStylePrHandler( );
- inline PropertyMapPtr getProperties() { return m_pProperties; };
+ const PropertyMapPtr& getProperties() { return m_pProperties; };
inline TblStyleType getType() { return m_nType; };
OUString getTypeString();
void appendInteropGrabBag(const OUString& aKey, const OUString& aValue);
diff --git a/writerfilter/source/dmapper/TextEffectsHandler.hxx b/writerfilter/source/dmapper/TextEffectsHandler.hxx
index d3c6318..1ee928d 100644
--- a/writerfilter/source/dmapper/TextEffectsHandler.hxx
+++ b/writerfilter/source/dmapper/TextEffectsHandler.hxx
@@ -46,7 +46,7 @@ public:
TextEffectsHandler(sal_uInt32 aElementId);
virtual ~TextEffectsHandler();
- boost::optional<PropertyIds> getGrabBagPropertyId() { return maPropertyId;}
+ const boost::optional<PropertyIds>& getGrabBagPropertyId() { return maPropertyId;}
css::beans::PropertyValue getInteropGrabBag();
diff --git a/writerfilter/source/dmapper/WrapPolygonHandler.hxx b/writerfilter/source/dmapper/WrapPolygonHandler.hxx
index d5122c5..c44cf0c 100644
--- a/writerfilter/source/dmapper/WrapPolygonHandler.hxx
+++ b/writerfilter/source/dmapper/WrapPolygonHandler.hxx
@@ -60,7 +60,7 @@ public:
WrapPolygonHandler();
virtual ~WrapPolygonHandler();
- WrapPolygon::Pointer_t getPolygon() { return mpPolygon;}
+ const WrapPolygon::Pointer_t& getPolygon() { return mpPolygon;}
private:
WrapPolygon::Pointer_t mpPolygon;
diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx b/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx
index 70726a7..d50d46e 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx
@@ -132,7 +132,7 @@ public:
void setDefine(Id nDefine);
Id getDefine() const { return mnDefine;}
- OOXMLParserState::Pointer_t getParserState() const { return mpParserState;}
+ const OOXMLParserState::Pointer_t& getParserState() const { return mpParserState;}
void sendTableDepth() const;
void setHandle();
@@ -220,7 +220,7 @@ protected:
void startAction(Token_t Element);
void endAction(Token_t Element);
- css::uno::Reference< css::uno::XComponentContext > getComponentContext() { return m_xContext;}
+ const css::uno::Reference< css::uno::XComponentContext >& getComponentContext() { return m_xContext;}
bool inPositionV;
@@ -245,7 +245,7 @@ public:
virtual ResourceEnum_t getResource() const override { return STREAM; }
- OOXMLPropertySet::Pointer_t getPropertySetAttrs() const { return mpPropertySetAttrs;}
+ const OOXMLPropertySet::Pointer_t& getPropertySetAttrs() const { return mpPropertySetAttrs;}
virtual void newProperty(const Id & rId, const OOXMLValue::Pointer_t& pVal) override;
void sendProperty(Id nId);
diff --git a/writerfilter/source/ooxml/OOXMLStreamImpl.hxx b/writerfilter/source/ooxml/OOXMLStreamImpl.hxx
index 70d12fc..0edb52e 100644
--- a/writerfilter/source/ooxml/OOXMLStreamImpl.hxx
+++ b/writerfilter/source/ooxml/OOXMLStreamImpl.hxx
@@ -80,7 +80,7 @@ public:
virtual css::uno::Reference<css::xml::sax::XFastTokenHandler> getFastTokenHandler() override;
// Giving access to mxDocumentStream. It is needed by resolving custom xml to get list of customxml's used in document.
- css::uno::Reference<css::io::XStream> accessDocumentStream() { return mxDocumentStream;}
+ const css::uno::Reference<css::io::XStream>& accessDocumentStream() { return mxDocumentStream;}
};
}}
#endif // INCLUDED_WRITERFILTER_SOURCE_OOXML_OOXMLSTREAMIMPL_HXX
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.hxx b/writerfilter/source/rtftok/rtfdocumentimpl.hxx
index fe239a4..f3c18ed 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.hxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.hxx
@@ -369,7 +369,7 @@ public:
void setAuthorInitials(OUString& rAuthorInitials);
void setIgnoreFirst(OUString& rIgnoreFirst);
void seek(sal_Size nPos);
- css::uno::Reference<css::lang::XMultiServiceFactory> getModelFactory()
+ const css::uno::Reference<css::lang::XMultiServiceFactory>& getModelFactory()
{
return m_xModelFactory;
}
commit f6ea0b2eb44073baf1445dc8e62fc8a245e5d378
Author: Noel Grandin <noel at peralex.com>
Date: Wed Apr 13 15:39:18 2016 +0200
loplugin:passstuffbyref in ucb
Change-Id: I4ba18c767c67c9c8d23aac3f8de728b7a229804d
diff --git a/ucb/source/core/providermap.hxx b/ucb/source/core/providermap.hxx
index 72800a5..b7a242a 100644
--- a/ucb/source/core/providermap.hxx
+++ b/ucb/source/core/providermap.hxx
@@ -44,7 +44,7 @@ public:
const css::uno::Reference< css::ucb::XContentProvider >& xProvider )
: m_xProvider( xProvider ) {}
- css::uno::Reference< css::ucb::XContentProvider > getProvider() const
+ const css::uno::Reference< css::ucb::XContentProvider >& getProvider() const
{ return m_xProvider; }
inline css::uno::Reference< css::ucb::XContentProvider > getResolvedProvider() const;
};
diff --git a/ucb/source/inc/regexpmap.hxx b/ucb/source/inc/regexpmap.hxx
index 09244e6..994d896 100644
--- a/ucb/source/inc/regexpmap.hxx
+++ b/ucb/source/inc/regexpmap.hxx
@@ -43,7 +43,7 @@ public:
Val * pTheValue):
m_aRegexp(rTheRegexp), m_pValue(pTheValue) {}
- OUString getRegexp() const { return m_aRegexp; }
+ const OUString& getRegexp() const { return m_aRegexp; }
Val const & getValue() const { return *m_pValue; }
diff --git a/ucb/source/sorter/sortresult.hxx b/ucb/source/sorter/sortresult.hxx
index ab16c45..e2461f4 100644
--- a/ucb/source/sorter/sortresult.hxx
+++ b/ucb/source/sorter/sortresult.hxx
@@ -165,7 +165,7 @@ public:
const SortedEntryList& GetS2OList() const { return maS2O; }
const SimpleList& GetO2SList() const { return maO2S; }
- css::uno::Reference < css::sdbc::XResultSet > GetResultSet() const { return mxOriginal; }
+ const css::uno::Reference < css::sdbc::XResultSet >& GetResultSet() const { return mxOriginal; }
SortInfo* GetSortInfo() const { return mpSortInfo; }
sal_IntPtr GetCount() const { return mnCount; }
diff --git a/ucb/source/ucp/cmis/auth_provider.hxx b/ucb/source/ucp/cmis/auth_provider.hxx
index 1c521d52..977254a 100644
--- a/ucb/source/ucp/cmis/auth_provider.hxx
+++ b/ucb/source/ucp/cmis/auth_provider.hxx
@@ -36,7 +36,7 @@ namespace cmis
static void setXEnv( const css::uno::Reference< css::ucb::XCommandEnvironment>& xEnv ) { sm_xEnv = xEnv; }
- static css::uno::Reference< css::ucb::XCommandEnvironment> getXEnv( ) { return sm_xEnv; }
+ static const css::uno::Reference< css::ucb::XCommandEnvironment>& getXEnv( ) { return sm_xEnv; }
};
}
diff --git a/ucb/source/ucp/file/filinsreq.hxx b/ucb/source/ucp/file/filinsreq.hxx
index 6d21967..a39b32a 100644
--- a/ucb/source/ucp/file/filinsreq.hxx
+++ b/ucb/source/ucp/file/filinsreq.hxx
@@ -57,7 +57,7 @@ class XInteractionSupplyNameImpl : public cppu::WeakImplHelper<
m_aNewName = Name;
}
- OUString getName() const
+ const OUString& getName() const
{
return m_aNewName;
}
diff --git a/ucb/source/ucp/file/filtask.hxx b/ucb/source/ucp/file/filtask.hxx
index 3bb6e26..9af0e04 100644
--- a/ucb/source/ucp/file/filtask.hxx
+++ b/ucb/source/ucp/file/filtask.hxx
@@ -119,7 +119,7 @@ namespace fileaccess
return m_xInteractionHandler;
}
- css::uno::Reference< css::ucb::XCommandEnvironment > SAL_CALL
+ const css::uno::Reference< css::ucb::XCommandEnvironment >& SAL_CALL
getCommandEnvironment()
{
return m_xCommandEnvironment;
diff --git a/ucb/source/ucp/ftp/ftpurl.hxx b/ucb/source/ucp/ftp/ftpurl.hxx
index 7a12714..f112bfd 100644
--- a/ucb/source/ucp/ftp/ftpurl.hxx
+++ b/ucb/source/ucp/ftp/ftpurl.hxx
@@ -94,11 +94,11 @@ namespace ftp {
~FTPURL();
- OUString host() const { return m_aHost; }
+ const OUString& host() const { return m_aHost; }
- OUString port() const { return m_aPort; }
+ const OUString& port() const { return m_aPort; }
- OUString username() const { return m_aUsername; }
+ const OUString& username() const { return m_aUsername; }
/** This returns the URL, but cleaned from
* unnessary ellipses.
diff --git a/ucb/source/ucp/tdoc/tdoc_stgelems.hxx b/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
index 2e68503..d71ccf4 100644
--- a/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
@@ -53,7 +53,7 @@ public:
bool isParentARootStorage() const
{ return m_bParentIsRootStorage; }
- css::uno::Reference< css::embed::XStorage >
+ const css::uno::Reference< css::embed::XStorage >&
getParentStorage() const
{ return m_xParentStorage; }
void setParentStorage( const css::uno::Reference< css::embed::XStorage > & xStg )
diff --git a/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx b/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx
index c512199..2b36a13 100644
--- a/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx
+++ b/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx
@@ -82,7 +82,7 @@ public:
const OUString & getURL() const { return m_aURL; }
- rtl::Reference< DAVSessionFactory > getSessionFactory() const
+ const rtl::Reference< DAVSessionFactory >& getSessionFactory() const
{ return m_xSessionFactory; }
// DAV methods
diff --git a/ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx b/ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx
index 1eb0eef..7251826 100644
--- a/ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx
+++ b/ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx
@@ -67,7 +67,7 @@ public:
const ::uno::Reference< ::uno::XComponentContext >& rxContext )
throw( DAVException );
- ::uno::Reference< ::uno::XComponentContext > getComponentContext() { return m_xContext; }
+ const ::uno::Reference< ::uno::XComponentContext >& getComponentContext() { return m_xContext; }
private:
typedef std::map< OUString, DAVSession * > Map;
commit eb1603cb5383be7e25f35053dd64f044ead90099
Author: Noel Grandin <noel at peralex.com>
Date: Wed Apr 13 15:38:30 2016 +0200
loplugin:passstuffbyref in slideshow
Change-Id: I6a58315ae63d543053d613a18ff769329f309c32
diff --git a/slideshow/source/engine/activities/activitybase.hxx b/slideshow/source/engine/activities/activitybase.hxx
index 50de045..5db55d2 100644
--- a/slideshow/source/engine/activities/activitybase.hxx
+++ b/slideshow/source/engine/activities/activitybase.hxx
@@ -106,9 +106,9 @@ protected:
EventQueue& getEventQueue() const { return mrEventQueue; }
- AnimatableShapeSharedPtr getShape() const { return mpShape; }
+ const AnimatableShapeSharedPtr& getShape() const { return mpShape; }
- ShapeAttributeLayerSharedPtr getShapeAttributeLayer() const
+ const ShapeAttributeLayerSharedPtr& getShapeAttributeLayer() const
{ return mpAttributeLayer; }
bool isRepeatCountValid() const { return bool(maRepeats); }
diff --git a/slideshow/source/engine/shapeattributelayer.cxx b/slideshow/source/engine/shapeattributelayer.cxx
index 92518bd..73b100d 100644
--- a/slideshow/source/engine/shapeattributelayer.cxx
+++ b/slideshow/source/engine/shapeattributelayer.cxx
@@ -236,7 +236,7 @@ namespace slideshow
return true;
}
- ShapeAttributeLayerSharedPtr ShapeAttributeLayer::getChildLayer() const
+ const ShapeAttributeLayerSharedPtr& ShapeAttributeLayer::getChildLayer() const
{
return mpChild;
}
diff --git a/slideshow/source/engine/shapes/drawshapesubsetting.cxx b/slideshow/source/engine/shapes/drawshapesubsetting.cxx
index fab2a40..3c3e1d7 100644
--- a/slideshow/source/engine/shapes/drawshapesubsetting.cxx
+++ b/slideshow/source/engine/shapes/drawshapesubsetting.cxx
@@ -277,7 +277,7 @@ namespace slideshow
maCurrentSubsets.push_back( maSubset );
}
- DocTreeNode DrawShapeSubsetting::getSubsetNode() const
+ const DocTreeNode& DrawShapeSubsetting::getSubsetNode() const
{
return maSubset;
}
diff --git a/slideshow/source/engine/shapes/drawshapesubsetting.hxx b/slideshow/source/engine/shapes/drawshapesubsetting.hxx
index 48dca8e..ec10162 100644
--- a/slideshow/source/engine/shapes/drawshapesubsetting.hxx
+++ b/slideshow/source/engine/shapes/drawshapesubsetting.hxx
@@ -84,7 +84,7 @@ namespace slideshow
/// Return subset node for this shape
- DocTreeNode getSubsetNode () const;
+ const DocTreeNode& getSubsetNode () const;
/// Get subset shape for given node, if any
AttributableShapeSharedPtr getSubsetShape ( const DocTreeNode& rTreeNode ) const;
diff --git a/slideshow/source/engine/shapes/shapeimporter.cxx b/slideshow/source/engine/shapes/shapeimporter.cxx
index a06b2dc..5546d16 100644
--- a/slideshow/source/engine/shapes/shapeimporter.cxx
+++ b/slideshow/source/engine/shapes/shapeimporter.cxx
@@ -580,7 +580,7 @@ bool ShapeImporter::isImportDone() const
return maShapesStack.empty();
}
-PolyPolygonVector ShapeImporter::getPolygons()
+const PolyPolygonVector& ShapeImporter::getPolygons()
{
return maPolygons;
}
diff --git a/slideshow/source/engine/shapes/viewappletshape.cxx b/slideshow/source/engine/shapes/viewappletshape.cxx
index 47f8f78..7d6468a 100644
--- a/slideshow/source/engine/shapes/viewappletshape.cxx
+++ b/slideshow/source/engine/shapes/viewappletshape.cxx
@@ -114,7 +114,7 @@ namespace slideshow
}
- ViewLayerSharedPtr ViewAppletShape::getViewLayer() const
+ const ViewLayerSharedPtr& ViewAppletShape::getViewLayer() const
{
return mpViewLayer;
}
diff --git a/slideshow/source/engine/shapes/viewappletshape.hxx b/slideshow/source/engine/shapes/viewappletshape.hxx
index dfef6ab..6707509 100644
--- a/slideshow/source/engine/shapes/viewappletshape.hxx
+++ b/slideshow/source/engine/shapes/viewappletshape.hxx
@@ -89,7 +89,7 @@ namespace slideshow
/** Query the associated view layer of this shape
*/
- ViewLayerSharedPtr getViewLayer() const;
+ const ViewLayerSharedPtr& getViewLayer() const;
// animation methods
diff --git a/slideshow/source/engine/shapes/viewbackgroundshape.cxx b/slideshow/source/engine/shapes/viewbackgroundshape.cxx
index 9966032..ec2d611 100644
--- a/slideshow/source/engine/shapes/viewbackgroundshape.cxx
+++ b/slideshow/source/engine/shapes/viewbackgroundshape.cxx
@@ -142,7 +142,7 @@ namespace slideshow
ENSURE_OR_THROW( mpViewLayer->getCanvas(), "ViewBackgroundShape::ViewBackgroundShape(): Invalid ViewLayer canvas" );
}
- ViewLayerSharedPtr ViewBackgroundShape::getViewLayer() const
+ const ViewLayerSharedPtr& ViewBackgroundShape::getViewLayer() const
{
return mpViewLayer;
}
diff --git a/slideshow/source/engine/shapes/viewbackgroundshape.hxx b/slideshow/source/engine/shapes/viewbackgroundshape.hxx
index 1985b82..92403da 100644
--- a/slideshow/source/engine/shapes/viewbackgroundshape.hxx
+++ b/slideshow/source/engine/shapes/viewbackgroundshape.hxx
@@ -64,7 +64,7 @@ namespace slideshow
/** Query the associated view layer of this shape
*/
- ViewLayerSharedPtr getViewLayer() const;
+ const ViewLayerSharedPtr& getViewLayer() const;
bool render( const GDIMetaFileSharedPtr& rMtf ) const;
diff --git a/slideshow/source/engine/shapes/viewmediashape.cxx b/slideshow/source/engine/shapes/viewmediashape.cxx
index 2fc4ea2..e0c30a2 100644
--- a/slideshow/source/engine/shapes/viewmediashape.cxx
+++ b/slideshow/source/engine/shapes/viewmediashape.cxx
@@ -113,7 +113,7 @@ namespace slideshow
}
- ViewLayerSharedPtr ViewMediaShape::getViewLayer() const
+ const ViewLayerSharedPtr& ViewMediaShape::getViewLayer() const
{
return mpViewLayer;
}
diff --git a/slideshow/source/engine/shapes/viewmediashape.hxx b/slideshow/source/engine/shapes/viewmediashape.hxx
index e935f0a..c04b3e9 100644
--- a/slideshow/source/engine/shapes/viewmediashape.hxx
+++ b/slideshow/source/engine/shapes/viewmediashape.hxx
@@ -78,7 +78,7 @@ namespace slideshow
/** Query the associated view layer of this shape
*/
- ViewLayerSharedPtr getViewLayer() const;
+ const ViewLayerSharedPtr& getViewLayer() const;
// animation methods
diff --git a/slideshow/source/engine/shapes/viewshape.cxx b/slideshow/source/engine/shapes/viewshape.cxx
index a10d346..2acc75f 100644
--- a/slideshow/source/engine/shapes/viewshape.cxx
+++ b/slideshow/source/engine/shapes/viewshape.cxx
@@ -722,7 +722,7 @@ namespace slideshow
ENSURE_OR_THROW( mpViewLayer, "ViewShape::ViewShape(): Invalid View" );
}
- ViewLayerSharedPtr ViewShape::getViewLayer() const
+ const ViewLayerSharedPtr& ViewShape::getViewLayer() const
{
return mpViewLayer;
}
diff --git a/slideshow/source/engine/shapes/viewshape.hxx b/slideshow/source/engine/shapes/viewshape.hxx
index 88b3f7a..9f6d46c 100644
--- a/slideshow/source/engine/shapes/viewshape.hxx
+++ b/slideshow/source/engine/shapes/viewshape.hxx
@@ -63,7 +63,7 @@ namespace slideshow
/** Query the associated view layer of this shape
*/
- ViewLayerSharedPtr getViewLayer() const;
+ const ViewLayerSharedPtr& getViewLayer() const;
/** Query dimension of a safety border around the shape for AA
@@ -222,7 +222,7 @@ namespace slideshow
{
}
- ::cppcanvas::CanvasSharedPtr getDestinationCanvas() const
+ const ::cppcanvas::CanvasSharedPtr& getDestinationCanvas() const
{
return mpDestinationCanvas;
}
diff --git a/slideshow/source/engine/shapesubset.cxx b/slideshow/source/engine/shapesubset.cxx
index e5c5eee..5a20d3e 100644
--- a/slideshow/source/engine/shapesubset.cxx
+++ b/slideshow/source/engine/shapesubset.cxx
@@ -119,7 +119,7 @@ namespace slideshow
return maTreeNode.isEmpty();
}
- DocTreeNode ShapeSubset::getSubset() const
+ const DocTreeNode& ShapeSubset::getSubset() const
{
return maTreeNode;
}
diff --git a/slideshow/source/engine/slide/slideimpl.cxx b/slideshow/source/engine/slide/slideimpl.cxx
index ab9aa83..a306726 100644
--- a/slideshow/source/engine/slide/slideimpl.cxx
+++ b/slideshow/source/engine/slide/slideimpl.cxx
@@ -721,7 +721,7 @@ namespace
}
}
- uno::Reference< animations::XAnimationNode > getMainSequence() const
+ const uno::Reference< animations::XAnimationNode >& getMainSequence() const
{
return maMainSequence;
}
diff --git a/slideshow/source/engine/slide/userpaintoverlay.cxx b/slideshow/source/engine/slide/userpaintoverlay.cxx
index 1a3ad4d..68a3a4e 100644
--- a/slideshow/source/engine/slide/userpaintoverlay.cxx
+++ b/slideshow/source/engine/slide/userpaintoverlay.cxx
@@ -224,7 +224,7 @@ namespace slideshow
}
//Retrieve all registered polygons.
- PolyPolygonVector getPolygons()
+ const PolyPolygonVector& getPolygons()
{
return maPolygons;
}
diff --git a/slideshow/source/engine/slidebitmap.cxx b/slideshow/source/engine/slidebitmap.cxx
index cee3d8a..c13a38f 100644
--- a/slideshow/source/engine/slidebitmap.cxx
+++ b/slideshow/source/engine/slidebitmap.cxx
@@ -109,7 +109,7 @@ namespace slideshow
maClipPoly = rClipPoly;
}
- css::uno::Reference< css::rendering::XBitmap > SlideBitmap::getXBitmap()
+ const css::uno::Reference< css::rendering::XBitmap >& SlideBitmap::getXBitmap()
{
return mxBitmap;
}
diff --git a/slideshow/source/engine/slideview.cxx b/slideshow/source/engine/slideview.cxx
index bc6fee9..e82ab80 100644
--- a/slideshow/source/engine/slideview.cxx
+++ b/slideshow/source/engine/slideview.cxx
@@ -305,7 +305,7 @@ public:
{
}
- basegfx::B1DRange getLayerPriority() const
+ const basegfx::B1DRange& getLayerPriority() const
{
return maLayerPrioRange;
}
diff --git a/slideshow/source/inc/shapeattributelayer.hxx b/slideshow/source/inc/shapeattributelayer.hxx
index 31c8eba..d52e8a9 100644
--- a/slideshow/source/inc/shapeattributelayer.hxx
+++ b/slideshow/source/inc/shapeattributelayer.hxx
@@ -124,7 +124,7 @@ namespace slideshow
@attention
This method is only supposed to be called from Shape objects
*/
- ShapeAttributeLayerSharedPtr getChildLayer() const;
+ const ShapeAttributeLayerSharedPtr& getChildLayer() const;
/** Set the additive mode for possible child attributes
diff --git a/slideshow/source/inc/shapeattributelayerholder.hxx b/slideshow/source/inc/shapeattributelayerholder.hxx
index 12044e5..ba596ad 100644
--- a/slideshow/source/inc/shapeattributelayerholder.hxx
+++ b/slideshow/source/inc/shapeattributelayerholder.hxx
@@ -87,7 +87,7 @@ namespace slideshow
return static_cast< bool >(mpAttributeLayer);
}
- ShapeAttributeLayerSharedPtr get() const
+ const ShapeAttributeLayerSharedPtr& get() const
{
return mpAttributeLayer;
}
diff --git a/slideshow/source/inc/shapeimporter.hxx b/slideshow/source/inc/shapeimporter.hxx
index 3c9b85b..e1fba6f 100644
--- a/slideshow/source/inc/shapeimporter.hxx
+++ b/slideshow/source/inc/shapeimporter.hxx
@@ -90,7 +90,7 @@ public:
importShape() call.
*/
bool isImportDone() const;
- PolyPolygonVector getPolygons();
+ const PolyPolygonVector& getPolygons();
double getImportedShapesCount() { return mnAscendingPrio; }
private:
diff --git a/slideshow/source/inc/shapesubset.hxx b/slideshow/source/inc/shapesubset.hxx
index b124187..6851475 100644
--- a/slideshow/source/inc/shapesubset.hxx
+++ b/slideshow/source/inc/shapesubset.hxx
@@ -122,7 +122,7 @@ namespace slideshow
/** Query subset this object represents
*/
- DocTreeNode getSubset() const;
+ const DocTreeNode& getSubset() const;
private:
// default copy/assignment are okay
diff --git a/slideshow/source/inc/slidebitmap.hxx b/slideshow/source/inc/slidebitmap.hxx
index d0e1692..d311a6d 100644
--- a/slideshow/source/inc/slidebitmap.hxx
+++ b/slideshow/source/inc/slidebitmap.hxx
@@ -68,7 +68,7 @@ namespace slideshow
void move( const ::basegfx::B2DPoint& rNewPos );
void clip( const ::basegfx::B2DPolyPolygon& rClipPoly );
- css::uno::Reference< css::rendering::XBitmap > getXBitmap();
+ const css::uno::Reference< css::rendering::XBitmap >& getXBitmap();
private:
::basegfx::B2DPoint maOutputPos;
commit cc2f103744fc5e36a2e583442e41bc6b9d0d0b90
Author: Noel Grandin <noel at peralex.com>
Date: Wed Apr 13 15:37:46 2016 +0200
loplugin:passstuffbyref in sdext
Change-Id: I954510b953dab133bcf7b37cf598757b7d8e5fca
diff --git a/sdext/source/presenter/PresenterBitmapContainer.cxx b/sdext/source/presenter/PresenterBitmapContainer.cxx
index 8c8759d..b062f5e 100644
--- a/sdext/source/presenter/PresenterBitmapContainer.cxx
+++ b/sdext/source/presenter/PresenterBitmapContainer.cxx
@@ -334,7 +334,7 @@ PresenterBitmapContainer::BitmapDescriptor::BitmapDescriptor (
}
}
-css::uno::Reference<css::rendering::XBitmap>
+const css::uno::Reference<css::rendering::XBitmap>&
PresenterBitmapContainer::BitmapDescriptor::GetNormalBitmap() const
{
return mxNormalBitmap;
diff --git a/sdext/source/presenter/PresenterBitmapContainer.hxx b/sdext/source/presenter/PresenterBitmapContainer.hxx
index 78c83d8..f087733 100644
--- a/sdext/source/presenter/PresenterBitmapContainer.hxx
+++ b/sdext/source/presenter/PresenterBitmapContainer.hxx
@@ -51,7 +51,7 @@ public:
explicit BitmapDescriptor (const std::shared_ptr<BitmapDescriptor>& rpDefault);
enum Mode {Normal, MouseOver, ButtonDown, Disabled, Mask};
- css::uno::Reference<css::rendering::XBitmap> GetNormalBitmap() const;
+ const css::uno::Reference<css::rendering::XBitmap>& GetNormalBitmap() const;
css::uno::Reference<css::rendering::XBitmap> GetBitmap(const Mode eMode) const;
void SetBitmap (
const Mode eMode,
diff --git a/sdext/source/presenter/PresenterController.cxx b/sdext/source/presenter/PresenterController.cxx
index 79e4d02..95880ba 100644
--- a/sdext/source/presenter/PresenterController.cxx
+++ b/sdext/source/presenter/PresenterController.cxx
@@ -450,43 +450,43 @@ PresenterTheme::SharedFontDescriptor
return PresenterTheme::SharedFontDescriptor();
}
-std::shared_ptr<PresenterTheme> PresenterController::GetTheme() const
+const std::shared_ptr<PresenterTheme>& PresenterController::GetTheme() const
{
return mpTheme;
}
-::rtl::Reference<PresenterWindowManager> PresenterController::GetWindowManager() const
+const ::rtl::Reference<PresenterWindowManager>& PresenterController::GetWindowManager() const
{
return mpWindowManager;
}
-Reference<presentation::XSlideShowController>
+const Reference<presentation::XSlideShowController>&
PresenterController::GetSlideShowController() const
{
return mxSlideShowController;
}
-rtl::Reference<PresenterPaneContainer> PresenterController::GetPaneContainer() const
+const rtl::Reference<PresenterPaneContainer>& PresenterController::GetPaneContainer() const
{
return mpPaneContainer;
}
-::rtl::Reference<PresenterPaneBorderPainter> PresenterController::GetPaneBorderPainter() const
+const ::rtl::Reference<PresenterPaneBorderPainter>& PresenterController::GetPaneBorderPainter() const
{
return mpPaneBorderPainter;
}
-std::shared_ptr<PresenterCanvasHelper> PresenterController::GetCanvasHelper() const
+const std::shared_ptr<PresenterCanvasHelper>& PresenterController::GetCanvasHelper() const
{
return mpCanvasHelper;
}
-Reference<drawing::XPresenterHelper> PresenterController::GetPresenterHelper() const
+const Reference<drawing::XPresenterHelper>& PresenterController::GetPresenterHelper() const
{
return mxPresenterHelper;
}
-std::shared_ptr<PresenterPaintManager> PresenterController::GetPaintManager() const
+const std::shared_ptr<PresenterPaintManager>& PresenterController::GetPaintManager() const
{
return mpPaintManager;
}
@@ -568,13 +568,13 @@ util::URL PresenterController::CreateURLFromString (const OUString& rsURL) const
return aURL;
}
-Reference<drawing::framework::XConfigurationController>
+const Reference<drawing::framework::XConfigurationController>&
PresenterController::GetConfigurationController() const
{
return mxConfigurationController;
}
-Reference<drawing::XDrawPage> PresenterController::GetCurrentSlide() const
+const Reference<drawing::XDrawPage>& PresenterController::GetCurrentSlide() const
{
return mxCurrentSlide;
}
diff --git a/sdext/source/presenter/PresenterController.hxx b/sdext/source/presenter/PresenterController.hxx
index 0b910f4..0bb013f 100644
--- a/sdext/source/presenter/PresenterController.hxx
+++ b/sdext/source/presenter/PresenterController.hxx
@@ -105,15 +105,15 @@ public:
GetViewBackground (const OUString& rsViewURL) const;
PresenterTheme::SharedFontDescriptor
GetViewFont (const OUString& rsViewURL) const;
- std::shared_ptr<PresenterTheme> GetTheme() const;
- ::rtl::Reference<PresenterWindowManager> GetWindowManager() const;
- css::uno::Reference<css::presentation::XSlideShowController>
+ const std::shared_ptr<PresenterTheme>& GetTheme() const;
+ const ::rtl::Reference<PresenterWindowManager>& GetWindowManager() const;
+ const css::uno::Reference<css::presentation::XSlideShowController>&
GetSlideShowController() const;
- rtl::Reference<PresenterPaneContainer> GetPaneContainer() const;
- ::rtl::Reference<PresenterPaneBorderPainter> GetPaneBorderPainter() const;
- std::shared_ptr<PresenterCanvasHelper> GetCanvasHelper() const;
- css::uno::Reference<css::drawing::XPresenterHelper> GetPresenterHelper() const;
- std::shared_ptr<PresenterPaintManager> GetPaintManager() const;
+ const rtl::Reference<PresenterPaneContainer>& GetPaneContainer() const;
+ const ::rtl::Reference<PresenterPaneBorderPainter>& GetPaneBorderPainter() const;
+ const std::shared_ptr<PresenterCanvasHelper>& GetCanvasHelper() const;
+ const css::uno::Reference<css::drawing::XPresenterHelper>& GetPresenterHelper() const;
+ const std::shared_ptr<PresenterPaintManager>& GetPaintManager() const;
double GetSlideAspectRatio() const;
void ShowView (const OUString& rsViewURL);
void HideView (const OUString& rsViewURL);
@@ -122,9 +122,9 @@ public:
css::uno::Reference<css::frame::XDispatch> GetDispatch (
const css::util::URL& rURL) const;
css::util::URL CreateURLFromString (const OUString& rsURL) const;
- css::uno::Reference<css::drawing::framework::XConfigurationController>
+ const css::uno::Reference<css::drawing::framework::XConfigurationController>&
GetConfigurationController() const;
- css::uno::Reference<css::drawing::XDrawPage> GetCurrentSlide() const;
+ const css::uno::Reference<css::drawing::XDrawPage>& GetCurrentSlide() const;
static bool HasTransition (css::uno::Reference<css::drawing::XDrawPage>& rxPage);
static bool HasCustomAnimation (css::uno::Reference<css::drawing::XDrawPage>& rxPage);
void SetAccessibilityActiveState (const bool bIsActive);
diff --git a/sdext/source/presenter/PresenterNotesView.cxx b/sdext/source/presenter/PresenterNotesView.cxx
index 914b356..b8ea266 100644
--- a/sdext/source/presenter/PresenterNotesView.cxx
+++ b/sdext/source/presenter/PresenterNotesView.cxx
@@ -673,7 +673,7 @@ void PresenterNotesView::ChangeFontSize (const sal_Int32 nSizeChange)
}
}
-std::shared_ptr<PresenterTextView> PresenterNotesView::GetTextView() const
+const std::shared_ptr<PresenterTextView>& PresenterNotesView::GetTextView() const
{
return mpTextView;
}
diff --git a/sdext/source/presenter/PresenterNotesView.hxx b/sdext/source/presenter/PresenterNotesView.hxx
index 418087d..653cd2d 100644
--- a/sdext/source/presenter/PresenterNotesView.hxx
+++ b/sdext/source/presenter/PresenterNotesView.hxx
@@ -85,7 +85,7 @@ public:
void ChangeFontSize (const sal_Int32 nSizeChange);
- std::shared_ptr<PresenterTextView> GetTextView() const;
+ const std::shared_ptr<PresenterTextView>& GetTextView() const;
// lang::XEventListener
diff --git a/sdext/source/presenter/PresenterPaneBase.cxx b/sdext/source/presenter/PresenterPaneBase.cxx
index 7ca1172..d05e841 100644
--- a/sdext/source/presenter/PresenterPaneBase.cxx
+++ b/sdext/source/presenter/PresenterPaneBase.cxx
@@ -116,12 +116,12 @@ void PresenterPaneBase::SetTitle (const OUString& rsTitle)
mpPresenterController->GetPaintManager()->Invalidate(mxBorderWindow);
}
-OUString PresenterPaneBase::GetTitle() const
+const OUString& PresenterPaneBase::GetTitle() const
{
return msTitle;
}
-Reference<drawing::framework::XPaneBorderPainter>
+const Reference<drawing::framework::XPaneBorderPainter>&
PresenterPaneBase::GetPaneBorderPainter() const
{
return mxBorderPainter;
@@ -156,7 +156,7 @@ void PresenterPaneBase::SetCalloutAnchor (const css::awt::Point& rCalloutAnchor)
mpPresenterController->GetPaintManager()->Invalidate(mxBorderWindow);
}
-awt::Point PresenterPaneBase::GetCalloutAnchor() const
+const awt::Point& PresenterPaneBase::GetCalloutAnchor() const
{
return maCalloutAnchor;
}
@@ -337,7 +337,7 @@ void PresenterPaneBase::CreateWindows (
}
}
-Reference<awt::XWindow> PresenterPaneBase::GetBorderWindow() const
+const Reference<awt::XWindow>& PresenterPaneBase::GetBorderWindow() const
{
return mxBorderWindow;
}
diff --git a/sdext/source/presenter/PresenterPaneBase.hxx b/sdext/source/presenter/PresenterPaneBase.hxx
index 0defffe..a1301e2 100644
--- a/sdext/source/presenter/PresenterPaneBase.hxx
+++ b/sdext/source/presenter/PresenterPaneBase.hxx
@@ -71,13 +71,13 @@ public:
virtual void SAL_CALL disposing() override;
- css::uno::Reference<css::awt::XWindow> GetBorderWindow() const;
+ const css::uno::Reference<css::awt::XWindow>& GetBorderWindow() const;
void SetBackground (const SharedBitmapDescriptor& rpBackground);
void SetTitle (const OUString& rsTitle);
- OUString GetTitle() const;
- css::uno::Reference<css::drawing::framework::XPaneBorderPainter> GetPaneBorderPainter() const;
+ const OUString& GetTitle() const;
+ const css::uno::Reference<css::drawing::framework::XPaneBorderPainter>& GetPaneBorderPainter() const;
void SetCalloutAnchor (const css::awt::Point& rAnchorPosition);
- css::awt::Point GetCalloutAnchor() const;
+ const css::awt::Point& GetCalloutAnchor() const;
// XInitialization
diff --git a/sdext/source/presenter/PresenterSpritePane.cxx b/sdext/source/presenter/PresenterSpritePane.cxx
index 9c4161c..36c3ad4 100644
--- a/sdext/source/presenter/PresenterSpritePane.cxx
+++ b/sdext/source/presenter/PresenterSpritePane.cxx
@@ -147,7 +147,7 @@ void SAL_CALL PresenterSpritePane::windowPaint (const awt::PaintEvent& rEvent)
}
-std::shared_ptr<PresenterSprite> PresenterSpritePane::GetSprite()
+const std::shared_ptr<PresenterSprite>& PresenterSpritePane::GetSprite()
{
return mpSprite;
}
diff --git a/sdext/source/presenter/PresenterSpritePane.hxx b/sdext/source/presenter/PresenterSpritePane.hxx
index a4b79bd..f2a110d 100644
--- a/sdext/source/presenter/PresenterSpritePane.hxx
+++ b/sdext/source/presenter/PresenterSpritePane.hxx
@@ -57,7 +57,7 @@ public:
using PresenterPaneBase::disposing;
- std::shared_ptr<PresenterSprite> GetSprite();
+ const std::shared_ptr<PresenterSprite>& GetSprite();
// XPane
diff --git a/sdext/source/presenter/PresenterTextView.cxx b/sdext/source/presenter/PresenterTextView.cxx
index 5a8a8aa..dd3132d 100644
--- a/sdext/source/presenter/PresenterTextView.cxx
+++ b/sdext/source/presenter/PresenterTextView.cxx
@@ -394,7 +394,7 @@ void PresenterTextView::Paint (
}
}
-SharedPresenterTextCaret PresenterTextView::GetCaret() const
+const SharedPresenterTextCaret& PresenterTextView::GetCaret() const
{
return mpCaret;
}
@@ -792,7 +792,7 @@ sal_Unicode PresenterTextParagraph::GetCharacter (
}
}
-OUString PresenterTextParagraph::GetText() const
+const OUString& PresenterTextParagraph::GetText() const
{
return msParagraphText;
}
@@ -1166,7 +1166,7 @@ void PresenterTextCaret::SetCaretMotionBroadcaster (
maBroadcaster = rBroadcaster;
}
-css::awt::Rectangle PresenterTextCaret::GetBounds() const
+const css::awt::Rectangle& PresenterTextCaret::GetBounds() const
{
return maCaretBounds;
}
diff --git a/sdext/source/presenter/PresenterTextView.hxx b/sdext/source/presenter/PresenterTextView.hxx
index 955f972..9a1da80 100644
--- a/sdext/source/presenter/PresenterTextView.hxx
+++ b/sdext/source/presenter/PresenterTextView.hxx
@@ -66,7 +66,7 @@ public:
void SetCaretMotionBroadcaster (
const ::std::function<void (sal_Int32,sal_Int32,sal_Int32,sal_Int32)>& rBroadcaster);
- css::awt::Rectangle GetBounds() const;
+ const css::awt::Rectangle& GetBounds() const;
private:
sal_Int32 mnParagraphIndex;
@@ -109,7 +109,7 @@ public:
void SetCharacterOffset (const sal_Int32 nCharacterOffset);
sal_Int32 GetCharacterCount() const;
sal_Unicode GetCharacter (const sal_Int32 nGlobalCharacterIndex) const;
- OUString GetText() const;
+ const OUString& GetText() const;
css::accessibility::TextSegment GetTextSegment (
const sal_Int32 nOffset,
const sal_Int32 nGlobalCharacterIndex,
@@ -247,7 +247,7 @@ public:
void Paint (const css::awt::Rectangle& rUpdateBox);
- SharedPresenterTextCaret GetCaret() const;
+ const SharedPresenterTextCaret& GetCaret() const;
sal_Int32 GetParagraphCount() const;
SharedPresenterTextParagraph GetParagraph (const sal_Int32 nParagraphIndex) const;
diff --git a/sdext/source/presenter/PresenterToolBar.cxx b/sdext/source/presenter/PresenterToolBar.cxx
index 2203007..203f76f 100644
--- a/sdext/source/presenter/PresenterToolBar.cxx
+++ b/sdext/source/presenter/PresenterToolBar.cxx
@@ -72,8 +72,8 @@ namespace {
const PresenterTheme::SharedFontDescriptor& rpFont);
void SetText (const OUString& rsText);
- OUString GetText() const;
- PresenterTheme::SharedFontDescriptor GetFont() const;
+ const OUString& GetText() const;
+ const PresenterTheme::SharedFontDescriptor& GetFont() const;
void Paint (
const Reference<rendering::XCanvas>& rxCanvas,
@@ -489,12 +489,12 @@ geometry::RealSize2D PresenterToolBar::GetMinimalSize()
return maMinimalSize;
}
-::rtl::Reference<PresenterController> PresenterToolBar::GetPresenterController() const
+const ::rtl::Reference<PresenterController>& PresenterToolBar::GetPresenterController() const
{
return mpPresenterController;
}
-Reference<XComponentContext> PresenterToolBar::GetComponentContext() const
+const Reference<XComponentContext>& PresenterToolBar::GetComponentContext() const
{
return mxComponentContext;
}
@@ -1143,7 +1143,7 @@ void SAL_CALL PresenterToolBarView::disposing()
}
-::rtl::Reference<PresenterToolBar> PresenterToolBarView::GetPresenterToolBar() const
+const ::rtl::Reference<PresenterToolBar>& PresenterToolBarView::GetPresenterToolBar() const
{
return mpToolBar;
}
@@ -1720,12 +1720,12 @@ void Text::SetText (const OUString& rsText)
msText = rsText;
}
-OUString Text::GetText() const
+const OUString& Text::GetText() const
{
return msText;
}
-PresenterTheme::SharedFontDescriptor Text::GetFont() const
+const PresenterTheme::SharedFontDescriptor& Text::GetFont() const
{
return mpFont;
}
diff --git a/sdext/source/presenter/PresenterToolBar.hxx b/sdext/source/presenter/PresenterToolBar.hxx
index 3348a8d..f4201a1 100644
--- a/sdext/source/presenter/PresenterToolBar.hxx
+++ b/sdext/source/presenter/PresenterToolBar.hxx
@@ -99,8 +99,8 @@ public:
void RequestLayout();
css::geometry::RealSize2D GetMinimalSize();
- ::rtl::Reference<PresenterController> GetPresenterController() const;
- css::uno::Reference<css::uno::XComponentContext> GetComponentContext() const;
+ const ::rtl::Reference<PresenterController>& GetPresenterController() const;
+ const css::uno::Reference<css::uno::XComponentContext>& GetComponentContext() const;
// lang::XEventListener
@@ -234,7 +234,7 @@ public:
virtual void SAL_CALL disposing() override;
- ::rtl::Reference<PresenterToolBar> GetPresenterToolBar() const;
+ const ::rtl::Reference<PresenterToolBar>& GetPresenterToolBar() const;
// XPaintListener
commit baf34a9e44fbd39c3657cabd22d871bc804ab12d
Author: Noel Grandin <noel at peralex.com>
Date: Wed Apr 13 15:37:03 2016 +0200
loplugin:passstuffbyref in sd
Change-Id: If5a68861451efe025b77f71a20e805b71240b827
diff --git a/sd/inc/CustomAnimationEffect.hxx b/sd/inc/CustomAnimationEffect.hxx
index 507bd9f..a1b6b2a 100644
--- a/sd/inc/CustomAnimationEffect.hxx
+++ b/sd/inc/CustomAnimationEffect.hxx
@@ -100,13 +100,13 @@ public:
SAL_DLLPRIVATE double getIterateInterval() const { return mfIterateInterval; }
void setIterateInterval( double fIterateInterval );
- SAL_DLLPRIVATE css::uno::Any getTarget() const { return maTarget; }
+ SAL_DLLPRIVATE const css::uno::Any& getTarget() const { return maTarget; }
void setTarget( const css::uno::Any& rTarget );
SAL_DLLPRIVATE bool hasAfterEffect() const { return mbHasAfterEffect; }
SAL_DLLPRIVATE void setHasAfterEffect( bool bHasAfterEffect ) { mbHasAfterEffect = bHasAfterEffect; }
- SAL_DLLPRIVATE css::uno::Any getDimColor() const { return maDimColor; }
+ SAL_DLLPRIVATE const css::uno::Any& getDimColor() const { return maDimColor; }
SAL_DLLPRIVATE void setDimColor( const css::uno::Any& rDimColor ) { maDimColor = rDimColor; }
SAL_DLLPRIVATE bool IsAfterEffectOnNext() const { return mbAfterEffectOnNextEffect; }
@@ -317,7 +317,7 @@ public:
SAL_DLLPRIVATE sal_Int32 getSequenceType() const { return mnSequenceType; }
- SAL_DLLPRIVATE css::uno::Reference< css::drawing::XShape > getTriggerShape() const { return mxEventSource; }
+ SAL_DLLPRIVATE const css::uno::Reference< css::drawing::XShape >& getTriggerShape() const { return mxEventSource; }
SAL_DLLPRIVATE void setTriggerShape( const css::uno::Reference< css::drawing::XShape >& xTrigger ) { mxEventSource = xTrigger; }
SAL_DLLPRIVATE virtual sal_Int32 getOffsetFromEffect( const CustomAnimationEffectPtr& xEffect ) const;
diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx
index 5eeea8d..099f36b 100644
--- a/sd/inc/drawdoc.hxx
+++ b/sd/inc/drawdoc.hxx
@@ -139,7 +139,7 @@ private:
OUString msDocAccTitle;
public:
SAL_DLLPRIVATE void setDocAccTitle( const OUString& rTitle ) { msDocAccTitle = rTitle; }
- SAL_DLLPRIVATE const OUString getDocAccTitle() const { return msDocAccTitle; }
+ SAL_DLLPRIVATE const OUString& getDocAccTitle() const { return msDocAccTitle; }
private:
bool bReadOnly;
public:
diff --git a/sd/inc/sdpage.hxx b/sd/inc/sdpage.hxx
index 46d47b9..b893e6a 100644
--- a/sd/inc/sdpage.hxx
+++ b/sd/inc/sdpage.hxx
@@ -231,7 +231,7 @@ public:
bool IsScaleObjects() const { return mbScaleObjects; }
void SetSoundFile(const OUString& rStr) { maSoundFile = rStr; }
- OUString GetSoundFile() const { return maSoundFile; }
+ const OUString& GetSoundFile() const { return maSoundFile; }
void SetLoopSound( bool bLoopSound ) { mbLoopSound = bLoopSound; }
bool IsLoopSound() const { return mbLoopSound; }
@@ -261,9 +261,9 @@ public:
virtual OUString GetLayoutName() const override { return maLayoutName; }
void SetFileName(const OUString& aName) { maFileName = aName; }
- OUString GetFileName() const { return maFileName; }
+ const OUString& GetFileName() const { return maFileName; }
void SetBookmarkName(const OUString& aName) { maBookmarkName = aName; }
- OUString GetBookmarkName() const { return maBookmarkName; }
+ const OUString& GetBookmarkName() const { return maBookmarkName; }
void ConnectLink();
void DisconnectLink();
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx b/sd/source/ui/animations/CustomAnimationList.cxx
index 328478a..3f5d502 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -355,7 +355,7 @@ public:
explicit CustomAnimationListEntry( CustomAnimationEffectPtr pEffect );
virtual ~CustomAnimationListEntry();
- CustomAnimationEffectPtr getEffect() const { return mpEffect; }
+ const CustomAnimationEffectPtr& getEffect() const { return mpEffect; }
private:
CustomAnimationEffectPtr mpEffect;
diff --git a/sd/source/ui/annotations/annotationtag.hxx b/sd/source/ui/annotations/annotationtag.hxx
index 4a7e0da..622b4f1 100644
--- a/sd/source/ui/annotations/annotationtag.hxx
+++ b/sd/source/ui/annotations/annotationtag.hxx
@@ -61,7 +61,7 @@ public:
BitmapEx CreateAnnotationBitmap(bool);
- css::uno::Reference< css::office::XAnnotation > GetAnnotation() const { return mxAnnotation; }
+ const css::uno::Reference< css::office::XAnnotation >& GetAnnotation() const { return mxAnnotation; }
void OpenPopup( bool bEdit );
void ClosePopup();
diff --git a/sd/source/ui/framework/configuration/ConfigurationUpdater.hxx b/sd/source/ui/framework/configuration/ConfigurationUpdater.hxx
index 11658fc..7542cfb 100644
--- a/sd/source/ui/framework/configuration/ConfigurationUpdater.hxx
+++ b/sd/source/ui/framework/configuration/ConfigurationUpdater.hxx
@@ -71,8 +71,8 @@ public:
void RequestUpdate (const css::uno::Reference<
css::drawing::framework::XConfiguration>& rxRequestedConfiguration);
- css::uno::Reference<
- css::drawing::framework::XConfiguration> GetCurrentConfiguration() const { return mxCurrentConfiguration;}
+ const css::uno::Reference<
+ css::drawing::framework::XConfiguration>& GetCurrentConfiguration() const { return mxCurrentConfiguration;}
friend class ConfigurationUpdaterLock;
/** Return a lock of the called ConfigurationUpdater. While the
diff --git a/sd/source/ui/func/fuconcs.cxx b/sd/source/ui/func/fuconcs.cxx
index a6e06d3..015ab43 100644
... etc. - the rest is truncated
More information about the Libreoffice-commits
mailing list