[Libreoffice-commits] online.git: loolwsd/Util.cpp loolwsd/Util.hpp

Tor Lillqvist tml at collabora.com
Thu Apr 14 08:40:23 UTC 2016


 loolwsd/Util.cpp |   28 ----------------------------
 loolwsd/Util.hpp |    3 ---
 2 files changed, 31 deletions(-)

New commits:
commit 1bd6cdde3b441ced6f93a231d699ea9483002170
Author: Tor Lillqvist <tml at collabora.com>
Date:   Thu Apr 14 11:35:38 2016 +0300

    Util::getSignalStatus() is unused
    
    Good, its semantics was a bit odd anyway.

diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp
index 2162b26..eaea899 100644
--- a/loolwsd/Util.cpp
+++ b/loolwsd/Util.cpp
@@ -491,34 +491,6 @@ namespace Util
         strncpy(FatalGdbString, streamStr.c_str(), sizeof(FatalGdbString));
     }
 
-    int getSignalStatus(const int code)
-    {
-        int retVal;
-
-        switch (code)
-        {
-            case SIGSEGV:
-            case SIGBUS:
-            case SIGABRT:
-            case SIGILL:
-            case SIGFPE:
-            case SIGTERM:
-            case SIGINT:
-            case SIGQUIT:
-            case SIGHUP:
-                retVal = EXIT_FAILURE;
-            break;
-
-            // Why are other signals treated as success? Will this function ever be called when a
-            // child was *not* terminated by a signal?
-            default:
-                retVal = EXIT_SUCCESS;
-            break;
-        }
-
-        return retVal;
-    }
-
     void requestTermination(const Poco::Process::PID& pid)
     {
         try
diff --git a/loolwsd/Util.hpp b/loolwsd/Util.hpp
index e56528d..109a78a 100644
--- a/loolwsd/Util.hpp
+++ b/loolwsd/Util.hpp
@@ -101,9 +101,6 @@ namespace Util
     void setTerminationSignals();
     void setFatalSignals();
 
-    /// Returns EXIT_SUCCESS or EXIT_FAILURE from <stdlib.h>
-    int getSignalStatus(const int code);
-
     void requestTermination(const Poco::Process::PID& pid);
 
     int getMemoryUsage(const Poco::Process::PID nPid);


More information about the Libreoffice-commits mailing list