[Libreoffice-commits] core.git: basic/qa

Ryan McCoskrie ryan.mccoskrie at gmail.com
Mon Apr 18 07:17:03 UTC 2016


 basic/qa/cppunit/basic_coverage.cxx |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

New commits:
commit 666dc67eaff92d019ea57a571f0156533f4507f8
Author: Ryan McCoskrie <ryan.mccoskrie at gmail.com>
Date:   Sun Apr 17 21:46:56 2016 +1200

    Remove needless typedef from basic/qa/cppunit/basic_coverage.cxx
    
    Change-Id: Iba1c48d58daa618107ad84240d613f675d447aad
    Reviewed-on: https://gerrit.libreoffice.org/24175
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/basic/qa/cppunit/basic_coverage.cxx b/basic/qa/cppunit/basic_coverage.cxx
index 585d54a..275fdb9 100644
--- a/basic/qa/cppunit/basic_coverage.cxx
+++ b/basic/qa/cppunit/basic_coverage.cxx
@@ -20,7 +20,6 @@ namespace
 class Coverage : public test::BootstrapFixture
 {
 private:
-    typedef std::vector< OUString > StringVec;
     int  m_nb_tests_ok;
     int  m_nb_tests_skipped;
     OUString m_sCurrentTest;
@@ -28,7 +27,7 @@ private:
     void run_test(const OUString& sFileName);
     void test_failed();
     void test_success();
-    StringVec get_subdirnames( const OUString& sDirName );
+    std::vector< OUString > get_subdirnames( const OUString& sDirName );
 
 public:
     Coverage();
@@ -95,9 +94,9 @@ void Coverage::run_test(const OUString& sFileURL)
     }
 }
 
-Coverage::StringVec Coverage::get_subdirnames( const OUString& sDirName )
+std::vector< OUString > Coverage::get_subdirnames( const OUString& sDirName )
 {
-    Coverage::StringVec sSubDirNames;
+    std::vector< OUString > sSubDirNames;
     osl::Directory aDir(sDirName);
     osl::DirectoryItem aItem;
     osl::FileStatus aFileStatus(osl_FileStatus_Mask_FileURL|osl_FileStatus_Mask_Type);
@@ -142,9 +141,9 @@ void Coverage::Coverage_Iterator()
 
     CPPUNIT_ASSERT(!sDirName.isEmpty());
     process_directory(sDirName); // any files in the root test dir are run in test harness default locale ( en-US )
-    Coverage::StringVec sLangDirs = get_subdirnames( sDirName );
+    std::vector< OUString > sLangDirs = get_subdirnames( sDirName );
 
-    for ( Coverage::StringVec::iterator it = sLangDirs.begin(), it_end = sLangDirs.end(); it != it_end; ++it )
+    for ( std::vector< OUString >::iterator it = sLangDirs.begin(), it_end = sLangDirs.end(); it != it_end; ++it )
     {
         OUString sDir( *it );
         sal_Int32 nSlash = (*it).lastIndexOf('/');


More information about the Libreoffice-commits mailing list