[Libreoffice-commits] core.git: 6 commits - bridges/source connectivity/source fpicker/source framework/source lingucomponent/source vcl/osx

Stephan Bergmann sbergman at redhat.com
Fri Apr 22 07:33:07 UTC 2016


 bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx        |    4 
 bridges/source/cpp_uno/gcc3_macosx_x86-64/uno2cpp.cxx        |    4 
 connectivity/source/drivers/macab/MacabConnection.cxx        |    4 
 connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx  |  180 +++++------
 connectivity/source/drivers/macab/MacabDriver.cxx            |    2 
 connectivity/source/drivers/macab/MacabResultSet.cxx         |   48 +-
 connectivity/source/drivers/macab/MacabResultSetMetaData.cxx |   18 -
 fpicker/source/aqua/SalAquaFilePicker.hxx                    |    2 
 fpicker/source/aqua/SalAquaPicker.hxx                        |    4 
 fpicker/source/aqua/SalAquaPicker.mm                         |    2 
 framework/source/dispatch/closedispatcher.cxx                |    2 
 lingucomponent/source/spellcheck/macosxspell/macspellimp.mm  |    6 
 vcl/osx/printaccessoryview.mm                                |    6 
 13 files changed, 141 insertions(+), 141 deletions(-)

New commits:
commit 29840e676927eb44c5857e854df283d58aae93c3
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Apr 21 20:15:57 2016 +0200

    loplugin:salbool
    
    Change-Id: I186376ceeb53126bc31d63d00a988be6cb7a5637

diff --git a/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm b/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
index 11d1356..959d518 100644
--- a/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
+++ b/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
@@ -246,7 +246,7 @@ sal_Int16 MacSpellChecker::GetSpellFailure( const OUString &rWord, const Locale
         }
 
         NSInteger aCount;
-        NSRange range = [macSpell checkSpellingOfString:aNSStr startingAt:0 language:aLang wrap:sal_False inSpellDocumentWithTag:macTag wordCount:&aCount];
+        NSRange range = [macSpell checkSpellingOfString:aNSStr startingAt:0 language:aLang wrap:false inSpellDocumentWithTag:macTag wordCount:&aCount];
         int rVal = 0;
         if(range.length>0)
         {
@@ -277,10 +277,10 @@ sal_Bool SAL_CALL
     MutexGuard  aGuard( GetLinguMutex() );
 
      if (rLocale == Locale()  ||  !rWord.getLength())
-        return sal_True;
+        return true;
 
     if (!hasLocale( rLocale ))
-        return sal_True;
+        return true;
 
     // Get property values to be used.
     // These are be the default values set in the SN_LINGU_PROPERTIES
commit 988e5c7b480c974c5bcc5c808092d0ea725511a2
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Apr 21 20:12:37 2016 +0200

    loplugin:passstuffbyref
    
    Change-Id: I45cc7c949dd8288bcc39f23c224370764c5cf0ec

diff --git a/fpicker/source/aqua/SalAquaFilePicker.hxx b/fpicker/source/aqua/SalAquaFilePicker.hxx
index e33a489..869c5aa 100644
--- a/fpicker/source/aqua/SalAquaFilePicker.hxx
+++ b/fpicker/source/aqua/SalAquaFilePicker.hxx
@@ -158,7 +158,7 @@ public:
        return m_pDelegate;
    }
 
-   inline OUString getSaveFileName() {
+   inline OUString const & getSaveFileName() {
        return m_sSaveFileName;
    }
 
diff --git a/fpicker/source/aqua/SalAquaPicker.hxx b/fpicker/source/aqua/SalAquaPicker.hxx
index 2ff8345..3459055 100644
--- a/fpicker/source/aqua/SalAquaPicker.hxx
+++ b/fpicker/source/aqua/SalAquaPicker.hxx
@@ -47,7 +47,7 @@ public:
     int run();
     int runandwaitforresult();
 
-    inline OUString getDisplayDirectory() { return m_sDisplayDirectory; }
+    inline OUString const & getDisplayDirectory() { return m_sDisplayDirectory; }
 
     inline ControlHelper* getControlHelper() const {
         return m_pControlHelper;
@@ -78,7 +78,7 @@ protected:
     void implsetDisplayDirectory( const OUString& rDirectory )
         throw( css::lang::IllegalArgumentException, css::uno::RuntimeException );
 
-    OUString implgetDisplayDirectory(  )
+    OUString const & implgetDisplayDirectory(  )
         throw( css::uno::RuntimeException );
 
     void implInitialize( );
diff --git a/fpicker/source/aqua/SalAquaPicker.mm b/fpicker/source/aqua/SalAquaPicker.mm
index 7f9f895..6028509 100644
--- a/fpicker/source/aqua/SalAquaPicker.mm
+++ b/fpicker/source/aqua/SalAquaPicker.mm
@@ -200,7 +200,7 @@ void SAL_CALL SalAquaPicker::implsetDisplayDirectory( const rtl::OUString& aDire
     }
 }
 
-rtl::OUString SAL_CALL SalAquaPicker::implgetDisplayDirectory() throw( uno::RuntimeException )
+rtl::OUString const & SAL_CALL SalAquaPicker::implgetDisplayDirectory() throw( uno::RuntimeException )
 {
     return m_sDisplayDirectory;
 }
commit db496668e0dec6cede2428f55efe7c192cd9c1de
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Apr 21 20:03:48 2016 +0200

    loplugin:salbool
    
    Change-Id: Ibcae25d2476de37842e4a0e670b5951f431195a2

diff --git a/connectivity/source/drivers/macab/MacabConnection.cxx b/connectivity/source/drivers/macab/MacabConnection.cxx
index 894ac7c..4c25d75 100644
--- a/connectivity/source/drivers/macab/MacabConnection.cxx
+++ b/connectivity/source/drivers/macab/MacabConnection.cxx
@@ -125,7 +125,7 @@ sal_Bool SAL_CALL MacabConnection::getAutoCommit(  ) throw(SQLException, Runtime
     // you have to distinguish which if you are in autocommit mode or not
     // at normal case true should be fine here
 
-    return sal_True;
+    return true;
 }
 
 void SAL_CALL MacabConnection::commit(  ) throw(SQLException, RuntimeException)
@@ -183,7 +183,7 @@ sal_Bool SAL_CALL MacabConnection::isReadOnly(  ) throw(SQLException, RuntimeExc
     checkDisposed(MacabConnection_BASE::rBHelper.bDisposed);
 
     // return if your connection to readonly
-    return sal_False;
+    return false;
 }
 
 void SAL_CALL MacabConnection::setCatalog( const OUString& ) throw(SQLException, RuntimeException)
diff --git a/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx b/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx
index d32f4f9..fa3e9c9 100644
--- a/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx
@@ -140,47 +140,47 @@ sal_Int32 SAL_CALL MacabDatabaseMetaData::getMaxTablesInSelect(  ) throw(SQLExce
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::doesMaxRowSizeIncludeBlobs(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::storesLowerCaseQuotedIdentifiers(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::storesLowerCaseIdentifiers(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::storesMixedCaseQuotedIdentifiers(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::storesMixedCaseIdentifiers(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::storesUpperCaseQuotedIdentifiers(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::storesUpperCaseIdentifiers(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsAlterTableWithAddColumn(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsAlterTableWithDropColumn(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Int32 SAL_CALL MacabDatabaseMetaData::getMaxIndexLength(  ) throw(SQLException, RuntimeException)
@@ -191,7 +191,7 @@ sal_Int32 SAL_CALL MacabDatabaseMetaData::getMaxIndexLength(  ) throw(SQLExcepti
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsNonNullableColumns(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 OUString SAL_CALL MacabDatabaseMetaData::getCatalogTerm(  ) throw(SQLException, RuntimeException)
@@ -218,7 +218,7 @@ OUString SAL_CALL MacabDatabaseMetaData::getExtraNameCharacters(  ) throw(SQLExc
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsDifferentTableCorrelationNames(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::isCatalogAtStart(  ) throw(SQLException, RuntimeException)
@@ -232,107 +232,107 @@ sal_Bool SAL_CALL MacabDatabaseMetaData::isCatalogAtStart(  ) throw(SQLException
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::dataDefinitionIgnoredInTransactions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::dataDefinitionCausesTransactionCommit(  ) throw(SQLException, RuntimeException)
 {
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsDataManipulationTransactionsOnly(  ) throw(SQLException, RuntimeException)
 {
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsDataDefinitionAndDataManipulationTransactions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsPositionedDelete(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsPositionedUpdate(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsOpenStatementsAcrossRollback(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsOpenStatementsAcrossCommit(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsOpenCursorsAcrossCommit(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsOpenCursorsAcrossRollback(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsTransactionIsolationLevel( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSchemasInDataManipulation(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsANSI92FullSQL(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsANSI92EntryLevelSQL(  ) throw(SQLException, RuntimeException)
 {
-    return sal_True; // should be supported at least
+    return true; // should be supported at least
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsIntegrityEnhancementFacility(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSchemasInIndexDefinitions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSchemasInTableDefinitions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsCatalogsInTableDefinitions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsCatalogsInIndexDefinitions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsCatalogsInDataManipulation(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsOuterJoins(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Int32 SAL_CALL MacabDatabaseMetaData::getMaxStatements(  ) throw(SQLException, RuntimeException)
@@ -355,198 +355,198 @@ sal_Int32 SAL_CALL MacabDatabaseMetaData::getMaxSchemaNameLength(  ) throw(SQLEx
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsTransactions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::allProceduresAreCallable(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsStoredProcedures(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSelectForUpdate(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::allTablesAreSelectable(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::isReadOnly(  ) throw(SQLException, RuntimeException)
 {
     // for the moment, we have read-only addresses, but this might change in the future
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::usesLocalFiles(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::usesLocalFilePerTable(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsTypeConversion(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::nullPlusNonNullIsNull(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsColumnAliasing(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsTableCorrelationNames(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsConvert( sal_Int32, sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsExpressionsInOrderBy(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsGroupBy(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsGroupByBeyondSelect(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsGroupByUnrelated(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsMultipleTransactions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsMultipleResultSets(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsLikeEscapeClause(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsOrderByUnrelated(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsUnion(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsUnionAll(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsMixedCaseIdentifiers(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsMixedCaseQuotedIdentifiers(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::nullsAreSortedAtEnd(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::nullsAreSortedAtStart(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::nullsAreSortedHigh(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::nullsAreSortedLow(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSchemasInProcedureCalls(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSchemasInPrivilegeDefinitions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsCatalogsInProcedureCalls(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsCatalogsInPrivilegeDefinitions(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsCorrelatedSubqueries(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSubqueriesInComparisons(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSubqueriesInExists(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSubqueriesInIns(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsSubqueriesInQuantifieds(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsANSI92IntermediateSQL(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 OUString SAL_CALL MacabDatabaseMetaData::getURL(  ) throw(SQLException, RuntimeException)
@@ -648,27 +648,27 @@ OUString SAL_CALL MacabDatabaseMetaData::getNumericFunctions(  ) throw(SQLExcept
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsExtendedSQLGrammar(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsCoreSQLGrammar(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsMinimumSQLGrammar(  ) throw(SQLException, RuntimeException)
 {
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsFullOuterJoins(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsLimitedOuterJoins(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Int32 SAL_CALL MacabDatabaseMetaData::getMaxColumnsInGroupBy(  ) throw(SQLException, RuntimeException)
@@ -701,9 +701,9 @@ sal_Bool SAL_CALL MacabDatabaseMetaData::supportsResultSetType( sal_Int32 setTyp
     {
         case ResultSetType::FORWARD_ONLY:
         case ResultSetType::SCROLL_INSENSITIVE:
-            return sal_True;
+            return true;
     }
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsResultSetConcurrency( sal_Int32 setType, sal_Int32 ) throw(SQLException, RuntimeException)
@@ -712,59 +712,59 @@ sal_Bool SAL_CALL MacabDatabaseMetaData::supportsResultSetConcurrency( sal_Int32
     {
         case ResultSetType::FORWARD_ONLY:
         case ResultSetType::SCROLL_INSENSITIVE:
-            return sal_True;
+            return true;
     }
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::ownUpdatesAreVisible( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::ownDeletesAreVisible( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::ownInsertsAreVisible( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::othersUpdatesAreVisible( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::othersDeletesAreVisible( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::othersInsertsAreVisible( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::updatesAreDetected( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::deletesAreDetected( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::insertsAreDetected( sal_Int32 ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabDatabaseMetaData::supportsBatchUpdates(  ) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 Reference< XConnection > SAL_CALL MacabDatabaseMetaData::getConnection(  ) throw(SQLException, RuntimeException)
diff --git a/connectivity/source/drivers/macab/MacabDriver.cxx b/connectivity/source/drivers/macab/MacabDriver.cxx
index 57632e6..e4fc71d 100644
--- a/connectivity/source/drivers/macab/MacabDriver.cxx
+++ b/connectivity/source/drivers/macab/MacabDriver.cxx
@@ -273,7 +273,7 @@ sal_Bool SAL_CALL MacabDriver::acceptsURL( const OUString& url )
     ::osl::MutexGuard aGuard(m_aMutex);
 
     if ( !m_aImplModule.isMacOSPresent() )
-        return sal_False;
+        return false;
 
     // here we have to look whether we support this URL format
     return url == "sdbc:address:macab";
diff --git a/connectivity/source/drivers/macab/MacabResultSet.cxx b/connectivity/source/drivers/macab/MacabResultSet.cxx
index dd19ebb..a3c2a3b 100644
--- a/connectivity/source/drivers/macab/MacabResultSet.cxx
+++ b/connectivity/source/drivers/macab/MacabResultSet.cxx
@@ -236,7 +236,7 @@ sal_Bool SAL_CALL MacabResultSet::getBoolean(sal_Int32) throw(SQLException, Runt
 
 ::dbtools::throwFunctionNotSupportedSQLException("getBoolean", nullptr);
 
-    return sal_False;
+    return false;
 }
 
 sal_Int8 SAL_CALL MacabResultSet::getByte(sal_Int32) throw(SQLException, RuntimeException)
@@ -524,9 +524,9 @@ sal_Bool SAL_CALL MacabResultSet::isBeforeFirst() throw(SQLException, RuntimeExc
     checkDisposed(MacabResultSet_BASE::rBHelper.bDisposed);
 
     if (m_nRowPos == -1)
-        return sal_True;
+        return true;
 
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSet::isAfterLast() throw(SQLException, RuntimeException)
@@ -536,9 +536,9 @@ sal_Bool SAL_CALL MacabResultSet::isAfterLast() throw(SQLException, RuntimeExcep
 
     sal_Int32 nRecords = m_aMacabRecords->size();
     if (m_nRowPos == nRecords)
-        return sal_True;
+        return true;
 
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSet::isFirst() throw(SQLException, RuntimeException)
@@ -547,9 +547,9 @@ sal_Bool SAL_CALL MacabResultSet::isFirst() throw(SQLException, RuntimeException
     checkDisposed(MacabResultSet_BASE::rBHelper.bDisposed);
 
     if (m_nRowPos == 0)
-        return sal_True;
+        return true;
 
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSet::isLast() throw(SQLException, RuntimeException)
@@ -559,9 +559,9 @@ sal_Bool SAL_CALL MacabResultSet::isLast() throw(SQLException, RuntimeException)
 
     sal_Int32 nRecords = m_aMacabRecords->size();
     if (m_nRowPos == nRecords - 1)
-        return sal_True;
+        return true;
 
-    return sal_False;
+    return false;
 }
 
 void SAL_CALL MacabResultSet::beforeFirst() throw(SQLException, RuntimeException)
@@ -599,10 +599,10 @@ sal_Bool SAL_CALL MacabResultSet::first() throw(SQLException, RuntimeException)
 
     sal_Int32 nRecords = m_aMacabRecords->size();
     if (nRecords == 0)
-        return sal_False;
+        return false;
 
     m_nRowPos = 0;
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabResultSet::last() throw(SQLException, RuntimeException)
@@ -612,10 +612,10 @@ sal_Bool SAL_CALL MacabResultSet::last() throw(SQLException, RuntimeException)
 
     sal_Int32 nRecords = m_aMacabRecords->size();
     if (nRecords == 0)
-        return sal_False;
+        return false;
 
     m_nRowPos = nRecords - 1;
-    return sal_True;
+    return true;
 }
 
 sal_Int32 SAL_CALL MacabResultSet::getRow() throw(SQLException, RuntimeException)
@@ -634,10 +634,10 @@ sal_Bool SAL_CALL MacabResultSet::absolute(sal_Int32 row) throw(SQLException, Ru
     sal_Int32 nRecords = m_aMacabRecords->size();
     if (row <= -1 ||
         row >= nRecords)
-        return sal_False;
+        return false;
 
     m_nRowPos = row;
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabResultSet::relative(sal_Int32 row) throw(SQLException, RuntimeException)
@@ -678,7 +678,7 @@ sal_Bool SAL_CALL MacabResultSet::rowDeleted() throw(SQLException, RuntimeExcept
     ::osl::MutexGuard aGuard( m_aMutex );
     checkDisposed(MacabResultSet_BASE::rBHelper.bDisposed);
 
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSet::rowInserted() throw(SQLException, RuntimeException)
@@ -686,7 +686,7 @@ sal_Bool SAL_CALL MacabResultSet::rowInserted() throw(SQLException, RuntimeExcep
     ::osl::MutexGuard aGuard( m_aMutex );
     checkDisposed(MacabResultSet_BASE::rBHelper.bDisposed);
 
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSet::rowUpdated() throw(SQLException, RuntimeException)
@@ -694,7 +694,7 @@ sal_Bool SAL_CALL MacabResultSet::rowUpdated() throw(SQLException, RuntimeExcept
     ::osl::MutexGuard aGuard( m_aMutex );
     checkDisposed(MacabResultSet_BASE::rBHelper.bDisposed);
 
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSet::wasNull() throw(SQLException, RuntimeException)
@@ -911,12 +911,12 @@ sal_Bool SAL_CALL MacabResultSet::moveToBookmark(const  Any& bookmark) throw( SQ
                 if (sUniqueIdentifier == sBookmark)
                 {
                     m_nRowPos = nRow;
-                    return sal_True;
+                    return true;
                 }
             }
         }
     }
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSet::moveRelativeToBookmark(const  Any& bookmark, sal_Int32 rows) throw( SQLException,  RuntimeException)
@@ -933,11 +933,11 @@ sal_Bool SAL_CALL MacabResultSet::moveRelativeToBookmark(const  Any& bookmark, s
         m_nRowPos += rows;
 
         if (-1 < m_nRowPos && m_nRowPos < nRecords)
-            return sal_True;
+            return true;
     }
 
     m_nRowPos = nRowSave;
-    return sal_False;
+    return false;
 }
 
 sal_Int32 SAL_CALL MacabResultSet::compareBookmarks(const  Any& firstItem, const  Any& secondItem) throw( SQLException,  RuntimeException)
@@ -957,7 +957,7 @@ sal_Int32 SAL_CALL MacabResultSet::compareBookmarks(const  Any& firstItem, const
 
 sal_Bool SAL_CALL MacabResultSet::hasOrderedBookmarks() throw( SQLException,  RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Int32 SAL_CALL MacabResultSet::hashBookmark(const  Any& bookmark) throw( SQLException,  RuntimeException)
@@ -1030,7 +1030,7 @@ sal_Bool MacabResultSet::convertFastPropertyValue(
         default:
             ;
     }
-    return sal_False;
+    return false;
 }
 
 void MacabResultSet::setFastPropertyValue_NoBroadcast(
diff --git a/connectivity/source/drivers/macab/MacabResultSetMetaData.cxx b/connectivity/source/drivers/macab/MacabResultSetMetaData.cxx
index abcb0ce..6dfc2e1 100644
--- a/connectivity/source/drivers/macab/MacabResultSetMetaData.cxx
+++ b/connectivity/source/drivers/macab/MacabResultSetMetaData.cxx
@@ -109,7 +109,7 @@ sal_Int32 SAL_CALL MacabResultSetMetaData::getColumnCount() throw(SQLException,
 
 sal_Bool SAL_CALL MacabResultSetMetaData::isCaseSensitive(sal_Int32) throw(SQLException, RuntimeException)
 {
-    return sal_True;
+    return true;
 }
 
 OUString SAL_CALL MacabResultSetMetaData::getSchemaName(sal_Int32) throw(SQLException, RuntimeException)
@@ -164,17 +164,17 @@ OUString SAL_CALL MacabResultSetMetaData::getColumnServiceName(sal_Int32) throw(
 
 sal_Bool SAL_CALL MacabResultSetMetaData::isCurrency(sal_Int32) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSetMetaData::isAutoIncrement(sal_Int32) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSetMetaData::isSigned(sal_Int32) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Int32 SAL_CALL MacabResultSetMetaData::getPrecision(sal_Int32) throw(SQLException, RuntimeException)
@@ -189,27 +189,27 @@ sal_Int32 SAL_CALL MacabResultSetMetaData::getScale(sal_Int32) throw(::com::sun:
 
 sal_Int32 SAL_CALL MacabResultSetMetaData::isNullable(sal_Int32) throw(SQLException, RuntimeException)
 {
-    return (sal_Int32) sal_True;
+    return (sal_Int32) true;
 }
 
 sal_Bool SAL_CALL MacabResultSetMetaData::isSearchable(sal_Int32) throw(SQLException, RuntimeException)
 {
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabResultSetMetaData::isReadOnly(sal_Int32) throw(SQLException, RuntimeException)
 {
-    return sal_True;
+    return true;
 }
 
 sal_Bool SAL_CALL MacabResultSetMetaData::isDefinitelyWritable(sal_Int32) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 sal_Bool SAL_CALL MacabResultSetMetaData::isWritable(sal_Int32) throw(SQLException, RuntimeException)
 {
-    return sal_False;
+    return false;
 }
 
 
commit 178622f47cfaade04952d9c2e721deb605871cd2
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Apr 21 19:53:24 2016 +0200

    loplugin:salbool
    
    Change-Id: I14a902c644c467d8e02474e5d0ba8d3dced2860f

diff --git a/framework/source/dispatch/closedispatcher.cxx b/framework/source/dispatch/closedispatcher.cxx
index ae89180..a09018f 100644
--- a/framework/source/dispatch/closedispatcher.cxx
+++ b/framework/source/dispatch/closedispatcher.cxx
@@ -372,7 +372,7 @@ IMPL_LINK_NOARG_TYPED(CloseDispatcher, impl_asyncCallback, LinkParamNone*, void)
             if( xSet.is() )
             {
                 css::uno::Any aVal( xSet->getFastPropertyValue( 0 ) );
-                sal_Bool bState = sal_False;
+                sal_Bool bState = false;
                 if( aVal >>= bState )
                     bQuickstarterRunning = bState;
             }
commit 78526aebc83623297cb769de6618a4eddf6a93ee
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Apr 21 19:51:08 2016 +0200

    loplugin:salbool
    
    Change-Id: I4298f1da63d29133412962a9e4552a7ed473ad28

diff --git a/vcl/osx/printaccessoryview.mm b/vcl/osx/printaccessoryview.mm
index 8d2ef5b..db23d3c 100644
--- a/vcl/osx/printaccessoryview.mm
+++ b/vcl/osx/printaccessoryview.mm
@@ -1083,7 +1083,7 @@ static void addEdit( NSView* pCurParent, long& rCurX, long& rCurY, long nAttachO
             }
             else if( rEntry.Name.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("Enabled")) )
             {
-                sal_Bool bValue = sal_True;
+                sal_Bool bValue = true;
                 rEntry.Value >>= bValue;
                 bEnabled = bValue;
             }
@@ -1101,7 +1101,7 @@ static void addEdit( NSView* pCurParent, long& rCurX, long& rCurY, long nAttachO
             }
             else if( rEntry.Name.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("InternalUIOnly")) )
             {
-                sal_Bool bValue = sal_False;
+                sal_Bool bValue = false;
                 rEntry.Value >>= bValue;
                 bIgnore = bValue;
             }
@@ -1177,7 +1177,7 @@ static void addEdit( NSView* pCurParent, long& rCurX, long& rCurY, long nAttachO
             }
             else if( aCtrlType.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("Bool")) && pCurParent )
             {
-                sal_Bool bVal = sal_False;
+                sal_Bool bVal = false;
                 PropertyValue* pVal = pController->getValue( aPropertyName );
                 if( pVal )
                     pVal->Value >>= bVal;
commit 8a09cd241c30969d1b5e61c17f611ddc1c09591c
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Apr 21 19:17:09 2016 +0200

    loplugin:salbool
    
    Change-Id: I3a96fd12e6fa3a64bd1888373dfce0f8f621aad4

diff --git a/bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx b/bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx
index 3813d9b..82c42da 100644
--- a/bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx
@@ -315,8 +315,8 @@ typelib_TypeClass cpp_vtable_call(
                 // is SET method
                 typelib_MethodParameter aParam;
                 aParam.pTypeRef = pAttrTypeRef;
-                aParam.bIn      = sal_True;
-                aParam.bOut     = sal_False;
+                aParam.bIn      = true;
+                aParam.bOut     = false;
 
                 eRet = cpp2uno_call( pCppI, aMemberDescr.get(),
                         nullptr, // indicates void return
diff --git a/bridges/source/cpp_uno/gcc3_macosx_x86-64/uno2cpp.cxx b/bridges/source/cpp_uno/gcc3_macosx_x86-64/uno2cpp.cxx
index 718bac1..02cbeaa 100644
--- a/bridges/source/cpp_uno/gcc3_macosx_x86-64/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_macosx_x86-64/uno2cpp.cxx
@@ -356,8 +356,8 @@ void unoInterfaceProxyDispatch(
             typelib_MethodParameter aParam;
             aParam.pTypeRef =
                 reinterpret_cast<typelib_InterfaceAttributeTypeDescription const *>(pMemberDescr)->pAttributeTypeRef;
-            aParam.bIn      = sal_True;
-            aParam.bOut     = sal_False;
+            aParam.bIn      = true;
+            aParam.bOut     = false;
 
             typelib_TypeDescriptionReference * pReturnTypeRef = nullptr;
             OUString aVoidName("void");


More information about the Libreoffice-commits mailing list