[Libreoffice-commits] core.git: vcl/unx

Khaled Hosny khaledhosny at eglug.org
Mon Apr 25 16:05:01 UTC 2016


 vcl/unx/generic/glyphs/gcach_layout.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit a8d853fd9c1d84d63cf41b31ea548b6be8a621ec
Author: Khaled Hosny <khaledhosny at eglug.org>
Date:   Mon Apr 25 17:41:35 2016 +0200

    Update comment a bit
    
    Change-Id: Ib2b9ea1b6509a57c08c9205e5fab124524bc91ea

diff --git a/vcl/unx/generic/glyphs/gcach_layout.cxx b/vcl/unx/generic/glyphs/gcach_layout.cxx
index 6e22fd0..8394678 100644
--- a/vcl/unx/generic/glyphs/gcach_layout.cxx
+++ b/vcl/unx/generic/glyphs/gcach_layout.cxx
@@ -553,10 +553,12 @@ bool HbLayoutEngine::Layout(ServerFontLayout& rLayout, ImplLayoutArgs& rArgs)
                 // * If the font has no GDEF table, we just check if the glyph has
                 //   zero advance width, but this is stupid and can be wrong. A
                 //   better way would to check the character's Unicode combining
-                //   class, but unfortunately glyph gives combining marks the
+                //   class, but unfortunately HarfBuzz gives combining marks the
                 //   cluster value of its base character, so nCharPos will be
                 //   pointing to the wrong character (but HarfBuzz might change
                 //   this in the future).
+                //   Newer versions of HarfBuzz can control this behaviour with
+                //   hb_buffer_set_cluster_level().
                 bool bDiacritic = false;
                 if (hb_ot_layout_has_glyph_classes(mpHbFace))
                 {


More information about the Libreoffice-commits mailing list