[Libreoffice-commits] core.git: basctl/source basegfx/source basic/source
Noel Grandin
noel at peralex.com
Thu Aug 4 05:46:54 UTC 2016
basctl/source/basicide/baside2.cxx | 2 +-
basctl/source/basicide/baside2.hxx | 4 ++--
basctl/source/basicide/baside2b.cxx | 2 +-
basctl/source/basicide/basides1.cxx | 2 +-
basctl/source/basicide/basobj3.cxx | 2 +-
basctl/source/basicide/macrodlg.cxx | 2 +-
basctl/source/basicide/moduldlg.hxx | 2 +-
basctl/source/dlged/dlgedobj.cxx | 2 +-
basctl/source/inc/basidesh.hxx | 6 +++---
basctl/source/inc/bastypes.hxx | 12 ++++++------
basctl/source/inc/dlgedobj.hxx | 2 +-
basegfx/source/inc/stringconversiontools.hxx | 6 +++---
basegfx/source/tools/stringconversiontools.cxx | 2 +-
basic/source/classes/sbunoobj.cxx | 8 ++++----
basic/source/comp/dim.cxx | 4 ++--
basic/source/comp/parser.cxx | 2 +-
basic/source/inc/parser.hxx | 2 +-
basic/source/inc/runtime.hxx | 4 ++--
basic/source/inc/symtbl.hxx | 4 ++--
basic/source/runtime/runtime.cxx | 4 ++--
basic/source/sbx/sbxscan.cxx | 2 +-
21 files changed, 38 insertions(+), 38 deletions(-)
New commits:
commit e5e7475febbca460c30eaf4959d3282688383ef2
Author: Noel Grandin <noel at peralex.com>
Date: Tue Aug 2 14:56:27 2016 +0200
loplugin:countusersofdefaultparams in basctl..basic
Change-Id: I16fac3317ebf55581cb9aaef676a9759de51d695
Reviewed-on: https://gerrit.libreoffice.org/27793
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index 1a4ad3e..c994910 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -778,7 +778,7 @@ void ModulWindow::UpdateData()
sal_Int32 ModulWindow::countPages( Printer* pPrinter )
{
- return FormatAndPrint( pPrinter );
+ return FormatAndPrint( pPrinter, -1 );
}
void ModulWindow::printPage( sal_Int32 nPage, Printer* pPrinter )
diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx
index 23d8477..8a04886 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -246,7 +246,7 @@ public:
void AddWatch( const OUString& rVName );
void RemoveSelectedWatch();
- void UpdateWatches( bool bBasicStopped = false );
+ void UpdateWatches( bool bBasicStopped );
};
@@ -313,7 +313,7 @@ private:
static void GoOnTop();
- sal_Int32 FormatAndPrint( Printer* pPrinter, sal_Int32 nPage = -1 );
+ sal_Int32 FormatAndPrint( Printer* pPrinter, sal_Int32 nPage );
SbModuleRef const & XModule();
protected:
virtual void Resize() override;
diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx
index 8c86398..d16fb35 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -1744,7 +1744,7 @@ void WatchWindow::AddWatch( const OUString& rVName )
aTreeListBox->MakeVisible(pNewEntry);
aRemoveWatchButton->Enable();
- UpdateWatches();
+ UpdateWatches(false);
}
void WatchWindow::RemoveSelectedWatch()
diff --git a/basctl/source/basicide/basides1.cxx b/basctl/source/basicide/basides1.cxx
index 6819a7c..4546873 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -1081,7 +1081,7 @@ void Shell::ManageToolbars()
VclPtr<BaseWindow> Shell::FindApplicationWindow()
{
- return FindWindow( ScriptDocument::getApplicationScriptDocument() );
+ return FindWindow( ScriptDocument::getApplicationScriptDocument(), "", "", TYPE_UNKNOWN );
}
VclPtr<BaseWindow> Shell::FindWindow(
diff --git a/basctl/source/basicide/basobj3.cxx b/basctl/source/basicide/basobj3.cxx
index 70b85e4..360b72f 100644
--- a/basctl/source/basicide/basobj3.cxx
+++ b/basctl/source/basicide/basobj3.cxx
@@ -254,7 +254,7 @@ void MarkDocumentModified( const ScriptDocument& rDocument )
{
if (Shell* pShell = GetShell())
{
- pShell->SetAppBasicModified();
+ pShell->SetAppBasicModified(true);
pShell->UpdateObjectCatalog();
}
}
diff --git a/basctl/source/basicide/macrodlg.cxx b/basctl/source/basicide/macrodlg.cxx
index c10aab9..aed300e 100644
--- a/basctl/source/basicide/macrodlg.cxx
+++ b/basctl/source/basicide/macrodlg.cxx
@@ -366,7 +366,7 @@ SbMethod* MacroChooser::CreateMacro()
if ( !pModule )
{
pModule = createModImpl( static_cast<vcl::Window*>( this ),
- aDocument, *m_pBasicBox, aLibName, aModName );
+ aDocument, *m_pBasicBox, aLibName, aModName, false );
}
OUString aSubName = m_pMacroNameEdit->GetText();
diff --git a/basctl/source/basicide/moduldlg.hxx b/basctl/source/basicide/moduldlg.hxx
index d3cc32b..238bcaa 100644
--- a/basctl/source/basicide/moduldlg.hxx
+++ b/basctl/source/basicide/moduldlg.hxx
@@ -262,7 +262,7 @@ public:
// Helper functions
SbModule* createModImpl( vcl::Window* pWin, const ScriptDocument& rDocument,
- TreeListBox& rBasicBox, const OUString& rLibName, const OUString& aModName, bool bMain = false );
+ TreeListBox& rBasicBox, const OUString& rLibName, const OUString& aModName, bool bMain );
void createLibImpl( vcl::Window* pWin, const ScriptDocument& rDocument,
CheckBox* pLibBox, TreeListBox* pBasicBox );
diff --git a/basctl/source/dlged/dlgedobj.cxx b/basctl/source/dlged/dlgedobj.cxx
index 33c7f8e..0f8edbe 100644
--- a/basctl/source/dlged/dlgedobj.cxx
+++ b/basctl/source/dlged/dlgedobj.cxx
@@ -79,7 +79,7 @@ DlgEdObj::DlgEdObj(const OUString& rModelName,
DlgEdObj::~DlgEdObj()
{
if ( isListening() )
- EndListening();
+ EndListening(true);
}
void DlgEdObj::SetPage(SdrPage* _pNewPage)
diff --git a/basctl/source/inc/basidesh.hxx b/basctl/source/inc/basidesh.hxx
index ee3c30f..43bbd94 100644
--- a/basctl/source/inc/basidesh.hxx
+++ b/basctl/source/inc/basidesh.hxx
@@ -185,14 +185,14 @@ public:
bool CallBasicErrorHdl( StarBASIC* pBasic );
long CallBasicBreakHdl( StarBASIC* pBasic );
- VclPtr<BaseWindow> FindWindow( const ScriptDocument& rDocument, const OUString& rLibName = OUString(), const OUString& rName = OUString(), ItemType nType = TYPE_UNKNOWN, bool bFindSuspended = false );
+ VclPtr<BaseWindow> FindWindow( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rName, ItemType nType, bool bFindSuspended = false );
VclPtr<DialogWindow> FindDlgWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rName, bool bCreateIfNotExist = false, bool bFindSuspended = false );
VclPtr<ModulWindow> FindBasWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rModName, bool bCreateIfNotExist = false, bool bFindSuspended = false );
VclPtr<BaseWindow> FindApplicationWindow();
- bool NextPage( bool bPrev = false );
+ bool NextPage( bool bPrev );
bool IsAppBasicModified () const { return m_bAppBasicModified; }
- void SetAppBasicModified (bool bModified = true) { m_bAppBasicModified = bModified; }
+ void SetAppBasicModified (bool bModified) { m_bAppBasicModified = bModified; }
// For Dialog Drag&Drop in Dialog Organizer:
// (defined in moduldlg.cxx)
diff --git a/basctl/source/inc/bastypes.hxx b/basctl/source/inc/bastypes.hxx
index 9f1c0fa..98cc417 100644
--- a/basctl/source/inc/bastypes.hxx
+++ b/basctl/source/inc/bastypes.hxx
@@ -286,15 +286,15 @@ private:
Map m_aMap;
};
-void CutLines( OUString& rStr, sal_Int32 nStartLine, sal_Int32 nLines, bool bEraseTrailingEmptyLines = false );
+void CutLines( OUString& rStr, sal_Int32 nStartLine, sal_Int32 nLines, bool bEraseTrailingEmptyLines );
OUString CreateMgrAndLibStr( const OUString& rMgrName, const OUString& rLibName );
sal_uLong CalcLineCount( SvStream& rStream );
-bool QueryReplaceMacro( const OUString& rName, vcl::Window* pParent = nullptr );
-bool QueryDelMacro( const OUString& rName, vcl::Window* pParent = nullptr );
-bool QueryDelDialog( const OUString& rName, vcl::Window* pParent = nullptr );
-bool QueryDelModule( const OUString& rName, vcl::Window* pParent = nullptr );
-bool QueryDelLib( const OUString& rName, bool bRef = false, vcl::Window* pParent = nullptr );
+bool QueryReplaceMacro( const OUString& rName, vcl::Window* pParent );
+bool QueryDelMacro( const OUString& rName, vcl::Window* pParent );
+bool QueryDelDialog( const OUString& rName, vcl::Window* pParent );
+bool QueryDelModule( const OUString& rName, vcl::Window* pParent );
+bool QueryDelLib( const OUString& rName, bool bRef, vcl::Window* pParent );
bool QueryPassword( const css::uno::Reference< css::script::XLibraryContainer >& xLibContainer, const OUString& rLibName, OUString& rPassword, bool bRepeat = false, bool bNewTitle = false );
class ModuleInfoHelper
diff --git a/basctl/source/inc/dlgedobj.hxx b/basctl/source/inc/dlgedobj.hxx
index 7d4addf..2fe4ca0 100644
--- a/basctl/source/inc/dlgedobj.hxx
+++ b/basctl/source/inc/dlgedobj.hxx
@@ -69,7 +69,7 @@ protected:
using SfxListener::StartListening;
void StartListening();
using SfxListener::EndListening;
- void EndListening(bool bRemoveListener = true);
+ void EndListening(bool bRemoveListener);
bool isListening() const { return bIsListening; }
bool TransformSdrToControlCoordinates(
diff --git a/basegfx/source/inc/stringconversiontools.hxx b/basegfx/source/inc/stringconversiontools.hxx
index c23fb50..519bc2c 100644
--- a/basegfx/source/inc/stringconversiontools.hxx
+++ b/basegfx/source/inc/stringconversiontools.hxx
@@ -36,8 +36,8 @@ namespace basegfx
const sal_Int32 nLen);
inline bool isOnNumberChar(const sal_Unicode aChar,
- bool bSignAllowed = true,
- bool bDotAllowed = true)
+ bool bSignAllowed,
+ bool bDotAllowed)
{
const bool bPredicate( (sal_Unicode('0') <= aChar && sal_Unicode('9') >= aChar)
|| (bSignAllowed && sal_Unicode('+') == aChar)
@@ -51,7 +51,7 @@ namespace basegfx
const sal_Int32 nPos,
bool bSignAllowed = true)
{
- return isOnNumberChar(rStr[nPos], bSignAllowed);
+ return isOnNumberChar(rStr[nPos], bSignAllowed, true);
}
bool getDoubleChar(double& o_fRetval,
diff --git a/basegfx/source/tools/stringconversiontools.cxx b/basegfx/source/tools/stringconversiontools.cxx
index 8ea8624..6cae400 100644
--- a/basegfx/source/tools/stringconversiontools.cxx
+++ b/basegfx/source/tools/stringconversiontools.cxx
@@ -170,7 +170,7 @@ namespace basegfx
const sal_Int32 aLen( rStr.getLength() );
if(aLen)
{
- if( isOnNumberChar(rStr[aLen - 1], false) &&
+ if( isOnNumberChar(rStr[aLen - 1], false, true) &&
fValue >= 0.0 )
{
rStr.append( ' ' );
diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx
index 10e96e6..3137561 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -523,7 +523,7 @@ SbxDataType unoToSbxType( const Reference< XIdlClass >& xIdlClass )
return eRetType;
}
-static void implSequenceToMultiDimArray( SbxDimArray*& pArray, Sequence< sal_Int32 >& indices, Sequence< sal_Int32 >& sizes, const Any& aValue, sal_Int32& dimension, bool bIsZeroIndex, Type* pType = nullptr )
+static void implSequenceToMultiDimArray( SbxDimArray*& pArray, Sequence< sal_Int32 >& indices, Sequence< sal_Int32 >& sizes, const Any& aValue, sal_Int32& dimension, bool bIsZeroIndex, Type* pType )
{
const Type& aType = aValue.getValueType();
TypeClass eTypeClass = aType.getTypeClass();
@@ -651,7 +651,7 @@ void unoToSbxValue( SbxVariable* pVar, const Any& aValue )
Sequence< sal_Int32 > indices;
Sequence< sal_Int32 > sizes;
sal_Int32 dimension = 0;
- implSequenceToMultiDimArray( pArray, indices, sizes, aWrap.Array, dimension, aWrap.IsZeroIndex );
+ implSequenceToMultiDimArray( pArray, indices, sizes, aWrap.Array, dimension, aWrap.IsZeroIndex, nullptr );
if ( pArray )
{
SbxDimArrayRef xArray = pArray;
@@ -1514,7 +1514,7 @@ enum INVOKETYPE
SetProp,
Func
};
-Any invokeAutomationMethod( const OUString& Name, Sequence< Any >& args, SbxArray* pParams, sal_uInt32 nParamCount, Reference< XInvocation >& rxInvocation, INVOKETYPE invokeType = Func )
+Any invokeAutomationMethod( const OUString& Name, Sequence< Any >& args, SbxArray* pParams, sal_uInt32 nParamCount, Reference< XInvocation >& rxInvocation, INVOKETYPE invokeType )
{
Sequence< sal_Int16 > OutParamIndex;
Sequence< Any > OutParam;
@@ -2274,7 +2274,7 @@ void SbUnoObject::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
}
else if( bInvocation && mxInvocation.is() )
{
- Any aRetAny = invokeAutomationMethod( pMeth->GetName(), args, pParams, nParamCount, mxInvocation );
+ Any aRetAny = invokeAutomationMethod( pMeth->GetName(), args, pParams, nParamCount, mxInvocation, Func );
unoToSbxValue( pVar, aRetAny );
}
diff --git a/basic/source/comp/dim.cxx b/basic/source/comp/dim.cxx
index e6c6b93..2bdf696 100644
--- a/basic/source/comp/dim.cxx
+++ b/basic/source/comp/dim.cxx
@@ -833,7 +833,7 @@ SbiProcDef* SbiParser::ProcDecl( bool bDecl )
pDef->SetType( eType );
if( Peek() == CDECL_ )
{
- Next(); pDef->SetCdecl();
+ Next(); pDef->SetCdecl(true);
}
if( Peek() == LIB )
{
@@ -939,7 +939,7 @@ SbiProcDef* SbiParser::ProcDecl( bool bDecl )
}
if( bByVal )
{
- pPar->SetByVal();
+ pPar->SetByVal(true);
}
if( bOptional )
{
diff --git a/basic/source/comp/parser.cxx b/basic/source/comp/parser.cxx
index e413c11..c246361 100644
--- a/basic/source/comp/parser.cxx
+++ b/basic/source/comp/parser.cxx
@@ -401,7 +401,7 @@ bool SbiParser::Parse()
Next();
Push( eCurTok );
aGen.Statement();
- Symbol();
+ Symbol(nullptr);
}
}
else
diff --git a/basic/source/inc/parser.hxx b/basic/source/inc/parser.hxx
index b2a44db..2225cbc 100644
--- a/basic/source/inc/parser.hxx
+++ b/basic/source/inc/parser.hxx
@@ -96,7 +96,7 @@ public:
bool TestComma();
void TestEoln();
- void Symbol( const KeywordSymbolInfo* pKeywordSymbolInfo = nullptr ); // let or call
+ void Symbol( const KeywordSymbolInfo* pKeywordSymbolInfo ); // let or call
void ErrorStmnt(); // ERROR n
void BadBlock(); // LOOP/WEND/NEXT
void NoIf(); // ELSE/ELSE IF without IF
diff --git a/basic/source/inc/runtime.hxx b/basic/source/inc/runtime.hxx
index d7ce4a3..78b39a8 100644
--- a/basic/source/inc/runtime.hxx
+++ b/basic/source/inc/runtime.hxx
@@ -297,7 +297,7 @@ class SbiRuntime
static bool implIsClass( SbxObject* pObj, const OUString& aClass );
- void StepSETCLASS_impl( sal_uInt32 nOp1, bool bHandleDflt = false );
+ void StepSETCLASS_impl( sal_uInt32 nOp1, bool bHandleDflt );
// the following routines are called by the single
// stepper and implement the single opcodes
@@ -327,7 +327,7 @@ class SbiRuntime
void StepGOSUB( sal_uInt32 ), StepRETURN( sal_uInt32 );
void StepTESTFOR( sal_uInt32 ), StepCASETO( sal_uInt32 ), StepERRHDL( sal_uInt32 );
void StepRESUME( sal_uInt32 ), StepSETCLASS( sal_uInt32 ), StepVBASETCLASS( sal_uInt32 ), StepTESTCLASS( sal_uInt32 ), StepLIB( sal_uInt32 );
- bool checkClass_Impl( const SbxVariableRef& refVal, const OUString& aClass, bool bRaiseErrors, bool bDefault = true );
+ bool checkClass_Impl( const SbxVariableRef& refVal, const OUString& aClass, bool bRaiseErrors, bool bDefault );
void StepCLOSE( sal_uInt32 ), StepPRCHAR( sal_uInt32 ), StepARGTYP( sal_uInt32 );
// all opcodes with two operands
void StepRTL( sal_uInt32, sal_uInt32 ), StepPUBLIC( sal_uInt32, sal_uInt32 ), StepPUBLIC_P( sal_uInt32, sal_uInt32 );
diff --git a/basic/source/inc/symtbl.hxx b/basic/source/inc/symtbl.hxx
index cc30090..e51a846 100644
--- a/basic/source/inc/symtbl.hxx
+++ b/basic/source/inc/symtbl.hxx
@@ -132,7 +132,7 @@ public:
void SetParamArray() { bParamArray = true; }
void SetWithEvents() { bWithEvents = true; }
void SetWithBrackets(){ bWithBrackets = true; }
- void SetByVal( bool bByVal_ = true ) { bByVal = bByVal_; }
+ void SetByVal( bool bByVal_ ) { bByVal = bByVal_; }
void SetStatic( bool bAsStatic = true ) { bStatic = bAsStatic; }
void SetNew() { bNew = true; }
void SetDefinedAs() { bAs = true; }
@@ -183,7 +183,7 @@ public:
OUString& GetAlias() { return aAlias; }
void SetPublic( bool b ) { bPublic = b; }
bool IsPublic() const { return bPublic; }
- void SetCdecl( bool b = true) { bCdecl = b; }
+ void SetCdecl( bool b ) { bCdecl = b; }
bool IsCdecl() const { return bCdecl; }
bool IsUsedForProcDecl() const { return mbProcDecl; }
void SetLine1( sal_uInt16 n ) { nLine1 = n; }
diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx
index c9559c5..5978764 100644
--- a/basic/source/runtime/runtime.cxx
+++ b/basic/source/runtime/runtime.cxx
@@ -3254,7 +3254,7 @@ void SbiRuntime::StepSETCLASS_impl( sal_uInt32 nOp1, bool bHandleDflt )
SbxVariableRef refVar = PopVar();
OUString aClass( pImg->GetString( static_cast<short>( nOp1 ) ) );
- bool bOk = checkClass_Impl( refVal, aClass, true );
+ bool bOk = checkClass_Impl( refVal, aClass, true, true );
if( bOk )
{
StepSET_Impl( refVal, refVar, bHandleDflt ); // don't do handle default prop for a "proper" set
@@ -3263,7 +3263,7 @@ void SbiRuntime::StepSETCLASS_impl( sal_uInt32 nOp1, bool bHandleDflt )
void SbiRuntime::StepVBASETCLASS( sal_uInt32 nOp1 )
{
- StepSETCLASS_impl( nOp1 );
+ StepSETCLASS_impl( nOp1, false );
}
void SbiRuntime::StepSETCLASS( sal_uInt32 nOp1 )
diff --git a/basic/source/sbx/sbxscan.cxx b/basic/source/sbx/sbxscan.cxx
index 05a4eae..cc864ec 100644
--- a/basic/source/sbx/sbxscan.cxx
+++ b/basic/source/sbx/sbxscan.cxx
@@ -316,7 +316,7 @@ static const double roundArray[] = {
***************************************************************************/
static void myftoa( double nNum, char * pBuf, short nPrec, short nExpWidth,
- bool bPt, bool bFix, sal_Unicode cForceThousandSep = 0 )
+ bool bPt, bool bFix, sal_Unicode cForceThousandSep )
{
short nExp = 0;
More information about the Libreoffice-commits
mailing list