[Libreoffice-commits] core.git: cui/source

Arnold Dumas arnold at dumas.at
Sun Aug 7 06:38:09 UTC 2016


 cui/source/options/sdbcdriverenum.cxx |    1 -
 cui/source/options/sdbcdriverenum.hxx |    3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f4d0818cd21f66b0d7f36f820fcf1b72e506e026
Author: Arnold Dumas <arnold at dumas.at>
Date:   Fri Aug 5 07:48:51 2016 +0200

    tdf#89329: use unique_ptr for pImpl in sdbcdriverenum
    
    Change-Id: Ie0bdc9693d2bade872ee3ac8d4cf6fd5c469493d
    Reviewed-on: https://gerrit.libreoffice.org/27891
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
    Tested-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/cui/source/options/sdbcdriverenum.cxx b/cui/source/options/sdbcdriverenum.cxx
index ba0ade2..6bf3254 100644
--- a/cui/source/options/sdbcdriverenum.cxx
+++ b/cui/source/options/sdbcdriverenum.cxx
@@ -79,7 +79,6 @@ namespace offapp
 
     ODriverEnumeration::~ODriverEnumeration() throw()
     {
-        delete m_pImpl;
     }
 
 
diff --git a/cui/source/options/sdbcdriverenum.hxx b/cui/source/options/sdbcdriverenum.hxx
index 5d75b2a..80f0b32 100644
--- a/cui/source/options/sdbcdriverenum.hxx
+++ b/cui/source/options/sdbcdriverenum.hxx
@@ -25,6 +25,7 @@
 #include <rtl/ustring.hxx>
 
 #include <vector>
+#include <memory>
 
 
 namespace offapp
@@ -39,7 +40,7 @@ namespace offapp
     class ODriverEnumeration
     {
     private:
-        ODriverEnumerationImpl* m_pImpl;
+        std::unique_ptr<ODriverEnumerationImpl> m_pImpl;
 
     public:
         ODriverEnumeration() throw();


More information about the Libreoffice-commits mailing list