[Libreoffice-commits] core.git: sfx2/source

Thorsten Behrens Thorsten.Behrens at CIB.de
Tue Aug 9 10:49:50 UTC 2016


 sfx2/source/appl/workwin.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit a53ea24f9a3e31669f83ff76cdddfec9aec90389
Author: Thorsten Behrens <Thorsten.Behrens at CIB.de>
Date:   Tue Aug 9 12:47:51 2016 +0200

    sfx2: add comment to avoid range-based for loop
    
    Change-Id: I7bdbe6eec52bdf76e1b93729e73d10b8be974fcc

diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx
index ec9cda9..7a93679 100644
--- a/sfx2/source/appl/workwin.cxx
+++ b/sfx2/source/appl/workwin.cxx
@@ -1290,9 +1290,11 @@ void SfxWorkWindow::UpdateObjectBars_Impl()
 
 void SfxWorkWindow::UpdateChildWindows_Impl()
 {
-    // any current or in the context available Childwindows
+    // tdf#100870, tdf#101320: don't use range-based for loop when
+    // container is modified
     for ( size_t n=0; n<aChildWins.size(); n++ )
     {
+        // any current or in the context available Childwindows
         SfxChildWin_Impl *pCW = aChildWins[n];
         SfxChildWindow *pChildWin = pCW->pWin;
         bool bCreate = false;


More information about the Libreoffice-commits mailing list