[Libreoffice-commits] core.git: svl/source svtools/source svx/inc svx/source ucb/source unodevtools/source
Noel Grandin
noel at peralex.com
Thu Aug 11 06:05:29 UTC 2016
svl/source/items/stylepool.cxx | 4 ++--
svl/source/numbers/zforfind.hxx | 12 ++++++------
svtools/source/contnr/contentenumeration.hxx | 2 +-
svtools/source/contnr/fileview.cxx | 2 +-
svtools/source/contnr/imivctl.hxx | 16 ++++++++--------
svtools/source/control/roadmap.cxx | 2 +-
svtools/source/uno/treecontrolpeer.cxx | 2 +-
svx/inc/galbrws2.hxx | 2 +-
svx/inc/sdr/overlay/overlaymanagerbuffered.hxx | 4 ++--
svx/inc/svdibrow.hxx | 2 +-
svx/source/accessibility/ChildrenManagerImpl.hxx | 2 +-
svx/source/dialog/contimp.hxx | 4 ++--
svx/source/dialog/framelink.cxx | 2 +-
svx/source/fmcomp/fmgridcl.cxx | 2 +-
svx/source/form/fmvwimp.cxx | 2 +-
svx/source/inc/filtnav.hxx | 4 ++--
svx/source/inc/fmshimp.hxx | 2 +-
svx/source/inc/gridcell.hxx | 2 +-
svx/source/svdraw/svdfmtf.hxx | 2 +-
svx/source/svdraw/svdhdl.cxx | 2 +-
svx/source/tbxctrls/tbunosearchcontrollers.cxx | 2 +-
ucb/source/ucp/file/shell.hxx | 2 +-
unodevtools/source/skeletonmaker/skeletoncpp.hxx | 4 ++--
unodevtools/source/skeletonmaker/skeletonjava.hxx | 2 +-
24 files changed, 41 insertions(+), 41 deletions(-)
New commits:
commit b796b24793827583550279d40bfe565c66ad284d
Author: Noel Grandin <noel at peralex.com>
Date: Wed Aug 10 13:44:57 2016 +0200
loplugin:countusersofdefaultparams in svl..unodevtools
Change-Id: Ie3d2cf29e99b8a51b80246aafa23a92e6c3404b2
Reviewed-on: https://gerrit.libreoffice.org/28017
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
diff --git a/svl/source/items/stylepool.cxx b/svl/source/items/stylepool.cxx
index 8ac1e4f..347334a 100644
--- a/svl/source/items/stylepool.cxx
+++ b/svl/source/items/stylepool.cxx
@@ -371,8 +371,8 @@ public:
std::shared_ptr<SfxItemSet> insertItemSet( const SfxItemSet& rSet );
// #i86923#
- IStylePoolIteratorAccess* createIterator( bool bSkipUnusedItemSets = false,
- bool bSkipIgnorableItems = false );
+ IStylePoolIteratorAccess* createIterator( bool bSkipUnusedItemSets,
+ bool bSkipIgnorableItems );
};
std::shared_ptr<SfxItemSet> StylePoolImpl::insertItemSet( const SfxItemSet& rSet )
diff --git a/svl/source/numbers/zforfind.hxx b/svl/source/numbers/zforfind.hxx
index ba24b87..e7b7a60 100644
--- a/svl/source/numbers/zforfind.hxx
+++ b/svl/source/numbers/zforfind.hxx
@@ -294,7 +294,7 @@ private:
// Get currency symbol and advance string position
bool GetCurrency( const OUString& rString,
sal_Int32& nPos,
- const SvNumberformat* pFormat = nullptr ); // optional number format to match against
+ const SvNumberformat* pFormat ); // optional number format to match against
// Get symbol AM or PM and advance string position
bool GetTimeAmPm( const OUString& rString,
@@ -335,21 +335,21 @@ private:
// Conversion of date to number
bool GetDateRef( double& fDays, // OUT: days diff to null date
sal_uInt16& nCounter, // Count of date substrings
- const SvNumberformat* pFormat = nullptr ); // optional number format to match against
+ const SvNumberformat* pFormat ); // optional number format to match against
// Analyze start of string
bool ScanStartString( const OUString& rString,
- const SvNumberformat* pFormat = nullptr );
+ const SvNumberformat* pFormat );
// Analyze middle substring
bool ScanMidString( const OUString& rString,
sal_uInt16 nStringPos,
- const SvNumberformat* pFormat = nullptr );
+ const SvNumberformat* pFormat );
// Analyze end of string
bool ScanEndString( const OUString& rString,
- const SvNumberformat* pFormat = nullptr );
+ const SvNumberformat* pFormat );
// Compare rString to substring of array indexed by nString
// nString == 0xFFFF => last substring
@@ -369,7 +369,7 @@ private:
// Main analyzing function
bool IsNumberFormatMain( const OUString& rString,
- const SvNumberformat* pFormat = nullptr); // optional number format to match against
+ const SvNumberformat* pFormat); // optional number format to match against
static inline bool MyIsdigit( sal_Unicode c );
diff --git a/svtools/source/contnr/contentenumeration.hxx b/svtools/source/contnr/contentenumeration.hxx
index c287f3a..13dd8d8 100644
--- a/svtools/source/contnr/contentenumeration.hxx
+++ b/svtools/source/contnr/contentenumeration.hxx
@@ -235,7 +235,7 @@ namespace svt
*/
EnumerationResult enumerateFolderContentSync(
const FolderDescriptor& _rFolder,
- const css::uno::Sequence< OUString >& rBlackList = css::uno::Sequence< OUString >()
+ const css::uno::Sequence< OUString >& rBlackList
);
/** cancels the running operation.
diff --git a/svtools/source/contnr/fileview.cxx b/svtools/source/contnr/fileview.cxx
index 4f05be0..30e13de 100644
--- a/svtools/source/contnr/fileview.cxx
+++ b/svtools/source/contnr/fileview.cxx
@@ -362,7 +362,7 @@ public:
FileViewResult GetFolderContent_Impl(
const OUString& rFolder,
const FileViewAsyncAction* pAsyncDescriptor,
- const css::uno::Sequence< OUString >& rBlackList = css::uno::Sequence< OUString >() );
+ const css::uno::Sequence< OUString >& rBlackList );
FileViewResult GetFolderContent_Impl(
const FolderDescriptor& _rFolder,
diff --git a/svtools/source/contnr/imivctl.hxx b/svtools/source/contnr/imivctl.hxx
index af0f2d9..a46b679 100644
--- a/svtools/source/contnr/imivctl.hxx
+++ b/svtools/source/contnr/imivctl.hxx
@@ -212,7 +212,7 @@ class SvxIconChoiceCtrl_Impl
void ShowCursor( bool bShow );
- void ImpArrange( bool bKeepPredecessors = false );
+ void ImpArrange( bool bKeepPredecessors );
void AdjustVirtSize( const Rectangle& );
void ResetVirtSize();
void CheckScrollBars();
@@ -252,14 +252,14 @@ class SvxIconChoiceCtrl_Impl
void SelectRect(
SvxIconChoiceCtrlEntry* pEntry1,
SvxIconChoiceCtrlEntry* pEntry2,
- bool bAdd = true,
- std::vector<Rectangle*>* pOtherRects = nullptr
+ bool bAdd,
+ std::vector<Rectangle*>* pOtherRects
);
void SelectRange(
SvxIconChoiceCtrlEntry* pStart,
SvxIconChoiceCtrlEntry* pEnd,
- bool bAdd = true
+ bool bAdd
);
void AddSelectedRect( const Rectangle& );
@@ -328,7 +328,7 @@ public:
void SetStyle( WinBits nWinStyle );
WinBits GetStyle() const { return nWinBits; }
void InsertEntry( SvxIconChoiceCtrlEntry*, size_t nPos );
- void CreateAutoMnemonics( MnemonicGenerator* _pGenerator = nullptr );
+ void CreateAutoMnemonics( MnemonicGenerator* _pGenerator );
void FontModified();
void SelectAll();
void SelectEntry(
@@ -433,8 +433,8 @@ public:
void SelectRect(
const Rectangle&,
- bool bAdd = true,
- std::vector<Rectangle*>* pOtherRects = nullptr
+ bool bAdd,
+ std::vector<Rectangle*>* pOtherRects
);
bool IsTextHit( SvxIconChoiceCtrlEntry* pEntry, const Point& rDocPos );
@@ -447,7 +447,7 @@ public:
#ifdef DBG_UTIL
void SetEntryTextMode(
SvxIconChoiceCtrlTextMode,
- SvxIconChoiceCtrlEntry* pEntry = nullptr
+ SvxIconChoiceCtrlEntry* pEntry
);
#endif
bool IsEntryEditingEnabled() const { return bEntryEditingEnabled; }
diff --git a/svtools/source/control/roadmap.cxx b/svtools/source/control/roadmap.cxx
index 9799414..2503ff4 100644
--- a/svtools/source/control/roadmap.cxx
+++ b/svtools/source/control/roadmap.cxx
@@ -69,7 +69,7 @@ public:
void SetInteractive( bool _bInteractive );
void SetClickHdl( const Link<HyperLabel*,void>& rLink );
- void Enable( bool bEnable = true);
+ void Enable( bool bEnable );
bool IsEnabled() const;
void GrabFocus();
diff --git a/svtools/source/uno/treecontrolpeer.cxx b/svtools/source/uno/treecontrolpeer.cxx
index bf334fa..053018c 100644
--- a/svtools/source/uno/treecontrolpeer.cxx
+++ b/svtools/source/uno/treecontrolpeer.cxx
@@ -87,7 +87,7 @@ public:
virtual ~UnoTreeListBoxImpl();
virtual void dispose() override;
- void insert( SvTreeListEntry* pEntry,SvTreeListEntry* pParent,sal_uLong nPos=TREELIST_APPEND );
+ void insert( SvTreeListEntry* pEntry, SvTreeListEntry* pParent, sal_uLong nPos );
virtual void RequestingChildren( SvTreeListEntry* pParent ) override;
diff --git a/svx/inc/galbrws2.hxx b/svx/inc/galbrws2.hxx
index d2dc8f0..a042ff7 100644
--- a/svx/inc/galbrws2.hxx
+++ b/svx/inc/galbrws2.hxx
@@ -161,7 +161,7 @@ public:
sal_Int8 ExecuteDrop( DropTargetHelper& rTarget, const ExecuteDropEvent& rEvt );
void StartDrag( vcl::Window* pWindow, const Point* pDragPoint = nullptr );
void TogglePreview( vcl::Window* pWindow, const Point* pPreviewPoint = nullptr );
- void ShowContextMenu( vcl::Window* pWindow, const Point* pContextPoint = nullptr );
+ void ShowContextMenu( vcl::Window* pWindow, const Point* pContextPoint );
bool KeyInput( const KeyEvent& rEvt, vcl::Window* pWindow );
static css::uno::Reference< css::frame::XFrame > GetFrame();
diff --git a/svx/inc/sdr/overlay/overlaymanagerbuffered.hxx b/svx/inc/sdr/overlay/overlaymanagerbuffered.hxx
index 8257419..3ef4a6e 100644
--- a/svx/inc/sdr/overlay/overlaymanagerbuffered.hxx
+++ b/svx/inc/sdr/overlay/overlaymanagerbuffered.hxx
@@ -59,7 +59,7 @@ namespace sdr
void ImpPrepareBufferDevice();
void ImpRestoreBackground() const ;
void ImpRestoreBackground(const vcl::Region& rRegionPixel) const;
- void ImpSaveBackground(const vcl::Region& rRegion, OutputDevice* pPreRenderDevice = nullptr);
+ void ImpSaveBackground(const vcl::Region& rRegion, OutputDevice* pPreRenderDevice);
OverlayManagerBuffered(
OutputDevice& rOutputDevice,
@@ -68,7 +68,7 @@ namespace sdr
public:
static rtl::Reference<OverlayManager> create(OutputDevice& rOutputDevice,
- bool bRefreshWithPreRendering = false);
+ bool bRefreshWithPreRendering);
// complete redraw
virtual void completeRedraw(const vcl::Region& rRegion, OutputDevice* pPreRenderDevice = nullptr) const override;
diff --git a/svx/inc/svdibrow.hxx b/svx/inc/svdibrow.hxx
index 5e16c69..11bd21a 100644
--- a/svx/inc/svdibrow.hxx
+++ b/svx/inc/svdibrow.hxx
@@ -73,7 +73,7 @@ public:
virtual ~SdrItemBrowserControl();
virtual void dispose() override;
void Clear();
- void SetAttributes(const SfxItemSet* pAttr, const SfxItemSet* p2ndSet=nullptr);
+ void SetAttributes(const SfxItemSet* pAttr, const SfxItemSet* p2ndSet);
sal_uInt16 GetCurrentWhich() const;
void EndChangeEntry();
void BreakChangeEntry();
diff --git a/svx/source/accessibility/ChildrenManagerImpl.hxx b/svx/source/accessibility/ChildrenManagerImpl.hxx
index 35f61fd..eadec9b 100644
--- a/svx/source/accessibility/ChildrenManagerImpl.hxx
+++ b/svx/source/accessibility/ChildrenManagerImpl.hxx
@@ -181,7 +181,7 @@ public:
before this method returns and events are sent to inform the
listeners of the new object.
*/
- void Update (bool bCreateNewObjectsOnDemand = true);
+ void Update (bool bCreateNewObjectsOnDemand);
/** Set the list of UNO shapes to the given list. This removes the old
list and does not add to it. The list of accessible shapes that is
diff --git a/svx/source/dialog/contimp.hxx b/svx/source/dialog/contimp.hxx
index a27b145..cddb4e9 100644
--- a/svx/source/dialog/contimp.hxx
+++ b/svx/source/dialog/contimp.hxx
@@ -117,8 +117,8 @@ public:
bool IsRedoPossible() const;
void UpdateGraphic( const Graphic& rGraphic, bool bGraphicLinked,
- const tools::PolyPolygon* pPolyPoly = nullptr,
- void* pEditingObj = nullptr );
+ const tools::PolyPolygon* pPolyPoly,
+ void* pEditingObj );
};
diff --git a/svx/source/dialog/framelink.cxx b/svx/source/dialog/framelink.cxx
index 6913002..2d64641 100644
--- a/svx/source/dialog/framelink.cxx
+++ b/svx/source/dialog/framelink.cxx
@@ -1351,7 +1351,7 @@ bool CheckFrameBorderConnectable( const Style& rLBorder, const Style& rRBorder,
double lcl_GetExtent( const Style& rBorder, const Style& rSide, const Style& rOpposite,
- long nAngleSide = 9000, long nAngleOpposite = 9000 )
+ long nAngleSide, long nAngleOpposite )
{
Style aOtherBorder = rSide;
long nOtherAngle = nAngleSide;
diff --git a/svx/source/fmcomp/fmgridcl.cxx b/svx/source/fmcomp/fmgridcl.cxx
index e397ec9..ea2243c 100644
--- a/svx/source/fmcomp/fmgridcl.cxx
+++ b/svx/source/fmcomp/fmgridcl.cxx
@@ -116,7 +116,7 @@ struct FmGridHeaderData
};
const sal_Int16 nChangeTypeOffset = 1000;
-void SetMenuItem(const ImageList& rList, sal_uInt16 nID, Menu* pMenu, Menu& rNewMenu, bool bDesignMode = true, sal_Int16 nOffset = nChangeTypeOffset)
+void SetMenuItem(const ImageList& rList, sal_uInt16 nID, Menu* pMenu, Menu& rNewMenu, bool bDesignMode, sal_Int16 nOffset = nChangeTypeOffset)
{
pMenu->SetItemImage(nID, rList.GetImage(nID));
pMenu->EnableItem(nID, bDesignMode);
diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx
index 8e65ae5..649676f 100644
--- a/svx/source/form/fmvwimp.cxx
+++ b/svx/source/form/fmvwimp.cxx
@@ -1129,7 +1129,7 @@ IMPL_LINK_NOARG_TYPED( FmXFormView, OnStartControlWizard, void*, void )
namespace
{
void lcl_insertIntoFormComponentHierarchy_throw( const FmFormView& _rView, const SdrUnoObj& _rSdrObj,
- const Reference< XDataSource >& _rxDataSource = nullptr, const OUString& _rDataSourceName = OUString(),
+ const Reference< XDataSource >& _rxDataSource, const OUString& _rDataSourceName,
const OUString& _rCommand = OUString(), const sal_Int32 _nCommandType = -1 )
{
FmFormPage& rPage = static_cast< FmFormPage& >( *_rView.GetSdrPageView()->GetPage() );
diff --git a/svx/source/inc/filtnav.hxx b/svx/source/inc/filtnav.hxx
index 021ff49..e386c50 100644
--- a/svx/source/inc/filtnav.hxx
+++ b/svx/source/inc/filtnav.hxx
@@ -293,8 +293,8 @@ private:
* If <TRUE/> the items will not be removed from the model, otherwise they will.
*/
void insertFilterItem(const ::std::vector<FmFilterItem*>& _rFilterList,FmFilterItems* _pTargetItems, bool _bCopy);
- SvTreeListEntry* getPrevEntry(SvTreeListEntry* _pStartWith = nullptr);
- SvTreeListEntry* getNextEntry(SvTreeListEntry* _pStartWith = nullptr);
+ SvTreeListEntry* getPrevEntry(SvTreeListEntry* _pStartWith);
+ SvTreeListEntry* getNextEntry(SvTreeListEntry* _pStartWith);
using SvTreeListBox::Select;
using SvTreeListBox::ExecuteDrop;
diff --git a/svx/source/inc/fmshimp.hxx b/svx/source/inc/fmshimp.hxx
index 1df45ba..a7476c2 100644
--- a/svx/source/inc/fmshimp.hxx
+++ b/svx/source/inc/fmshimp.hxx
@@ -325,7 +325,7 @@ protected:
// form handling
/// load or unload the forms on a page
- SAL_DLLPRIVATE void loadForms( FmFormPage* _pPage, const LoadFormsFlags _nBehaviour = LoadFormsFlags::Load | LoadFormsFlags::Sync );
+ SAL_DLLPRIVATE void loadForms( FmFormPage* _pPage, const LoadFormsFlags _nBehaviour );
SAL_DLLPRIVATE void smartControlReset( const css::uno::Reference< css::container::XIndexAccess >& _rxModels );
diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx
index 8801a6a..71e4ba4 100644
--- a/svx/source/inc/gridcell.hxx
+++ b/svx/source/inc/gridcell.hxx
@@ -225,7 +225,7 @@ protected:
inline void setTransparent( bool _bSet ) { m_bTransparent = _bSet; }
// control alignment
- inline void setAlignedController( bool _bAlign = true ) { m_bAlignedController = _bAlign; }
+ inline void setAlignedController( bool _bAlign ) { m_bAlignedController = _bAlign; }
/** determined whether or not the value property is locked
diff --git a/svx/source/svdraw/svdfmtf.hxx b/svx/source/svdraw/svdfmtf.hxx
index a14bda0..e8440da 100644
--- a/svx/source/svdraw/svdfmtf.hxx
+++ b/svx/source/svdraw/svdfmtf.hxx
@@ -167,7 +167,7 @@ public:
size_t DoImport(
const GDIMetaFile& rMtf,
SdrObjList& rDestList,
- size_t nInsPos = SAL_MAX_SIZE,
+ size_t nInsPos,
SvdProgressInfo* pProgrInfo = nullptr);
};
diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index dd9f08d..ba06645 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -91,7 +91,7 @@ public:
explicit SdrHdlBitmapSet(sal_uInt16 nResId);
~SdrHdlBitmapSet();
- const BitmapEx& GetBitmapEx(BitmapMarkerKind eKindOfMarker, sal_uInt16 nInd=0);
+ const BitmapEx& GetBitmapEx(BitmapMarkerKind eKindOfMarker, sal_uInt16 nInd);
};
diff --git a/svx/source/tbxctrls/tbunosearchcontrollers.cxx b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
index dfce497..0979bf7 100644
--- a/svx/source/tbxctrls/tbunosearchcontrollers.cxx
+++ b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
@@ -74,7 +74,7 @@ static const sal_Int32 REMEMBER_SIZE = 10;
void impl_executeSearch( const css::uno::Reference< css::uno::XComponentContext >& rxContext,
const css::uno::Reference< css::frame::XFrame >& xFrame,
const ToolBox* pToolBox,
- const bool aSearchBackwards = false,
+ const bool aSearchBackwards,
const bool aFindAll = false )
{
css::uno::Reference< css::util::XURLTransformer > xURLTransformer( css::util::URLTransformer::create( rxContext ) );
diff --git a/ucb/source/ucp/file/shell.hxx b/ucb/source/ucp/file/shell.hxx
index 3408ad0..cac588f 100644
--- a/ucb/source/ucp/file/shell.hxx
+++ b/ucb/source/ucp/file/shell.hxx
@@ -439,7 +439,7 @@ namespace fileaccess {
void SAL_CALL copyPersistentSet( const OUString& srcUnqPath,
const OUString& dstUnqPath,
- bool withChildren = false );
+ bool withChildren );
// Special optimized method for getting the properties of a directoryitem, which
diff --git a/unodevtools/source/skeletonmaker/skeletoncpp.hxx b/unodevtools/source/skeletonmaker/skeletoncpp.hxx
index d8c3f93..bd05604 100644
--- a/unodevtools/source/skeletonmaker/skeletoncpp.hxx
+++ b/unodevtools/source/skeletonmaker/skeletoncpp.hxx
@@ -43,8 +43,8 @@ void printMethods(std::ostream & o,
OUString const & name,
codemaker::GeneratedTypeSet & generated,
OString const & delegate,
- OString const & classname=OString(),
- OString const & indentation=OString(),
+ OString const & classname,
+ OString const & indentation,
bool defaultvalue=false,
OUString const & propertyhelper=OUString());
diff --git a/unodevtools/source/skeletonmaker/skeletonjava.hxx b/unodevtools/source/skeletonmaker/skeletonjava.hxx
index 4402fc1..9efeeb1 100644
--- a/unodevtools/source/skeletonmaker/skeletonjava.hxx
+++ b/unodevtools/source/skeletonmaker/skeletonjava.hxx
@@ -36,7 +36,7 @@ void printMethods(std::ostream & o,
OUString const & name,
codemaker::GeneratedTypeSet & generated,
OString const & delegate,
- OString const & indentation=OString(),
+ OString const & indentation,
bool defaultvalue=false,
bool usepropertymixin=false);
More information about the Libreoffice-commits
mailing list