[Libreoffice-commits] core.git: framework/qa

[Tor Lillqvist]

 framework/qa/complex/XTitle/CheckXTitle.java |   13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

New commits:
commit 3cff10827974cd773810faa2857ab81a6dcff0ee
Author: Tor Lillqvist <tml at collabora.com>
Date:   Thu Aug 11 11:15:06 2016 +0300

    Follow-up to 38a3743e0c5d52f9386f74097fd512d3133fbbe3
    
    Change-Id: If70b5754c161a0e1b262abeac8c54dde60515280

diff --git a/framework/qa/complex/XTitle/CheckXTitle.java b/framework/qa/complex/XTitle/CheckXTitle.java
index 3e00864..1372cf3 100644
--- a/framework/qa/complex/XTitle/CheckXTitle.java
+++ b/framework/qa/complex/XTitle/CheckXTitle.java
@@ -210,11 +210,12 @@ public class CheckXTitle
         xDisProv = null;
     }
 
-    /** @short checks loading of new document with readonly set to true
+    /** @short checks creation of new empty document with readonly set to true
 
-        @descr loads a new document with readonly mode set to true.
-               this should fail because new doc can not be opened in
-               read only mode
+        @descr creation of a new document with readonly property set
+               to true.  this should not fail even if as such it can
+               be seen as a slightly silly thing to do. But existing
+               3rd-party code depends on it to work.
     */
     @Test public void checkLoadingWithReadOnly()
     {
@@ -232,10 +233,8 @@ public class CheckXTitle
         try{
                 xDoc = m_xLoader.loadComponentFromURL("private:factory/swriter", "_default", 0, lArgs);
         } catch (Exception e) {
-            //exception is expected. do nothing
         }
-
-        assertNull("Loading new document with read only mode true should have failed", xDoc);
+        assertNotNull("Creating a new document read with ReadOnly property true should work (even if slightly silly)", xDoc);
     }
 
     private XMultiServiceFactory getMSF()