[Libreoffice-commits] core.git: dbaccess/source
Arnold Dumas
arnold at dumas.at
Mon Aug 15 06:50:12 UTC 2016
dbaccess/source/ui/dlg/odbcconfig.cxx | 1 -
dbaccess/source/ui/dlg/odbcconfig.hxx | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 95abd2fcc7acc9faaf00812f9e808a86baae6bea
Author: Arnold Dumas <arnold at dumas.at>
Date: Sun Aug 14 21:39:51 2016 +0200
tdf#89329: use unique_ptr for pImpl in odbcconfig
Change-Id: Ieba9b60dfa8e61d41a18096e1bddc3c8c70b2e2f
Reviewed-on: https://gerrit.libreoffice.org/28113
Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
Tested-by: Noel Grandin <noelgrandin at gmail.com>
diff --git a/dbaccess/source/ui/dlg/odbcconfig.cxx b/dbaccess/source/ui/dlg/odbcconfig.cxx
index b4c482d..cd90b3a 100644
--- a/dbaccess/source/ui/dlg/odbcconfig.cxx
+++ b/dbaccess/source/ui/dlg/odbcconfig.cxx
@@ -147,7 +147,6 @@ OOdbcEnumeration::OOdbcEnumeration()
OOdbcEnumeration::~OOdbcEnumeration()
{
freeEnv();
- delete m_pImpl;
unload();
}
diff --git a/dbaccess/source/ui/dlg/odbcconfig.hxx b/dbaccess/source/ui/dlg/odbcconfig.hxx
index eb60bad..04af12d 100644
--- a/dbaccess/source/ui/dlg/odbcconfig.hxx
+++ b/dbaccess/source/ui/dlg/odbcconfig.hxx
@@ -53,7 +53,7 @@ class OOdbcEnumeration
oslGenericFunction m_pDataSources;
#endif
- OdbcTypesImpl* m_pImpl;
+ std::unique_ptr<OdbcTypesImpl> m_pImpl;
// needed because we can't have a member of type SQLHANDLE: this would require us to include the respective
// ODBC file, which would lead to a lot of conflicts with other includes
More information about the Libreoffice-commits
mailing list