[Libreoffice-commits] core.git: sw/qa
Stephan Bergmann
sbergman at redhat.com
Wed Aug 17 08:17:39 UTC 2016
sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx |binary
1 file changed
New commits:
commit 6be059453e243af45de6f5a3fa33d30b6dbf3d36
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Wed Aug 17 10:14:45 2016 +0200
Use full absolute URL in footer-contain-hyperlink.docx
What this binary change does is change in the contained
word/_rels/footer1.xml.rels from
Target="www.google.com"
to
Target="http://www.google.com/"
because of:
<sberg> vmiklos, do you know how
sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx (introduced with
4654e9b113a66c800161d0ee82d587055fff4f8b ["fdo#74271: Added unit test & code
changes for footer contains hyperlink."]) was created? It contains a
word/_rels/footer1.xml.rels with a <Relationship Id="rId1"
Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink"
Target="www.google.com" TargetMode="External"/>, where that
Target="www.google.com" is not a proper URL, but the testFooterContainHyper
link test in sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx expects it to end
up as "http://www.google.com/"
<vmiklos> sberg: [...] that sounds like a bug, MSO resolves that as a regular
relative file reference, i.e. to file:///...\ooxmlexport\data\www.google.com
<sberg> vmiklos, ah, that's good to know; I'm trying to fix tdf#86087 ["FILESAVE
FILEOPEN VIEWING: Can't open or save relative links in docx"] by turning
relative URLs into absolute ones when reading docx etc. in
writerfilter/source/dmapper/DomainMapper_Impl.cxx, but that now caused that
test to fail
<sberg> vmiklos, so I guess it's best to modify
sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx to contain
<http://www.google.com/> instead of merely <www.google.com>
<vmiklos> sberg: yes, i think so
Change-Id: I7986acb66f260faaf8fe5398f3778cc35fb9930d
diff --git a/sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx b/sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx
index 27b00ed..42c68d5 100644
Binary files a/sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx and b/sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx differ
More information about the Libreoffice-commits
mailing list