[Libreoffice-commits] core.git: extensions/source
Arnold Dumas
arnold at dumas.at
Fri Aug 19 08:44:32 UTC 2016
extensions/source/abpilot/datasourcehandling.cxx | 4 +---
extensions/source/abpilot/datasourcehandling.hxx | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
New commits:
commit e420085f6f106cd78b70ffc3abd02e32123230f4
Author: Arnold Dumas <arnold at dumas.at>
Date: Fri Aug 19 09:27:16 2016 +0200
tdf#89329: use unique_ptr for pImpl in datasourcehandling
Change-Id: Ib019d26a72d234245cc1a7322bfbfb11705f29d3
Reviewed-on: https://gerrit.libreoffice.org/28231
Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
Tested-by: Noel Grandin <noelgrandin at gmail.com>
diff --git a/extensions/source/abpilot/datasourcehandling.cxx b/extensions/source/abpilot/datasourcehandling.cxx
index ac9cbe6..3b80969 100644
--- a/extensions/source/abpilot/datasourcehandling.cxx
+++ b/extensions/source/abpilot/datasourcehandling.cxx
@@ -333,8 +333,7 @@ namespace abp
{
if( this != &_rSource )
{
- delete m_pImpl;
- m_pImpl = new ODataSourceImpl( *_rSource.m_pImpl );
+ m_pImpl.reset( new ODataSourceImpl( *_rSource.m_pImpl ) );
}
return *this;
}
@@ -348,7 +347,6 @@ namespace abp
ODataSource::~ODataSource( )
{
- delete m_pImpl;
}
void ODataSource::store(const AddressSettings& rSettings)
diff --git a/extensions/source/abpilot/datasourcehandling.hxx b/extensions/source/abpilot/datasourcehandling.hxx
index 97c0441..65a4398 100644
--- a/extensions/source/abpilot/datasourcehandling.hxx
+++ b/extensions/source/abpilot/datasourcehandling.hxx
@@ -96,7 +96,7 @@ namespace abp
class ODataSource
{
private:
- ODataSourceImpl* m_pImpl;
+ std::unique_ptr<ODataSourceImpl> m_pImpl;
public:
More information about the Libreoffice-commits
mailing list