[Libreoffice-commits] core.git: sal/qa

Stephan Bergmann sbergman at redhat.com
Thu Dec 1 11:19:46 UTC 2016


 sal/qa/osl/condition/osl_Condition.cxx |    5 -----
 sal/qa/osl/pipe/osl_Pipe.cxx           |    3 ---
 2 files changed, 8 deletions(-)

New commits:
commit 659210773abff4dd4a5937c7995af5c0981e9020
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Dec 1 12:19:19 2016 +0100

    loplugin:unnecessaryoverride (dtors) in sal
    
    Change-Id: I498bb634f2a5800f5effab99227aa4699ed91aae

diff --git a/sal/qa/osl/condition/osl_Condition.cxx b/sal/qa/osl/condition/osl_Condition.cxx
index ec254ee..8ee37b2 100644
--- a/sal/qa/osl/condition/osl_Condition.cxx
+++ b/sal/qa/osl/condition/osl_Condition.cxx
@@ -39,11 +39,6 @@ public:
     //get the Condition to operate
     ConditionThread( ::osl::Condition& Con, ConditionType tType): m_MyCon( Con ), m_MyType( tType ) { }
 
-    virtual ~ConditionThread( ) override
-    {
-        // LLA: do not throw in DTors!
-        // LLA: CPPUNIT_ASSERT_MESSAGE( "#ConditionThread does not shutdown properly.\n", sal_False == this -> isRunning( ) );
-    }
 protected:
     ::osl::Condition& m_MyCon;
     ConditionType m_MyType;
diff --git a/sal/qa/osl/pipe/osl_Pipe.cxx b/sal/qa/osl/pipe/osl_Pipe.cxx
index 3e72763..988df00 100644
--- a/sal/qa/osl/pipe/osl_Pipe.cxx
+++ b/sal/qa/osl/pipe/osl_Pipe.cxx
@@ -736,9 +736,6 @@ namespace osl_StreamPipe
         sal_Char buf[256];
         Pipe_DataSink_Thread( ) { }
 
-        virtual ~Pipe_DataSink_Thread( ) override
-            {
-            }
     protected:
         void SAL_CALL run( ) override
             {


More information about the Libreoffice-commits mailing list