[Libreoffice-commits] core.git: include/drawinglayer include/editeng include/filter include/formula include/i18nlangtag
Noel Grandin
noel.grandin at collabora.co.uk
Mon Dec 5 05:55:08 UTC 2016
include/drawinglayer/animation/animationtiming.hxx | 6 +++---
include/drawinglayer/attribute/fillgraphicattribute.hxx | 2 +-
include/drawinglayer/primitive2d/clippedborderlineprimitive2d.hxx | 2 +-
include/drawinglayer/primitive2d/svggradientprimitive2d.hxx | 10 +++++-----
include/drawinglayer/texture/texture3d.hxx | 4 ++--
include/editeng/bulletitem.hxx | 4 ++--
include/editeng/editeng.hxx | 2 +-
include/editeng/flditem.hxx | 4 ++--
include/editeng/outlobj.hxx | 2 +-
include/editeng/paperinf.hxx | 2 +-
include/editeng/splwrap.hxx | 4 ++--
include/editeng/svxacorr.hxx | 2 +-
include/editeng/svxrtf.hxx | 4 ++--
include/editeng/unoedhlp.hxx | 2 +-
include/editeng/unoforou.hxx | 2 +-
include/filter/msfilter/escherex.hxx | 2 +-
include/filter/msfilter/msdffimp.hxx | 4 ++--
include/filter/msfilter/mstoolbar.hxx | 2 +-
include/formula/formula.hxx | 4 ++--
include/formula/funcutl.hxx | 2 +-
include/i18nlangtag/languagetag.hxx | 2 +-
21 files changed, 34 insertions(+), 34 deletions(-)
New commits:
commit fe3e1067bfa8d62d2a43c7ea227d87327ee020d2
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Fri Dec 2 16:34:40 2016 +0200
loplugin:countusersofdefaultparams in include/drawinglayer..i18nlangtag
Change-Id: I081ed66a88fc11648f5c63919c3de2a71f1afd59
Reviewed-on: https://gerrit.libreoffice.org/31556
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/include/drawinglayer/animation/animationtiming.hxx b/include/drawinglayer/animation/animationtiming.hxx
index 59c3960..4514349 100644
--- a/include/drawinglayer/animation/animationtiming.hxx
+++ b/include/drawinglayer/animation/animationtiming.hxx
@@ -56,7 +56,7 @@ namespace drawinglayer
double mfState;
public:
- AnimationEntryFixed(double fDuration, double fState = 0.0);
+ AnimationEntryFixed(double fDuration, double fState);
virtual ~AnimationEntryFixed() override;
virtual AnimationEntry* clone() const override;
@@ -76,7 +76,7 @@ namespace drawinglayer
double mfStop;
public:
- AnimationEntryLinear(double fDuration, double fFrequency = 250.0, double fStart = 0.0, double fStop = 1.0);
+ AnimationEntryLinear(double fDuration, double fFrequency, double fStart, double fStop);
virtual ~AnimationEntryLinear() override;
virtual AnimationEntry* clone() const override;
@@ -115,7 +115,7 @@ namespace drawinglayer
sal_uInt32 mnRepeat;
public:
- AnimationEntryLoop(sal_uInt32 nRepeat = 0xffffffff);
+ AnimationEntryLoop(sal_uInt32 nRepeat);
virtual ~AnimationEntryLoop() override;
virtual AnimationEntry* clone() const override;
diff --git a/include/drawinglayer/attribute/fillgraphicattribute.hxx b/include/drawinglayer/attribute/fillgraphicattribute.hxx
index 87304c6..a2a2174 100644
--- a/include/drawinglayer/attribute/fillgraphicattribute.hxx
+++ b/include/drawinglayer/attribute/fillgraphicattribute.hxx
@@ -53,7 +53,7 @@ namespace drawinglayer
FillGraphicAttribute(
const Graphic& rGraphic,
const basegfx::B2DRange& rGraphicRange,
- bool bTiling = false,
+ bool bTiling,
double fOffsetX = 0.0,
double fOffsetY = 0.0);
FillGraphicAttribute(const FillGraphicAttribute& rCandidate);
diff --git a/include/drawinglayer/primitive2d/clippedborderlineprimitive2d.hxx b/include/drawinglayer/primitive2d/clippedborderlineprimitive2d.hxx
index 62bd981..5b4a141 100644
--- a/include/drawinglayer/primitive2d/clippedborderlineprimitive2d.hxx
+++ b/include/drawinglayer/primitive2d/clippedborderlineprimitive2d.hxx
@@ -47,7 +47,7 @@ namespace drawinglayer
const basegfx::BColor& rRGBColorGap,
bool bHasGapColor,
const short nStyle,
- double fPatternScale = 1.0 );
+ double fPatternScale );
/// compare operator
virtual bool operator==(const BasePrimitive2D& rPrimitive) const override;
diff --git a/include/drawinglayer/primitive2d/svggradientprimitive2d.hxx b/include/drawinglayer/primitive2d/svggradientprimitive2d.hxx
index 1ac5b2f..8bef69e 100644
--- a/include/drawinglayer/primitive2d/svggradientprimitive2d.hxx
+++ b/include/drawinglayer/primitive2d/svggradientprimitive2d.hxx
@@ -44,7 +44,7 @@ namespace drawinglayer
double mfOpacity;
public:
- SvgGradientEntry(double fOffset, const basegfx::BColor& rColor = basegfx::BColor(0.0, 0.0, 0.0), double fOpacity = 1.0)
+ SvgGradientEntry(double fOffset, const basegfx::BColor& rColor, double fOpacity)
: mfOffset(fOffset),
maColor(rColor),
mfOpacity(fOpacity)
@@ -155,7 +155,7 @@ namespace drawinglayer
const SvgGradientEntryVector& rGradientEntries,
const basegfx::B2DPoint& rStart,
bool bUseUnitCoordinates,
- SpreadMethod aSpreadMethod = SpreadMethod::Pad);
+ SpreadMethod aSpreadMethod);
virtual ~SvgGradientHelper();
/// data read access
@@ -208,7 +208,7 @@ namespace drawinglayer
const basegfx::B2DPoint& rStart,
const basegfx::B2DPoint& rEnd,
bool bUseUnitCoordinates,
- SpreadMethod aSpreadMethod = SpreadMethod::Pad);
+ SpreadMethod aSpreadMethod);
virtual ~SvgLinearGradientPrimitive2D() override;
/// data read access
@@ -276,8 +276,8 @@ namespace drawinglayer
const basegfx::B2DPoint& rStart,
double fRadius,
bool bUseUnitCoordinates,
- SpreadMethod aSpreadMethod = SpreadMethod::Pad,
- const basegfx::B2DPoint* pFocal = nullptr);
+ SpreadMethod aSpreadMethod,
+ const basegfx::B2DPoint* pFocal);
virtual ~SvgRadialGradientPrimitive2D() override;
/// data read access
diff --git a/include/drawinglayer/texture/texture3d.hxx b/include/drawinglayer/texture/texture3d.hxx
index dd21e06..70aefdc 100644
--- a/include/drawinglayer/texture/texture3d.hxx
+++ b/include/drawinglayer/texture/texture3d.hxx
@@ -107,8 +107,8 @@ namespace drawinglayer
GeoTexSvxBitmapExTiled(
const BitmapEx& rBitmapEx,
const basegfx::B2DRange& rRange,
- double fOffsetX = 0.0,
- double fOffsetY = 0.0);
+ double fOffsetX,
+ double fOffsetY);
virtual void modifyBColor(const basegfx::B2DPoint& rUV, basegfx::BColor& rBColor, double& rfOpacity) const override;
virtual void modifyOpacity(const basegfx::B2DPoint& rUV, double& rfOpacity) const override;
diff --git a/include/editeng/bulletitem.hxx b/include/editeng/bulletitem.hxx
index 3d75512..98c872b 100644
--- a/include/editeng/bulletitem.hxx
+++ b/include/editeng/bulletitem.hxx
@@ -60,8 +60,8 @@ class EDITENG_DLLPUBLIC SvxBulletItem : public SfxPoolItem
public:
static SfxPoolItem* CreateDefault();
- explicit SvxBulletItem( sal_uInt16 nWhich = 0 );
- explicit SvxBulletItem( SvStream& rStrm, sal_uInt16 nWhich = 0 );
+ explicit SvxBulletItem( sal_uInt16 nWhich );
+ explicit SvxBulletItem( SvStream& rStrm, sal_uInt16 nWhich );
SvxBulletItem( const SvxBulletItem& );
virtual ~SvxBulletItem() override;
diff --git a/include/editeng/editeng.hxx b/include/editeng/editeng.hxx
index 2b4f236..f95b798 100644
--- a/include/editeng/editeng.hxx
+++ b/include/editeng/editeng.hxx
@@ -399,7 +399,7 @@ public:
void QuickDelete( const ESelection& rSel );
void QuickMarkToBeRepainted( sal_Int32 nPara );
- void SetGlobalCharStretching( sal_uInt16 nX, sal_uInt16 nY = 100 );
+ void SetGlobalCharStretching( sal_uInt16 nX, sal_uInt16 nY );
void GetGlobalCharStretching( sal_uInt16& rX, sal_uInt16& rY ) const;
void SetEditTextObjectPool( SfxItemPool* pPool );
diff --git a/include/editeng/flditem.hxx b/include/editeng/flditem.hxx
index 272b919..d7c43ff 100644
--- a/include/editeng/flditem.hxx
+++ b/include/editeng/flditem.hxx
@@ -115,7 +115,7 @@ public:
SvxDateField();
explicit SvxDateField( const Date& rDate,
- SvxDateType eType = SVXDATETYPE_VAR,
+ SvxDateType eType,
SvxDateFormat eFormat = SVXDATEFORMAT_STDSMALL );
sal_Int32 GetFixDate() const { return nFixDate; }
@@ -274,7 +274,7 @@ public:
SV_DECL_PERSIST1( SvxExtTimeField, SvxFieldData, css::text::textfield::Type::EXTENDED_TIME )
SvxExtTimeField();
explicit SvxExtTimeField( const tools::Time& rTime,
- SvxTimeType eType = SVXTIMETYPE_VAR,
+ SvxTimeType eType,
SvxTimeFormat eFormat = SVXTIMEFORMAT_STANDARD );
sal_Int64 GetFixTime() const { return m_nFixTime; }
diff --git a/include/editeng/outlobj.hxx b/include/editeng/outlobj.hxx
index 6bde289..86a10e1 100644
--- a/include/editeng/outlobj.hxx
+++ b/include/editeng/outlobj.hxx
@@ -60,7 +60,7 @@ class EDITENG_DLLPUBLIC OutlinerParaObject
public:
// constructors/destructor
- OutlinerParaObject( const EditTextObject&, const ParagraphDataVector&, bool bIsEditDoc = true);
+ OutlinerParaObject( const EditTextObject&, const ParagraphDataVector&, bool bIsEditDoc);
OutlinerParaObject( const EditTextObject&);
OutlinerParaObject( const OutlinerParaObject&);
~OutlinerParaObject();
diff --git a/include/editeng/paperinf.hxx b/include/editeng/paperinf.hxx
index 8b0d454..490c54f 100644
--- a/include/editeng/paperinf.hxx
+++ b/include/editeng/paperinf.hxx
@@ -39,7 +39,7 @@ public:
static Size GetDefaultPaperSize( MapUnit eUnit = MapUnit::MapTwip );
static Size GetPaperSize( Paper ePaper, MapUnit eUnit = MapUnit::MapTwip );
static Size GetPaperSize( const Printer* pPrinter );
- static Paper GetSvxPaper( const Size &rSize, MapUnit eUnit, bool bSloppy = false );
+ static Paper GetSvxPaper( const Size &rSize, MapUnit eUnit, bool bSloppy );
static long GetSloppyPaperDimension( long nSize );
static OUString GetName( Paper ePaper );
};
diff --git a/include/editeng/splwrap.hxx b/include/editeng/splwrap.hxx
index b6b651a..1dd0947 100644
--- a/include/editeng/splwrap.hxx
+++ b/include/editeng/splwrap.hxx
@@ -74,10 +74,10 @@ private:
public:
SvxSpellWrapper( vcl::Window* pWn,
- const bool bStart = false, const bool bIsAllRight = false );
+ const bool bStart, const bool bIsAllRight );
SvxSpellWrapper( vcl::Window* pWn,
css::uno::Reference< css::linguistic2::XHyphenator > &xHyphenator,
- const bool bStart = false, const bool bOther = false );
+ const bool bStart, const bool bOther );
virtual ~SvxSpellWrapper();
diff --git a/include/editeng/svxacorr.hxx b/include/editeng/svxacorr.hxx
index dbe2704..beecd96 100644
--- a/include/editeng/svxacorr.hxx
+++ b/include/editeng/svxacorr.hxx
@@ -347,7 +347,7 @@ public:
// Load, Set, Get - the exception list for capital letters at the
// beginning of a sentence
- void SaveCplSttExceptList( LanguageType eLang = LANGUAGE_SYSTEM );
+ void SaveCplSttExceptList( LanguageType eLang );
SvStringsISortDtor* LoadCplSttExceptList(LanguageType eLang)
{ return GetLanguageList_( eLang ).LoadCplSttExceptList(); }
const SvStringsISortDtor* GetCplSttExceptList( LanguageType eLang )
diff --git a/include/editeng/svxrtf.hxx b/include/editeng/svxrtf.hxx
index 1018440..2698699 100644
--- a/include/editeng/svxrtf.hxx
+++ b/include/editeng/svxrtf.hxx
@@ -59,7 +59,7 @@ class ContentNode;
class EditNodeIdx
{
public:
- EditNodeIdx(EditEngine* pEE, ContentNode* pNd = nullptr);
+ EditNodeIdx(EditEngine* pEE, ContentNode* pNd);
~EditNodeIdx() {}
sal_Int32 GetIdx() const;
EditNodeIdx* Clone() const; // Cloning itself
@@ -343,7 +343,7 @@ class EDITENG_DLLPUBLIC SvxRTFItemStackType
public:
SvxRTFItemStackType( const SvxRTFItemStackType&, const EditPosition&,
- bool bCopyAttr = false );
+ bool bCopyAttr );
~SvxRTFItemStackType();
//cmc, I'm very suspicios about SetStartPos, it doesn't change
//its children's starting position, and the implementation looks
diff --git a/include/editeng/unoedhlp.hxx b/include/editeng/unoedhlp.hxx
index 995b50d..ca8dac2 100644
--- a/include/editeng/unoedhlp.hxx
+++ b/include/editeng/unoedhlp.hxx
@@ -46,7 +46,7 @@ private:
public:
SvxEditSourceHint( sal_uInt32 nId );
- SvxEditSourceHint( sal_uInt32 nId, sal_uLong nValue, sal_Int32 nStart=0, sal_Int32 nEnd=0 );
+ SvxEditSourceHint( sal_uInt32 nId, sal_uLong nValue, sal_Int32 nStart, sal_Int32 nEnd );
using TextHint::GetValue;
sal_Int32 GetStartValue() const { return mnStart;}
diff --git a/include/editeng/unoforou.hxx b/include/editeng/unoforou.hxx
index 151564c..1efbefa 100644
--- a/include/editeng/unoforou.hxx
+++ b/include/editeng/unoforou.hxx
@@ -50,7 +50,7 @@ private:
mutable sal_Int32 mnParaAttribsCache;
public:
- SvxOutlinerForwarder( Outliner& rOutl, bool bOutlText = false );
+ SvxOutlinerForwarder( Outliner& rOutl, bool bOutlText );
virtual ~SvxOutlinerForwarder() override;
virtual sal_Int32 GetParagraphCount() const override;
diff --git a/include/filter/msfilter/escherex.hxx b/include/filter/msfilter/escherex.hxx
index 746bb2a..00286c9 100644
--- a/include/filter/msfilter/escherex.hxx
+++ b/include/filter/msfilter/escherex.hxx
@@ -533,7 +533,7 @@ public:
sal_uInt32 nPictureOffset,
const GraphicObject& rObj,
const OString& rId,
- const GraphicAttr* pAttr = nullptr
+ const GraphicAttr* pAttr
);
~EscherBlibEntry();
diff --git a/include/filter/msfilter/msdffimp.hxx b/include/filter/msfilter/msdffimp.hxx
index 396f88e..ae17359 100644
--- a/include/filter/msfilter/msdffimp.hxx
+++ b/include/filter/msfilter/msdffimp.hxx
@@ -100,7 +100,7 @@ public:
void SetDefaultPropSet( SvStream& rIn, sal_uInt32 nOffDgg ) const;
void ApplyAttributes( SvStream& rIn, SfxItemSet& rSet ) const;
void ApplyAttributes( SvStream& rIn, SfxItemSet& rSet, DffObjData& rObjData ) const;
- void ImportGradientColor( SfxItemSet& aSet, MSO_FillType eMSO_FillType, double dTrans, double dBackTrans = 1.0 ) const;
+ void ImportGradientColor( SfxItemSet& aSet, MSO_FillType eMSO_FillType, double dTrans, double dBackTrans ) const;
};
#define COL_DEFAULT RGB_COLORDATA( 0xFA, 0xFB, 0xFC )
@@ -588,7 +588,7 @@ public:
const OUString& rBaseURL,
sal_uInt32 nOffsDgg,
SvStream* pStData,
- SdrModel* pSdrModel_ = nullptr,
+ SdrModel* pSdrModel_,
long nApplicationScale = 0,
ColorData mnDefaultColor_ = COL_DEFAULT,
SvStream* pStData2_ = nullptr,
diff --git a/include/filter/msfilter/mstoolbar.hxx b/include/filter/msfilter/mstoolbar.hxx
index 0f35c5c..ab3143a 100644
--- a/include/filter/msfilter/mstoolbar.hxx
+++ b/include/filter/msfilter/mstoolbar.hxx
@@ -95,7 +95,7 @@ public:
class Indent
{
public:
- Indent( bool binit = false )
+ Indent( bool binit )
{
if ( binit )
TBBase::nIndent = 0;
diff --git a/include/formula/formula.hxx b/include/formula/formula.hxx
index c0a12a3..8ef48ea 100644
--- a/include/formula/formula.hxx
+++ b/include/formula/formula.hxx
@@ -65,7 +65,7 @@ class FORMULA_DLLPUBLIC FormulaModalDialog : public ModalDialog, public formul
public:
FormulaModalDialog( vcl::Window* pParent
,IFunctionManager* _pFunctionMgr
- ,IControlReferenceHandler* _pDlg = nullptr );
+ ,IControlReferenceHandler* _pDlg );
virtual ~FormulaModalDialog() override;
virtual void dispose() override;
@@ -101,7 +101,7 @@ public:
, SfxChildWindow* pCW
, vcl::Window* pParent
, IFunctionManager* _pFunctionMgr
- , IControlReferenceHandler* _pDlg = nullptr );
+ , IControlReferenceHandler* _pDlg );
virtual ~FormulaDlg() override;
virtual void dispose() override;
private:
diff --git a/include/formula/funcutl.hxx b/include/formula/funcutl.hxx
index a2632ef..99a3e4e 100644
--- a/include/formula/funcutl.hxx
+++ b/include/formula/funcutl.hxx
@@ -101,7 +101,7 @@ protected:
virtual void LoseFocus() override;
public:
- RefButton(vcl::Window* _pParent, WinBits nStyle = 0);
+ RefButton(vcl::Window* _pParent, WinBits nStyle);
virtual ~RefButton() override;
virtual void dispose() override;
void SetReferences( IControlReferenceHandler* pDlg, RefEdit* pEdit );
diff --git a/include/i18nlangtag/languagetag.hxx b/include/i18nlangtag/languagetag.hxx
index 14de1ee..ea87f53 100644
--- a/include/i18nlangtag/languagetag.hxx
+++ b/include/i18nlangtag/languagetag.hxx
@@ -514,7 +514,7 @@ public:
private use, like 'x-...', are not allowed and FALSE is
returned in this case.
*/
- static bool isValidBcp47( const OUString& rString, OUString* o_pCanonicalized = nullptr,
+ static bool isValidBcp47( const OUString& rString, OUString* o_pCanonicalized,
bool bDisallowPrivate = false );
/** If nLang is a generated on-the-fly LangID */
More information about the Libreoffice-commits
mailing list