[Libreoffice-commits] core.git: unoxml/qa

Stephan Bergmann sbergman at redhat.com
Tue Dec 6 15:39:42 UTC 2016


 unoxml/qa/unit/domtest.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit d752b1682307008d3e08a9f11e50ddc506d5f6ab
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Dec 6 16:38:31 2016 +0100

    Remove broken SAL_INFO
    
    Identifier apparently is not null terminated; caused CppunitTest_unoxml_domtest
    to fail with out-of-bounds read under -fsanitize=address.
    
    Change-Id: Id7c6ef6323d41d16b559488604e1c1feb725d608

diff --git a/unoxml/qa/unit/domtest.cxx b/unoxml/qa/unit/domtest.cxx
index f6b940b..bc7ff57 100644
--- a/unoxml/qa/unit/domtest.cxx
+++ b/unoxml/qa/unit/domtest.cxx
@@ -173,7 +173,6 @@ struct TokenHandler
 {
     virtual ::sal_Int32 SAL_CALL getTokenFromUTF8( const uno::Sequence< ::sal_Int8 >& Identifier ) throw (uno::RuntimeException) override
     {
-        SAL_INFO("unoxml", "getTokenFromUTF8() " << reinterpret_cast<const char*>(Identifier.getConstArray()));
         return Identifier.getLength() ? Identifier[0] : 0;
     }
 


More information about the Libreoffice-commits mailing list