[Libreoffice-commits] core.git: vcl/source

Khaled Hosny khaledhosny at eglug.org
Sun Dec 11 00:26:21 UTC 2016


 vcl/source/gdi/pdfwriter_impl.cxx |   12 ------------
 1 file changed, 12 deletions(-)

New commits:
commit d5e7e817980bfce29196dc55a20270201f77c673
Author: Khaled Hosny <khaledhosny at eglug.org>
Date:   Thu Dec 8 07:04:27 2016 +0200

    Drop a hack for Type 1, the future is here
    
    The original issue for reference:
    https://bz.apache.org/ooo/show_bug.cgi?id=36691
    
    Change-Id: I3b68c2c9f7cb94445875ef5a005e73dcfe65fa3a
    Reviewed-on: https://gerrit.libreoffice.org/31823
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Khaled Hosny <khaledhosny at eglug.org>

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx
index 75ba6d1..56f7d97 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8621,18 +8621,6 @@ void PDFWriterImpl::drawLayout( SalLayout& rLayout, const OUString& rText, bool
                 }
                 else
                     aUnicodes.push_back(rText[pGlyphs[i]->mnCharPos]);
-                // #i36691# hack that is needed because currently the pGlyphs[]
-                // argument is ignored for embeddable fonts and so the layout
-                // engine's glyph work is ignored (i.e. char mirroring)
-                // TODO: a real solution would be to map the layout engine's
-                // glyphid (i.e. FreeType's synthetic glyphid for a Type1 font)
-                // back to unicode and then to embeddable font's encoding
-                if( (getReferenceDevice()->GetLayoutMode() & ComplexTextLayoutFlags::BiDiRtl) != ComplexTextLayoutFlags::Default )
-                {
-                    size_t nI = aUnicodes.size()-1;
-                    for( int n = 0; n < nChars; n++, nI-- )
-                        aUnicodes[nI] = static_cast<sal_Ucs>(GetMirroredChar(aUnicodes[nI]));
-                }
             }
             else
                 aUnicodes.push_back( 0 );


More information about the Libreoffice-commits mailing list