[Libreoffice-commits] core.git: ucb/source

Jochen Nitschke j.nitschke+logerrit at ok.de
Sun Dec 11 13:34:29 UTC 2016


 ucb/source/sorter/sortresult.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cc6da0af33380eb598ecfd47b4c4bde8db764289
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date:   Sun Dec 11 12:13:21 2016 +0100

    fix out of bounds access
    
    since commit 96ec36cf261eec3ec07f3caa2673a916571c4287
    Date:   Thu Dec 8 21:49:47 2016 +0100
        ucb: replace "SimpleList" trash
    
    found by cppcheck
    
    Change-Id: I13d62bdb6cb1a714182f90078d4a2990c790301a
    Reviewed-on: https://gerrit.libreoffice.org/31856
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Eike Rathke <erack at redhat.com>

diff --git a/ucb/source/sorter/sortresult.cxx b/ucb/source/sorter/sortresult.cxx
index 5a289b5..24a507a 100644
--- a/ucb/source/sorter/sortresult.cxx
+++ b/ucb/source/sorter/sortresult.cxx
@@ -1492,7 +1492,7 @@ void SortedResultSet::Remove( sal_IntPtr nPos, sal_IntPtr nCount, EventList *pEv
         sal_IntPtr nSortPos = m_O2S[nPos];
         m_O2S.erase(m_O2S.begin() + nPos);
 
-        for (size_t j=1; j <= m_O2S.size(); ++j)
+        for (size_t j=1; j < m_O2S.size(); ++j)
         {
             sal_IntPtr nVal = m_O2S[j];
             if ( nVal > nSortPos )


More information about the Libreoffice-commits mailing list