[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sfx2/source

[Stephan Bergmann]

 sfx2/source/view/classificationhelper.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 34a7f06ab3e2da22aca44f7689d0f0748a615771
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Dec 13 19:34:00 2016 +0100

    That's probably not meant to be a C++ reference to a uno::Reference
    
    ...as introduced with e75f6e549eb825c310d16d11babf0fba5ee7fd7a "sfx2: make
    SfxClassificationHelper not require a full doc shell".  Made
    CppunitTest_sfx2_classification crash now when dereferencing
    m_xDocumentProperties in
    SfxClassificationHelper::Impl::pushToDocumentProperties, when built with a
    recent Clang trunk build.
    
    Change-Id: Id0b7fa0627b9642f748f07d7dfa05353114225fa
    (cherry picked from commit e90b004a41153770e672bb1d4524852499ab0ca5)
    Reviewed-on: https://gerrit.libreoffice.org/32002
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sfx2/source/view/classificationhelper.cxx b/sfx2/source/view/classificationhelper.cxx
index 0a6974f..cb6ece7 100644
--- a/sfx2/source/view/classificationhelper.cxx
+++ b/sfx2/source/view/classificationhelper.cxx
@@ -334,7 +334,7 @@ public:
     std::map<SfxClassificationPolicyType, SfxClassificationCategory> m_aCategory;
     /// Possible categories of a policy to choose from.
     std::vector<SfxClassificationCategory> m_aCategories;
-    const uno::Reference<document::XDocumentProperties>& m_xDocumentProperties;
+    uno::Reference<document::XDocumentProperties> m_xDocumentProperties;
 
     explicit Impl(const uno::Reference<document::XDocumentProperties>& xDocumentProperties);
     void parsePolicy();