[Libreoffice-commits] core.git: Branch 'aoo/trunk' - solenv/src svtools/workben

Pedro Giffuni pfg at apache.org
Sat Dec 24 06:08:12 UTC 2016


 solenv/src/version.c            |    8 --------
 svtools/workben/cui/loadlib.cxx |    6 ------
 2 files changed, 14 deletions(-)

New commits:
commit 9feaf73b22cb8ee5ba90440c50d06179f4bce8ba
Author: Pedro Giffuni <pfg at apache.org>
Date:   Sat Dec 24 02:08:28 2016 +0000

    Avoid including some dates in executable files.
    
    Embedding build dates and other environment specific information may
    casue gratuitous difference in the resulting binaries, which makes more
    difficult security verifications and binary updates.
    
    We currently make no claims but this is the first step to generate
    reproducible builds. For more information check:
    https://reproducible-builds.org/
    
    While here, since we have been so lazy about updating it, also add the svn
    Revision keyword to configure.ac.

diff --git a/solenv/src/version.c b/solenv/src/version.c
index 8db2097..604d83b 100644
--- a/solenv/src/version.c
+++ b/solenv/src/version.c
@@ -28,22 +28,16 @@
 
 struct VersionInfo
 {
-    const char* pTime;
-    const char* pDate;
     const char* pUpd;
     const char* pMinor;
     const char* pBuild;
-    const char* pInpath;
 };
 
 static const struct VersionInfo g_aVersionInfo =
 {
-    __TIME__,
-    __DATE__,
     _UPD,
     _LAST_MINOR,
     _BUILD,
-    _INPATH
 };
 
 #if defined(WNT) || defined(OS2)
@@ -65,8 +59,6 @@ const struct VersionInfo *GetVersionInfo(void)
 int main( int argc, char **argv )
 {
     const VersionInfo *pInfo = GetVersionInfo();
-    fprintf( stderr, "Date : %s\n", pInfo->pDate);
-    fprintf( stderr, "Time : %s\n", pInfo->pTime);
     fprintf( stderr, "UPD : %s\n", pInfo->pUpd);
     delete pInfo;
     return 0;
diff --git a/svtools/workben/cui/loadlib.cxx b/svtools/workben/cui/loadlib.cxx
index 190fac9..fd34fc2 100644
--- a/svtools/workben/cui/loadlib.cxx
+++ b/svtools/workben/cui/loadlib.cxx
@@ -37,12 +37,9 @@ using namespace rtl;
 extern "C" {
 struct VersionInfo
 {
-        const char*     pTime;
-        const char*     pDate;
         const char*     pUpd;
         const char*     pMinor;
         const char*     pBuild;
-        const char*     pInpath;
 };
 
 typedef VersionInfo*(__LOADONCALLAPI *GetVersionInfo)(void);
@@ -67,12 +64,9 @@ int __LOADONCALLAPI main( int argc, char **argv )
     }
     if ( pInfo )
     {
-        fprintf( stdout, "Date : %s\n", pInfo->pDate );
-        fprintf( stdout, "Time : %s\n", pInfo->pTime );
         fprintf( stdout, "UPD : %s\n", pInfo->pUpd );
         fprintf( stdout, "Minor : %s\n", pInfo->pMinor );
         fprintf( stdout, "Build : %s\n", pInfo->pBuild );
-        fprintf( stdout, "Inpath : %s\n", pInfo->pInpath );
     }
     else
         fprintf( stderr, "VersionInfo not Found !\n" );


More information about the Libreoffice-commits mailing list