[Libreoffice-commits] core.git: sal/cppunittester sd/source sw/source vcl/headless xmlsecurity/source

Caolán McNamara caolanm at redhat.com
Mon Feb 8 12:17:55 UTC 2016


 sal/cppunittester/cppunittester.cxx          |    2 +-
 sd/source/ui/animations/CategoryListBox.hxx  |    2 +-
 sw/source/core/unocore/unotbl.cxx            |    2 +-
 vcl/headless/svpgdi.cxx                      |    4 ++--
 xmlsecurity/source/helper/ooxmlsecparser.hxx |    2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 16b93ae648f3e9675eeb6980925957e2ccbcfdf2
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Feb 8 10:33:02 2016 +0000

    cppcheck: noExplicitConstructor
    
    Change-Id: I74585aa5a50cd335f4fd0a3ba4fed230b98993c3

diff --git a/sal/cppunittester/cppunittester.cxx b/sal/cppunittester/cppunittester.cxx
index 22af500..fa0c5793 100644
--- a/sal/cppunittester/cppunittester.cxx
+++ b/sal/cppunittester/cppunittester.cxx
@@ -173,7 +173,7 @@ namespace {
 
 struct test_name_compare
 {
-    test_name_compare(const std::string& rName):
+    explicit test_name_compare(const std::string& rName):
         maName(rName)
     {
     }
diff --git a/sd/source/ui/animations/CategoryListBox.hxx b/sd/source/ui/animations/CategoryListBox.hxx
index 4b9debb..f044ac4 100644
--- a/sd/source/ui/animations/CategoryListBox.hxx
+++ b/sd/source/ui/animations/CategoryListBox.hxx
@@ -9,7 +9,7 @@ namespace sd {
 class CategoryListBox : public ListBox
 {
 public:
-    CategoryListBox( vcl::Window* pParent );
+    explicit CategoryListBox( vcl::Window* pParent );
     virtual ~CategoryListBox();
 
     virtual void        MouseButtonUp( const MouseEvent& rMEvt ) SAL_OVERRIDE;
diff --git a/sw/source/core/unocore/unotbl.cxx b/sw/source/core/unocore/unotbl.cxx
index 31372e1..6f88f48 100644
--- a/sw/source/core/unocore/unotbl.cxx
+++ b/sw/source/core/unocore/unotbl.cxx
@@ -1974,7 +1974,7 @@ public:
     unsigned short m_nRows;
     unsigned short m_nColumns;
 
-    Impl(SwFrameFormat *const pFrameFormat)
+    explicit Impl(SwFrameFormat *const pFrameFormat)
         : SwClient(pFrameFormat)
         , m_Listeners(m_Mutex)
         , m_pPropSet(aSwMapProvider.GetPropertySet(PROPERTY_MAP_TEXT_TABLE))
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 5baa761..b99ea09 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -103,7 +103,7 @@ namespace
     class SourceHelper
     {
     public:
-        SourceHelper(const SalBitmap& rSourceBitmap)
+        explicit SourceHelper(const SalBitmap& rSourceBitmap)
         {
             const SvpSalBitmap& rSrcBmp = static_cast<const SvpSalBitmap&>(rSourceBitmap);
 
@@ -142,7 +142,7 @@ namespace
     class MaskHelper
     {
     public:
-        MaskHelper(const SalBitmap& rAlphaBitmap)
+        explicit MaskHelper(const SalBitmap& rAlphaBitmap)
         {
             const SvpSalBitmap& rMask = static_cast<const SvpSalBitmap&>(rAlphaBitmap);
             const BitmapBuffer* pMaskBuf = rMask.GetBuffer();
diff --git a/xmlsecurity/source/helper/ooxmlsecparser.hxx b/xmlsecurity/source/helper/ooxmlsecparser.hxx
index 73ac0b2..dbb0151 100644
--- a/xmlsecurity/source/helper/ooxmlsecparser.hxx
+++ b/xmlsecurity/source/helper/ooxmlsecparser.hxx
@@ -45,7 +45,7 @@ class OOXMLSecParser: public cppu::WeakImplHelper
     bool m_bReferenceUnresolved;
 
 public:
-    OOXMLSecParser(XSecController* pXSecController);
+    explicit OOXMLSecParser(XSecController* pXSecController);
     virtual ~OOXMLSecParser();
 
     // XDocumentHandler


More information about the Libreoffice-commits mailing list