[Libreoffice-commits] core.git: 2 commits - qadevOOo/tests sal/qa

[Caolán McNamara]

 qadevOOo/tests/java/ifc/awt/tree/_XTreeControl.java |   13 -------------
 sal/qa/rtl/random/rtl_random.cxx                    |    3 +--
 2 files changed, 1 insertion(+), 15 deletions(-)

New commits:
commit 049cf885c6e6c12ac9fa20bcb4ca1472de5b9115
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Feb 16 09:56:20 2016 +0000

    coverity#1352448 Use of untrusted scalar value
    
    and
    
    coverity#1352449 Use of untrusted scalar value
    
    I suspect this will fix the warning, given that "Casting narrower unsigned
    pBuffer[i] to wider signed type short effectively tests its lower bound", so
    if we pass it though as-is we probably quieten these
    
    Change-Id: I2ece08f7301f5d548d905d221e5a6af0da51a2bb

diff --git a/sal/qa/rtl/random/rtl_random.cxx b/sal/qa/rtl/random/rtl_random.cxx
index e3a70e4..c91bb54 100644
--- a/sal/qa/rtl/random/rtl_random.cxx
+++ b/sal/qa/rtl/random/rtl_random.cxx
@@ -198,9 +198,8 @@ public:
     }
     ~Statistics(){}
 
-    void addValue(sal_Int16 _nIndex, sal_Int32 _nValue)
+    void addValue(sal_uInt8 _nIndex, sal_Int32 _nValue)
     {
-        OSL_ASSERT(_nIndex >= 0 && _nIndex < 256);
         m_nDispensation[_nIndex] += _nValue;
     }
 
commit 7e06965243d1e3a98519c659b7ad580d1ff46ab5
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Feb 16 09:51:47 2016 +0000

    coverity#1327093 UrF: Unread field
    
    Change-Id: I354f29592e6bd036d9a548c7c2c3a3722c8c9450

diff --git a/qadevOOo/tests/java/ifc/awt/tree/_XTreeControl.java b/qadevOOo/tests/java/ifc/awt/tree/_XTreeControl.java
index c7400e4..519cd25 100644
--- a/qadevOOo/tests/java/ifc/awt/tree/_XTreeControl.java
+++ b/qadevOOo/tests/java/ifc/awt/tree/_XTreeControl.java
@@ -81,9 +81,6 @@ public class _XTreeControl extends MultiMethodTest {
     boolean mTreeCollapsed2 = false;
     boolean mTreeCollapsing2 = false;
 
-    boolean mTreeNodeEditing1 = false;
-    boolean mTreeNodeEdit1 = false;
-
     public interface XTreeDataModelListenerEvent{
         void fireEvent();
     }
@@ -152,12 +149,10 @@ public class _XTreeControl extends MultiMethodTest {
     public class TreeEditListenerImpl1 implements XTreeEditListener{
         public void nodeEditing(XTreeNode xTreeNode) throws VetoException {
             log.println("event at EditListener 1: nodeEditing");
-            mTreeNodeEditing1 = true;
         }
 
         public void nodeEdited(XTreeNode xTreeNode, String string) {
             log.println("event at EditListener 1: nodeEdited");
-            mTreeNodeEdit1 = true;
         }
 
         public void disposing(EventObject eventObject) {
@@ -190,11 +185,6 @@ public class _XTreeControl extends MultiMethodTest {
         mTreeCollapsing2 = false;
     }
 
-    private void resetEditListener(){
-        mTreeNodeEditing1 = false;
-        mTreeNodeEdit1 = false;
-    }
-
     @Override
     public void before(){
         mXNode = (XMutableTreeNode) tEnv.getObjRelation("XTreeControl_Node");
@@ -569,10 +559,7 @@ public class _XTreeControl extends MultiMethodTest {
         log.println("add EditListener 2....");
         oObj.addTreeEditListener(mTreeEditListener2);
 
-        resetEditListener();
-
         try {
-
             oObj.startEditingAtNode(mXNode);
         } catch (com.sun.star.lang.IllegalArgumentException ex) {
             log.println("ERROR: could not start editing at node: " + ex.toString());