[Libreoffice-commits] core.git: 2 commits - sd/qa

Stephan Bergmann sbergman at redhat.com
Tue Feb 16 13:44:28 UTC 2016


 sd/qa/unit/tiledrendering/tiledrendering.cxx |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 2368192433ac3a936fea765eaae5dfd4b46b4daa
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Feb 16 14:41:39 2016 +0100

    loplugin:stringconstant
    
    Change-Id: Id23a8ff3afa6e96e802d77b02f89ad2289c47460

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 1c99479..3fbe6c0 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -527,7 +527,7 @@ void SdTiledRenderingTest::testInsertPage()
 
     uno::Reference<lang::XComponent> xComponent;
     xComponent = xLoader->loadComponentFromURL(
-        getURLFromSrc(DATA_DIRECTORY) + OUString("insert-delete.odp"),
+        getURLFromSrc(DATA_DIRECTORY) + "insert-delete.odp",
         "_blank",
         0,
         aFilterOptions);
commit 7882a89147e8e33d8f7980756aa2f3d468cbd5b4
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Feb 16 14:41:22 2016 +0100

    loplugin:loopvartoosmall
    
    Change-Id: Ib5e7b7ffcd1e6421eb08f7b7d4cf16d0353ad6fa

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 770f03bd7..1c99479 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -572,9 +572,9 @@ void SdTiledRenderingTest::testInsertPage()
         comphelper::dispatchCommand(".uno:InsertPage", aArgs);
 
     // Verify inserted slides
-    for(unsigned nIterator=0; nIterator < m_aPageList.size(); nIterator++)
+    for(auto i: m_aPageList)
     {
-        SdPage* pPage = pDoc->GetSdPage(m_aPageList[nIterator], PK_STANDARD);
+        SdPage* pPage = pDoc->GetSdPage(i, PK_STANDARD);
         CPPUNIT_ASSERT(pPage);
     }
 
@@ -585,9 +585,9 @@ void SdTiledRenderingTest::testInsertPage()
         comphelper::dispatchCommand(".uno:DeletePage", aArgs);
 
     // Verify deleted slides
-    for(unsigned nIterator=0; nIterator < m_aPageList.size(); nIterator++)
+    for(auto i: m_aPageList)
     {
-        SdPage* pPage = pDoc->GetSdPage(m_aPageList[nIterator], PK_STANDARD);
+        SdPage* pPage = pDoc->GetSdPage(i, PK_STANDARD);
         CPPUNIT_ASSERT(pPage == nullptr);
     }
 
@@ -598,9 +598,9 @@ void SdTiledRenderingTest::testInsertPage()
         comphelper::dispatchCommand(".uno:Undo", aArgs);
 
     // Verify inserted slides
-    for(unsigned nIterator=0; nIterator < m_aPageList.size(); nIterator++)
+    for(auto i: m_aPageList)
     {
-        SdPage* pPage = pDoc->GetSdPage(m_aPageList[nIterator], PK_STANDARD);
+        SdPage* pPage = pDoc->GetSdPage(i, PK_STANDARD);
         CPPUNIT_ASSERT(pPage);
     }
 
@@ -611,9 +611,9 @@ void SdTiledRenderingTest::testInsertPage()
         comphelper::dispatchCommand(".uno:Redo", aArgs);
 
     // Verify deleted slides
-    for(unsigned nIterator=0; nIterator < m_aPageList.size(); nIterator++)
+    for(auto i: m_aPageList)
     {
-        SdPage* pPage = pDoc->GetSdPage(m_aPageList[nIterator], PK_STANDARD);
+        SdPage* pPage = pDoc->GetSdPage(i, PK_STANDARD);
         CPPUNIT_ASSERT(pPage == nullptr);
     }
 


More information about the Libreoffice-commits mailing list