[Libreoffice-commits] core.git: basegfx/test oox/qa sal/qa

Jaskaran jvsg1303 at gmail.com
Fri Feb 19 06:26:31 UTC 2016


 basegfx/test/basegfx3d.cxx                  |   40 --------------
 basegfx/test/basegfxtools.cxx               |    5 -
 basegfx/test/genericclipper.cxx             |    2 
 oox/qa/unit/vba_encryption.cxx              |    1 
 sal/qa/osl/process/osl_Thread.cxx           |   32 -----------
 sal/qa/rtl/cipher/rtl_cipher.cxx            |   80 ----------------------------
 sal/qa/rtl/crc32/rtl_crc32.cxx              |    8 --
 sal/qa/rtl/doublelock/rtl_doublelocking.cxx |    9 ---
 8 files changed, 177 deletions(-)

New commits:
commit 9fe9f487a25a15558b77a8afc359e844922f1e83
Author: Jaskaran <jvsg1303 at gmail.com>
Date:   Fri Feb 19 00:03:22 2016 +0530

    tdf#97703 Removed a few redundant calls to setUp and tearDown
    
    Calls to CppUnit::TextFixture::setUp and CppUnit::TextFixture::tearDown
    have been removed. I hope that saves a few milliseconds of build time :)
    
    Change-Id: I611db2f5c5673ab86bf8f92beb4f6e8a70443b34
    Reviewed-on: https://gerrit.libreoffice.org/22496
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/basegfx/test/basegfx3d.cxx b/basegfx/test/basegfx3d.cxx
index 61f7815..951553e 100644
--- a/basegfx/test/basegfx3d.cxx
+++ b/basegfx/test/basegfx3d.cxx
@@ -28,14 +28,6 @@ namespace basegfx3d
 class b3dhommatrix : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     // insert your test code here.
     // this is only demonstration code
@@ -56,14 +48,6 @@ public:
 class b3dpoint : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     // insert your test code here.
     // this is only demonstration code
@@ -84,14 +68,6 @@ public:
 class b3drange : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     // insert your test code here.
     void EmptyMethod()
@@ -110,14 +86,6 @@ public:
 class b3dtuple : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     // insert your test code here.
     // this is only demonstration code
@@ -138,14 +106,6 @@ public:
 class b3dvector : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     // insert your test code here.
     void EmptyMethod()
diff --git a/basegfx/test/basegfxtools.cxx b/basegfx/test/basegfxtools.cxx
index 0577c7b..7d27fa5 100644
--- a/basegfx/test/basegfxtools.cxx
+++ b/basegfx/test/basegfxtools.cxx
@@ -48,11 +48,6 @@ public:
         maKeyStops(getTestVector())
     {}
 
-    void setUp() override
-    {}
-
-    void tearDown() override
-    {}
 
     void test()
     {
diff --git a/basegfx/test/genericclipper.cxx b/basegfx/test/genericclipper.cxx
index 4a7020e..dde7afa 100644
--- a/basegfx/test/genericclipper.cxx
+++ b/basegfx/test/genericclipper.cxx
@@ -63,8 +63,6 @@ public:
             B2DRange(0,90,20,150));
     }
 
-    void tearDown() override
-    {}
 
     void validate(const char* pName,
                   const char* pValidSvgD,
diff --git a/oox/qa/unit/vba_encryption.cxx b/oox/qa/unit/vba_encryption.cxx
index 93525a2..0e3c5ab 100644
--- a/oox/qa/unit/vba_encryption.cxx
+++ b/oox/qa/unit/vba_encryption.cxx
@@ -89,7 +89,6 @@ void TestVbaEncryption::testProjKey1()
 void TestVbaEncryption::setUp()
 {
 }
-
 void TestVbaEncryption::tearDown()
 {
 }
diff --git a/sal/qa/osl/process/osl_Thread.cxx b/sal/qa/osl/process/osl_Thread.cxx
index 245c5ba..0d0eb0f2 100644
--- a/sal/qa/osl/process/osl_Thread.cxx
+++ b/sal/qa/osl/process/osl_Thread.cxx
@@ -1478,9 +1478,6 @@ namespace osl_Thread
     {
     public:
         // initialise your test code values here.
-        void setUp() override {}
-
-        void tearDown() override {}
 
         void getIdentifier_001()
         {
@@ -1497,9 +1494,6 @@ namespace osl_Thread
     class getCurrentIdentifier : public CppUnit::TestFixture
     {
     public:
-        void setUp() override {}
-        void tearDown() override {}
-
         void getCurrentIdentifier_001()
         {
             oslThreadIdentifier oId;
@@ -1604,8 +1598,6 @@ namespace osl_Thread
     class schedule : public CppUnit::TestFixture
     {
     public:
-        void setUp() override {}
-        void tearDown() override {}
 
         /** The requested thread will get terminate the next time schedule() is called.
 
@@ -1814,14 +1806,6 @@ namespace osl_ThreadData
     class ctors : public CppUnit::TestFixture
     {
     public:
-        // initialise your test code values here.
-        void setUp() override
-            {
-            }
-
-        void tearDown() override
-            {
-            }
 
         // insert your test code here.
         void ctor_001()
@@ -1837,14 +1821,6 @@ namespace osl_ThreadData
     class setData : public CppUnit::TestFixture
     {
     public:
-        // initialise your test code values here.
-        void setUp() override
-            {
-            }
-
-        void tearDown() override
-            {
-            }
 
         /** the same instance of the class can have different values in different threads
          */
@@ -1948,14 +1924,6 @@ namespace osl_ThreadData
     class getData : public CppUnit::TestFixture
     {
     public:
-        // initialise your test code values here.
-        void setUp() override
-            {
-            }
-
-        void tearDown() override
-            {
-            }
 
         // After setData in child threads, get Data in the main thread, should be independent
         void getData_001()
diff --git a/sal/qa/rtl/cipher/rtl_cipher.cxx b/sal/qa/rtl/cipher/rtl_cipher.cxx
index 0a47769..e24e6c5 100644
--- a/sal/qa/rtl/cipher/rtl_cipher.cxx
+++ b/sal/qa/rtl/cipher/rtl_cipher.cxx
@@ -33,14 +33,6 @@ namespace rtl_cipher
 class create : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void create_001()
         {
@@ -105,14 +97,6 @@ public:
 class createBF : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void createBF_001()
         {
@@ -153,14 +137,6 @@ public:
 class decode : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void test_encode(sal_uInt8 _nKeyValue, sal_uInt8 _nArgValue, rtl::OString const& _sPlainTextStr)
         {
@@ -290,14 +266,6 @@ public:
 class decodeBF : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void decodeBF_001()
         {
@@ -314,14 +282,6 @@ public:
 class destroy : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void destroy_001()
         {
@@ -341,14 +301,6 @@ public:
 class destroyBF : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void destroyBF_001()
         {
@@ -370,14 +322,6 @@ public:
 class encode : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void test_encode(sal_uInt8 _nKeyValue, sal_uInt8 _nArgValue, sal_uInt8 _nDataValue)
         {
@@ -443,14 +387,6 @@ public:
 class encodeBF : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void encodeBF_001()
         {
@@ -467,14 +403,6 @@ public:
 class init : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void init_001()
         {
@@ -580,14 +508,6 @@ public:
 class initBF : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     void initBF_001()
         {
diff --git a/sal/qa/rtl/crc32/rtl_crc32.cxx b/sal/qa/rtl/crc32/rtl_crc32.cxx
index cce0b40..03e1f98 100644
--- a/sal/qa/rtl/crc32/rtl_crc32.cxx
+++ b/sal/qa/rtl/crc32/rtl_crc32.cxx
@@ -30,14 +30,6 @@ namespace rtl_CRC32
 class test : public CppUnit::TestFixture
 {
 public:
-    // initialise your test code values here.
-    void setUp() override
-    {
-    }
-
-    void tearDown() override
-    {
-    }
 
     // insert your test code here.
     void rtl_crc32_001()
diff --git a/sal/qa/rtl/doublelock/rtl_doublelocking.cxx b/sal/qa/rtl/doublelock/rtl_doublelocking.cxx
index 15bf66f..faf2ebe 100644
--- a/sal/qa/rtl/doublelock/rtl_doublelocking.cxx
+++ b/sal/qa/rtl/doublelock/rtl_doublelocking.cxx
@@ -147,15 +147,6 @@ namespace rtl_DoubleLocking
     {
     public:
 
-        // initialise your test code values here.
-        void setUp() override
-            {
-            }
-
-        void tearDown() override
-            {
-            }
-
         void getValue_001()
             {
                 rtl::OUString aStr = Gregorian::get();


More information about the Libreoffice-commits mailing list