[Libreoffice-commits] core.git: sc/source

Stephan Bergmann sbergman at redhat.com
Mon Feb 22 13:31:48 UTC 2016


 sc/source/ui/view/cellsh2.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 21b3620be84a6b3c87cd7bf317dda506b4e37d2a
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Mon Feb 22 14:28:13 2016 +0100

    Missing dispose of dialog
    
    ...causing crash later at
    
    > SfxItemPool::GetFrozenIdRanges() const
    > SfxItemSet::~SfxItemSet()
    > SfxTabDialog::dispose()
    > ScRefHdlrImpl<ScValidationDlg, SfxTabDialog, false>::dispose()
    > ScValidationDlg::dispose()
    > OutputDevice::disposeOnce()
    > VclPtr<vcl::Window>::disposeAndClear()
    > vcl::LazyDeletor::~LazyDeletor()
    > vcl::LazyDelete::flush()
    > ImplYield(bool, bool, unsigned long)
    > Application::Yield()
    
    Change-Id: Ia4ae95cbbf4b5660ed08058b67ab674029c0b437

diff --git a/sc/source/ui/view/cellsh2.cxx b/sc/source/ui/view/cellsh2.cxx
index f5be225..70c0af5 100644
--- a/sc/source/ui/view/cellsh2.cxx
+++ b/sc/source/ui/view/cellsh2.cxx
@@ -849,7 +849,7 @@ void ScCellShell::ExecuteDB( SfxRequest& rReq )
                     }
 
                     // cell range picker
-                    auto pDlg = VclPtr<ScValidationDlg>::Create(nullptr, &aArgSet, pTabViewShell);
+                    ScopedVclPtr<ScValidationDlg> pDlg(VclPtr<ScValidationDlg>::Create(nullptr, &aArgSet, pTabViewShell));
 
                     short nResult = pDlg->Execute();
                     if ( nResult == RET_OK )


More information about the Libreoffice-commits mailing list