[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp

[Tor Lillqvist]

 loolwsd/LOOLBroker.cpp |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit c9fef1eb7e341ed6e67d93a9cdd57deca3168c81
Author: Tor Lillqvist <tml at collabora.com>
Date:   Tue Feb 23 09:09:17 2016 +0200

    Add comment about weird use of condition variable

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index 2450c79..3eb8db3 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -553,6 +553,8 @@ static int createLibreOfficeKit(const bool sharePages,
     // block the loolbroker forever
     {
         int retries = 5;
+        // Note that the use of a condition variable and mutex here is totally pointless as far as I
+        // see. There is no code that would notify the condition variable.
         std::mutex fifoMutex;
         std::condition_variable fifoCV;
         std::unique_lock<std::mutex> lock(fifoMutex);