[Libreoffice-commits] online.git: loolwsd/PROBLEMS

[Tor Lillqvist]

 loolwsd/PROBLEMS |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

New commits:
commit f0d7438f88ccc06e53f008e77535ee43aa61003d
Author: Tor Lillqvist <tml at collabora.com>
Date:   Mon Feb 29 13:06:08 2016 +0200

    Add one more thing

diff --git a/loolwsd/PROBLEMS b/loolwsd/PROBLEMS
index 38fc312..17bdab6 100644
--- a/loolwsd/PROBLEMS
+++ b/loolwsd/PROBLEMS
@@ -44,3 +44,17 @@
 - Occasionally Control-C (SIGINT) doesn't shut fown loolwsd. One has
   to kill it with SIGKILL. Which of course leaves all the chroot jails
   around.
+
+- I don't think the loolwsd program actually any longer does anything
+  that would need any capability. Still it is given cap_fowner,
+  cap_mknod, and cap_sys_chroot in Makefile.am (and the Debian and RPM
+  packaging), and it calls dropCapability() to drop those (without
+  having used them for anything). It would obviously be better to not
+  give it those capabilities in the first place. Unfortunately this is
+  a bit complicated because the dropCapability() function also does a
+  bit of a dance around the possibility that somebody is running
+  loolwsd under sudo. Does anybody actually do that? It seems like a
+  very bad idea. (Yes, I know I added that code myself, as a debugging
+  aid, but I dare not drop it now in case it is somebody's "normal"
+  method of working when debugging this, or even when not debugging.)
+  Also, the Capabilities.hpp defines a *static* variable uid...