[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sc/qa

[Markus Mohrhard]

 sc/qa/unit/ucalc.hxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d44e7d7181dc5d107ea54de36fbecd4e1b03e606
Author: Markus Mohrhard <markus.mohrhard at collabora.co.uk>
Date:   Sun Jan 3 16:29:50 2016 +0100

    the idea behind the test can't work right now
    
    The Test currently tries to test the OpenCL and the SW interpreter and
    assumes that it will show different results. However if we succeed in
    generating an OpenCL interpreter we will never generate a SW interpreter.
    
    There are a number of problems with the approach taken in this test.
    
    1.) Assuming that we are able to execute OpenCL is an invalid
    assumption.
    
    2.) Changing the configuration inside of a test needs to be exeption
    save as we are otherwise left with a strange config for the remaining
    test cases.
    
    3.) Changing the configuration does not change the formula group
    interpreter. This needs to be done explicitly.
    
    Change-Id: I679985ee7551b21aaa52038e107324980e7e1bb6
    (cherry picked from commit f4dc8a869ac49f19c20fc5fa606448e9103726bd)
    Reviewed-on: https://gerrit.libreoffice.org/21202
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Tested-by: Michael Stahl <mstahl at redhat.com>

diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index fc90f81..b3e5bf3 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -474,7 +474,7 @@ public:
     CPPUNIT_TEST(testFormulaCreateStringFromTokens);
     CPPUNIT_TEST(testFormulaParseReference);
     CPPUNIT_TEST(testFetchVectorRefArray);
-    CPPUNIT_TEST(testFormulaHashAndTag);
+    // CPPUNIT_TEST(testFormulaHashAndTag);
     CPPUNIT_TEST(testFormulaTokenEquality);
     CPPUNIT_TEST(testFormulaRefData);
     CPPUNIT_TEST(testFormulaCompiler);