[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - 2 commits - libreofficekit/source

Caolán McNamara caolanm at redhat.com
Mon Jan 11 02:12:27 PST 2016


 libreofficekit/source/gtk/lokdocview.cxx |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 699b5e361d1f75b1414a351dfe4d05d88e2b49e2
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Dec 19 15:09:10 2015 +0000

    coverity#1343632 Resource leak
    
    Change-Id: I79bf35a4c1a2f0463abc202f6c2b104ffdd5139c
    (cherry picked from commit 5b05a3fa2d6873c1046a959c545db133b1974e2c)
    Reviewed-on: https://gerrit.libreoffice.org/21269
    Reviewed-by: David Tardon <dtardon at redhat.com>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/libreofficekit/source/gtk/lokdocview.cxx b/libreofficekit/source/gtk/lokdocview.cxx
index 6ce7344..918f292 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -2579,13 +2579,13 @@ lok_doc_view_set_partmode(LOKDocView* pDocView,
                           int nPartMode)
 {
     LOKDocViewPrivate& priv = getPrivate(pDocView);
+    if (!priv->m_pDocument)
+        return;
+
     GTask* task = g_task_new(pDocView, nullptr, nullptr, nullptr);
     LOEvent* pLOEvent = new LOEvent(LOK_SET_PARTMODE);
     GError* error = nullptr;
 
-    if (!priv->m_pDocument)
-        return;
-
     pLOEvent->m_nPartMode = nPartMode;
     g_task_set_task_data(task, pLOEvent, LOEvent::destroy);
 
commit 195866b16f044bc792526145b739602166ca7276
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Dec 19 15:08:01 2015 +0000

    coverity#1343631 Resource leak
    
    Change-Id: Ic5d7c88ae4080c2e103fb691c2e326a9e239aa12
    (cherry picked from commit 169298fa73d2c5429d1960db6049a4ed15653b4f)
    Reviewed-on: https://gerrit.libreoffice.org/21268
    Reviewed-by: David Tardon <dtardon at redhat.com>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/libreofficekit/source/gtk/lokdocview.cxx b/libreofficekit/source/gtk/lokdocview.cxx
index ae8e52a..6ce7344 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -2649,13 +2649,13 @@ lok_doc_view_set_edit(LOKDocView* pDocView,
                       gboolean bEdit)
 {
     LOKDocViewPrivate& priv = getPrivate(pDocView);
+    if (!priv->m_pDocument)
+        return;
+
     GTask* task = g_task_new(pDocView, nullptr, nullptr, nullptr);
     LOEvent* pLOEvent = new LOEvent(LOK_SET_EDIT);
     GError* error = nullptr;
 
-    if (!priv->m_pDocument)
-        return;
-
     pLOEvent->m_bEdit = bEdit;
     g_task_set_task_data(task, pLOEvent, LOEvent::destroy);
 


More information about the Libreoffice-commits mailing list