[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/source

Caolán McNamara caolanm at redhat.com
Thu Jul 21 15:54:33 UTC 2016


 vcl/source/control/field2.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 836a7634b2042de4f08fcc2296fc33ca2d040a60
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Thu Jul 21 12:18:36 2016 +0100

    Resolves: tdf#100558 last 'section' of date field not incremented
    
    presumably a regression from...
    
    commit 3cad6c806e5247ce20b78eb688551aa5d872b934
    Author: Chr. Rossmanith <ChrRossmanith at gmx.de>
    Date:   Fri Mar 1 21:47:10 2013 +0100
    
        Replace (Xub)String with OUString in vcl(field)
    
    where UniString::Search returned a max short on not-found
    while OUString::indexOf returns a -1
    
    Change-Id: Ia3ef80dd318375ccdb3bdcee9bed7b70bf67cae1
    (cherry picked from commit 82913e694a4169f9ddeef399e659aec78cc9c8d6)
    Reviewed-on: https://gerrit.libreoffice.org/27375
    Reviewed-by: Lionel Elie Mamane <lionel at mamane.lu>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/vcl/source/control/field2.cxx b/vcl/source/control/field2.cxx
index b08bd788..c415b04 100644
--- a/vcl/source/control/field2.cxx
+++ b/vcl/source/control/field2.cxx
@@ -1343,7 +1343,7 @@ void DateField::ImplDateSpinArea( bool bUp )
                 for ( sal_Int8 i = 1; i <= 3; i++ )
                 {
                     nPos = aText.indexOf( aDateSep, nPos );
-                    if ( nPos >= (sal_Int32)aSelection.Max() )
+                    if (nPos < 0 || nPos >= (sal_Int32)aSelection.Max())
                     {
                         nDateArea = i;
                         break;


More information about the Libreoffice-commits mailing list