[Libreoffice-commits] core.git: comphelper/source include/comphelper

Xisco Fauli anistenis at gmail.com
Fri Jun 3 06:50:22 UTC 2016


 comphelper/source/misc/accimplaccess.cxx |    3 +--
 include/comphelper/accimplaccess.hxx     |    3 ++-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 2d2971090b31776719e83d811c17a01aaf5222c7
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Wed Jun 1 01:21:36 2016 +0200

    tdf#89329: use unique_ptr for pImpl in accimplaccess
    
    Change-Id: Ib10088b5669695dd5e288fe043ad72056a34b1e4
    Reviewed-on: https://gerrit.libreoffice.org/25745
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/comphelper/source/misc/accimplaccess.cxx b/comphelper/source/misc/accimplaccess.cxx
index 76ed77c..1c4096f 100644
--- a/comphelper/source/misc/accimplaccess.cxx
+++ b/comphelper/source/misc/accimplaccess.cxx
@@ -24,6 +24,7 @@
 
 #include <set>
 #include <string.h>
+#include <memory>
 
 
 namespace comphelper
@@ -49,8 +50,6 @@ namespace comphelper
 
     OAccessibleImplementationAccess::~OAccessibleImplementationAccess( )
     {
-        delete m_pImpl;
-        m_pImpl = nullptr;
     }
 
 
diff --git a/include/comphelper/accimplaccess.hxx b/include/comphelper/accimplaccess.hxx
index ab960dd..5c048da 100644
--- a/include/comphelper/accimplaccess.hxx
+++ b/include/comphelper/accimplaccess.hxx
@@ -23,6 +23,7 @@
 #include <cppuhelper/implbase1.hxx>
 #include <com/sun/star/lang/XUnoTunnel.hpp>
 #include <comphelper/comphelperdllapi.h>
+#include <memory>
 
 namespace com { namespace sun { namespace star { namespace accessibility {
     class XAccessible;
@@ -62,7 +63,7 @@ namespace comphelper
     class COMPHELPER_DLLPUBLIC OAccessibleImplementationAccess : public OAccImpl_Base
     {
     private:
-        OAccImpl_Impl*  m_pImpl;
+        std::unique_ptr<OAccImpl_Impl>  m_pImpl;
 
     protected:
         /// retrieves the parent previously set via <method>setAccessibleParent</method>


More information about the Libreoffice-commits mailing list