[Libreoffice-commits] core.git: framework/source include/framework

Stephan Bergmann sbergman at redhat.com
Fri Jun 3 06:58:48 UTC 2016


 framework/source/fwe/dispatch/interaction.cxx |    9 ++-------
 include/framework/interaction.hxx             |    4 ++--
 2 files changed, 4 insertions(+), 9 deletions(-)

New commits:
commit 69a3080ae9d1439bd325f55d6c799952b02536e0
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Jun 3 08:58:14 2016 +0200

    loplugin:refcounting (RequestFilterSelect_Impl derives from XInterface)
    
    Change-Id: Iabf9b94626b599b4fe799523b3523e18df5203c5

diff --git a/framework/source/fwe/dispatch/interaction.cxx b/framework/source/fwe/dispatch/interaction.cxx
index cf4f27c..a9b36bb 100644
--- a/framework/source/fwe/dispatch/interaction.cxx
+++ b/framework/source/fwe/dispatch/interaction.cxx
@@ -157,14 +157,9 @@ css::uno::Sequence< css::uno::Reference< css::task::XInteractionContinuation > >
 
 RequestFilterSelect::RequestFilterSelect( const OUString& sURL )
     : pImpl( new RequestFilterSelect_Impl( sURL ))
-{
-    pImpl->acquire();
-}
+{}
 
-RequestFilterSelect::~RequestFilterSelect()
-{
-    pImpl->release();
-}
+RequestFilterSelect::~RequestFilterSelect() {}
 
 // return abort state of interaction
 // If it is true, return value of method "getFilter()" will be unspecified then!
diff --git a/include/framework/interaction.hxx b/include/framework/interaction.hxx
index f7793d3..6858a04 100644
--- a/include/framework/interaction.hxx
+++ b/include/framework/interaction.hxx
@@ -30,11 +30,11 @@
 #include <com/sun/star/document/NoSuchFilterRequest.hpp>
 #include <com/sun/star/uno/RuntimeException.hpp>
 
+#include <rtl/ref.hxx>
 #include <rtl/ustring.hxx>
 #include <com/sun/star/uno/Reference.hxx>
 #include <com/sun/star/uno/Sequence.hxx>
 #include <framework/fwedllapi.h>
-#include <memory>
 
 namespace framework{
 
@@ -61,7 +61,7 @@ namespace framework{
 class RequestFilterSelect_Impl;
 class FWE_DLLPUBLIC RequestFilterSelect
 {
-    std::unique_ptr<RequestFilterSelect_Impl> pImpl;
+    rtl::Reference<RequestFilterSelect_Impl> pImpl;
 
 public:
     RequestFilterSelect( const OUString& sURL );


More information about the Libreoffice-commits mailing list