[Libreoffice-commits] core.git: include/sfx2 sfx2/source

Xisco Fauli anistenis at gmail.com
Mon Jun 6 07:16:30 UTC 2016


 include/sfx2/prnmon.hxx      |    2 +-
 sfx2/source/view/printer.cxx |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6b51e9afe01171a46f19fb96b1c2a2074d5a92ca
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Sat Jun 4 23:54:47 2016 +0200

    tdf#89329: use unique_ptr for pImpl in prnmon
    
    Change-Id: I73fe5dc51f2352c5def618ad4011b436f15230a2
    Reviewed-on: https://gerrit.libreoffice.org/25900
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/include/sfx2/prnmon.hxx b/include/sfx2/prnmon.hxx
index 289d57d..f54e883 100644
--- a/include/sfx2/prnmon.hxx
+++ b/include/sfx2/prnmon.hxx
@@ -34,7 +34,7 @@ struct SfxPrintOptDlg_Impl;
 class SfxPrintOptionsDialog : public ModalDialog
 {
 private:
-    SfxPrintOptDlg_Impl*    pDlgImpl;
+    std::unique_ptr<SfxPrintOptDlg_Impl>   pDlgImpl;
     SfxViewShell*           pViewSh;
     SfxItemSet*             pOptions;
     VclPtr<SfxTabPage>      pPage;
diff --git a/sfx2/source/view/printer.cxx b/sfx2/source/view/printer.cxx
index 7f95cf8..996ab8a 100644
--- a/sfx2/source/view/printer.cxx
+++ b/sfx2/source/view/printer.cxx
@@ -222,7 +222,7 @@ SfxPrintOptionsDialog::~SfxPrintOptionsDialog()
 
 void SfxPrintOptionsDialog::dispose()
 {
-    delete pDlgImpl;
+    pDlgImpl.reset();
     pPage.disposeAndClear();
     delete pOptions;
     ModalDialog::dispose();


More information about the Libreoffice-commits mailing list