[Libreoffice-commits] core.git: include/xmloff xmloff/source

Xisco Fauli anistenis at gmail.com
Mon Jun 6 07:18:46 UTC 2016


 include/xmloff/xmlnumfe.hxx      |    3 ++-
 xmloff/source/style/xmlnumfe.cxx |    5 ++---
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 52af06b471ed3e4627be3950330ad311b71c275b
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Wed Jun 1 01:03:01 2016 +0200

    tdf#89329: use unique_ptr for pImpl in xmlnumfe
    
    Change-Id: I1c07b20f187d4b7045d68e0b7f95725de039bf77
    Reviewed-on: https://gerrit.libreoffice.org/25743
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/include/xmloff/xmlnumfe.hxx b/include/xmloff/xmlnumfe.hxx
index 8e47ff6..be72e4b 100644
--- a/include/xmloff/xmlnumfe.hxx
+++ b/include/xmloff/xmlnumfe.hxx
@@ -26,6 +26,7 @@
 #include <com/sun/star/util/XNumberFormatsSupplier.hpp>
 #include <com/sun/star/uno/Sequence.h>
 #include <rtl/ustrbuf.hxx>
+#include <memory>
 
 #define XML_WRITTENNUMBERSTYLES "WrittenNumberStyles"
 
@@ -49,7 +50,7 @@ private:
     OUString             sPrefix;
     SvNumberFormatter*          pFormatter;
     OUStringBuffer       sTextContent;
-    SvXMLNumUsedList_Impl*      pUsedList;
+    std::unique_ptr<SvXMLNumUsedList_Impl>      pUsedList;
     CharClass*                  pCharClass;
     LocaleDataWrapper*          pLocaleData;
 
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index dc785d07..78bd915 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -254,7 +254,7 @@ SvXMLNumFmtExport::SvXMLNumFmtExport(
         pLocaleData = new LocaleDataWrapper( rExport.getComponentContext(), aLanguageTag );
     }
 
-    pUsedList = new SvXMLNumUsedList_Impl;
+    pUsedList.reset(new SvXMLNumUsedList_Impl);
 }
 
 SvXMLNumFmtExport::SvXMLNumFmtExport(
@@ -288,12 +288,11 @@ SvXMLNumFmtExport::SvXMLNumFmtExport(
         pLocaleData = new LocaleDataWrapper( rExport.getComponentContext(), aLanguageTag );
     }
 
-    pUsedList = new SvXMLNumUsedList_Impl;
+    pUsedList.reset(new SvXMLNumUsedList_Impl);
 }
 
 SvXMLNumFmtExport::~SvXMLNumFmtExport()
 {
-    delete pUsedList;
     delete pLocaleData;
     delete pCharClass;
 }


More information about the Libreoffice-commits mailing list