[Libreoffice-commits] core.git: include/unotools unotools/source
Xisco Fauli
anistenis at gmail.com
Mon Jun 6 07:19:27 UTC 2016
include/unotools/configvaluecontainer.hxx | 4 ++--
unotools/source/config/configvaluecontainer.cxx | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
New commits:
commit a4a97fb56c526a0f3793e55826afce42f4b0eeef
Author: Xisco Fauli <anistenis at gmail.com>
Date: Sat Jun 4 23:09:16 2016 +0200
tdf#89329: use unique_ptr for pImpl in configvaluecontainer
Change-Id: Ide38cacc59a44515287d51dadb23836eaac14518
Reviewed-on: https://gerrit.libreoffice.org/25904
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin at gmail.com>
diff --git a/include/unotools/configvaluecontainer.hxx b/include/unotools/configvaluecontainer.hxx
index 970bc18..664f10a 100644
--- a/include/unotools/configvaluecontainer.hxx
+++ b/include/unotools/configvaluecontainer.hxx
@@ -23,6 +23,7 @@
#include <com/sun/star/uno/XComponentContext.hpp>
#include <osl/mutex.hxx>
#include <o3tl/typed_flags_set.hxx>
+#include <memory>
enum class CVCFlags
@@ -65,8 +66,7 @@ namespace utl
class UNOTOOLS_DLLPUBLIC OConfigurationValueContainer
{
private:
- OConfigurationValueContainerImpl*
- m_pImpl;
+ std::unique_ptr<OConfigurationValueContainerImpl> m_pImpl;
protected:
diff --git a/unotools/source/config/configvaluecontainer.cxx b/unotools/source/config/configvaluecontainer.cxx
index a13b52a..df0a002 100644
--- a/unotools/source/config/configvaluecontainer.cxx
+++ b/unotools/source/config/configvaluecontainer.cxx
@@ -220,7 +220,6 @@ namespace utl
OConfigurationValueContainer::~OConfigurationValueContainer()
{
- delete m_pImpl;
}
void OConfigurationValueContainer::implConstruct( const OUString& _rConfigLocation,
More information about the Libreoffice-commits
mailing list